Ubuntu
software-center package

The user's own review looks like somebody else's

Bug #710396 reported by Dylan McCall
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Medium
Aaron Peachey
Natty
Fix Released
Medium
Aaron Peachey

Bug Description

Binary package hint: software-center

When I have reviewed a piece of software, my review appears in the list. Right now it looks like any other review. So, looking through the reviews I may come across my own. This feels like the following: “…and here's a review by some guy named Dylanmccall.” It feels like my computer doesn't know who I am, and it can be a little confusing.

Perhaps one's own rating and review could be de-emphasized and separated from the list of other peoples' reviews.

Tags: bitesize
Michael Vogt (mvo)
Changed in software-center (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Michael Vogt (mvo)
tags: added: bitesize
Revision history for this message
Michael Vogt (mvo) wrote :

This is actually a little more work than I initially though:
- add self.proxy.find_credentials() call to login_sso.py (this ensures that credentials are only fetched if there is no login required)
- call "whoami()" in UbuntuSSOAPI get get username
- when building the reviews, compare username with the reviews.username and color the own ones differently.

Revision history for this message
Aaron Peachey (aaronp) wrote :

working on this one

Changed in software-center (Ubuntu Natty):
assignee: nobody → Aaron Peachey (aaronp)
Revision history for this message
Aaron Peachey (aaronp) wrote :

linked branch resolves this issue

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 3.1.16

---------------
software-center (3.1.16) natty; urgency=low

  [ Michael Vogt ]
  * merged lp:~mmcg069/software-center/reviews-and-netstatus
    many thanks to Matthew McGowan
  * test/test_appdetails_view.py:
    - add appdetails netstatus tests
  * merged lp:~aaronp/software-center/fix-694836, many thanks
    (LP: #694836)
  * softwarecenter/view/softwarepane.py:
    - add helper to init atk names so that mago can pick them up
  * tests/Makefile, test/mago/test_with_mago.py:
    - use new style mago for search tests and enable in auto-tests

  [ Gary Lasker ]
  * softwarecenter/distro/Ubuntu.py,
    softwarecenter/models/appstore.py:
    - fix crash if attempting to download a remote icon before
      the cache is ready (LP: #688991)
  * softwarecenter/models/appstore.py:
    - fix intermittent AttributeError in on_get_value (LP: #712170)
    - fix attribute error when building a custom list (LP: #712888)
  * test/test_custom_lists.py:
    - add unit test for custom lists

  [ Aaron Peachey ]
  * view/appdetailsview_gtk.py:
     - change label to click to write a review if user already has
       a review for that package LP: #709738
     - alter review look if it belongs to current user LP: #710396

  [ Matthew McGowan ]
  * lp:~mmcg069/software-center/tiny-back-forward-tweak:
    - a small tweak to make the arrow in the back-forward button pick
      a better size across a wider range of gtk themes.
 -- Michael Vogt <email address hidden> Tue, 08 Feb 2011 11:58:53 +0100

Changed in software-center (Ubuntu Natty):
status: Confirmed → Fix Released
Revision history for this message
Aaron Peachey (aaronp) wrote :

When testing this bug fix, please note you will need to submit a new review before the fix will take effect.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specification updated. <https://wiki.ubuntu.com/SoftwareCenter/RatingsAndReviews?action=diff&rev2=65&rev1=63>

Revision history for this message
Aaron Peachey (aaronp) wrote :

Thanks mpt, will tweak the code to suit

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.