testsuite script does not stop running postgresql clusters correctly

Binary package hint: postgresql-common

The testsuite script in /usr/share/postgresql-common/testsuite attempts to stop any existing running postgresql clusters before running any tests by invoking postgresql's initscript with the following code:

  # temporarily move away existing clusters
  for v in $(ls /usr/lib/postgresql/); do
      if [ -x "/etc/init.d/postgresql-$v" ]; then
          /etc/init.d/postgresql-$v stop
      fi
  done

However, in Ubuntu 10.10 (maverick) and newer, the postgresql initscript is no longer versioned; it's just /etc/init.d/postgresql. Because there are running clusters, the second test in /usr/share/postgresql-common/t/010_defaultport_cluster.t stops the testsuite because it prompts for a password.

Two things should be done to address this; first, something like the following patch should be applied the testsuite script:

--- a/testsuite 2011-02-02 16:13:30.273258985 -0800
+++ b/testsuite 2011-02-02 16:14:01.109259639 -0800
@@ -42,6 +42,9 @@
         /etc/init.d/postgresql-$v stop
     fi
 done
+if [ -x "/etc/init.d/postgresql" ]; then
+ /etc/init.d/postgresql stop
+fi

 if [ -d /etc/postgresql ]; then
     mv /etc/postgresql /etc/postgresql.testsuite;

and second, it'd be nice if the psql command in /usr/share/postgresql-common/t/010_defaultport_cluster.t:

  like_program_out 0, 'env LC_MESSAGES=C psql -h 127.0.0.1 -l', 2, qr/could not connect/,

could include the '-w' switch to never prompt for a password.

Fixing this would make the testsuite runnable again under maverick and natty.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: postgresql-common 111
ProcVersionSignature: Ubuntu 2.6.35-25.44-generic-pae 2.6.35.10
Uname: Linux 2.6.35-25-generic-pae i686
Architecture: i386
Date: Wed Feb 2 16:06:25 2011
InstallationMedia: Ubuntu-Server 10.10 "Maverick Meerkat" - Release i386 (20101007)
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: postgresql-common