Ubuntu
multipath-tools package

local-top should pass -p part, not -p p

Bug #712840 reported by Serge Hallyn
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
multipath-tools (Ubuntu)
Fix Released
Medium
Serge Hallyn

Bug Description

Binary package hint: multipath-tools

The initramfs local-top file shipped with multipath-tools passes '-p p' to kpartx, but it should pass '-p part'.

Related branches

lp:~serge-hallyn/ubuntu/natty/multipath-tools/kpartx-p
Chuck Short (community): Approve
Diff: 26 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
debian/initramfs/local-top (+1/-1)
lp:ubuntu/natty/multipath-tools
Serge Hallyn (serge-hallyn)
Changed in multipath-tools (Ubuntu):
status: New → In Progress
assignee: nobody → Serge Hallyn (serge-hallyn)
importance: Undecided → Medium
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

(This should also be SRU'd to lucid and maverick)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package multipath-tools - 0.4.8-14ubuntu10

---------------
multipath-tools (0.4.8-14ubuntu10) natty; urgency=low

  * pass '-p part' to kpartx in initramfs script, not '-p p', to
    make sure /dev/mapper/ names are formed as expected. (LP: #712840)
 -- Serge Hallyn <email address hidden> Thu, 03 Feb 2011 18:40:36 -0600

Changed in multipath-tools (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Phillip Susi (psusi) wrote :

I believe this change is incorrect and should be reversed. The -p switch should not be used at all and kpartx should use its usual rule of adding 'p' when the previous character is a digit, as this has been the rule always used on Linux for forming partition names.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

@Phillip,

thanks for your input. The point of this bug was to stay closer to what Debian does. Please feel free to open a bug with Debian and, if they change their policy, we will follow suit.

Revision history for this message
Phillip Susi (psusi) wrote :

I agree that deviating from upstream should be avoided without good cause, but by using this switch, Debian is deviating from upstream. Are you aware of a good reason for this?

Revision history for this message
Phillip Susi (psusi) wrote :

Also as I mentioned in bug #737027, the dmraid part of this rule is broken due to case mismatch. I don't have a multipath installation to check, but I suspect it suffers from the same problem and so the rule isn't run at all anyway.

Revision history for this message
Phillip Susi (psusi) wrote : Re: [Bug 712840] Re: local-top should pass -p part, not -p p

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/23/2011 09:18 PM, Phillip Susi wrote:
> Also as I mentioned in bug #737027, the dmraid part of this rule is
> broken due to case mismatch. I don't have a multipath installation to
> check, but I suspect it suffers from the same problem and so the rule
> isn't run at all anyway.

I just checked the source code and it seems that multipath-tools does
use lower case, while lvm and dmraid both use upper case. Odd.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2KpKIACgkQJ4UciIs+XuLApgCgoIae8oeqHjH5tZ0eA+i8Ak0i
d6wAnRqjFiVUlw6owT2zfpcsb5o8hSTI
=AGdJ
-----END PGP SIGNATURE-----

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Quoting Phillip Susi (<email address hidden>):
> I agree that deviating from upstream should be avoided without good
> cause, but by using this switch, Debian is deviating from upstream. Are
> you aware of a good reason for this?

No, I'm not.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.