Media player should be automatically started up when play button is pressed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Sound Menu |
Fix Released
|
Low
|
Conor Curran | ||
Unity Foundations |
Fix Released
|
Low
|
Conor Curran | ||
indicator-sound (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
Binary package hint: indicator-sound
Recently, ever since Banshee implemented the part of the Sound Menu specification that states "Banshee should be altered to comply with the standard behavior: it should keep playing if closed while playing, it should exit if closed while not playing, and it should restore location and other state on relaunching", I have been encountering this particular broken use case:-
1. While Banshee is playing a song, pause the playback.
2. Open Banshee's window for some reason or other (e.g. to look for a song in the collection), but don't resume playback
3. Close Banshee's window (Banshee quits at this point)
4. Press the Play/Pause button on the keyboard -- Nothing happens.
At #4, I'm expecting Banshee to continue playback, or if playback was stopped before, I would expect it to start playing something from whichever media source was active. But Banshee is no longer running, and no longer listening to media keys, so nothing happens, and I either get confused, or annoyed. So, I open the sound menu again, and click on Banshee, start playback, and close its window so that I can resume doing whatever it was that I was doing prior to attempting to start playback.
Related branches
- Ted Gould (community): Approve
-
Diff: 654 lines (+241/-70)13 files modifiedsrc/common-defs.h (+2/-1)
src/indicator-sound.c (+2/-2)
src/mpris2-controller.vala (+7/-7)
src/mpris2-watcher.vala (+1/-1)
src/player-controller.vala (+17/-11)
src/player-item.vala (+2/-2)
src/slider-menu-item.c (+23/-15)
src/transport-menu-item.vala (+46/-16)
src/transport-widget.c (+105/-3)
src/voip-input-widget.c (+2/-2)
src/volume-widget.c (+29/-7)
src/volume-widget.h (+1/-1)
vapi/common-defs.vapi (+4/-2)
Changed in indicator-sound: | |
assignee: | nobody → Matthew Paul Thomas (mpt) |
status: | New → Opinion |
importance: | Undecided → Wishlist |
Changed in indicator-sound (Ubuntu): | |
status: | New → Opinion |
tags: | added: design |
Changed in indicator-sound: | |
status: | Confirmed → Triaged |
importance: | Wishlist → Low |
assignee: | Matthew Paul Thomas (mpt) → Conor Curran (cjcurran) |
Changed in indicator-sound (Ubuntu): | |
importance: | Undecided → Low |
status: | Opinion → Triaged |
Changed in indicator-sound: | |
milestone: | 0.6.0 → 0.6.1 |
Changed in indicator-sound: | |
milestone: | 0.6.1 → 0.6.2 |
Changed in indicator-sound: | |
status: | In Progress → Triaged |
Changed in indicator-sound: | |
milestone: | 0.6.2 → 0.6.3 |
Changed in indicator-sound: | |
milestone: | 0.6.3 → none |
Changed in indicator-sound: | |
status: | Triaged → In Progress |
milestone: | none → 0.6.4 |
Changed in unity-foundations: | |
milestone: | none → unity-3.6.6 |
Changed in unity-foundations: | |
importance: | Undecided → Low |
assignee: | nobody → Conor Curran (cjcurran) |
status: | New → Triaged |
Changed in indicator-sound: | |
milestone: | 0.6.4 → none |
Changed in unity-foundations: | |
milestone: | unity-3.6.6 → none |
Changed in unity-foundations: | |
status: | In Progress → Fix Committed |
Changed in indicator-sound: | |
status: | In Progress → Fix Committed |
Changed in indicator-sound (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity-foundations: | |
status: | Fix Committed → Fix Released |
Changed in indicator-sound: | |
status: | Fix Committed → Fix Released |
In the specification I also said: "However, the API should provide a way for a player to register a Play action, so that the Play button can work even when the player is not running."
I suggest that Banshee use that API, so that if it is not running, pressing the keyboard's Play button (or clicking the Play button in the sound menu) will launch Banshee and continue playback from where it left off.