Account screen cleanup
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Control Panel |
Fix Released
|
Medium
|
Natalia Bidart | ||
| ubuntuone-control-panel (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart | ||
| Natty |
Fix Released
|
Medium
|
Natalia Bidart | ||
Bug Description
This is a bit of a meta bug for a few smaller issues with the account screen :)
Bug #715825 - Personal Details and Your Services boxes are not homogenous
- fixed
Bug #706661 - Improve location of the "Get Support" button
- fixed
Bug #716516 - don't show "total storage" in "your services" if there is no additive process
- won't fix
* Frame borders are now deprecated: http://
- fixed
* Frames should use proper indentation and alignment. That is, not centered; left aligned.
- fixed
* Size of storage in "Services" frame should be right aligned for easier comparison and to maintain a justified look as per: http://
- won't fix: like I mentioned in bug #716516, the storage string is a fixed, non-translatable string sent from the server. We should do some complex parsing that is not planned for this cycle.
* There should be a separator between regular services and "Total Storage" to support the additive process.
- won't fix, same comment as before.
* The "Edit" and "Buy more storage and new plans" links should instead be buttons and expand to fit the frame in order to maintain a justified look as mentioned above.
- I changed the buttons to be as wide as the section they are in, and I set the link button to have the border relief 'normal'. I still think that buttons that wide are 'ugly' (at least from my point of view :-)). I didn't change them to be regular buttons since we need those to open urls, and that is what LinkButtons are for.
* The social network buttons should be right aligned in the window to finish off the justified look.
- fixed
I've attached a mockup of what all the changes together would look like :)
- Thanks!
Related branches
- Martin Albisetti (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 564 lines (+100/-148)5 files modifieddata/dashboard.ui (+70/-78)
ubuntuone/controlpanel/gtk/gui.py (+17/-25)
ubuntuone/controlpanel/gtk/tests/test_gui.py (+13/-23)
ubuntuone/controlpanel/gtk/tests/test_widgets.py (+0/-16)
ubuntuone/controlpanel/gtk/widgets.py (+0/-6)
| Danielle Foré (danrabbit) wrote | #1 |
| Natalia Bidart (nataliabidart) wrote | #2 |
| Changed in ubuntuone-control-panel: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| Natalia Bidart (nataliabidart) wrote | #3 |
| description: | updated |
| description: | updated |
| Changed in ubuntuone-control-panel (Ubuntu): | |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| importance: | Undecided → Medium |
| milestone: | none → natty-alpha-3 |
| status: | New → Triaged |
| Changed in ubuntuone-control-panel: | |
| status: | Triaged → In Progress |
| Changed in ubuntuone-control-panel: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-control-panel: | |
| status: | Fix Committed → In Progress |
| Danielle Foré (danrabbit) wrote | #4 |
| Natalia Bidart (nataliabidart) wrote | #5 |
| Changed in ubuntuone-control-panel: | |
| status: | In Progress → Fix Released |
| Launchpad Janitor (janitor) wrote | #6 |
| Changed in ubuntuone-control-panel (Ubuntu Natty): | |
| status: | Triaged → Fix Released |
Daniel,
thanks a lot for helping on making the control panel looks better. Question, did you run this mockup by Ivanka/Cristian? I personally don't like removing the frame borders, nor changing the link buttons to regular buttons since they open stuff in the browser.
From my POV, a regular button indicates that something will happen in the same UI, while link buttons trivially mean that something will be opened in the browser.