indicator invisible on first run

Bug #720030 reported by Fabien Tassin
92
This bug affects 18 people
Affects Status Importance Assigned to Milestone
Weather Indicator
Fix Released
Medium
Vadim Rutkovsky
indicator-weather (Ubuntu)
Fix Released
Medium
Andrew Starr-Bochicchio

Bug Description

Binary package hint: indicator-weather

install indicator-weather, start it: there's nothing visible in the panel until it's configured.
See the video attached

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: indicator-weather 11.02.13+repack-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-3.30-generic 2.6.38-rc4
Uname: Linux 2.6.38-3-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Wed Feb 16 14:05:19 2011
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Alpha i386 (20100331)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, user)
 LANG=en_US.UTF-8
 LC_MESSAGES=en_US.utf8
 SHELL=/usr/bin/tcsh
SourcePackage: indicator-weather
settings:
 refresh_rate = 15
  placechosen = 0
  unit = S
  notif = N
  wind = mph

Revision history for this message
Fabien Tassin (fta) wrote :
Revision history for this message
Vadim Rutkovsky (roignac) wrote :

We'll add an animated icon "gathering data" (not sure, if python binding support animated icons as in Netwrok Manager) and will not display menu until icon is ready.

Does the icon appear in a short period of time?

Changed in weather-indicator:
assignee: nobody → Vadim Rutkovsky (roignac)
importance: Undecided → Medium
milestone: none → 11.02.27
status: New → Confirmed
Changed in indicator-weather (Ubuntu):
status: New → Confirmed
Changed in indicator-weather (Ubuntu):
importance: Undecided → Medium
status: Confirmed → Triaged
Revision history for this message
John Vivirito (gnomefreak) wrote :

If you click on the left of the network-manager icon (just barely to the left) you can right click it and configure it from there. when you are finished it will show up.
There is just one thing i dont like is that you can not move it away from the rest of the indicators. But i do have to say it is much much better than the normal/old applet, if you right click on it it lists pretty much everything that you could want to know, where as the old applet you would need to open a dialog window for most info

Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

@Vadim: I think this bug is about when you first install indicator-weather, no locations are configured in it and so no icon appears in the menu bar. This is very disconcerting for new users - when I just installed indicator-weather, I didn't think it was running because i couldn't see any interface! Perhaps a cloud should be shown in red if there are no locations configured?

Revision history for this message
John S. Gruber (jsjgruber) wrote :

My experience mathes Felix's. It's not when it is just gathering data, it is before it is configured, and it doesn't eventually appear, you have to search for it as John mentions in comment 3. Once it is configured is does show up.

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

It seems, that the problem is actual for other indicators - see bug #730842. I guess, it is a libappindicator problem

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Unconfigured weather indicator is supposed to show up the icon. Soon a new unstable version with many patches will be released - hope, this will be fixed there.

Revision history for this message
Daniel Sandman (almehdi-deactivatedaccount) wrote :

I too had this exact problem until now. I thought it was completely gone. I had it working but after a reboot or upgrade it disappeared. Thanks to Fabien Tassins video i now got it set up and it is visible again.

Revision history for this message
Rifester (rife-mark) wrote :

I too had this problem... The indicator is not visible until configured by right clicking just next to the network manager icon. After configuration it appeared.

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Pushed a couple of indicator icon related fixes in the trunk, check bzr210 package in unstable PPA.

Can anybody check the following points:
1) The issue is not reproducible for weather indicator from unstable ppa
2) The issue occurs for other indicators too (I got the same issue for network-manager with disconnected wi-fi)
3) The issue is reproducible in Unity 3D only (not Gnome 2 or Unity 2D)

Changed in weather-indicator:
status: Confirmed → Incomplete
Revision history for this message
John S. Gruber (jsjgruber) wrote :

I'm now unable to reproduce in either the classic desktop or unity-3d with 10.02.13 natty or with either 10.02.13 in the unstable ppa (10.02.13-repack-0ubuntu1 or 10.02.13+bzr210+rc1~natty1).

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Marking as 'Fix Commited' per John's comment.
I'm sure, that the issue is not caused by Weather indicator, but by some library (libappindicator, python bindings etc.)

Please, reopen the issue, if this is reproducible on Lucid/Maverick or any version of Weather Indicator

Changed in weather-indicator:
status: Incomplete → Fix Committed
Changed in weather-indicator:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-weather - 11.03.20+repack-0ubuntu1

---------------
indicator-weather (11.03.20+repack-0ubuntu1) natty; urgency=low

  * New upstream release.
   - Fix unsafe tempfile handling (LP: #720112).
   - Fix gconf related crashers (LP: #723557).
   - Fix TypeError in getHumidex() (LP: #730287).
   - Allow two userid's to run indicator-weather
     simultaneously (LP: #730378).
   - Fix night icon showing during daytime (LP: #715657).
   - Fix indicator invisible on first run (LP: #720030).
   - Fix AttributeError in __find_city_by_code() (LP: #733681).
   - Fix AttributeError when clicking "Forecast" if there is
     no network connection (LP: # 730193).
  * debian/control:
   - Drop depends on python-simplejson, python-gconf,
     python-pymetar, and python-gweather.
   - Add depends on python-desktopcouch-records and
     python-pywapi.
  * Drop all old patches, applied upstream.
  * 01_lp_738804.patch: Fix crash on city names with spaces.
  * debian/rules:
   - Tweak get-orig-source target for new upstream
     directory naming.
   - Don't compress AUTHORS and COPYING. Needed for
     about dialog.
  * debian/indicator-weather.install: Install AUTHORS
    and COPYING files to /usr/share/doc/indicator-weather
    to fix crash in about dialog.
  * debian/indicator-weather.lintian-overrides: Overide
    lintian warning about extra copyright file.
 -- Andrew Starr-Bochicchio <email address hidden> Sun, 20 Mar 2011 22:16:35 -0400

Changed in indicator-weather (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

Sorry to break it to you, but this isn't fixed. I just upgraded to 11.03.20+repack-0ubuntu1, and indicator-weather forgot the location information and became invisible again. It's as if the image file for 'please set me up' is missing, corrupted, or 1px wide. I have never seen this behaviour with any other indicator.

Revision history for this message
John S. Gruber (jsjgruber) wrote :

Felix: Is there any clue in your .cache/indicator-weather.log file? This is still working for me but I am having trouble with indicator-weather failing to start sometimes.

Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

$ tail .cache/indicator-weather.log
2011-03-23 00:50:02,788 - DEBUG - Setting: getting value for wind
2011-03-23 00:50:02,864 - DEBUG - Setting: getting value for data_source
2011-03-23 00:50:02,955 - DEBUG - Setting: getting value for placechosen
2011-03-23 00:50:03,204 - DEBUG - Setting: getting value for places
2011-03-23 00:50:03,259 - DEBUG - Setting: can't find value for places
2011-03-23 00:50:03,260 - DEBUG - Setting: getting value for show_label
2011-03-23 00:50:03,306 - DEBUG - Setting: can't find value for show_label
2011-03-23 00:50:03,307 - DEBUG - Preferences: got settings: rate=15, unit=S, notif=N, wind=mph, placechosen=0, places=None
2011-03-23 00:50:03,308 - DEBUG - Indicator: could not parse places
2011-03-23 00:50:03,308 - DEBUG - Indicator: making a menu for no places

Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

I've confirmed that this is still a bug by installing it on a new computer. I didn't have permission to reopen this bug, so I created a new one: bug #740950. Interested parties should subscribe to that!

Changed in weather-indicator:
status: Fix Released → Confirmed
Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

The problem was that the icon was not set when no place was specified. Here's a patch that fixes it - it uses the pre-existing weather-indicator icon "icon.png". It also hardcodes the icon for "weather-indicator-unknown", which did not seem to exist either.

Hard-coding the icons is not ideal in the long term but appears to be the best option at present. In the long run it would be better to design an svg and put it in /usr/share/icons/ubuntu-mono-dark as per one of these links:
http://freakaboutlinux.wordpress.com/2010/12/02/custom-indicator-applet-icon/
http://askubuntu.com/questions/30458/custom-libindicator-icon-is-not-displayed?amp

But since since indicator-weather appears broken on install to (all?) new users, it's probably best to push out this fix as soon as possible.

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Great job, Felix! Applied a slightly modified patch

Changed in weather-indicator:
milestone: 11.03.20 → cloudy-2
status: Confirmed → Fix Committed
Changed in weather-indicator:
status: Fix Committed → Fix Released
Changed in indicator-weather (Ubuntu):
status: Fix Released → In Progress
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
tags: added: patch
Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

Andrew: if you are actively working on this for Natty beta, then try chmod +x'ing debian/postinst . That script should be installing the necessary icons into the hicolor theme but that's not happening upon normal install at the moment (possibly because the file is suspiciously not executable at present). It may be that changing that permission is all that's required to fix this bug 'the right way'.

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

I set it in-progress to remind myself to double check before I make an upload to natty. I blew away my config in desktopcouch and was greeted with the orange weather indicator icon.

I'm fairly certain that that postinst script is no longer needed with this approach. Was that generated by quickly? Running xdg-icon-resource from debian/postinst seems a little weird to me. I think it would be better handled in the "upstream" build system as it would never get done if you try to install from source...

Revision history for this message
Felix Lawrence (felix-lawrence) wrote : Re: [Bug 720030] Re: indicator invisible on first run

> I'm fairly certain that that postinst script is no longer needed with
> this approach.

Correct. At some point in the future though, if we want support for system themes then we'd want to transition back away from hardcoding these icons.

> Was that generated by quickly? Running xdg-icon-resource
> from debian/postinst seems a little weird to me. I think it would be
> better handled in the "upstream" build system as it would never get done
> if you try to install from source...

So xdg-icon-resource should be run from setup.py? And I guess we should xdg-icon-resource uninstall icons in a debian/postrm file.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-weather - 11.03.27+repack-0ubuntu1

---------------
indicator-weather (11.03.27+repack-0ubuntu1) natty; urgency=low

  * New upstream release.
   - Fix for LP: #720030 "indicator invisible on first run",
     thanks Felix!
   - Fix for LP: #739209 "indicator-weather crashed with
     AttributeError in get_value(): 'NoneType' object has no
     attribute 'execute_view'"
   - Fix for LP: #739907 "indicator-weather failed to start
     falsely reporting duplicate instance", thanks Felix!
   - Fix for LP: #735667 "indicator-weather crashed with NetworkException
     in FetchReport(): HTTP Error 408: Request Time-out"
   - And even more bug fixes.
  * debian/indicator-weather.install: COPYING file no longer
    needed. Now uses common-license version.
  * Drop lintian over-ride for extra-license-file.
  * Drop debian/patches/01_lp_738804.patch, applied upstream.
  * debian/rules: No need to delete empty dir anymore.
  * fix-google-coordinates-lp739420.patch: Fix formatting
    of coordinates Google. Patch by Felix Lawrence!
    Fixes LP: #739420 and LP: #744702.
 -- Andrew Starr-Bochicchio <email address hidden> Mon, 28 Mar 2011 18:39:38 -0400

Changed in indicator-weather (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.