Ubuntu
netcfg package

domain_nodot needs free()'d

Bug #724636 reported by Bryce Harrington
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
netcfg (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: ubiquity

Was trolling through recent ubiquity changes looking for memory leaks and noticed this.
Looks like a strdup() is happening without a corresponding free().
Don't think this would cause a leak but I don't know what calls this routine or how often it might get invoked.

Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks. This needs to be changed in netcfg though (see d-i/README in ubiquity) so reassigning there.

affects: ubiquity (Ubuntu) → netcfg (Ubuntu)
Revision history for this message
Colin Watson (cjwatson) wrote :

Also, free() already checks for NULL, so there's no need for the if. Otherwise, applied. Thanks!

Changed in netcfg (Ubuntu):
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package netcfg - 1.63ubuntu2

---------------
netcfg (1.63ubuntu2) oneiric; urgency=low

  * Free domain_nodot at the end of netcfg_write_common (thanks, Bryce
    Harrington; LP: #724636).
 -- Colin Watson <email address hidden> Sun, 24 Jul 2011 13:48:49 +0100

Changed in netcfg (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.