Should use tp_account_manager_dup()

Bug #724978 reported by Guillaume Desmottes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Me Menu
Fix Released
Low
Ken VanDine
indicator-me (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

 /* the daemon is used to communicate via DBus */
 daemon = tp_dbus_daemon_dup(&error);

 if (daemon == NULL)
 {
  g_debug("Cannot create DBus daemon: %s\n", error->message);
  g_error_free(error);
  return;
 }

 priv->manager = TP_ACCOUNT_MANAGER (g_object_new (TP_TYPE_ACCOUNT_MANAGER,
  "dbus-daemon", daemon,
  "dbus-connection", ((TpProxy *) daemon)->dbus_connection,
  "bus-name", "org.freedesktop.Telepathy.AccountManager",
  "object-path", "/org/freedesktop/Telepathy/AccountManager",
  NULL));

Any reason to not use tp_account_manager_dup()? That would make this code much simpler.

Related branches

Kalle Valo (kvalo)
Changed in indicator-me:
importance: Undecided → Low
Changed in indicator-me:
assignee: nobody → Ken VanDine (ken-vandine)
milestone: none → 0.2.14
Changed in indicator-me:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-me - 0.2.14-0ubuntu1

---------------
indicator-me (0.2.14-0ubuntu1) natty; urgency=low

  * New upstream release.
    - Added a11y description
    - Should use tp_account_manager_dup() (LP: #724978)
    - Once status is set to offline the me menu becomes disabled so can't
      be used to go online (LP: #550824)
 -- Ken VanDine <email address hidden> Thu, 03 Mar 2011 17:08:23 -0500

Changed in indicator-me (Ubuntu):
status: New → Fix Released
Changed in indicator-me:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.