Generic icon in windows list

debdiff attached. This also fixes bug #526650 typo in description issue.

Set to confirmed, since I reproduced the issue in Lubuntu 11.04.

Thanks for the patch. The icon name is weird, but as upstream also use it for the desktop file, it should be OK.
Could you convert the autogenerated patch to something integrate with others patches ? You need to use quilt, and to insert it after the 03_... patch.

On Mon, 09 May 2011 Julien Lavergne <email address hidden> wrote:

> Could you convert the autogenerated patch to something integrate
> with others patches ? You need to use quilt, and to insert it after
> the 03_... patch.

Well, yes, I could. But isn't one major benefit of using the new
quilt-based packaging source format to *avoid* the need for this sort of
manual patch creation work, especially for small changes like this?

As I understand it, the new 3.0 format allows (and in some sense
encourages) packagers to "just make the change" and let the package
build system worry about how to store it. It even puts a nice
DEP-3-consistent comment tag about the LP bug into the generated patch
file, all automatically.

So... shouldn't we use that nice new capability? Especially
since this patch is probably going to get integrated upstream pretty
soon anyway :)

Can you explain the value of (or reason for) continuing to create
patches "by hand" in this situation?

Jonathan

On Mon, 9 May 2011 13:46:28 -0700
Jonathan Marsden <email address hidden> wrote:

> Well, yes, I could. But isn't one major benefit of using the new
> quilt-based packaging source format to *avoid* the need for this sort of
> manual patch creation work, especially for small changes like this?
No, 3.0 (quilt) include facilities to create and use patches. You can let dpkg generated the patch, but usually you rename it to something more useful than debian-changes ....

> As I understand it, the new 3.0 format allows (and in some sense
> encourages) packagers to "just make the change" and let the package
> build system worry about how to store it. It even puts a nice
> DEP-3-consistent comment tag about the LP bug into the generated patch
> file, all automatically.
Same here, it's a tool to help. Even the DEP-3 are incomplete, you need to fill them. Also, you don't need all the text above the DEP-3 tag.
Technically, yes, you could let the patch like this, but it's just horribly ugly :)

> So... shouldn't we use that nice new capability? Especially
> since this patch is probably going to get integrated upstream pretty
> soon anyway :)
Integrate upstream doesn't mean released. For example, LXDE doesn't release very often, so it's possible that your patch will be kept during 1 or more cycle.

> Can you explain the value of (or reason for) continuing to create
> patches "by hand" in this situation?
You can keep the patch generated, but please, improve it a bit. It doesn't mean you have to re-create it by hand, just use this one and customize it with quilt.

Regards,
Julien Lavergne

I still think this is spending scarce Lubuntu dev/packager time on low priority work, but OK: here is a prettier debdiff.

This bug was fixed in the package lxsession-edit - 0.2.0~svn20090913-0ubuntu4

---------------
lxsession-edit (0.2.0~svn20090913-0ubuntu4) oneiric; urgency=low

  * debian/control:
   - Correct typo and English in Desciption:. (LP: #526650)
  * debian/patches/90_associate-icon-with-main-window.patch:
   - Associate icon with main window. (LP: #737275)
 -- Jonathan Marsden <email address hidden> Sat, 07 May 2011 23:32:14 -0700