rabbitmq-erlang-client doesn't ship a proper copyright file

Bug #739719 reported by Steve Langasek
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rabbitmq-erlang-client (Ubuntu)
Fix Released
Medium
Brian Thomason
Natty
Fix Released
Medium
Brian Thomason
rabbitmq-plugins-common (Ubuntu)
Fix Released
Medium
Unassigned
Natty
Fix Released
Medium
Unassigned
rabbitmq-stomp (Ubuntu)
Fix Released
Medium
Unassigned
Natty
Fix Released
Medium
Unassigned

Bug Description

Processing rabbitmq-erlang-client in NEW, I see that there's an overridden lintian warning:

$ lintian --show-overrides *.changes
O: rabbitmq-erlang-client: extra-license-file usr/share/doc/rabbitmq-erlang-client/COPYING.gz
$

This is not an appropriate override. The warning is absolutely correct; this is a bug that should be fixed in the package.

debian/copyright is expected to contain a full and complete copy of all license information needed for a given binary package, with the exception of those licenses shipped in /usr/share/common-licenses which can be included by reference. For rabbitmq-erlang-client, this is not the case; the software is distributed under the MPL, which is not a license included in /usr/share/common-licenses, so the *full* text of the license must be included in debian/copyright, not simply shipped as an adjacent COPYING file. And once it's in debian/copyright, the COPYING file is redundant and doesn't need to be included in the binary package.

BTW, I'm pretty sure this is incorrect:

  The Debian packaging is:

      Copyright (C) 2011 Brian Thomason <email address hidden>

It's almost certainly Copyright (C) 2011 Canonical Ltd. :)

Tags: patch
Steve Langasek (vorlon)
Changed in rabbitmq-erlang-client (Ubuntu):
assignee: nobody → Brian Thomason (brian-thomason)
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Brian Thomason (brian-thomason) wrote :

This patch adds the complete MPL 1.1 text to debian/copyright, provides proper attribution to Canonical for the copyright on the packaging itself, and removes the patch that added the mpl copyright file in the first place.

Revision history for this message
Brian Thomason (brian-thomason) wrote :

This patch adds the complete MPL 1.1 text to debian/copyright, and provides proper attribution to Canonical for the copyright on the packaging itself.

This patch is for the rabbitmq-stomp package.

Revision history for this message
Brian Thomason (brian-thomason) wrote :

This patch provides proper packaging copyright attribution to Canonical.

tags: added: patch
Changed in rabbitmq-erlang-client (Ubuntu):
status: Triaged → New
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Adding tasks and triaging for the other 2 affected packages.

Changed in rabbitmq-erlang-client (Ubuntu):
status: New → Fix Committed
Changed in rabbitmq-plugins-common (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Changed in rabbitmq-stomp (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

I just uploaded a rabbit-erlang-client that fixes FTBFS of some dependent packages. I went ahead and grabbed and sponsored Brian's copyright fixes here too. In the queue for release approval.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rabbitmq-plugins-common - 0.0.1-0ubuntu3

---------------
rabbitmq-plugins-common (0.0.1-0ubuntu3) natty; urgency=low

  * Provided proper copyright attribution, LP: #739719
 -- Brian Thomason <email address hidden> Mon, 21 Mar 2011 17:29:35 -0400

Changed in rabbitmq-plugins-common (Ubuntu Natty):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rabbitmq-stomp - 2.3.1+hg20110303-0ubuntu4

---------------
rabbitmq-stomp (2.3.1+hg20110303-0ubuntu4) natty; urgency=low

  [ Brian Thomason ]
  * Added full MPL 1.1 text to debian/copyright and added proper copyright
    attribution for packaging itself, LP: #739719

  [ Dustin Kirkland ]
  * debian/control: add versioned build-depends, and trigger a rebuild to
    fix FTBFS
 -- Dustin Kirkland <email address hidden> Tue, 19 Apr 2011 15:40:03 -0400

Changed in rabbitmq-stomp (Ubuntu Natty):
status: Triaged → Fix Released
Changed in rabbitmq-erlang-client (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.