indicator-weather failed to start falsely reporting duplicate instance

Bug #739907 reported by John S. Gruber
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Weather Indicator
Fix Released
Medium
Unassigned
indicator-weather (Ubuntu)
Fix Released
Undecided
Andrew Starr-Bochicchio

Bug Description

Binary package hint: indicator-weather

Failed to start as pid file already exists from last boot--and the pid is in use--but for /usr/bin/unity-window-decorator not indicator-weather. I don't think the code tries to check that the pid refers to indicator-weather.

Is this check really necessary or should we rely on xdg only to start it once for a particular X session and that it not be defined in the gnome-conf as a program to start automatically? I wonder if the earlier reports this addressed were artifacts of the evolution of the program rather than a problem that should be addressed with a lock.

To address this as-is, perhaps comparing the indicator-weather.pid's creation time to the creation time of /tmp would work, or make the file /tmp/indicator-weather-USERID.pid?

Just some ideas. Thanks again.

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: indicator-weather 11.03.20+repack-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-7.36-generic 2.6.38
Uname: Linux 2.6.38-7-generic i686
Architecture: i386
Date: Mon Mar 21 21:51:15 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110305)
ProcEnviron:
 LANGUAGE=en_US:en
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: indicator-weather
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
John S. Gruber (jsjgruber) wrote :
Revision history for this message
John S. Gruber (jsjgruber) wrote :

 ps aux | fgrep 1895
gruber 1895 0.0 0.3 31564 10480 ? Sl 20:49 0:03 /usr/bin/unity-window-decorator
gruber 3568 0.0 0.0 4100 776 pts/1 S+ 22:26 0:00 fgrep --color=auto 1895

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Thats is strange - why did the pid file was not removed on indicator exit?
Maybe, this was an emergency reboot? In this case, we might add a check, that stored pid is a pid of indicator-weather process.

Changed in indicator-weather (Ubuntu):
status: New → Incomplete
Changed in weather-indicator:
status: New → Incomplete
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

I had this problem also but in Ubuntu 10.10 Maverick. To start it I had to go to /.cache and delete the .pid file before I could get it open again. However this issue occured only sometimes which is very strange. However if I do face such an issue I will upload the log file.

Revision history for this message
Felix Lawrence (felix-lawrence) wrote :

I had this problem too. indicator-weather crashed (so did not delete the .pid file) and would not reopen on the next boot.

I like John's suggestion of moving the file to /tmp/indicator-weather-USERID.pid . This way if indicator-weather does not get shut down cleanly, the .pid file is automatically deleted next time the computer reboots - this method is simple and clean.

Changed in weather-indicator:
status: Incomplete → In Progress
status: In Progress → Confirmed
Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Thanks Felix, applied your patch

Changed in weather-indicator:
importance: Undecided → Medium
milestone: none → cloudy-2
status: Confirmed → Fix Committed
Changed in weather-indicator:
status: Fix Committed → In Progress
status: In Progress → Fix Released
tags: added: patch
Changed in indicator-weather (Ubuntu):
status: Incomplete → Triaged
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-weather - 11.03.27+repack-0ubuntu1

---------------
indicator-weather (11.03.27+repack-0ubuntu1) natty; urgency=low

  * New upstream release.
   - Fix for LP: #720030 "indicator invisible on first run",
     thanks Felix!
   - Fix for LP: #739209 "indicator-weather crashed with
     AttributeError in get_value(): 'NoneType' object has no
     attribute 'execute_view'"
   - Fix for LP: #739907 "indicator-weather failed to start
     falsely reporting duplicate instance", thanks Felix!
   - Fix for LP: #735667 "indicator-weather crashed with NetworkException
     in FetchReport(): HTTP Error 408: Request Time-out"
   - And even more bug fixes.
  * debian/indicator-weather.install: COPYING file no longer
    needed. Now uses common-license version.
  * Drop lintian over-ride for extra-license-file.
  * Drop debian/patches/01_lp_738804.patch, applied upstream.
  * debian/rules: No need to delete empty dir anymore.
  * fix-google-coordinates-lp739420.patch: Fix formatting
    of coordinates Google. Patch by Felix Lawrence!
    Fixes LP: #739420 and LP: #744702.
 -- Andrew Starr-Bochicchio <email address hidden> Mon, 28 Mar 2011 18:39:38 -0400

Changed in indicator-weather (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.