Ubuntu
software-center package

software-center crashed with AttributeError in _on_submit_review_finished(): 'ReviewLoaderJsonAsync' object has no attribute '_reviews'

Bug #754639 reported by Ярослав Почернин
218
This bug affects 44 people
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
High
Gary Lasker
Ubuntu ubuntu-11.04
Natty
Fix Released
High
Gary Lasker
Ubuntu ubuntu-11.04

Bug Description

Binary package hint: software-center

Crashed on submitting an app review.

ProblemType: Crash
DistroRelease: Ubuntu 11.04
Package: software-center 3.1.26.1
ProcVersionSignature: Ubuntu 2.6.38-8.41-generic 2.6.38.2
Uname: Linux 2.6.38-8-generic i686
Architecture: i386
Date: Fri Apr 8 17:35:19 2011
ExecutablePath: /usr/share/software-center/software-center
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110202)
InterpreterPath: /usr/bin/python2.7
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/bin/software-center
ProcEnviron:
 SHELL=/bin/bash
 LANGUAGE=ru_RU:ru:en_GB:en
 LANG=ru_RU.UTF-8
PythonArgs: ['/usr/bin/software-center']
SourcePackage: software-center
Title: software-center crashed with AttributeError in _on_submit_review_finished(): 'ReviewLoaderJsonAsync' object has no attribute '_reviews'
Traceback:
 Traceback (most recent call last):
   File "/usr/share/software-center/softwarecenter/db/reviews.py", line 290, in _on_submit_review_finished
     if not app in self._reviews:
 AttributeError: 'ReviewLoaderJsonAsync' object has no attribute '_reviews'
UpgradeStatus: Upgraded to natty on 2011-03-25 (14 days ago)
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

Revision history for this message
Ярослав Почернин (yaroslav-pochernin) wrote :
Apport retracing service (apport)
tags: removed: need-duplicate-check
Gary Lasker (gary-lasker)
visibility: private → public
Revision history for this message
Jimbo (james-saveker) wrote :

Software centre crashed with this error upon me submitting a review on a chess game.

Extender (msveshnikov)
Changed in software-center (Ubuntu):
status: New → Confirmed
Revision history for this message
Alejandro Meneses (alejandro9225) wrote :

Same here on a Ubuntu 64-bit system.

Gary Lasker (gary-lasker)
Changed in software-center (Ubuntu):
assignee: nobody → Gary Lasker (gary-lasker)
importance: Undecided → High
milestone: none → ubuntu-11.04
status: Confirmed → In Progress
Gary Lasker (gary-lasker)
Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Gareth Williams (gareththered) wrote :

Same here, while reviewing Pipewalker. (Play it if you are stressed out from debugging Ubuntu!!)

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Haha, thanks Gareth. Definitely sounds like a plan! :)

Btw, this fix will be available soon with the next development release of Software Center in natty.

Thanks again all!

Revision history for this message
Stephan (stephan-hoehne) wrote :

happens also with Architecture: amd64

Revision history for this message
Achim (achimtrf-deactivatedaccount) wrote :

After reviews. Going in my corner, waiting for the update ;)

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Heh, sorry 'bout that, Achim! This fix is in Software Center 3.1.26.2 which is currently held up in the queue for beta-2 freeze. But soon...soon. :)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 3.1.26.2

---------------
software-center (3.1.26.2) natty; urgency=low

  [ Michael Vogt ]
  * softwarecenter/db/update.py:
    - do not crash if /var/lib/apt-xapian-index/cataloged_times.p can
      not be read (LP: #636049)
  * merged lp:~mvo/software-center/get-reviews-subprocess (LP: #743020):
    - don't use multiprocessing anymore, instead glib.spawn_async()
      a helper app, this finally fixes the crashes with accessibility
      turned on (LP: #743020)
    - update rnrclient_pristine.py to the latest upstream version
      that supports origin and distroseries as arguments
    - add support for getting all the origins of the DB, this is
      needed for the new rnrclient_pristine.py functionatlity
    - ship get_reviews_helper.py, get_review_stats_helper.py for
      the glib.spawn_async() change
    - this also makes the reviews fully work in the guest session again

  [ Gary Lasker ]
  * softwarecenter/db/reviews.py:
    - update review loader to check for JoinableQueue rather than
      Queue so that we re-enable the ReviewLoaderThreadedRNRClient
      (LP: #754639)
  * utils/submit_review.py:
    - remove two strings marked for translation that are never
      actually shown in the ui, also add translators note for
      combobox entries (LP: #750421)
  * refresh .pot file

  [ Aaron Peachey ]
  * softwarecenter/view/widgets/reviews.py:
    - advise user that app needs to be installed in order to review,
      even if reviews exist (LP: #754879)
 -- Michael Vogt <email address hidden> Mon, 11 Apr 2011 23:02:12 +0200

Changed in software-center (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.