LXDE and Lubuntu is not recognized

Bug #778148 reported by Julien Lavergne
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
hardinfo (Ubuntu)
Fix Released
Low
Julien Lavergne

Bug Description

Binary package hint: hardinfo

In Computer => Operating System => Desktop Envrironnement, LXDE or Lubuntu is not recongnized. The entry field shows "Unknow (Window manager: Openbox).
To detect if it's a LXDE or a Lubuntu session, hardinfo can try to detect if lxsession is running. If it's the case, it can consider that it's a LXDE session. Then, if the environnement variable DESKTOP_SESSION=Lubuntu, it's a Lubuntu session.

Tags: patch
Revision history for this message
Jonathan Marsden (jmarsden) wrote :

This looked pretty trivial, so I had a quick go at doing it.

Rather than "try to detect if lxsession is running", which seemed a bit awkward, I checked for XDG_CURRENT_DESKTOP and if that exists, use that as the current DE name. If in addition DESKTOP_SESSION exists, it is added as additional information in parentheses, so in Lubuntu you see

  Desktop Environment LXDE (Lubuntu)

Looks sane to me.

Patch and debdiff attached, this will soon be in my PPA ppa:jmarsden/lubuntu for anyone wishing to test it that way.

Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Here is the debdiff.

Changed in hardinfo (Ubuntu):
status: New → Confirmed
tags: added: patch
Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Added patch tag, set to confirmed.

Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks Jonathan, the patch looks good to me, and it's working perfectly. As lxsession should be the only one to use XDG_DESKTOP_SESSION, it should be ok.

Could you forward it upstream, to have their opinion ?

About the debdiff, the version number is wrong, and you need to set the release to oneiric. Do you test if it builds on a oneiric chroot/pbuilder ?

Revision history for this message
Jonathan Marsden (jmarsden) wrote :

I didn't realize oneiric was usable already for development and testing ...

It builds fine in an oneiric pbuilder, and if I do pbuilder-oneiric login and then apt-get install hardinfo, and then update to my new hardinfo package, and set the two variables by hand, it works and displays "LXDE (Lubuntu)" as desired.

The version number was just what dch -i did to it. I'll change it to 0.51-2~jmarsden1 for my PPA and re-upload.

I've not forwarded the patch upstream, I'll do that next. Do I need to do something specific ("Also affects project"?) to this bug in LP to indicate that? I'm not comfortable with the LP stuff for pointers to other bugtrackers etc. yet. Time to learn, I suppose :)

Revision history for this message
Jonathan Marsden (jmarsden) wrote :

I changed my mind on the package version ...
I think you meant the ~jmarsden1 is OK for my PPA, but not for a debdiff here :)

Here is a debdiff to hardinfo-0.5.1-1.1ububntu4 for oneiric.

Since Debian has hardinfo and LXDE too, and so has the same issue, officially I should probably create 0.5.1-2 and then look for a DD mentor to get it into Debian unstable, and then request a sync?? I don't see anything in the recent Ubuntu-only packaging changes to hardinfo that looks truly Ubuntu-specific -- am I right? Shouldn't they all be put into a 0.5.1-2 package for Debian. so Ubuntu does not have to maintain a difference from Debian?

Revision history for this message
Julien Lavergne (gilir) wrote : Re: [Bug 778148] Re: LXDE and Lubuntu is not recognized

On Sat, 07 May 2011 17:09:19 -0000
Jonathan Marsden <email address hidden> wrote:
> I didn't realize oneiric was usable already for development and testing
> ...
>
> It builds fine in an oneiric pbuilder, and if I do pbuilder-oneiric
> login and then apt-get install hardinfo, and then update to my new
> hardinfo package, and set the two variables by hand, it works and
> displays "LXDE (Lubuntu)" as desired.
Oneiric is available, but only for testing if the package build correctly. No need to test if it's working inside the chroot, it's too early in the cycle :) If it's working on Natty, it should be good on Oneiric.

> I've not forwarded the patch upstream, I'll do that next. Do I need to
> do something specific ("Also affects project"?) to this bug in LP to
> indicate that? I'm not comfortable with the LP stuff for pointers to
> other bugtrackers etc. yet. Time to learn, I suppose :)
If hardinfo project is registered in Launchpad, you can add "Also affects project". If not, it's enough to just copy/paste the url of the bug report upstream. Launchpad support links with other bugtracker (like Bugzilla) to track status on other bugtracker, but not all bugtrackers are supported.

Revision history for this message
Julien Lavergne (gilir) wrote :

On Sat, 07 May 2011 17:38:48 -0000
Jonathan Marsden <email address hidden> wrote:

> Here is a debdiff to hardinfo-0.5.1-1.1ububntu4 for oneiric.
Perfect, thank you. I'll proceed with this.

> Since Debian has hardinfo and LXDE too, and so has the same issue,
> officially I should probably create 0.5.1-2 and then look for a DD
> mentor to get it into Debian unstable, and then request a sync?? I
> don't see anything in the recent Ubuntu-only packaging changes to
> hardinfo that looks truly Ubuntu-specific -- am I right? Shouldn't they
> all be put into a 0.5.1-2 package for Debian. so Ubuntu does not have to
> maintain a difference from Debian?
No, the normal process is to report the patch to Debian bugtracker. You can use submittodebian for that. Only the maintainer of hardinfo in Debian should commit a change on his package. An upload by another DD is only for special cases (security issue, RC bug ...).

Changed in hardinfo (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → Low
assignee: nobody → Julien Lavergne (gilir)
Revision history for this message
Julien Lavergne (gilir) wrote :

I found a cosmetic issue with this. If you run a standart session of LXDE, you will have : "LXDE (LXDE)", which is not pretty. Could you add a condition so if XDG_CURRENT_DESKTOP == DESKTOP_SESSION, only "LXDE" is shown ? Thanks

Changed in hardinfo (Ubuntu):
status: In Progress → Incomplete
assignee: Julien Lavergne (gilir) → nobody
Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Revised debdiff attached.

Changed in hardinfo (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Jonathan Marsden (jmarsden) wrote :

I thought that "Incomplete" means the report of the issue was incomplete, not that the debdiff is incomplete.

I set status back to confirmed, this is a confirmed issue at this point as far as I know.

Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks, the patch looks fine. Please also forwarded it upstream (http://bugs.hardinfo.org/index.php).

Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Added to upstream bugtracker as http://bugs.hardinfo.org/showreport.php?bugid=55

Revision history for this message
Julien Lavergne (gilir) wrote :

Uploaded, thanks :)

Changed in hardinfo (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Julien Lavergne (gilir)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hardinfo - 0.5.1-1.1ubuntu4

---------------
hardinfo (0.5.1-1.1ubuntu4) oneiric; urgency=low

  * debian/patches/03-detect-lxde.patch
   - Detect LXDE and Lubuntu from XDG_CURRENT_DESKTOP and
     DESKTOP_SESSION environment variables. (LP: #778148)
 -- Jonathan Marsden <email address hidden> Thu, 07 May 2011 10:22:53 -0700

Changed in hardinfo (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.