lxc-create -t ubuntu with user binding complains about any missing groups

Bug #813403 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

I'm on oneiric, up to date. I ran
 sudo lxc-create -t ubuntu -n lucid-test-lp -f /etc/lxc/local.conf -- -r lucid -a i386 -b robertc
and it complained (but still completed):
adduser: The group `libvirtd' does not exist.
'ubuntu' template installed
'lucid-test-lp' created

Related branches

Changed in lxc (Ubuntu):
importance: Undecided → Low
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

This one is due to the -b option. We blindly add all of robertc's groups (on the host) to the robertc user in the container. This fails for groups which don't exist in the container.

We could do a check, for each group, whether it exists in the container. I think the error message may actually be a helpful reminder in some cases, so I will mark this bug wontfix. If you feel I'm looking at it wrongly and we should avoid the error message, then please feel free to change it to confirmed.

Changed in lxc (Ubuntu):
status: New → Won't Fix
Revision history for this message
Robert Collins (lifeless) wrote :

I'm going to mark it confirmed - I think adding groups is unneeded (certainly my manual bind mounting process docs for Launchpad did not add the user to any groups.

Changed in lxc (Ubuntu):
status: Won't Fix → Confirmed
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, I'll either remove that, or add a check that each group exists in the container.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 813403] Re: lxc-create -t ubuntu complains about missing group libvirtd

On Thu, Jul 21, 2011 at 8:50 AM, Serge Hallyn <email address hidden> wrote:
> Thanks, I'll either remove that, or add a check that each group exists
> in the container.

FWIW my preference is to remove it - or make it a separate flag.

I don't expect that e.g. membership in an NFS group or whatever (think
folk in company networks) is something to replicate into the container
by default.

summary: - lxc-create -t ubuntu complains about missing group libvirtd
+ lxc-create -t ubuntu with user binding complains about any missing
+ groups
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.7.4.2-3ubuntu1

---------------
lxc (0.7.4.2-3ubuntu1) oneiric; urgency=low

  * Merge from Debian (0.7.4.2-3) (LP: #812892)
    - patches: import debian's patches 02-07
      * 06 needed to be ported due to changes upstream
    - debian/lxc.manpages: switch to Debian version
    - debian/lxc.TODO
    - switch README.Debian for lxc.README.Debian from debian package
    - remove debian/watch and debian/gbp.conf
    - bump debian/compat
    - copy debian/copyright from debian package
    - copy debian/source/options
    - debian/control: increased debhelper version to >= 8.

  * Remaining changes:
    - keep debian/patches/diff-to-bcbd102cb to bump to upstream git HEAD
    - keep ubuntu patches 0004-0006, which are pending acceptance upstream.
    - keep lxcguest package (not in debian):
      * debian/control: define package
      * debian/fstab.lxc and debian/fstab.libvirt
      * debian/lxcguest.console.upstart
      * debian/lxcguest.lxcguest.upstart
      * debian/lxcguest.lxcmount.upstart
      * debian/lxcguest.install
      * debian/lxc-is-container: keep Ubuntu-specific script
    - debian/local: a new set of scripts, NOT yet merged from Debian.
    - debian/lxc.default: keep example MIRROR
    - lxc-dev package (not in Ubuntu):
      * skip debian/control entry
      * skip debian/lxc-dev.install
    - debian/lxc.dirs:
      * keep Ubuntu-specific entries:
        * usr/share/lintian/overrides
        * usr/share/doc/lxc/examples
    - debian/lxc.docs: only in Ubuntu
    - debian/lxc.install: keep Ubuntu version
    - debian/rules: keep old version (new debian version is lovely but
      fails to build Ubuntu package.

  * debian/patches/0007-bindhome-dont-add-groups.patch: when binding a user
    into container, don't auto-insert his groups from the host into the
    container (LP: #813403).
 -- Serge Hallyn <email address hidden> Fri, 22 Jul 2011 11:47:41 -0500

Changed in lxc (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.