Ubuntu
libvirt package

Please put comment in /etc/default/libvirt-bin or remove it from the .deb

Bug #823638 reported by gdahlman
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libvirt (Ubuntu)
Fix Released
High
Serge Hallyn
Lucid
Fix Released
Undecided
Unassigned
Maverick
Fix Released
Undecided
Unassigned
Natty
Fix Released
Undecided
Unassigned

Bug Description

=========================
SRU Justification
1. Impact: changes to /etc/default/libvirt-bin are ignored at start
2. How bug was addressed:
   a. for natty+oneiric, change 'exec' section to a script, and source /etc/default/libvirt-bin.
   b. for lucid and maverick, add a comment to /etc/default/libvirt-bin that it is unused.
   (the reason for different treatment is that before natty, not using the file was our intent.
   Since then, we intended to use it but had a bug).
3. Minimal patch: see uploaded debdiff
4. Test case: add an option to /etc/default/libvirt-bin. It won't be reflected at libvirtd startup.
5. Regression potential: there should be none unless admins have put bad options into /etc/default/libvirt-bin which were being ignored before.
=========================

http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/natty/libvirt/natty/view/head:/debian/libvirt-bin.default

/etc/default/libvirt-bin is not used with upstart and has not been used for three releases anymore

It is very confusing to users to try and add arguments and have them ignored.

Please add a simple text comment at the top of the file telling people to modify /etc/init/libvirt-bin

See original description
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, I will add a comment next time the package gets uploaded.

---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

Changed in libvirt (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Actually,

this was *not* by design. If the /etc/default/libvirt-bin file exists it is supposed to be sourced. That is supposed to be the case at least until the upstart config override files are supported.

This was actually a bug. The file must be re-sourced in each upstart config section.

Changed in libvirt (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Serge Hallyn (serge-hallyn)
importance: Low → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 0.9.2-4ubuntu10

---------------
libvirt (0.9.2-4ubuntu10) oneiric; urgency=low

  * Source /etc/default/libvirt-bin at the upstart 'start' section (LP: #823638)
 -- Serge Hallyn <email address hidden> Mon, 15 Aug 2011 13:00:41 -0500

Changed in libvirt (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :
description: updated
description: updated
Serge Hallyn (serge-hallyn)
Changed in libvirt (Ubuntu Lucid):
status: New → In Progress
Changed in libvirt (Ubuntu Maverick):
status: New → In Progress
Changed in libvirt (Ubuntu Natty):
status: New → In Progress
Revision history for this message
Jiri Hoogeveen (wica128) wrote :

When you say it is fixed in 0.9.2-4ubuntu10 means that this does not get fixed in 10.04-LTS ? which has libvirt version 0.7.5

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

@Jiri,

that message was automatically generated by launchpad when the fixed package went upstream. The packages to fix this for lucid through natty are waiting to be accepted into the -proposed queues. Once they show up there, someone (other than me) will have to confirm that they fix the issue there.

Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello gdahlman, or anyone else affected,

Accepted libvirt into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in libvirt (Ubuntu Natty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello gdahlman, or anyone else affected,

Accepted libvirt into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in libvirt (Ubuntu Lucid):
status: In Progress → Fix Committed
Changed in libvirt (Ubuntu Maverick):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello gdahlman, or anyone else affected,

Accepted libvirt into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 0.7.5-5ubuntu27.17

---------------
libvirt (0.7.5-5ubuntu27.17) lucid-proposed; urgency=low

  * debian/libvirt-bin.upstart: add a pre-stop script to shut down running VMs
    before the host shuts down. (LP: #350936)
  * debian/libvirt-bin.default: add a comment that this file is not actually
    used at startup. (LP: #823638)
 -- Serge Hallyn <email address hidden> Mon, 15 Aug 2011 15:20:37 -0500

Changed in libvirt (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote :

Is anyone available to test this for natty and/or maverick?

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Verified for maverick-proposed. (defaults file has a warning)

Martin Pitt (pitti)
tags: added: verification-done-natty
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 0.8.3-1ubuntu19.4

---------------
libvirt (0.8.3-1ubuntu19.4) maverick-proposed; urgency=low

  * New version of debian/patches/lxc-use-own-ptyfns.patch. Previous version
    failed to build.

libvirt (0.8.3-1ubuntu19.3) maverick-proposed; urgency=low

  * lxc_controller: use our own unlocpt+grantpt rather than glibc's, which
    can't handle opening a pty in a devpts not mounted at /dev/pts.
    (LP: #863629)
 -- Serge Hallyn <email address hidden> Tue, 15 Nov 2011 08:06:57 -0600

Changed in libvirt (Ubuntu Maverick):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 0.8.8-1ubuntu6.7

---------------
libvirt (0.8.8-1ubuntu6.7) natty-proposed; urgency=low

  * lxc_controller: use our own unlocpt+grantpt rather than glibc's, which
    can't handle opening a pty in a devpts not mounted at /dev/pts.
    (LP: #863629)
 -- Serge Hallyn <email address hidden> Tue, 01 Nov 2011 18:00:51 +0000

Changed in libvirt (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.