pcmanfm crashed with SIGSEGV in g_object_unref()

StacktraceTop:
 g_object_unref (_object=0xccdaf694fdac8f4e) at /build/buildd/glib2.0-2.29.90/./gobject/gobject.c:2680
 item_reload_icon (model=0x8bb800, item=0x7a8ca0, tp=0x96be40) at gtk/fm-dir-tree-model.c:80
 on_theme_changed (theme=<optimized out>, model=0x8bb800) at gtk/fm-dir-tree-model.c:180
 g_closure_invoke (closure=0x8b3da0, return_value=0x0, n_param_values=1, param_values=0x7af900, invocation_hint=<optimized out>) at /build/buildd/glib2.0-2.29.90/./gobject/gclosure.c:774
 signal_emit_unlocked_R (node=<optimized out>, detail=0, instance=0x6db880, emission_return=0x0, instance_and_params=0x7af900) at /build/buildd/glib2.0-2.29.90/./gobject/gsignal.c:3272

Thank you for your bug report. Forwarded upstream.

I've also posted this to PCManFm mailing list :

I have a possible bug fix for this :
http://sourceforge.net/tracker/?func=detail&aid=3466416&group_id=156956&atid=801864

To reproduce the crash, open PCManFm, select the TreeView, that's important, it doesn't segfault in the default view.
Then, change the icon theme, when you set the new theme it crashes.

Here's the changes I've done :
@@ -88,7 +88,7 @@ static void item_reload_icon(FmDirTreeMo
         for(l = item->children; l; l=l->next)
         {
             child = (FmDirTreeItem*)l->data;
- item_reload_icon(model, l, tp);
+ item_reload_icon(model, child, tp);
             gtk_tree_path_next(tp);
         }
         gtk_tree_path_up(tp);
@@ -177,7 +177,7 @@ static void on_theme_changed(GtkIconThem
     GtkTreePath* tp = gtk_tree_path_new_first();
     for(l = model->roots; l; l=l->next)
     {
- item_reload_icon(model, l, tp);
+ item_reload_icon(model, l->data, tp);
         gtk_tree_path_next(tp);
     }
     gtk_tree_path_free(tp);

Item_reload_icon is a recursive function, it seems to crash in the second call line 80, in :
g_object_unref(item->icon);

There's also a compiler warning about line 180.

I'm not sure if these changes are correct, I'm not an expert but that works. :D

Can someone check this in the attached patch and merge if it's correct.

Regards.

--
Axel FILMORE

libfm.patch

diff -rup libfm/src/gtk/fm-dir-tree-model.c 01-libfm/src/gtk/fm-dir-tree-model.c
--- libfm/src/gtk/fm-dir-tree-model.c 2012-01-25 10:03:09.487929009 +0100
+++ 01-libfm/src/gtk/fm-dir-tree-model.c 2012-01-25 10:06:04.001892067 +0100
@@ -88,7 +88,7 @@ static void item_reload_icon(FmDirTreeMo
         for(l = item->children; l; l=l->next)
         {
             child = (FmDirTreeItem*)l->data;
- item_reload_icon(model, l, tp);
+ item_reload_icon(model, child, tp);
             gtk_tree_path_next(tp);
         }
         gtk_tree_path_up(tp);
@@ -177,7 +177,7 @@ static void on_theme_changed(GtkIconThem
     GtkTreePath* tp = gtk_tree_path_new_first();
     for(l = model->roots; l; l=l->next)
     {
- item_reload_icon(model, l, tp);
+ item_reload_icon(model, l->data, tp);
         gtk_tree_path_next(tp);
     }
     gtk_tree_path_free(tp);

The attachment "libfm.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]