fwts: should examine the PCC tables

Bug #863175 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
Low
Colin Ian King

Bug Description

The Intel PCC interface http://acpica.org/download/Processor-Clocking-Control-v1p0.pdf could do with some sanity checking.

Fwts should probably do PCC table sanity checking with a new "pcc" test. Section 2.1 explains the table format quite clearly, so it should be relatively straight forward

Changed in fwts (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Colin Ian King (colin-king) wrote :

Couple of notes:

In tests, evaluation of \_SB_.OSC, PCCH, PCCP (and _PSD) objects generally results in a SMI being called which is impossible to do from the user space context. Thus sanity checking the return data from these objects is impossible. The only other sanity checking that can be done is to search for the PCC header (see section 2.1) of the PCC spec and validate the structure.

1. If PCC objects exist, we should validate if the PCC header exists
2. If PCC header exists, should the PCC objects exist?
3. Validate PCC header fields

Revision history for this message
Colin Ian King (colin-king) wrote :

New pcc test sent to fwts-devel mailing list for review.

Changed in fwts (Ubuntu):
status: New → In Progress
importance: Wishlist → Low
assignee: nobody → Colin King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed, commit 7bca5235939672e609c73f05b4565cf32dd8b9bc

Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 0.26.02-1ubuntu1

---------------
fwts (0.26.02-1ubuntu1) raring; urgency=low

  * Apply FWTS_UNUSED() to a few more arguments to fix !x86 FTBFS.
 -- Adam Conrad <email address hidden> Fri, 07 Dec 2012 12:50:24 -0700

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.