Ubuntu
virt-viewer package

Bad port '0' upon connect qemu+ssh

Bug #871847 reported by geppz
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
virt-viewer (Ubuntu)
Fix Released
High
Unassigned
Oneiric
Fix Released
High
Unassigned

Bug Description

Hi there, it's not possible to use virt-viewer --connect qemu+ssh:..... anymore in Oneiric Ocelot (virt-viewer 0.4.1-1ubuntu1) because of a bug. It returns the following error during connect:
Bad port '0'
This is due to a bug in the C code, which I have traced.
Please apply the patch in attachment to the Oneiric Ocelot virt-viewer 0.4.1-1ubuntu1 sources.

==============
SRU Justification:
1. Impact: using a normal -c URI results in failure.
2. Development Fix: the bug was fixed by syncing the newer debian package.
3. Stable Fix: the patch fixing the bug was cherrypicked from the debian package
4. Test case: start a libvir vm, then try to connect using
    virt-viewer -c qemu+ssh://localhost/system <vm-name>
5. Regression potential: the cherrypicked patch only affects the code calculating the connection URI, so if there is any regression it would manifest itself in new errors connecting to a remote URI with virt-viewer.
==============

See original description
Revision history for this message
geppz (no-carrier) wrote :
Serge Hallyn (serge-hallyn)
Changed in virt-viewer (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks for reporting this bug and providing the patch! Easily reproduced.

Changed in virt-viewer (Ubuntu):
status: New → Confirmed
importance: Medium → High
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Complete debdiff incorporating geppz' patch" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package virt-viewer - 0.4.1-3ubuntu1

---------------
virt-viewer (0.4.1-3ubuntu1) precise; urgency=low

  * Sync from Debian (fixes LP: #871847)
  * Remaining patches not in debian (renamed Ubuntu patches, starting with
    9001 to distinguish from the Debian patches)
    - debian/patches/9001-initial-zoom.patch
    - 9002-propagate-primary-window-zoom.patch
    - 9003-set-window-title-with-domain-name.patch

virt-viewer (0.4.1-3) unstable; urgency=low

  * [9e79afb] ff callbacks must be invoked from a clean stack. Fixes a hang
    when connecting to an unknown host or wrong port.

virt-viewer (0.4.1-2) unstable; urgency=low

  * [3c6e6de] Build against GTK+3
  * [599a1e1] Really fix using alternate ssh ports. Many,many thanks to Luca
    Capello for debugging this and for providing a patch. (Closes: #637548)
 -- Serge Hallyn <email address hidden> Tue, 18 Oct 2011 08:40:29 -0500

Changed in virt-viewer (Ubuntu):
status: Confirmed → Fix Released
Serge Hallyn (serge-hallyn)
description: updated
Revision history for this message
Peter Matulis (petermatulis) wrote :

Is this fix going to be backported to any older releases, notably 11.10 that just came out?

Brian Murray (brian-murray)
Changed in virt-viewer (Ubuntu Oneiric):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

I've now pushed a package with the debdiff in comment #7 to oneiric-proposed. (I actually made that debdiff in october. I didn't have upload rights to virt-viewer, and somehow it didn't get aroudn to being sponsored into the proposed queue)

Revision history for this message
Serge Hallyn (serge-hallyn) wrote : Re: [Bug 871847] Re: Bad port '0' upon connect qemu+ssh

Ok, apparently I still don't have upload rights for virt-viewer. Can
someone please update a version with the debdiff in comment #7?

Revision history for this message
Felix Geyer (debfx) wrote :

I've uploaded it to oneiric-proposed.

Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello geppz, or anyone else affected,

Accepted virt-viewer into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in virt-viewer (Ubuntu Oneiric):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Steven Wagner (stevenwagner) wrote :

I need this fix, but was unable to get oneiric-proposed repo to work for me.

Revision history for this message
Steven Wagner (stevenwagner) wrote :

okay, got it to work by just enabling it through the gui. Verified patch fixes issue as expected.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package virt-viewer - 0.4.1-1ubuntu2

---------------
virt-viewer (0.4.1-1ubuntu2) oneiric-proposed; urgency=low

  * debian/patches/0004-Really-fix-using-alternate-ssh-ports.patch:
    Fix for bad default port taken from newer sid package (LP: #871847)
 -- Serge Hallyn <email address hidden> Tue, 18 Oct 2011 09:38:25 -0500

Changed in virt-viewer (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.