Recovery from HDD doesn't show the correct language for zh_CN

Bug #888298 reported by Mario Limonciello
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dell-recovery (Ubuntu)
Fix Released
Undecided
Unassigned
Oneiric
Fix Released
Undecided
Unassigned

Bug Description

Dell recovery has a feature that during OOBE it will capture the selected language and pre-select that language for installation if recovery is invoked from the HDD. It does this by passing the language from GRUB on the kernel command line.

[impact]
For simplified Chinese, this doesn't work properly and the installer is still shown in English.

[development fix]
This requires fixes in both casper and dell-recovery. Casper was fixed in bug 882308. This has been fixed in dell-recovery trunk and will be included in precise with the next dell-recovery upload.

[stable fix]
The fix from trunk has been backported to oneiric.

[regressional potential]
Very low.
The regression potential here is only for pre-installed systems with dell-recovery that create recovery media after this fix hits the archive that people use to reinstall a system, choose a non-english language and then run recovery from HDD. The updated packages will be included on that recovery media, so it will only reach the recovery partition of the reinstall.

[test case]
1) Create recovery media using the fixed dell-recovery and an ubuntu oneiric ISO containing casper 1.287.1 (or the backported casper fix).
2) Install using the media in the default mode.
3) Select simplified chinese at OOBE
4) Invoke dell-recovery and select to restore the HDD
5) Verify that simplified chinese shows up at recovery.

Changed in dell-recovery (Ubuntu):
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Mario, or anyone else affected,

Accepted dell-recovery into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in dell-recovery (Ubuntu Oneiric):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Kent Baxley (kentb) wrote :

Testing Mario's fix plus the updated casper:

1) Installed and used Simplified Chinese in oem-config / OOBE.

2) Rebooted and, from the grub menu, selected to perform a restore.

3) During the ubiquity phase of the installation, the text above the progress bar is now in Chinese and the slideshow is still translated in Chinese, as expected.

4) After a reboot and re-run through the oem-config portion of the restore, there is no more garbaged-up text above the progress bar during the video. It is in Simpified Chinese where applicable. The video is translated into Chinese as well.

I think between the casper fix and Mario's dell-recovery fixes, we are now in good shape on this bug.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dell-recovery - 1.12

---------------
dell-recovery (1.12) precise; urgency=low

  [ Mario Limonciello ]
  * Update bootloader patches to current grub2-trunk.
  * Add support to run GRUB2 binary builder out of tree via environment
    variables.
  * Add a 10 second countdown and automatic reboot at the end of stage 1.
  * Call emergency.sh as LAST item in casper.
  * If running in persistent mode, forcefully regenerate the apt-cache
    on boot.
  * Copy files using a blacklist excluding casper-rw rather than an all
    inclusive whitelist. Fixes problems with persistence and dell-recovery.
  * Update the GPT utility partition creation logic. (LP: #877858)
  * Capture the state of all packages after post install scripts to prevent
    bad interactions with remove_oem_extras after ubiquity r5804
  * Update README for more current information.
  * Don't regenerate the UUID during stage 1 anymore. Instead, pre-populate
    the disk's UUID on the kernel command line of the target install.
    Requires casper 1.290 or later to work.
  * Add some preseeded language fixes that are reactive to casper 1.289
    from precise and 1.287.1 from oneiric. (LP: #888298)
    - Don't preseed the language in a standard preseed file as it overrides
      casper's attempt at setting the language.
    - Don't let dell-bootstrap set language based on locale. Only have it
      set English if no other language has been specified yet.
  * Create a flag on the disk filesystem to indicate an install is in progress.
  * Remove the casper UUID in SUCCESS_SCRIPT as well as stage 1 of recovery.
    This will prevent the RP from booting unless the UUID is present on
    /proc/cmdline.
  * Don't include grubenv in the files that go in /factory on install media.
  * Include a grub.cfg script that will be copied into the recovery media and
    source the proper location of installs in progress.
  * Always set install_finished on completion to ensure sticks aren't booted
    again.
  * Unset install_finished when mounting the RP during OOBE.

  [ Kent Baxley ]
  * Preseed chinese installs as zh_CN.UTF-8 rather than just zh_CN. Fixes
    translation problems for chinese factory installs. (LP: #879114)

  [ Chen Hsin-Yi ]
  * Encode all strings stored in XML as UTF-8. (LP: #890113)
  * Add a unit test to test for bug 890113.

  [ Chris Townsend ]
  * Fix pyflakes error of assigned but unused variable 'e' from UTF-8 XML
    patch.
 -- Mario Limonciello <email address hidden> Thu, 17 Nov 2011 19:04:21 -0600

Changed in dell-recovery (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dell-recovery - 1.11.2

---------------
dell-recovery (1.11.2) oneiric-proposed; urgency=low

  * Backport fixes from trunk:
    - Add some preseeded language fixes that are reactive to casper 1.289
      from precise and 1.287.1 from oneiric.
    - Don't preseed the language in a standard preseed file as it overrides
      casper's attempt at setting the language.
    - Don't let dell-bootstrap set language based on locale. Only have it
      set English if no other language has been specified yet.
    - (LP: #888298)
 -- Mario Limonciello <email address hidden> Wed, 09 Nov 2011 15:27:03 -0600

Changed in dell-recovery (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.