bzr smart server protocol dissector

Attached debdiff

Thanks for attaching a debdiff. I'm not sure if it's really worth to add this support for precise though, perhaps it's better to just let it come in with precise+1 when the next upstream wireshark release is merged.

Thanks Jelmer for the feedback. I'll unsubscribe the sponsors team from this one.

It's accepted upstream now, so I'm fine with this from a release/freeze POV.

Hi,

Vibhav, your debdiff FTBFS with 1.6.6 (and I think that with 1.6.5, it was also FTBFSing). Could you please have a look? Here is the build log:
...
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I./../.. -I./.. -I/usr/include/p11-kit-1 -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/local/include -I/usr/include -DPLUGIN_DIR=\"/usr/lib/wireshark/libwireshark1/plugins\" -DINET6 "-D_U_=__attribute__((unused))" -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign -Warray-bounds -Wcast-align -Wformat-security -fexcess-precision=fast -I/usr/include -I/usr/local/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include -MT libdissectors_la-packet-bzr.lo -MD -MP -MF .deps/libdissectors_la-packet-bzr.Tpo -c packet-bzr.c -fPIC -DPIC -o .libs/libdissectors_la-packet-bzr.o
packet-bzr.c: In function 'get_bzr_prefixed_len':
packet-bzr.c:83:12: error: expected ';' before 'header_len'
packet-bzr.c:81:8: warning: variable 'header_len' set but not used [-Wunused-but-set-variable]
packet-bzr.c: In function 'get_bzr_pdu_len':
packet-bzr.c:100:30: error: expected ';' before numeric constant
packet-bzr.c:105:43: error: expected ')' before 'len'
packet-bzr.c:106:37: error: expected ')' before 'len'
packet-bzr.c:112:44: error: expected ')' before 'len'
packet-bzr.c: In function 'dissect_prefixed_bencode':
packet-bzr.c:136:9: error: expected ')' before 'plen'
packet-bzr.c:136:9: error: too few arguments to function 'proto_tree_add_item'
../../epan/proto.h:684:1: note: declared here
packet-bzr.c:145:13: error: 'offset4' undeclared (first use in this function)
packet-bzr.c:145:13: note: each undeclared identifier is reported only once for each function it appears in
packet-bzr.c:148:12: error: expected ';' before 'plen'
packet-bzr.c: In function 'dissect_prefixed_bytes':
packet-bzr.c:162:9: error: expected ')' before 'plen'
packet-bzr.c:162:9: error: too few arguments to function 'proto_tree_add_item'
../../epan/proto.h:684:1: note: declared here
packet-bzr.c:171:13: error: 'offset4' undeclared (first use in this function)
packet-bzr.c:174:12: error: expected ';' before 'plen'
packet-bzr.c: In function 'dissect_bzr_pdu':
packet-bzr.c:226:8: error: 'protocol_version_len1' undeclared (first use in this function)
make[6]: *** [libdissectors_la-packet-bzr.lo] Error 1
make[6]: Leaving directory `/«PKGBUILDDIR»/epan/dissectors'
make[5]: *** [all-recursive] Error 1

I checked upstream svn, and the file epan/dissectors/packet-bzr.c is not the same, at least line 88 (and I think the ones with compilation errors).

Could you pelase have a look?

Thanks,
Fabrice

Successfully builds in my PPA
https://launchpad.net/~vibhavp/+archive/vibhavppa/+sourcepub/2474649/+listing-archive-extra

Thanks for your patch. I took the liberty of adding some information to debian/changelog about when the patch can be dropped again.

This bug was fixed in the package wireshark - 1.6.8-1ubuntu1

---------------
wireshark (1.6.8-1ubuntu1) quantal; urgency=low

  * debian/patches/add-bzr-smart-server-protocol-dissector-support.patch
    - Adds dissector for the bzr smart server protocol (LP: #907033)
      Patch can be dropped once 1.8.0 lands in Debian:
      http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678585
 -- Vibhav Pant <email address hidden> Fri, 25 May 2012 15:16:52 +0530