Ubuntu
crda package

FTBFS with new layout of libnl3

Bug #908464 reported by Andreas Moog
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
crda (Ubuntu)
Fix Released
High
Unassigned

Bug Description

The libnl3 package split out more libs into separate packages. This needs some adjusting of the previous patch as now the package FTBFS. A working debdiff is attached.

crda (1.1.1-1ubuntu4) precise; urgency=low

  * debian/control: Build-depend on libnl-genl-3-dev
  * debian/patches/libnl3.patch: (LP: #908464)
    - Use pkg-config to determine NLLIBS

 -- Andreas Moog <email address hidden> Sat, 24 Dec 2011 22:28:49 +0100

See original description
Tags: ftbfs precise

Related branches

lp:ubuntu/precise/crda
Revision history for this message
Andreas Moog (ampelbein) wrote :
description: updated
Revision history for this message
Micah Gersten (micahg) wrote :

Taking a look

Changed in crda (Ubuntu):
assignee: nobody → Micah Gersten (micahg)
status: New → In Progress
Revision history for this message
Micah Gersten (micahg) wrote :

Thanks for the patch. This looks good except for the lack of DEP-3 headers on the patch. Please see http://dep.debian.net/deps/dep3/ for more information. It built fine, so I'm happy to sponsor once the headers are added.

Changed in crda (Ubuntu):
assignee: Micah Gersten (micahg) → Andreas Moog (amoog)
status: In Progress → Incomplete
Revision history for this message
Andreas Moog (ampelbein) wrote :

I'm sorry, I don't understand. The DEP3 headers are there, added by Colin Watson, who wrote the patch in the first place. I merely change the patch to use pkg-config instead of hardcoding the ld arguments:

Description: Add libnl3 support
Author: Colin Watson <email address hidden>
Forwarded: no
Last-Update: 2011-11-26

Revision history for this message
Micah Gersten (micahg) wrote :

You are correct, I'm sorry I thought it was a new patch.

Changed in crda (Ubuntu):
status: Incomplete → In Progress
assignee: Andreas Moog (amoog) → Micah Gersten (micahg)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Was this tested? It looks to me like you'd be missing changes to CFLAGS, since the libnl3 headers have now moved to /usr/include/libnl3 (from /usr/include).

Revision history for this message
Andreas Moog (ampelbein) wrote :

The original makefile already includes the correct -I options from pkg-config, this info is missing from the patch context:

ifeq ($(NL3FOUND),Y)
CFLAGS += -DCONFIG_LIBNL20
NLLIBS += -lnl-genl
NLLIBNAME = libnl-3.0
endif

ifeq ($(NLLIBNAME),)
$(error Cannot find development files for any supported version of libnl)
endif

NLLIBS += `pkg-config --libs $(NLLIBNAME)`
CFLAGS += `pkg-config --cflags $(NLLIBNAME)`

Micah Gersten (micahg)
Changed in crda (Ubuntu):
assignee: Micah Gersten (micahg) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crda - 1.1.1-1ubuntu4

---------------
crda (1.1.1-1ubuntu4) precise; urgency=low

  * debian/control: Build-depend on libnl-genl-3-dev
  * debian/patches/libnl3.patch: (LP: #908464)
    - Use pkg-config to determine NLLIBS
 -- Andreas Moog <email address hidden> Sat, 24 Dec 2011 22:28:49 +0100

Changed in crda (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Micah Gersten (micahg) wrote :

Uploaded, please forward to Debian.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.