C++ apps will fail to compile with current bluez package

The attachment "Fix bluez for other C++ apps" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

For the record, sitplus FTBFS because of this bug.

Regarding how to fix it,
Debian applied this patch: http://patch-tracker.debian.org/patch/series/view/bluez/4.98-2/09_fix_compile_with_C++.patch ; but the following thread: http://marc.info/?l=linux-bluetooth&m=132644310919279&w=2 indicates that it may not be a good idea to apply it.
The patch you are proposing has been discussed on the upstream mailing-list as well, as far as I can see. Has the discussion come to the conclusion that we can safely apply it now?

I believe so, I had a discussion with Patrick Ohly about the patch and other distro packagers were CC'd in the email. The only reason I filed the bug was that Patrick assured me that the patch will land in upstream soon. Please also see : http://lists.syncevolution.org/pipermail/syncevolution/2012-February/003385.html

And since debian has already applied the patch, I believe they've verified that it's good at their end as well. I think it'll be best if someone could merge the package from debian.

Ah, might I add, I believe the patch I attached is a better version since it uses ifdef's to ensure that the code works as expected for C and introduces changes only for C++

I don't see any patch for bluez applied in Debian. Could you point me to where you saw this?

I'd personally follow upstream to say that I'd rather not include such a patch unless it was vetted by a GCC/C++ expert... or if it was included in bluez proper.

@Mathieu
It's in the SVN repo, please also see debian bug 657531. Like I said earlier, the patch is properly ifdef'd, so I really don't see the reason for concern.

This bug was fixed in the package bluez - 4.98-2ubuntu1

---------------
bluez (4.98-2ubuntu1) precise; urgency=low

  * Merge with Debian unstable. Remaining Ubuntu changes:
    - Upstart support:
      o Add debian/bluez.bluetooth.upstart.
      o debian/rules: Drop -DEB_UPDATE_RCD_PARAMS
      o Disable 07-fix-639356.patch and don't install 97-bluetooth.rules (in
        debian/bluez.install) and debian/bluez-udev (in debian/rules), we
        don't want to use the udev rules to start bluez. The upstart job does
        that already.
    - debian/bluez-alsa.install: Install ALSA bluetooth configuration into the
      right place for ALSA 1.0.25.
    - Add debian/source_bluez.py Apport package hook. Install in
      debian/bluez.install.
    - debian/control: Build against libnl3-dev, not libnl-dev.
    - debian/socket_audio.patch: re-enable the socket API for the bluetooth
      audio manager. This reverts an upstream change that switches to the
      MediaEndpoint DBus API by default, but it looks like PulseAudio isn't
      quite ready to use that yet. (LP #918736)
    - Add sbc_mmx.patch: Fix building with gcc 4.7. Not applied right now.
    - Drop debian/bluez.preinst and debian/bluez-alsa.preinst: Obsolete
      conffile migrations, 10.04 LTS has a much newer version.
  * 4.98-2 fixes building C++ apps. (LP: #927097)

bluez (4.98-2) unstable; urgency=low

  * Provides proximity.conf by bluez. (Closes: #656889)
    Update debian/bluez.install. proximity.conf was installed to
    etc/bluetooth/proximity.conf.
 -- Martin Pitt <email address hidden> Wed, 22 Feb 2012 10:51:07 +0100