Landscape client settings UI has more complex state than the underlying file
Bug #931937 reported by
Geoff Teale
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Landscape Client |
Fix Released
|
High
|
Geoff Teale | ||
Bug Description
The landscape settings UI needs to present two distinct classes of configuration (hosted and LDS), but the underlying config file doesn't reflect this distincton. Attempting to simulate this makes the code overly complicated.
This could be resolved by introducing intermediate persistance for the UI (GConf) and implementing proper state transitions in the client.
Related branches
lp:~tealeg/landscape-client/ui-state
- Alberto Donato (community): Approve
- Free Ekanayaka (community): Approve
-
Diff: 544 lines (+535/-0)2 files modifiedlandscape/ui/model/configuration/state.py (+312/-0)
landscape/ui/model/configuration/tests/test_state.py (+223/-0)
lp:~tealeg/landscape-client/ui-storage
- Alberto Donato (community): Approve
- Free Ekanayaka (community): Approve
-
Diff: 1891 lines (+1196/-327)12 files modifiedglib-2.0/schemas/com.canonical.landscape-client-settings.gschema.xml (+37/-0)
landscape/ui/controller/configuration.py (+11/-35)
landscape/ui/controller/tests/test_configuration.py (+5/-5)
landscape/ui/lib/polkit.py (+3/-2)
landscape/ui/model/configuration/mechanism.py (+2/-1)
landscape/ui/model/configuration/proxy.py (+5/-2)
landscape/ui/model/configuration/state.py (+329/-144)
landscape/ui/model/configuration/tests/test_state.py (+458/-137)
landscape/ui/model/configuration/tests/test_uisettings.py (+189/-0)
landscape/ui/model/configuration/uisettings.py (+57/-0)
landscape/ui/tests/helpers.py (+95/-0)
setupui.py (+5/-1)
| tags: |
added: points-3 removed: points-4 |
| Changed in landscape-client: | |
| milestone: | 12.02.2 → 12.03.1 |
| Changed in landscape-client: | |
| status: | In Progress → Fix Committed |
| Changed in landscape-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
