Messaging Menu

Inconsistency between messaging menu and sound menu pips

Bug #933593 reported by Omer Akram on 2012-02-16

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Ayatana Design	Fix Released	Undecided	Matthew Paul Thomas
Messaging Menu	Fix Released	High	Lars Karlitski
The Sound Menu	Fix Released	High	Conor Curran	The Sound Menu 0.8.5
indicator-sound (Ubuntu)	Fix Released	High	Unassigned

Bug Description

In precise now, the running indicator for apps in the messaging menu is away from the app icon but in the SoundMenu they are quite near. I don't know which is what design wants but I'd prefer what we have in the messaging menu now.

see screenshot

Related branches

lp:~cjcurran/indicator-sound/move-app-icon-in-from-the-gutter

Merged into lp:indicator-sound/fifth

Charles Kerr (community): Approve on 2012-03-30

lp:indicator-sound/fifth

lp:ubuntu/lucid/indicator-sound (Merged)

lp:ubuntu/precise/indicator-sound

Revision history for this message

Omer Akram (om26er) wrote on 2012-02-16:

Untitled.png Edit (76.2 KiB, image/png)

Revision history for this message

Adolfo Jayme Barrientos (fitojb) wrote on 2012-02-16:

That difference in the spacing of pips is due to the Messaging menu having elements with a radio button (the IM status menu items). In order to be equal, the Messaging menu needs to be redesigned to remove the radio buttonsor the Sound menu be redesigned to add menu items with radio buttons?

Therefore I don't see this as a problem, but maybe other solutions may exist. Opinions?

Revision history for this message

Conscious User (conscioususer) wrote on 2012-02-16:

According to

https://wiki.ubuntu.com/MenuLayout#Horizontal_padding

the current design of both menus is correct. The left column is normally reserved for radio/check/progress/playing symbols, with icons coming after, but the sound menu is an approved exception.

But I don't know how up-to-date this wiki is.

Revision history for this message

Conor Curran (cjcurran) wrote on 2012-02-28:

Yes the icon for the sound menu should be in the 'gutter'. As for the messaging menu the implementation is spec compliant but granted there is a design inconsistency there.

Conor Curran (cjcurran) on 2012-02-28

Changed in indicator-sound:
status:	New → Incomplete
Changed in indicator-messages:
status:	New → Incomplete

Conor Curran (cjcurran) on 2012-03-29

Changed in indicator-sound:
assignee:	nobody → Conor Curran (cjcurran)

Revision history for this message

Matthew Paul Thomas (mpt) wrote on 2012-03-29:

Yes, please change the spacing in the sound menu to be consistent with the messaging menu, battery menu, network menu, and user menu. Thanks Conor.

Changed in ayatana-design:
assignee:	nobody → Matthew Paul Thomas (mpt)
status:	New → Fix Committed
Changed in indicator-messages:
status:	Incomplete → Invalid
Changed in indicator-sound:
status:	Incomplete → Triaged

Conor Curran (cjcurran) on 2012-03-29

Changed in indicator-sound:
milestone:	none → 0.8.5

Revision history for this message

Matthew Paul Thomas (mpt) wrote on 2012-03-29:

UI Freeze exception request sent to ubuntu-doc@.

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2012-03-29:

I'm in a good mood today, so I'll give a +1 from Docs. The sound menu is in one screenshot though, so let's get this change is as soon as possible. Thanks!

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2012-03-29:

specifically, it's unity-appmenu-intro.png

Conor Curran (cjcurran) on 2012-03-30

Changed in indicator-sound:
status:	Triaged → In Progress
Changed in indicator-sound (Ubuntu):
status:	New → In Progress

Conor Curran (cjcurran) on 2012-03-30

Changed in indicator-sound:
importance:	Undecided → High
status:	In Progress → Fix Released
Changed in indicator-sound (Ubuntu):
importance:	Undecided → High

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-30:

This bug was fixed in the package indicator-sound - 0.8.5.0-0ubuntu1

---------------
indicator-sound (0.8.5.0-0ubuntu1) precise; urgency=low

  * New upstream release.
    - Inconsistency between messaging menu and sound menu pips (LP: #933593)
    - indicator-sound-service crashed with SIGSEGV in
      fast_validate() (LP: #949837)
    - free-memory-read crash in indicator-sound-service's file
      monitoring (LP: #965848)
    - minor memory leaks in blacklist handling (LP: #960578)
    - FIX (LP: FIX)
  * -debian/patches/lp_945827.patch, debian/patches/lp_960846.patch
     - dropped, merged upstream
-- Ken VanDine <email address hidden> Fri, 30 Mar 2012 14:45:03 -0400