OEM Priority Project

The prompt for installing MP3 playback support dialogue box does not fit in a 1024x600 display

Bug #962860 reported by Chih-Hsyuan Ho on 2012-03-23

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
OEM Priority Project	Fix Released	Medium	Ursula Junque
Precise	Fix Released	Undecided	Unassigned
libubuntuone	Status tracked in Trunk
Stable-3-0	Fix Released	High	dobey	libubuntuone 3.0.1
Trunk	Fix Released	High	dobey
libubuntuone (Ubuntu)	Fix Released	High	dobey
Precise	Fix Released	High	dobey	Ubuntu precise-updates

Bug Description

* Ubuntu Release: 12.04 Beta1
* Steps to reproduce it:
1. Click on link to "Ubuntu One" music store
2. Click on any album link to open up its play list
3. Try to trial play any of the songs in the list

Please see the attached screen shots for more information.

Tags:

Related branches

lp:~dobey/libubuntuone/alertbar-align

Merged into lp:libubuntuone at revision 152

Alejandro J. Cura (community): Approve (code and irl) on 2012-04-19

Roberto Alsina (community): Approve (code review) on 2012-04-19

lp:~dobey/libubuntuone/alertbar-align-3-0

Merged into lp:libubuntuone/stable-3-0 at revision 159

Manuel de la Peña (community): Approve on 2012-04-23

lp:ubuntu/precise-proposed/libubuntuone

lp:ubuntu/quantal/libubuntuone

Revision history for this message

Chih-Hsyuan Ho (chih) wrote on 2012-03-23:

Screenshot rhythmbox with launcher.png Edit (221.8 KiB, image/png)

Kent Lin (kent-jclin) on 2012-03-23

Changed in oem-priority:
importance:	Undecided → High

Kent Lin (kent-jclin) on 2012-03-23

Changed in oem-priority:
importance:	High → Medium

Revision history for this message

Rick Spencer (rick-rickspencer3) wrote on 2012-03-30:

Is it possible to resize the dialog to fit in a width of only 600 pix?

Changed in rhythmbox (Ubuntu):
assignee:	nobody → Canonical Desktop Team (canonical-desktop-team)
importance:	Undecided → Low

James M. Leddy (jm-leddy) on 2012-04-02

Changed in oem-priority:
assignee:	nobody → Ursula Junque (ursinha)

James M. Leddy (jm-leddy) on 2012-04-03

Changed in rhythmbox (Ubuntu):
status:	New → Invalid
Changed in rhythmbox-ubuntuone:
assignee:	nobody → Canonical Desktop Team (canonical-desktop-team)
status:	New → Incomplete
status:	Incomplete → New
Changed in rhythmbox-ubuntuone (Ubuntu):
assignee:	nobody → Canonical Desktop Team (canonical-desktop-team)
importance:	Undecided → Medium

Revision history for this message

James M. Leddy (jm-leddy) wrote on 2012-04-04:

libubuntone-shorten-mp3install-message.diff Edit (2.8 KiB, text/plain)

Changes the message to "MP3 playback plugin must be installed to play Previews and Purchased Music."

Changed in rhythmbox-ubuntuone:
status:	New → Invalid
Changed in rhythmbox-ubuntuone (Ubuntu):
status:	New → Invalid
Changed in libubuntuone (Ubuntu):
assignee:	nobody → Canonical Desktop Team (canonical-desktop-team)

Revision history for this message

dobey (dobey) wrote on 2012-04-04:

Is there a string/UI freeze break approval for this? I don't see one here.

Also, why is this not being done as a branch against upstream?

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2012-04-04:

The attachment "libubuntone-shorten-mp3install-message.diff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags:

added: patch

Revision history for this message

James M. Leddy (jm-leddy) wrote on 2012-04-04:

Screenshot from 2012-04-04 15:55:31.png Edit (275.0 KiB, image/png)

Screenshot with the shorter message.

Revision history for this message

James M. Leddy (jm-leddy) wrote on 2012-04-04:

libubuntone-shorten-mp3install-message-against-trunk.diff Edit (646 bytes, text/plain)

In response to comment #4, patch against trunk.

Rick McBride (rmcbride) on 2012-04-06

Changed in libubuntuone:
assignee:	nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
status:	New → Triaged

Revision history for this message

Micah Gersten (micahg) wrote on 2012-04-19:

Unsubscribing ubuntu-sponsors until "upstream" Ubuntu One decides what they want to do with this, Also, no UIFe as mentioned in comment #4. Please resubscribe ubuntu-sponsors when the appropriate paperwork is filed.

Revision history for this message

Manuel de la Peña (mandel) wrote on 2012-04-19:

Example of the widget running as in trunk and with the proposed fix (background) Edit (926.0 KiB, image/png)

Fixing the bug by changing the text is not the correct way. What is happening here is that the label is not wrapping which makes the frame be too big. If we changed the text we would just be fixing the eng version (I do agree that the proposed text is better).

I propose to fix the bug by making the text wrap which will ensure that the widget uses the correct size and will be fix the issue for all langs. Also, doing that will not require a UIFe because we are talking about a bug and we are not being a PITA to the translators.

You can see an attachment with the image of the new wrappig version (background) and the old one. I have also added a branch with the fix which the u1 team will ensure that lands following the correct paper work.

Revision history for this message

Manuel de la Peña (mandel) wrote on 2012-04-19:

#10

Also, I forgot to mention, there are padding issues in there, I'll fix those to (icon and button)

Revision history for this message

Manuel de la Peña (mandel) wrote on 2012-04-19:

#11

Fix used in music player in a small screen. Edit (292.5 KiB, image/png)

The following is the fix running in a small screen

dobey (dobey) on 2012-04-19

no longer affects:	rhythmbox-ubuntuone (Ubuntu)
no longer affects:	rhythmbox (Ubuntu)
no longer affects:	rhythmbox-ubuntuone
Changed in libubuntuone (Ubuntu):
assignee:	Canonical Desktop Team (canonical-desktop-team) → Rodney Dawes (dobey)
status:	New → Triaged
importance:	Undecided → High

James M. Leddy (jm-leddy) on 2012-04-30

Changed in oem-priority:
status:	New → Triaged

dobey (dobey) on 2012-05-18

Changed in libubuntuone (Ubuntu Precise):
milestone:	none → precise-updates

Revision history for this message

Chris Halse Rogers (raof) wrote on 2012-05-23:

#12

Why is this not yet fixed in Quantal? We're getting past the time where I'm happy to pocket-copy from precise-updates to quantal.

I'll accept this now, but please also upload to quantal. There's no reason quantal should wait 7 days for the fix.

Changed in libubuntuone (Ubuntu Precise):
status:	Triaged → Fix Committed
tags:	added: verification-needed

Revision history for this message

Chris Halse Rogers (raof) wrote on 2012-05-23: Please test proposed package

#13

Hello Chih-Hsyuan, or anyone else affected,

Accepted libubuntuone into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message

Chih-Hsyuan Ho (chih) wrote on 2012-05-23:

#14

Screenshot from 2012-05-23 02_05_24.png Edit (285.1 KiB, image/png)

With the gir1.2-ubuntuoneui-3.0 and libubuntuoneui-3.0-1 in precise proposed (main), this issue is properly addressed (a screen shot is attached.)

Jean-Baptiste Lallement (jibel) on 2012-05-23

tags:

added: verification-done
removed: verification-needed

Revision history for this message

dobey (dobey) wrote on 2012-05-23:

#15

Chris, because we want it pocket-copied. We'll be doing new releases off a new stable branch soon for Quantal, but having to resort to 0ubuntu0.1 numbering for releasing the exact same code on both Q and P is tedious, so we're trying to avoid that until we start having new releases.

Also, libubuntuone is FTBFS on Quantal at the moment, due to changes in gcc 4.7 adding a new warning which isn't available to use in gcc 4.6 on Precise, which makes fixing it a bit difficult, but which I hope to have fixed soon.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-05-25:

#16

This bug was fixed in the package libubuntuone - 3.0.1-0ubuntu1.1

---------------
libubuntuone (3.0.1-0ubuntu1.1) quantal; urgency=low

* New upstream release.
- Enable line wrap for the MP3/subscribe alert label. (LP: #962860)
-- Rodney Dawes <email address hidden> Mon, 21 May 2012 16:30:28 -0400

Changed in libubuntuone (Ubuntu):
status:	Triaged → Fix Released

James M. Leddy (jm-leddy) on 2012-05-25

Changed in oem-priority:
status:	Triaged → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-05-30:

#17

This bug was fixed in the package libubuntuone - 3.0.1-0ubuntu1

---------------
libubuntuone (3.0.1-0ubuntu1) precise-proposed; urgency=low

* New upstream release.
- Enable line wrap for the MP3/subscribe alert label. (LP: #962860)
-- Rodney Dawes <email address hidden> Mon, 21 May 2012 16:30:28 -0400