Resume fails if kernel swsusp method is not configured

Bug #985346 reported by A Dasgupta
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
uswsusp (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

Bug in script:

    debian/initramfs-tools/scripts/local-premount/uswsusp

(This script has stayed the same at least from lucid to precise.
I guess this will need to go upstream?)

Problem:

The uswsusp initramfs boot script (scripts/local-premount/uswsusp)
exits if the kernel swsusp's "resume=<dev>" is not set (i.e. it is set
neither in initramfs conf.d/resume nor as a grub boot parameter)
resulting in a failed resume from hibernation.

This should not happen since /sbin/resume has its own config file and
the script does not pass the "resume=<dev>" parameter to /sbin/resume
anyway, so /sbin/resume should be run independently of the
"resume=" parameter (unless the noresume boot parameter is present).

Fix:

The line

    [ -n ${resume}" ] || exit 0;

should have been

    [ -z "${noresume}" ] || exit 0;

Patch attached.

Comment: An alternative fix would be to modify the above boot script
to pass the "resume=<dev>" parameter as /sbin/resume -r ${resume},
which would let users specify the resume device in a more unified
way between kernel swsusp and userland uswsusp methods. But
it would also create more complications (/sbin/resume's config file
may not get used for resume anymore) and it will disturb the current
independence of the kernel and userland methods as well.
.

Tags: patch
Revision history for this message
A Dasgupta (adg) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch for boot script initramfs-tools/scripts/local-premount/uswsusp" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in uswsusp (Ubuntu):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.