AM_PATH_PYTHON regression

Bug #997456 reported by Robert Collins
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
automake1.11 (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Won't Fix
Medium
Unassigned

Bug Description

[Test Case]
You can reproduce it by attempting a 'make distcheck' in any automake based AM_PYTHON using package (e.g. subunit).

[Regression Potential]
This fixes bad code with more careful code, so potential is low. The test case described should be all that is necessary.

------------------

AM_PATH_PYTHON used to generate install logic like:
if test -z "$(DESTDIR)"; then \
   PYTHON=$(PYTHON) $(py_compile) --basedir "$(demodir)" $$dlist; \
else \
  PYTHON=$(PYTHON) $(py_compile) --destdir "$(DESTDIR)" --basedir "$(demodir)" $$dlist; \
fi; \

Now however, it generates it without the test -z guard, which makes regular 'make install', and 'make distcheck' fail:
make distcheck
....
../py-compile: Missing argument to --destdir.

Revision history for this message
Robert Collins (lifeless) wrote :

(Will attach patch soon, just testing it out)

Revision history for this message
Robert Collins (lifeless) wrote :
tags: added: patch
Changed in automake1.11 (Ubuntu):
importance: Undecided → Medium
tags: added: regression-release
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in automake1.11 (Ubuntu):
status: New → Confirmed
Revision history for this message
Barry Warsaw (barry) wrote :

Hi Robert, it looks like you're reporting/fixing this against the Precise version of the package, so a couple of questions:

- Is this still a problem with the Quantal version?
- If so, is the patch still appropriate? (Note that we're sync'd back up with Debian for the quantal version)
- Can you please fill out the information for an SRU of the package https://wiki.ubuntu.com/StableReleaseUpdates
  Specifically, it would help to have a detailed description of how to reproduce the bug so that we can verify when it is fixed.

Thanks!

Changed in automake1.11 (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Robert Collins (lifeless) wrote :

Yes - see http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/automake1.11/quantal/view/head:/lib/am/python.am (You could have seen this yourself :P)
Yes.

You can reproduce it by attempting a 'make distcheck' in any automake based AM_PYTHON using package (e.g. subunit).

The impact is already described - it generates bad code, and is a regression from earlier versions of automake. I suspect I haven't sent it upstream, I probably got distracted :(.

Changed in automake1.11 (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Robert Collins (lifeless) wrote :

(btw, I really dislike this 'mark incomplete' thing when the bug has all the data needed for validation :> - we know its not going to stop being a bug on precise until its explicitly fixed.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package automake1.11 - 1:1.11.5-2ubuntu1

---------------
automake1.11 (1:1.11.5-2ubuntu1) quantal; urgency=low

  * Fix make install (and thus distcheck) for Python - only call py-compile
    with a --destdir parameter if it is indeed set. (LP: #997456)
 -- Robert Collins <email address hidden> Thu, 10 May 2012 16:59:23 +1200

Changed in automake1.11 (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Re-targetted at quantal and precise-proposed, uploaded to both. Unsubscribing sponsors.

Changed in automake1.11 (Ubuntu Precise):
status: New → Triaged
importance: Undecided → Medium
description: updated
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 997456] Re: AM_PATH_PYTHON regression

I'm forwarding this upstream now. Mea culpa for not doing so earlier.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted automake1.11 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/automake1.11/1:1.11.3-1ubuntu3 in a few hours and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in automake1.11 (Ubuntu Precise):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Stéphane Graber (stgraber) wrote :

subunit in precise fails because of http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=669491 and the version in quantal no longer has a distcheck target.

What other package can I use to test the SRU?

Revision history for this message
Stéphane Graber (stgraber) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing the automake1.11 SRU from precise-proposed based on upstream's rejection of this change (and the 33 days without verification of the fix).

Robert, if you still think this is necessary in spite of upstream's reject then we can re-SRU it; but it seems to me it's probably better to just make sure py-compile is being updated in step with the related macros.

Changed in automake1.11 (Ubuntu Precise):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.