diff -Nru kubuntu-notification-helper-14.04ubuntu9/debian/changelog kubuntu-notification-helper-14.04ubuntu10/debian/changelog --- kubuntu-notification-helper-14.04ubuntu9/debian/changelog 2014-04-01 11:34:41.000000000 +0000 +++ kubuntu-notification-helper-14.04ubuntu10/debian/changelog 2014-04-02 09:55:51.000000000 +0000 @@ -1,3 +1,15 @@ +kubuntu-notification-helper (14.04ubuntu10) trusty; urgency=medium + + * Work around a bug in ubuntu-drivers-common not reporting the vbox + dkms driver as recommended. Previously recommended && !installed were the + primary requirements for a driver notification. Now we will also consider + the possible-driver-list-length. If the list only has one entry we will + show a notification even if that one entry is not recommended. + * Add a kDebug to the module's ::init to see when the lazy init timer + actually runs out. + + -- Harald Sitter Wed, 02 Apr 2014 11:52:05 +0200 + kubuntu-notification-helper (14.04ubuntu9) trusty; urgency=medium * Port driverevent to new dbus API, needs some code copy for marshalling diff -Nru kubuntu-notification-helper-14.04ubuntu9/src/daemon/driverevent/driverevent.cpp kubuntu-notification-helper-14.04ubuntu10/src/daemon/driverevent/driverevent.cpp --- kubuntu-notification-helper-14.04ubuntu9/src/daemon/driverevent/driverevent.cpp 2014-04-01 11:15:15.000000000 +0000 +++ kubuntu-notification-helper-14.04ubuntu10/src/daemon/driverevent/driverevent.cpp 2014-04-02 09:45:28.000000000 +0000 @@ -99,13 +99,21 @@ // be fully used by QList :'< // Manually iter instead. Driver driver = device.drivers.at(i); - if (driver.recommended) { + // If there is only one driver listed, we consider it an option. + // This works around an issue with virtualbox where the one and + // only driver is not marked as recommended. However, from + // a notification point of view it makes sense to notify about + // single-option drivers all the same as even if not considered + // recommended they probably should be looked at by the user. + if (driver.recommended || device.drivers.length() == 1) { QApt::Package *package = m_aptBackend->package(driver.packageName); if (package) { if (!package->isInstalled()) { m_showNotification = true; break; } + } else { + kDebug() << "package" << driver.packageName << "could not be found"; } } } diff -Nru kubuntu-notification-helper-14.04ubuntu9/src/daemon/notificationhelpermodule.cpp kubuntu-notification-helper-14.04ubuntu10/src/daemon/notificationhelpermodule.cpp --- kubuntu-notification-helper-14.04ubuntu9/src/daemon/notificationhelpermodule.cpp 2014-04-01 11:35:20.000000000 +0000 +++ kubuntu-notification-helper-14.04ubuntu10/src/daemon/notificationhelpermodule.cpp 2014-04-02 09:28:43.000000000 +0000 @@ -81,6 +81,7 @@ void NotificationHelperModule::init() { + kDebug(); m_configWatcher = new ConfigWatcher(this); m_apportEvent = new ApportEvent(this, "Apport");