diff -Nru unity-5.12/AUTHORS unity-5.14.0/AUTHORS --- unity-5.12/AUTHORS 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/AUTHORS 2012-07-18 11:12:56.000000000 +0000 @@ -1,24 +1,23 @@ - 3v1n0 , Marco Trevisan (Treviño) - agateau - alanbell@ubuntu.com + 3v1n0 , Marco Trevisan (Trevi?o) + ?ukasz 'sil2100' Zemczak Albert Astals - Alejandro Piñeiro - Alexandros Frantzis - Alexandros Frantzis , Marc Ordinas i Llopis , Jay Taoko + Alejandro Pi?eiro Alex Launi Alex Launi , Allan LeSage + Alexandros Frantzis + Alexandros Frantzis , Marc Ordinas i Llopis , Jay Taoko Andrea Azzarone Andrea Azzarone Andrea Cimitan Andrey Logvinov + Aur?lien G?teau Benjamin Kerensa Bilal Akhtar Bilal Akhtar , Thomi Richards Brandon Schaefer Brandon Schaefer Brandon Schaefer + Brandon Schaefer Brandon Schaefer , Thomi Richards Brandon Schaefer Chase Douglas @@ -30,8 +29,8 @@ David Gomes David Planella Didier Roche - foxoman Gabor Kelemen + Gary Lasker Gordon Allott Henri De Veene Jani Monoses @@ -40,31 +39,30 @@ Jason Smith Jason Smith , Andrea Cimitan Jason Smith , Jay Taoko , Brandon Schaefer - Jason Smith , Marco Trevisan (Treviño) , Thomi Richards - Jason Smith , smspillaz + Jason Smith , Marco Trevisan (Trevi?o) , Thomi Richards Jason Smith , Tim Penhey - jassmith@gmail.com - Jay Ó Broin + Jason Smith , smspillaz + Jay ? Broin Jay Taoko - Jay Taoko , Mirco Müller + Jay Taoko , Mirco M?ller , Mirco M?ller , Andrea Cimitan Jay Taoko , Robert Carr Jeremy Bicha Kevin DuBois Koichi Akabe Lars Uebernickel - Loïc Molinari + Lo?c Molinari Lorenzo Mattei Luke Yelavich Marco Biscaro Marco Biscaro , Rick Spencer Marco Trevisan + Marco Trevisan (Trevi?o) + Marco Trevisan (Trevi?o) , 3v1n0 + Marco Trevisan (Trevi?o) , Andrea Cimitan + Marco Trevisan (Trevi?o) , Brandon Schaefer , Tim Penhey + Marco Trevisan (Trevi?o) , Michal Hruby + Marco Trevisan (Trevi?o) , Thomi Richards Marco Trevisan - Marco Trevisan (Treviño) - Marco Trevisan (Treviño) , 3v1n0 - Marco Trevisan (Treviño) , Andrea Cimitan - Marco Trevisan (Treviño) , Brandon Schaefer , Tim Penhey - Marco Trevisan (Treviño) , Michal Hruby - Marco Trevisan (Treviño) , Thomi Richards Marius Gedminas Martin Albisetti Martin Mrazik @@ -74,6 +72,9 @@ Michael Vogt Michal Hruby Mikkel Kamstrup Erlandsen + Mirco M?ller + Mirco M?ller , Mirco M?ller + Mirco M?ller Mirco Müller Mitsuya Shibata Neil Jagdish Patel @@ -83,7 +84,7 @@ Paolo Rotolo Paul Sladen Paul Sladen , Andrea Cimitan - Rafał Cieślak + Rafa? Cie?lak Ricardo Mendoza Robert Carr Robert Carr @@ -92,16 +93,10 @@ Sam Spilsbury Sam Spilsbury , Daniel van Vugt Sebastien Bacher - smspillaz - smspillaz , Daniel van Vugt - smspillaz , Sam Spilsbury Sven Baars Tarmac Ted Gould - Thomas Voß - Thomi Richards - Thomi Richards , Alex Launi - Thomi Richards , Thomi Richards + Thomas Vo? Thomi Richards Thomi Richards , Alex Launi Thomi Richards , Brandon Schaefer @@ -110,6 +105,9 @@ Thomi Richards , Ted Gould Thomi Richards , Thomi Richards Thomi Richards , Tim Penhey + Thomi Richards + Thomi Richards , Alex Launi + Thomi Richards , Thomi Richards Tim Penhey Tim Penhey , Gordon Allott Tim Penhey , Jason Smith @@ -118,3 +116,10 @@ Unity Merger Victor Eduardo Zaid Yeganeh + agateau + alanbell@ubuntu.com + foxoman + jassmith@gmail.com + smspillaz + smspillaz , Daniel van Vugt + smspillaz , Sam Spilsbury diff -Nru unity-5.12/ChangeLog unity-5.14.0/ChangeLog --- unity-5.12/ChangeLog 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/ChangeLog 2012-07-18 11:12:56.000000000 +0000 @@ -1,3 +1,529 @@ +2012-07-18 Gary Lasker + + manual-tests/SoftwareCenter.txt: added tests for Ubuntu Software Center/Unity launcher integration feature. Fixes: . Approved by Marco Trevisan (Trevi?o), Brandon Schaefer, Christopher Lee. + +2012-07-12 Gary Lasker + + clarify the steps for selecting a game (many thanks Christopher Lee) + +2012-07-10 Gary Lasker + + targeted to the 5.0 series branch, update Unity launcher Software Center integration manual tests and provide additional important test cases to thoroughly test the full set of integration details, including all of the bug fixes for Unity branch https://code.launchpad.net/~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes/+merge/110214 and the corresponding Software Center branch https://code.launchpad.net/~gary-lasker/software-center/unity-launcher-integration-fixes + +2012-07-17 Andrea Azzarone + + Backport lp:~thomir/unity/fix-for-754565. Fixes: https://bugs.launchpad.net/bugs/754565. Approved by Marco Trevisan (Trevi?o). + +2012-07-16 Andrea Azzarone + + Minor changes. + +2012-07-16 Andrea Azzarone + + Backport AP test. + +2012-07-16 Andrea Azzarone + + Backport lp:~yeganeh/unity/fix-for-754565. + +2011-09-30 Zaid Yeganeh + + [unityshell] Added key modifier/flags to the mouse events of launcher icons, and added logic for shift+click = new instance + + modified: + plugins/unityshell/src/AbstractLauncherIcon.h + - Added flags to the mouse events + + plugins/unityshell/src/Launcher.cpp + - Pass through key flags to launcher icons + + plugins/unityshell/src/LauncherIcon.cpp + - Logic added for shift click based on flag state + + plugins/unityshell/src/LauncherIcon.h + plugins/unityshell/src/SimpleLauncherIcon.cpp + plugins/unityshell/src/SimpleLauncherIcon.h + - Changed interfaces based on the AbstractLauncherIcon + +2012-07-17 Bilal Akhtar + + SoftwareCenterLauncherIcon: avoid the "Waiting to Install" tooltip to stay after installation + + Be consistent with auto-hiding launcher.. Fixes: https://bugs.launchpad.net/bugs/925014, https://bugs.launchpad.net/bugs/1002440, https://bugs.launchpad.net/bugs/1012896. Approved by Marco Trevisan (Trevi?o), Brandon Schaefer, Thomi Richards. + +2012-06-27 Bilal Akhtar + + Merge from 5.0 branch + +2012-06-27 Bilal Akhtar + + Added test, need to probably fix it though + +2012-06-20 Bilal Akhtar + + Fix urgent quirk after installation of paid app + +2012-06-17 Bilal Akhtar + + Fixed string comparison, thanks Tim + +2012-06-13 Bilal Akhtar + + Fix the delay in adding launcher icons to the launcher by ensuring a redraw takes place (bug #1012896) and also fix the string comparison of desktop file with software-center-agent. + +2012-06-13 Bilal Akhtar + + Fix bug #925014 on the Unity side. Check if an aptdaemon task was specified. If not, then the icon tooltip will stay the same (i.e. the app name, rather than Waiting to install) + +2012-06-13 Bilal Akhtar + + Fix bug #1002440, by not creating SC launcher icon if the desktop file was unspecified or set to SC's agent, as in the case of paid apps. Instead, the icon will be added at the end of the install + +2012-07-17 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-987955. Fixes: https://bugs.launchpad.net/bugs/987955. Approved by Marco Trevisan (Trevi?o). + +2012-07-03 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-987955. + +2012-07-16 Brandon Schaefer + + Scale mode now does not skip the first super to open the dash.. Fixes: https://bugs.launchpad.net/bugs/1023811. Approved by Marco Trevisan (Trevi?o). + +2012-07-13 Brandon Schaefer + + * fixes launcher -> scale mode -> dash problem + +2012-07-13 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-772445. Fixes: https://bugs.launchpad.net/bugs/772445. Approved by Marco Trevisan (Trevi?o). + +2012-07-13 Andrea Azzarone + + Minor changes. + +2012-07-13 Andrea Azzarone + + Merge trunk. + +2012-07-13 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-772445 + +2012-07-13 Andrea Azzarone + + Backport branch lp:~andyrock/unity/fix-839717. Fixes: https://bugs.launchpad.net/bugs/839717. Approved by Marco Trevisan (Trevi?o). + +2012-07-13 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-839717. + +2012-07-09 Marco Trevisan (Trevi?o) + + KeyboardUtil: fix possible crash if XkbGetKeyboard returns null + + Also use initializer list. Fixes: https://bugs.launchpad.net/bugs/920258. Approved by Gord Allott. + +2012-07-06 Marco Trevisan (Trevi?o) + + KeyboardUtil: fix typo + +2012-07-06 Marco Trevisan (Trevi?o) + + KeyboardUtil: oops, fix return value. + +2012-07-06 Marco Trevisan (Trevi?o) + + KeyboardUtil: fix possible crash if XkbGetKeyboard returns null + + Also use initializer list + +2012-07-04 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-932531. Fixes: https://bugs.launchpad.net/bugs/932531. Approved by Tim Penhey. + +2012-07-03 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-932531. + +2012-07-04 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-bug-955158. Fixes: https://bugs.launchpad.net/bugs/955158. Approved by Tim Penhey. + +2012-07-04 Andrea Azzarone + + Remove default_item_layout/list. + +2012-07-03 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-bug-955158. + +2012-07-03 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-934062. Fixes: https://bugs.launchpad.net/bugs/934062. Approved by Marco Trevisan (Trevi?o). + +2012-07-03 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-934062. + +2012-07-02 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-851982.. Fixes: https://bugs.launchpad.net/bugs/851982. Approved by Brandon Schaefer. + +2012-07-02 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-851982 + +2012-06-29 Marco Trevisan (Trevi?o) + + PluginAdapterCompiz: ignore offscreen windows when looking for the top one. Fixes: https://bugs.launchpad.net/bugs/996604. Approved by Brandon Schaefer. + +2012-06-30 Marco Trevisan (Trevi?o) + + test_launcher: add autopilot test to check spread initialization on double click + +2012-06-30 Marco Trevisan (Trevi?o) + + PluginAdapterCompiz: ignore offscreen windows when looking for the top one + +2012-06-29 Didier Roche + + Fix a crash when a GError exception is triggered. Fixes: https://bugs.launchpad.net/bugs/778470. Approved by Sam Spilsbury. + +2012-06-28 Didier Roche + + import glib for handling the GError (LP: #778470) + +2012-06-28 Marco Trevisan (Trevi?o) + + DashView: filter out the unprintable keys when focusing the search bar + + The search bar can't be focused when invalid keys (such as shift, ctrl, F1...) are pressed.. Fixes: https://bugs.launchpad.net/bugs/931393. Approved by Andrea Azzarone. + +2012-06-28 Marco Trevisan (Trevi?o) + + DashView: filter out the unprintable keys when focusing the search bar + + The search bar can't be focused when invalid keys (such as shift, ctrl, F1...) are pressed... + +2012-06-28 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-1016239. Fixes: https://bugs.launchpad.net/bugs/1016239. Approved by Marco Trevisan (Trevi?o). + +2012-06-27 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-1016239 + +2012-06-27 Brandon Schaefer + + The dash will now open when invoked while in spread/scale mode.. Fixes: https://bugs.launchpad.net/bugs/944033. Approved by Thomi Richards. + +2012-06-26 Brandon Schaefer + + * Fixes opening the dash when in scale mode + +2012-06-25 Brandon Schaefer + + The switcher now focuses it's own window, instead of leaving it to the current one. Now Alt+F4 does not work while the switcher is active.. Fixes: . Approved by Thomi Richards. + +2012-06-25 Brandon Schaefer + + * SRU fix for alt+f4 re opening a program while using the switcher. + +2012-06-25 Brandon Schaefer + + Fixes closing the shurnk Hud when clicking outside it's geometry.. Fixes: https://bugs.launchpad.net/bugs/962651. Approved by Thomi Richards. + +2012-06-25 Brandon Schaefer + + * switched close and it... + +2012-06-25 Brandon Schaefer + + * ap and minor fixes + +2012-06-22 Brandon Schaefer + + * Hud will close when clicking anywhere outside of it's current geo (including being shrunk) + +2012-06-25 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-994163. Fixes: https://bugs.launchpad.net/bugs/994163. Approved by ?ukasz Zemczak. + +2012-06-22 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-994163. + +2012-06-22 Brandon Schaefer + + Fixes AP test, get_compiz_option wasn't included in utilities.. Fixes: . Approved by Thomi Richards. + +2012-06-21 Brandon Schaefer + + * fixes ap test get_compiz_option wasn't in 5.0 + +2012-06-21 Marco Trevisan (Trevi?o) + + IMTextEntry: don't ingore ctrl/alt keypress to make ibus still working. Fixes: . Approved by Brandon Schaefer. + +2012-06-22 Marco Trevisan (Trevi?o) + + IMTextEntry: don't ingore ctrl/alt keypress to make ibus still working + +2012-06-21 Brandon Schaefer + + Fixes focus problem when entering expo mode from KeyNav(Alt+F1).. Fixes: https://bugs.launchpad.net/bugs/962408. Approved by Marco Trevisan (Trevi?o). + +2012-06-21 Brandon Schaefer + + * Fixes going into expo mode from key nav mode (alt+f1) + +2012-06-21 Brandon Schaefer + + Documents and files now dragged from the Dash to the Launcher into an application will close the dash.. Fixes: https://bugs.launchpad.net/bugs/865168. Approved by Marco Trevisan (Trevi?o). + +2012-06-21 Brandon Schaefer + + * Dragging documents and files to an app on the launcher closes the dash. + +2012-06-20 Marco Trevisan (Trevi?o) + + IMTextEntry: ignore invalid keypress when using modifiers keys. + + All the key pressure when pressing the Alt or Super key should be ignored. + When pressing Ctrl key we should only allow: A key, arrow keys, Backspace or Delete keys and Home or Delete keys.. Fixes: https://bugs.launchpad.net/bugs/1013751. Approved by . + +2012-06-20 Marco Trevisan (Trevi?o) + + test_im_text_entry: fix the IMTextEntry inclusion + +2012-06-19 Marco Trevisan (Trevi?o) + + IMTextEntry: ignore invalid keypress when using modifiers keys. + + All the key pressure when pressing the Alt or Super key should be ignored. + When pressing Ctrl key we should only allow: A key, arrow keys, Backspace or + Delete keys and Home or Delete keys. + +2012-06-20 Marco Trevisan (Trevi?o) + + DashController / HudController: hide the overlay when the spread is initiated. Fixes: https://bugs.launchpad.net/bugs/870284. Approved by . + +2012-06-19 Marco Trevisan (Trevi?o) + + autopilot, added tests for Dash and Hud on spread + +2012-06-19 Marco Trevisan (Trevi?o) + + HudController: hide the HUD when the spread is initiated + +2012-06-19 Marco Trevisan (Trevi?o) + + DashController: hide the dash when spread is initiated + +2012-06-19 ?ukasz 'sil2100' Zemczak + + Cherry-picked from unity trunk (rev2407): + Launcher: Fix dragging to the last position when out of the launcher. Fixes: https://bugs.launchpad.net/bugs/971421. Approved by Marco Trevisan (Trevi?o). + +2012-06-18 ?ukasz 'sil2100' Zemczak + + Cherry-picked from unity trunk (rev2407): + Launcher: Fix dragging to the last position when out of the launcher + +2012-06-17 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-987674. Fixes: https://bugs.launchpad.net/bugs/987674. Approved by Tim Penhey. + +2012-06-15 Andrea Azzarone + + Fix bug 987674. + +2012-06-17 Andrea Azzarone + + Backport lp:~andyrock/unity/hud-reset + . Fixes: https://bugs.launchpad.net/bugs/1011507. Approved by Tim Penhey. + +2012-06-15 Andrea Azzarone + + Add missing files. + +2012-06-15 Andrea Azzarone + + Backport lp:~andyrock/unity/hud-reset. + +2012-06-06 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-1008656.. Fixes: https://bugs.launchpad.net/bugs/1008656. Approved by ?ukasz Zemczak. + +2012-06-06 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-1008656. + +2012-06-06 ?ukasz 'sil2100' Zemczak + + Back-porting fix from unity trunk. + When dragging a non-application, do not saturate all icons automatically, but only those that are needed. + + Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230).. Fixes: https://bugs.launchpad.net/bugs/863230. Approved by . + +2012-06-06 ?ukasz 'sil2100' Zemczak + + When dragging a non-application, do not saturate all icons automatically, but only those that are needed. + + Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230) + +2012-06-06 Andrea Azzarone + + Draw the result grid in proximity of the search entry. Backport lp:~andyrock/unity/fix-1008603. Fixes: https://bugs.launchpad.net/bugs/1008603. Approved by ?ukasz Zemczak. + +2012-06-06 Andrea Azzarone + + Backport lp:~andyrock/unity/fix-1008603 + +2012-06-06 ?ukasz 'sil2100' Zemczak + + Back-porting fix from unity trunk. + Don't show the switcher window during constructing the view. Wait for the ShowView timeout.. Fixes: https://bugs.launchpad.net/bugs/987156. Approved by Tim Penhey. + +2012-06-05 ?ukasz 'sil2100' Zemczak + + Added two manual-tests for testing the fixed behavior. Better have everything well tested. + +2012-06-05 ?ukasz 'sil2100' Zemczak + + Added a unit test for the switcher show functionality. The same as in the previous proposition. + +2012-06-05 ?ukasz 'sil2100' Zemczak + + Don't show the switcher window during constructing the view. Wait for the show timeout. + +2012-06-04 Andrea Azzarone + + Backports branch lp:~andyrock/unity/hud-text.. Fixes: https://bugs.launchpad.net/bugs/939436. Approved by Tim Penhey. + +2012-05-31 Andrea Azzarone + + Backport lp:~andyrock/unity/hud-text. + +2012-05-24 Marco Trevisan (Trevi?o) + + BamfLauncherIcon: Unset the BamfApplication when removing the icon. + + Doing this manually, we prevent that a duplicated application can be added between the removal of the BamfLauncherIcon and the effective destruction (that is controlled by a timeout in LauncherModel).. Fixes: https://bugs.launchpad.net/bugs/1003574. Approved by . + +2012-05-24 Marco Trevisan (Trevi?o) + + LauncherController: use glib::Signal to handle the Bamf matcher signal. + +2012-05-24 Marco Trevisan (Trevi?o) + + BamfLauncherIcon: Disconnect all the _bamf_app signals at once on removal. + +2012-05-24 Marco Trevisan (Trevi?o) + + GLib::SignalManager: allow to disconnect all the signals for a given Object. + + When the signal string name is empty, we disconnect all the sigals + for the given object. + +2012-05-24 Gord Allott + + * Capture information about the icon of the application to be installed from the software center. Re-use it when rendering the launcher interface. + * Fix bug #981168. Fixes: https://bugs.launchpad.net/bugs/981168. Approved by Gord Allott. + +2012-05-24 Gord Allott + + fixed up memory leaks + +2012-04-17 Jay Taoko + + * Capture information about the icon of the application to be installed from the software center. Re-use it when rendering the launcher interface. + +2012-04-16 Jay Taoko + + * Capture part of the content of Launcher::handle_dbus_method_call into a lambda call. + +2012-05-23 ?ukasz 'sil2100' Zemczak + + Backported andyrock's fix from lp:unity/6.0 - Unmute launcher (LP: #949448).. Fixes: https://bugs.launchpad.net/bugs/949448. Approved by Andrea Azzarone. + +2012-05-23 ?ukasz 'sil2100' Zemczak + + Backported andyrock's fix for LP: #949448 from lp:unity/6.0. + +2012-05-23 Andrea Azzarone + + Backports lp:~andyrock/unity/queue-draw-result-view-grid from lp:unity/6.0.. Fixes: . Approved by Andrea Azzarone, ?ukasz Zemczak. + +2012-05-23 Andrea Azzarone + + Backports branch lp:~andyrock/unity/queue-draw-result-view-grid. + +2012-05-23 Marco Trevisan (Trevi?o) + + UnityScreen: reduce the BGHash::RefreshColor() calls + + Don't call BGHash::RefreshColor() every atom on the XRoot window changes, + do it only when the target one changes. Fixes: . Approved by Andrea Azzarone. + +2012-05-23 Marco Trevisan (Trevi?o) + + UnityScreen: reduce the BGHash::RefreshColor() calls + + Don't call BGHash::RefreshColor() every atom on the XRoot window changes, + do it only when the target one changes. + +2012-05-23 Andrea Azzarone + + Backports branch lp:~vanvugt/unity/fix-987304.. Fixes: https://bugs.launchpad.net/bugs/987304. Approved by Marco Trevisan (Trevi?o). + +2012-05-23 Andrea Azzarone + + Backports branch lp:~vanvugt/unity/fix-987304. + +2012-05-23 Andrea Azzarone + + Backported fix from lp:unity/6.0 - Dash - search field is hidden by tooltips (LP: #978030).. Fixes: https://bugs.launchpad.net/bugs/978030. Approved by Andrea Azzarone, ?ukasz Zemczak. + +2012-05-23 Andrea Azzarone + + Backports branch lp:~andyrock/unity/fix-978030. + +2012-04-27 Andrea Azzarone + + Add AP tests. + +2012-04-27 Andrea Azzarone + + Disable the bfb/hudlaunchericon tooltip when the dash/hud is open. + Hide a launcher icon tooltip as soon as the dash/hud is shown. + +2012-05-23 ?ukasz 'sil2100' Zemczak + + Backported andyrock's fix from trunk - fix UnityViewWindow background when blur is disabled.. Fixes: . Approved by Gord Allott. + +2012-05-23 ?ukasz 'sil2100' Zemczak + + Backported andyrock's fix for LP: #989291. Fix UnityViewWindow background when blur is disabled. + +2012-05-21 Marco Trevisan (Trevi?o) + + Merged branches lp:~3v1n0/unity/launcher-double-icons-tests and lp:~3v1n0/unity/quick-app-reopen-icon-fix. Fixes: https://bugs.launchpad.net/bugs/772063, https://bugs.launchpad.net/bugs/995916, https://bugs.launchpad.net/bugs/999820. Approved by . + +2012-05-21 Marco Trevisan (Trevi?o) + + Merging fix for "Missing GIMP icon bug" + +2012-05-21 Marco Trevisan (Trevi?o) + + Merging single-icon AP tests. + +2012-04-27 Didier Roche + + Release\ 5.12.0 + 2012-04-26 Sebastien Bacher Revert r2331, it's creating hang issues on start.. Fixes: . Approved by Didier Roche. @@ -20,15 +546,15 @@ remove USC launcher again from unity on download/install failure or cancel -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) We need to flag a bamf view that we control using an icon using the "unity-seen" qdata, or unity will duplicate it on bamfdaemon respawn. (LP: #928912). Fixes: https://bugs.launchpad.net/bugs/928912. Approved by Michal Hruby, Tim Penhey. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) autopilot, test_launcher: removed the xclock test... We'll put it back soon. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) Merging thomi's fixes @@ -48,26 +574,26 @@ CLeaned up test. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) autopilot, use kill instead of pkill to close applications -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: export the application ID for introspection -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) autopilot, test_launcher: added test to check the launcher status after bamfdaemon killing -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) LauncherController: set the "unity-seen" qdata to all the BamfApplications we have This avoid that we create two icons for the same application instance. Moving to the safer GUINT... -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: Focus an application if no child window is actually on top of the stack. Raises all urgent windows. @@ -75,27 +601,27 @@ Plus, don't perform unneeded checks when focusing non-active applications.. Fixes: https://bugs.launchpad.net/bugs/802816, https://bugs.launchpad.net/bugs/986443. Approved by Tim Penhey. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) Merging with trunk. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) manual test: updated. -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) Merge with trunk -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) manual-tests, Launcher: added a test for non top non-focused windows -2012-04-21 Marco Trevisan (Treviño) +2012-04-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: raise all the urgent windows, if there are any -2012-04-21 Marco Trevisan (Treviño) +2012-04-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: focus an application if no child window is actually on top of the stack. @@ -104,64 +630,64 @@ Plus, don't perform unneeded checks for non-active applications. -2012-04-21 Marco Trevisan (Treviño) +2012-04-21 Marco Trevisan (Trevi?o) WindowManager: add method to get if a window is on top. Top window is a window that is on top of the stack, excluding invisible, not mapped, minimized, set "above" and unity windows. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) manual-test, Launcher: added manual test for the Chromium web applications. Fixes: . Approved by Tim Penhey. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) manual-test, Launcher: added manual test for the Chromium web applications -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) BamfLauncherIcon: activate the icon using the quicklist item using an Idle. This fixes the bug #986461 that caused the spread not to initiate clicking on the quicklist application name.. Fixes: https://bugs.launchpad.net/bugs/986461. Approved by Thomi Richards. -2012-04-26 Marco Trevisan (Treviño) +2012-04-26 Marco Trevisan (Trevi?o) WindowManager: removed the g_debug("%s", G_STRFUNC); from AddProperties dummy implementation -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) autopilot, test_quicklist: add a test to check that spread works when initiated by quicklist -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) autopilot, keybindings: include spread keybindings -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) autopilot, add WindowManager emulator -2012-04-25 Marco Trevisan (Treviño) +2012-04-25 Marco Trevisan (Trevi?o) test_quicklist: added test to check if the application label works -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) unityshell: set PluginAdapter as introspectable child -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) WindowManager: make it introspectable, implementation in PluginAdapter. -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) Merge with trunk -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: remove the _quicklist_activated_id related source on destruction -2012-04-21 Marco Trevisan (Treviño) +2012-04-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: activate the icon using the quicklist item using an Idle. @@ -178,7 +704,7 @@ 2012-04-25 Andrea Azzarone - Don't crop the bottom of results in card view when a category is not expanded.. Fixes: https://bugs.launchpad.net/bugs/975003. Approved by Marco Trevisan (Treviño). + Don't crop the bottom of results in card view when a category is not expanded.. Fixes: https://bugs.launchpad.net/bugs/975003. Approved by Marco Trevisan (Trevi?o). 2012-04-25 Andrea Azzarone @@ -198,7 +724,7 @@ 2012-04-25 Michal Hruby - Make sure hud's spinner stops spinning after hud service returns reply. Fixes: https://bugs.launchpad.net/bugs/987781. Approved by Gord Allott, Marco Trevisan (Treviño). + Make sure hud's spinner stops spinning after hud service returns reply. Fixes: https://bugs.launchpad.net/bugs/987781. Approved by Gord Allott, Marco Trevisan (Trevi?o). 2012-04-24 Michal Hruby @@ -214,7 +740,7 @@ 2012-04-24 Andrea Azzarone - Enable dnd for all launcher icons (and not just the ones matching the type).. Fixes: https://bugs.launchpad.net/bugs/880798. Approved by Marco Trevisan (Treviño). + Enable dnd for all launcher icons (and not just the ones matching the type).. Fixes: https://bugs.launchpad.net/bugs/880798. Approved by Marco Trevisan (Trevi?o). 2012-04-25 Andrea Azzarone @@ -234,7 +760,7 @@ 2012-04-24 Andrea Azzarone - Set a shortcut for the new apps on the launcher too.. Fixes: https://bugs.launchpad.net/bugs/778499. Approved by Marco Trevisan (Treviño). + Set a shortcut for the new apps on the launcher too.. Fixes: https://bugs.launchpad.net/bugs/778499. Approved by Marco Trevisan (Trevi?o). 2012-04-24 Andrea Azzarone @@ -252,17 +778,17 @@ Fixes bug #778499. -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) DeviceLauncherSection: updated to use glib::SignalManager and glib::Object This allow to be more safe; it fixes also some crashes caused by the fact that DeviceLauncherIcon didn't own the GVolume* object. Now it uses glib::Object completely, so we can automagically ref/unref the volume when the icon is created/removed.. Fixes: https://bugs.launchpad.net/bugs/918548, https://bugs.launchpad.net/bugs/977762. Approved by Andrea Azzarone. -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) DeviceLauncherSection: use glib::SignalManager -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) DeviceLauncherIcon: use a glib::Object to handle the volume. @@ -271,7 +797,7 @@ 2012-04-24 Brandon Schaefer - UnityScreen: use smart_pointers correctly, destruct items in correct order. Fixes: https://bugs.launchpad.net/bugs/987932. Approved by Marco Trevisan (Treviño). + UnityScreen: use smart_pointers correctly, destruct items in correct order. Fixes: https://bugs.launchpad.net/bugs/987932. Approved by Marco Trevisan (Trevi?o). 2012-04-24 Brandon Schaefer @@ -290,13 +816,13 @@ * Changed WindowThread to use a unique ptr * Also fixed a memory leak with the debugger * Some cleaning up also - * Thanks Treviño for the information :) + * Thanks Trevi?o for the information :) 2012-04-24 Brandon Schaefer UnityScreen: destroy the controllers before the window thread - Fixes crashes enabling/disabling plugins in CCSM. Fixes: https://bugs.launchpad.net/bugs/931201, https://bugs.launchpad.net/bugs/942286, https://bugs.launchpad.net/bugs/947844, https://bugs.launchpad.net/bugs/952378. Approved by Marco Trevisan (Treviño). + Fixes crashes enabling/disabling plugins in CCSM. Fixes: https://bugs.launchpad.net/bugs/931201, https://bugs.launchpad.net/bugs/942286, https://bugs.launchpad.net/bugs/947844, https://bugs.launchpad.net/bugs/952378. Approved by Marco Trevisan (Trevi?o). 2012-04-23 Brandon Schaefer @@ -305,27 +831,27 @@ 2012-04-24 Michal Hruby - GLibDBusProxy: Remove 1 second timeout we used before connecting to dbus proxies. Fixes: . Approved by Marco Trevisan (Treviño). + GLibDBusProxy: Remove 1 second timeout we used before connecting to dbus proxies. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-04-24 Michal Hruby Remove 1 second timeout we used before connecting to dbus proxies -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) HudLauncherIcon: close the HUD when activating the icon As design requested in bug #963918. Fixes: https://bugs.launchpad.net/bugs/963918. Approved by Gord Allott. -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) HudLauncherIcon: removed unneeded space. -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) autopilot, test_hud: add test to check if clicking over the HUD icon closes it. -2012-04-24 Marco Trevisan (Treviño) +2012-04-24 Marco Trevisan (Trevi?o) HudLauncherIcon: close the HUD when activating the icon @@ -354,66 +880,66 @@ Acquire input shape removal through RAII semantics -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) Hud: update the icon size to match the launcher icon size when in auto-hide mode Plus prevent a couple of crashes. Fixes: https://bugs.launchpad.net/bugs/921506, https://bugs.launchpad.net/bugs/983646. Approved by Tim Penhey. -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) HudView: Set the minimum icon height to match the content_layout So the icon is vertically centered to the hud search (minimal) layout if needed. -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) HudIcon: use unsigned integer for padding. -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) HudView: remove space -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) HudIcon: Fix the icon position to be relative to size, add a minimum vertical padding This makes the icon draw correctly when it's big, also it makes the view to increas its vertical size slightly to use some padding if needed. -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) HudView: fix the geometry not to change when the icon size changes -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) HudController: add SetIcon function that removes some code duplication -2012-04-23 Marco Trevisan (Treviño) +2012-04-23 Marco Trevisan (Trevi?o) IconTexture: be more safe when handling _pixbuf_cached Set it to null when invalid and during initialization -2012-04-22 Marco Trevisan (Treviño) +2012-04-22 Marco Trevisan (Trevi?o) Merging with trunk (window button fixes) -2012-04-22 Marco Trevisan (Treviño) +2012-04-22 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) Hud: update the icon size to match the launcher icon size. -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) Merging with icon fixes branch 2012-04-23 Andrea Azzarone - Use 2 columns in the card view in desktop mode when filters are opened.. Fixes: https://bugs.launchpad.net/bugs/977817. Approved by Mirco Müller, Marco Trevisan (Treviño), Andrea Cimitan. + Use 2 columns in the card view in desktop mode when filters are opened.. Fixes: https://bugs.launchpad.net/bugs/977817. Approved by Mirco M?ller, Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-04-20 Andrea Azzarone @@ -425,7 +951,7 @@ 2012-04-21 Michael Rawson - Fixes position of "show desktop" icon-LP:964073. Fixes: https://bugs.launchpad.net/bugs/964073. Approved by Marco Trevisan (Treviño). + Fixes position of "show desktop" icon-LP:964073. Fixes: https://bugs.launchpad.net/bugs/964073. Approved by Marco Trevisan (Trevi?o). 2012-04-18 Michael Rawson @@ -455,17 +981,17 @@ Moved show desktop icon to intended position -2012-04-21 Marco Trevisan (Treviño) +2012-04-21 Marco Trevisan (Trevi?o) WindowButtons: avoid to disable the Overlay close button. This fixes a regression I probabily introduced (sorry).. Fixes: https://bugs.launchpad.net/bugs/986264. Approved by Andrea Azzarone. -2012-04-20 Marco Trevisan (Treviño) +2012-04-20 Marco Trevisan (Trevi?o) WindowButtons: remove extra space, and be more crash-safe -2012-04-20 Marco Trevisan (Treviño) +2012-04-20 Marco Trevisan (Trevi?o) WindowButtons: avoid to disable the Overlay close button. @@ -473,7 +999,7 @@ 2012-04-20 Andrea Azzarone - Don't activate "home.lens" during dash closing.. Fixes: https://bugs.launchpad.net/bugs/914785. Approved by Michal Hruby, Marco Trevisan (Treviño). + Don't activate "home.lens" during dash closing.. Fixes: https://bugs.launchpad.net/bugs/914785. Approved by Michal Hruby, Marco Trevisan (Trevi?o). 2012-04-20 Andrea Azzarone @@ -509,7 +1035,7 @@ 2012-04-20 Chase Douglas - Fix potential pointer lockup on initial drag gesture.. Fixes: https://bugs.launchpad.net/bugs/979418. Approved by Marco Trevisan (Treviño), Alex Launi. + Fix potential pointer lockup on initial drag gesture.. Fixes: https://bugs.launchpad.net/bugs/979418. Approved by Marco Trevisan (Trevi?o), Alex Launi. 2012-04-12 Chase Douglas @@ -532,21 +1058,21 @@ Add grab counting in compiz screen mock -2012-04-19 Marco Trevisan (Treviño) +2012-04-19 Marco Trevisan (Trevi?o) WindowButtons: disable the close button if the controlled window is not closable Added support to WindowManager to get if a window is closable and maximizable, then used the IsWindowClosable method to enable or disable the close window button.. Fixes: https://bugs.launchpad.net/bugs/981196. Approved by Thomi Richards, Brandon Schaefer. -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) manual-tests: WindowButtons, added test case for disabled close button -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) WindowButtons: disable the close button if the controlled window is not closable -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) WindowManager: add functions to get if a window is maximizable and closable @@ -572,7 +1098,7 @@ 2012-04-19 Andrea Azzarone - Add a sanity check to avoid crashes.. Fixes: https://bugs.launchpad.net/bugs/982730. Approved by Marco Trevisan (Treviño). + Add a sanity check to avoid crashes.. Fixes: https://bugs.launchpad.net/bugs/982730. Approved by Marco Trevisan (Trevi?o). 2012-04-20 Andrea Azzarone @@ -624,7 +1150,7 @@ 2012-04-19 Brandon Schaefer - HudIcon now filters out windows on different workspaces and windows that are hidden.. Fixes: . Approved by Marco Trevisan (Treviño). + HudIcon now filters out windows on different workspaces and windows that are hidden.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-04-18 Brandon Schaefer @@ -687,51 +1213,51 @@ * Fixed 2 ap fails -2012-04-18 Marco Trevisan (Treviño) +2012-04-18 Marco Trevisan (Trevi?o) QuicklistView: fixed the quicklist key navigation, to make it consistent with Gtk menus navigation. The prelight of the items is now completely controlled by QuicklistView and never by QuicklistMenuItem, the children can define now when they are slectable.. Fixes: https://bugs.launchpad.net/bugs/911561, https://bugs.launchpad.net/bugs/978926, https://bugs.launchpad.net/bugs/979096. Approved by Thomi Richards. -2012-04-19 Marco Trevisan (Treviño) +2012-04-19 Marco Trevisan (Trevi?o) autopilot, test_quicklist: cyclic keynav docstring fixes -2012-04-19 Marco Trevisan (Treviño) +2012-04-19 Marco Trevisan (Trevi?o) autopilot, test_quicklist: use the Eventually matcher to avoid false-negatives -2012-04-19 Marco Trevisan (Treviño) +2012-04-19 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-19 Marco Trevisan (Treviño) +2012-04-19 Marco Trevisan (Trevi?o) autopilot: quicklist emulator, applying Thomi's fixes. -2012-04-18 Marco Trevisan (Treviño) +2012-04-18 Marco Trevisan (Trevi?o) autopilot, test_quicklist: docstrings updated. -2012-04-18 Marco Trevisan (Treviño) +2012-04-18 Marco Trevisan (Trevi?o) autopilot: quicklist, use only properties -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) TestQuicklistMenuitems: added GetSelectable tests -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) autopilot, quicklist: added other tests to check the cyclic key-navigation Also the quicklist emulator now includes the selectable_items property -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) autopilot, quicklist: use the new selectable item property instead of computing it -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) QuicklistMenuItem: add GetSelectable virtual method @@ -739,38 +1265,38 @@ the items are selectable when visible and enabled, while the Separator item can never be selected. -2012-04-13 Marco Trevisan (Treviño) +2012-04-13 Marco Trevisan (Trevi?o) autopilot, quicklist: add more last/first tests -2012-04-12 Marco Trevisan (Treviño) +2012-04-12 Marco Trevisan (Trevi?o) autopilot, test_quicklist: added first bunch of key navigation tests -2012-04-12 Marco Trevisan (Treviño) +2012-04-12 Marco Trevisan (Trevi?o) QuicklistView, QuicklistMenuItem: export absolute geometries for introspection -2012-04-11 Marco Trevisan (Treviño) +2012-04-11 Marco Trevisan (Trevi?o) QuicklistView: add support to Home/End Page up/down buttons to select items -2012-04-11 Marco Trevisan (Treviño) +2012-04-11 Marco Trevisan (Trevi?o) QuicklistView: use the new SelectItem into RecvItemMouseDrag -2012-04-11 Marco Trevisan (Treviño) +2012-04-11 Marco Trevisan (Trevi?o) QuicklistMenuItem: don't change the focus on move, only on enter/leave This to keep the consistency with GTK menus. Also when leaving an unselected entry, we shouldn't unselect all. -2012-04-11 Marco Trevisan (Treviño) +2012-04-11 Marco Trevisan (Trevi?o) QuicklistMenuItem: make the introspection prelight name more explicit -2012-04-11 Marco Trevisan (Treviño) +2012-04-11 Marco Trevisan (Trevi?o) QuicklistView: enhance the key navigation to follow the same menus behavior @@ -788,7 +1314,7 @@ mouse pointer is moved over an unselected item, the focus should be moved to that item. -2012-04-11 Marco Trevisan (Treviño) +2012-04-11 Marco Trevisan (Trevi?o) QuicklistView: manage the prelight item status, avoid double-selected items @@ -903,7 +1429,7 @@ 2012-04-18 Michal Hruby - Make sure we don't try to remove sources that were already removed.. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Azzarone. + Make sure we don't try to remove sources that were already removed.. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Azzarone. 2012-04-18 Michal Hruby @@ -911,7 +1437,7 @@ 2012-04-18 Andrea Azzarone - Fixes bug #980924.. Fixes: https://bugs.launchpad.net/bugs/980924. Approved by Gord Allott, Marco Trevisan (Treviño). + Fixes bug #980924.. Fixes: https://bugs.launchpad.net/bugs/980924. Approved by Gord Allott, Marco Trevisan (Trevi?o). 2012-04-18 Andrea Azzarone @@ -921,17 +1447,17 @@ Fixes LP bug #980924. -2012-04-18 Marco Trevisan (Treviño) +2012-04-18 Marco Trevisan (Trevi?o) UScreen: code updated to be more C++ friendly. Also moved into the unity namespace.. Fixes: . Approved by Andrea Azzarone. -2012-04-18 Marco Trevisan (Treviño) +2012-04-18 Marco Trevisan (Trevi?o) UScreen: ref the GdkScreen object we own. -2012-04-18 Marco Trevisan (Treviño) +2012-04-18 Marco Trevisan (Trevi?o) UScreen: code updated to be more C++ friendly. @@ -939,7 +1465,7 @@ 2012-04-18 Andrea Azzarone - Fix compilation of standalone launcher.. Fixes: https://bugs.launchpad.net/bugs/983989. Approved by Marco Trevisan (Treviño), Sam Spilsbury. + Fix compilation of standalone launcher.. Fixes: https://bugs.launchpad.net/bugs/983989. Approved by Marco Trevisan (Trevi?o), Sam Spilsbury. 2012-04-18 Andrea Azzarone @@ -947,7 +1473,7 @@ 2012-04-18 Andrea Azzarone - Use std::shared_ptr::reset instead of = some::Ptr(new...) for UScreen::proxy_. Fixes: . Approved by Marco Trevisan (Treviño). + Use std::shared_ptr::reset instead of = some::Ptr(new...) for UScreen::proxy_. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-04-18 Andrea Azzarone @@ -1255,7 +1781,7 @@ 2012-04-17 Thomi Richards - Added the autopilot wait_for attribute feature.. Fixes: . Approved by Marco Trevisan (Treviño), Brandon Schaefer. + Added the autopilot wait_for attribute feature.. Fixes: . Approved by Marco Trevisan (Trevi?o), Brandon Schaefer. 2012-04-13 Thomi Richards @@ -1309,7 +1835,7 @@ Force menu reposition on popup in case its contents have changed. - Fixes bug 883317.. Fixes: https://bugs.launchpad.net/bugs/883317. Approved by Marco Trevisan (Treviño). + Fixes bug 883317.. Fixes: https://bugs.launchpad.net/bugs/883317. Approved by Marco Trevisan (Trevi?o). 2012-04-13 Lars Uebernickel @@ -1317,7 +1843,7 @@ 2012-04-17 Michal Hruby - Fix a couple of wrong reference/memory management issues. Fixes: https://bugs.launchpad.net/bugs/979429. Approved by Marco Trevisan (Treviño). + Fix a couple of wrong reference/memory management issues. Fixes: https://bugs.launchpad.net/bugs/979429. Approved by Marco Trevisan (Trevi?o). 2012-04-16 Michal Hruby @@ -1347,7 +1873,7 @@ Fixes bug #980828. -2012-04-16 Marco Trevisan (Treviño) +2012-04-16 Marco Trevisan (Trevi?o) Fix the behaviour of alt-tab and clicking on the launcher icon to just raise the most recently used window, not all for that app. @@ -1379,47 +1905,47 @@ Tweaks to the test. -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) PluginAdapter: avoid to raise and unminimize top_window if already done -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) Launcher: be more clear in comment (yeah?) -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) UScreen: use GetMonitorAtPosition in GetMonitorWithMouse -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) WindowManager, BamfLauncherIcon: some code cleanup -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) autopilot, test_launcher: updated click test to check minimized windows too Removed debug data -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) autopilot, test_switcher: updated against new updates -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) unityshell: show the Alt+Tab window in the monitor where is the active window As per design. -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) WindowManager: add method to get the active window. -2012-04-15 Marco Trevisan (Treviño) +2012-04-15 Marco Trevisan (Trevi?o) PluginAdapter: removing debugging bits -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) Merging with branch changes @@ -1431,7 +1957,7 @@ * Added an AP test for the new design changes. -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) SwitcherController: Removing the code for the Quick Alt+Tab, it should behave always at the same way @@ -1440,50 +1966,50 @@ the current workspace) of that application which is not minimised should be focused -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) autopilot: fixed the AP test -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) BamfLauncherIcon: Also invisible windows shouldn't be counted as available in monitor Now the spread works as expected, clicking on each monitor's panel! ;) -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't consider an unmapped window as one in monitor -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) BamfLauncherIcon: focus a window if the application is not active on the current monitor -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) Launcher: if the current launcher is used for all the monitors, don't filter windows per monitor -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) SwitcherController: include the switcher monitor when activating a group -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) WindowManager: add GetWindowMonitor method, and use UScreen to fetch it This now used in PluginAdapter not to have inconsistences. -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) UScreen: allow to get the monitor for a given point -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) unityshell: switcher, use UScreen to get the monitor value. Not using this can cause inconsistences, due to the fact that compiz numbers the devices in a different way. -2012-04-14 Marco Trevisan (Treviño) +2012-04-14 Marco Trevisan (Trevi?o) PluginAdapter::FocusWindowGroup: add a parameter to define if focusing the on-top window only @@ -1550,15 +2076,15 @@ * Merged with trunk, fixed conficts -2011-12-15 Marco Trevisan (Treviño) +2011-12-15 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't include dialog windows on Alt+Tab. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) manual-tests: Added test for QuickAltTab -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) PluginAdapter: Add support for the FocusVisibility::OnlyVisibleOnTop on FocusWindowGroup @@ -1567,7 +2093,7 @@ Code indentation fixes included. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) BamfLauncherIcon: when we receive a "quick" activate, use the OnlyVisibleOnTop focus visbility @@ -1575,7 +2101,7 @@ to only focus the first application window on top of the stack. That is used when we receive a Switcher activate with a button != 0. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) SwitcherController: use the button value of ActionArg to indicate the switch type @@ -1947,7 +2473,7 @@ 2012-04-06 Didier Roche - sometimes you see a hundred lines of conflicts in a file… and then, you realize it's just because of a blank added line… + sometimes you see a hundred lines of conflicts in a file? and then, you realize it's just because of a blank added line? 2012-04-05 Gord Allott @@ -1979,7 +2505,7 @@ 2012-04-06 Andrea Cimitan - Fix average colors tweaks. Fixes: . Approved by Andrea Cimitan, Mirco Müller. + Fix average colors tweaks. Fixes: . Approved by Andrea Cimitan, Mirco M?ller. 2012-04-06 Andrea Cimitan @@ -1993,11 +2519,11 @@ Remove useless computation and improves saturation tune -2012-04-06 Mirco Müller +2012-04-06 Mirco M?ller Make sure the special masking of the dash's decoration is restored when a repaint of the lens-nav-bar destroyed it.. Fixes: . Approved by Andrea Cimitan. -2012-04-06 Mirco Müller +2012-04-06 Mirco M?ller Make sure the special masking of the dash's decoration is restored when a repaint of the lens-nav-bar destroyed it @@ -2011,7 +2537,7 @@ 2012-04-06 Michal Hruby - Fixes a regression that caused the category icons to use default icons. Fixes: . Approved by Mirco Müller. + Fixes a regression that caused the category icons to use default icons. Fixes: . Approved by Mirco M?ller. 2012-04-06 Michal Hruby @@ -2086,848 +2612,848 @@ window to opaque with PAINT_WINDOW_NO_CORE_INSTANCE_MASK when fully hidden so it turns up in scale -2012-04-06 Mirco Müller +2012-04-06 Mirco M?ller fontconfig changed and broke the line-spacing for the horiz. tile-renderer, so the line-spacing was adjusted to avoid text being clipped in the card-view (e.g. gwibber-lens entries with three lines of body-text). Fixes: https://bugs.launchpad.net/bugs/974523. Approved by Sam Spilsbury. -2012-04-06 Mirco Müller +2012-04-06 Mirco M?ller After fontconfig changed, the line-spacing for the horiz. tile-renderer had to be adjusted, so text isn't clipped in the card-view... thus fixing LP: #974523 -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) Autopilot: added the testing support for the panel. Fixes: . Approved by Tim Penhey. -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) test_panel: added missing sleep time, waiting for app discovery -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) test_panel: add more sleeps... -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) autopilot, test_panel: make some tests more robust -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) PanelMenuView: added missing introspection variable (fix typo) -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) autopilot, test_panel: added grab area tests! -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) autopilot, test_panel: more indicator tests, plus panel key navigation. -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) autopilot, test_panel: added some indicators interaction tests -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) autopilot, panel: allow to get an indicator entry by the name-hint -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot: removed some tests duplication, added the PanelHoveringTests class -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) test_panel: adding menu tests -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) test_panel: added more window buttons tests for fitts law check -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) test_panel: making the tests more solid -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot: test_panel, some improvements to the move / maximize code -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, panel tests: some optimizations following Tim's review. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, panel: make the click tests less prone to false positive -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_panel: fix the "close button" test for other monitors -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) test_panel: even more tests for strange bugs -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, BAMF: closed is a signal... Let's use another trick -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_panel: add some bug related window buttons tests -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_panel: add test to check window buttons in multimonitor with overlays -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) DashController: use BuildWrapper and export the monitor into the introspection data -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) PanelMenuView: include fading timings into the introspection data -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_panel: added even more WindowButtons tests. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) DashView: add introspection data about the form-factor -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_panel: added first tests for window buttons -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, bamf: get if a window has been closed -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot: panel, improved the window buttons related functions -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) PanelMenuView: add more introspection data -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_panel: do most of the initialization into the PanelTestsBase class -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, test_panel: added test to check that the window title has changed -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) test_panel: using self.screen_geo.drag_window_to_monitor instead of the self-provided function -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) X11: added ScreenGeometry().drag_window_to_monitor utility function -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, test_panel: added an utility function to launch application windows for a given monitor -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, bamf: add the set_focus method support -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merging with WindowButtons changes -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) test_panel: use maximize in cleanups, added a new test switching focused window -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, panel: added other window title related tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: use absolute geometry for introspection data -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, panel: fixed some math, and more properties -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, panel: applying the Thomi's fixes -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, test_launcher: add keynav / switcher tests for focus activation -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) test_launcher: check if key_nav resumes the focus on cancel -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) autopilot, test_launcher: added tests for focus resume on launcher switcher Tests cover bug #970420 -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: introspection, use "entry_id", or Autopilot won't work with "id" parameters -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, test_panel: added first panel title tests -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, bamf: use the window geometry using gdk, xlib aren't working here. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, bamf: add monitor property to window -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, keybindings: added some window management keybindings support -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, add first panel support. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Panel: use GetAbsoluteGeometry for introspection... -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) WindowButtons, PanelIndicatorEntryView: Set invisible items event insensitive Also, improve the introspection data -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-cleanup into panel-p-tests. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: introspection add human-readable type and menu geometries -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelMenuView: introspection, add introspection property if the desktop is active. -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) A lot of panel fixes with code cleanup and improvements to the panel code.. Fixes: https://bugs.launchpad.net/bugs/655184, https://bugs.launchpad.net/bugs/839690, https://bugs.launchpad.net/bugs/865701, https://bugs.launchpad.net/bugs/875932, https://bugs.launchpad.net/bugs/921316, https://bugs.launchpad.net/bugs/921918, https://bugs.launchpad.net/bugs/934680, https://bugs.launchpad.net/bugs/936425, https://bugs.launchpad.net/bugs/939054, https://bugs.launchpad.net/bugs/940683, https://bugs.launchpad.net/bugs/951747, https://bugs.launchpad.net/bugs/953868, https://bugs.launchpad.net/bugs/962410, https://bugs.launchpad.net/bugs/963118, https://bugs.launchpad.net/bugs/963134, https://bugs.launchpad.net/bugs/968261, https://bugs.launchpad.net/bugs/970420, https://bugs.launchpad.net/bugs/971947. Approved by Tim Penhey. -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) PanelView: Ops, fixing merge issue -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Merging with trunk, resolving conflicts -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) PanelMenuView: don't allow clicks in the grab-area when an overlay is opened -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelMenuView: remove the PostLayoutManagement set window-buttons' monitor -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelController: Set the layout as the last thing, to avoid geometry changes (andyrock) And this finally fixes the "Cut" menus issue that happened on startup, kudos to Andrea Azzarone for this fix. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) DashController: save the dash monitor value and emit that both when showing and hiding the dash This caused an issue when hiding the dash in a monitor and trying to close it from another. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-grab-area into panel-p-tray. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-window-buttons into panel-p-grab-area. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) WindowButtons: make the buttons multi-monitor aware. This is needed to ignore the overlay events for another monitor. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelMenuView: don't ignore clicks on window buttons if the dash is opened on the given panel -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelMenuView: only change the title on the target panel, when using the launcher switcher -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) SwitcherController: include the monitor in the UBUS_SWITCHER_SHOWN message -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) LauncherController: be multi-monitor aware when informing about the launcher key nav/switcher start -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) LauncherController: don't restore the focus if the selected icon is currently running. -2012-04-04 Marco Trevisan (Treviño) +2012-04-04 Marco Trevisan (Trevi?o) PanelMenuView: s/OnMenusClosed/NotifyAllMenusClosed/g -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) PanelMenuView: be safer, if the current _new_application has been closed, just reset it. This fixes the always-visible menu issue that can happen when quickly closing/opening applications -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) PanelMenuView: no need to overwrite QueueDraw -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) PanelMenuView: adding more constants, removed unneeded _padding variable -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) PanelMenuView: s/AllMenusClosed/OnMenusClosed/g -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelMenuView: set the maximum entries width on the PostLayout This fixes the missing menus / compressed menus issue that could happen on fresh start... -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelView: use Window type for tray Xid -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelController: the tray can have more than one XID, on multimonitor. Updating unityshell for it. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelTray: use Window type for xid -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelMenuView: reduce the risk of getting an empty panel menu on startup -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelView: fixed some spacing issues -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelView: set some methods const -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelView: added the more generic IsActive method to get if a view is currently the active one -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-menu-view into panel-p-panel-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-grab-area into panel-p-tray. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-buttons into panel-p-grab-area. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) WindowButtons: ignore the click events when the buttons are not enabled. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: fixed typo in the comment -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelView: main code cleanup, fixed dash/HUD switch. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelMenuView: fix console gtk_widget_path errors -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merging with panel-p-menu-view changes -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelMenuView: removed the useless (at this point) HasOurWindowFocused... -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelMenuView: make the possible methods const. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) WindowManager: GetGeometry* related methods set to const Plus removed some unneeded casts. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-grab-area into panel-p-tray. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-buttons into panel-p-grab-area. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicators-view into panel-p-window-buttons. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) - PanelIndicatorsView: «don't use "using namespace indicator;" in a header file.» + PanelIndicatorsView: ?don't use "using namespace indicator;" in a header file.? -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-grab-area into panel-p-tray. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-buttons into panel-p-grab-area. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicators-view into panel-p-window-buttons. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicator-entry into panel-p-indicators-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: make GetLabel const -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-grab-area into panel-p-tray. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-buttons into panel-p-grab-area. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicators-view into panel-p-window-buttons. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicator-entry into panel-p-indicators-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: don't use "using namespace ..." into the Header Also fixed some typo and the widget path errors -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-panel-view into panel-p-cleanup. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-core into panel-p-menu-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-manager into panel-p-core. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-tray into panel-p-window-manager. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-grab-area into panel-p-tray. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-window-buttons into panel-p-grab-area. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicators-view into panel-p-window-buttons. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-indicator-entry into panel-p-indicators-view. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) Merged panel-p-style into panel-p-indicator-entry. -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) WindowButtons: ignore click events if not enabled. -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) Panel: Fixing the overlay name... -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) Ops... s/Overaly/Overlay/g ... -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) Merging with upstream -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelMenuView: code cleanup, multimonitor bug fixes and misc improvements @@ -2942,25 +3468,25 @@ Maximized windows list is re-populated on startup or when adding a new screen. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) Added misc changes needed to make the panel rock -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) WindowManager: implemented some methods to handle the window position/size. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelTray: code rewritten to use more C++ utilities -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: addded to unity namespace, rewritten the event handling The grabbing handle has been greatly improved -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) WindowButtons: code cleanup, more control to the buttons. @@ -2969,11 +3495,11 @@ Also the handling of the controlled window is now done internally, not by the PanelMenuView. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelIndicatorsView: some API cleanup, added more protected virtual members -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: @@ -2981,39 +3507,39 @@ extendible in the near future. Also fixed issues with the indicator entries and Scale/Expo. Reduced some memory or CPU usage. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelIndicatorEntryView, PanelMenuView: set widget path types before name. This fixes a lot of warnings. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: use the correct panel type to get the font -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: Set the WindowButtons padding as per design. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: Only Scale is active for a window subset, show their app name. The desktop name otherwise. So on Super+S the desktop name is shown. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PluginAdapter: added IsScaleActiveForGroup to get if scale is running for a window subset -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: make the desktop name to draw in all the panels -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Removing all the LIM stuff, it will be back soon! -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelIndicatorsView: removed the "layout workaround", NUX likes us now! @@ -3024,130 +3550,130 @@ This also fixes an issue with multimonitor, that caused menus on other monitors not to be clickable. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelView: remove useless methods -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) WindowButtons: don't be confused by different overlays Now switching from Dash to Hud and back works. See bug #963118 -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) unityshell: typo: s/showPanelFirstMenuKeyInitiate/showPanelFirstMenuKeyTerminate/ -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Panel: s/Dash/Overlay/g -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: use Window type for windows. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PluginAdapter: window's can't be obscured by window in different screens. Checking the geometry, though. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: use nux::Rect.IsInside where possible -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: when we don't control the active window, all clicks are over the grab area -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) PanelMenuView: don't draw anything on the panel located into a monitor that doesn't control the active window -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) PanelTray: remove the idle before destroying the window. Let's be paranoid! ;) -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) PanelTray: don't crash when unplugging a monitor. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) PanelView: putting back some changes lost during merges -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Merging with latest trunk. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: don't sync our geometry if not focused This will make the unity-panel-service correctly handle the keyboard navigation. -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) Merging with newer lp:~3v1n0/unity/lim -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/indicators-tests -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/dbus-indicators-proxy -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) Merging again with lp:~3v1n0/unity/indicators-p -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/indicators-p -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) Merging with changes in lp:~3v1n0/unity/lim -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) unityshell: listen also the launcher switcher signals -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) LauncherController: emit the right keynav signal -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) PluginAdapter: add some more spacing, to improve readability -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) PanelMenuView: put return types on the same line of the function name -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) PanelMenuView: add OnApplicationClosed function, to avoid casts Also added more controls to avoid un-hidden menus. -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) PanelMenuView: reset the _new_application if it points to an invalid application -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) PanelMenuView: add GetTopWindow method to get the top valid window, even if not in focus @@ -3157,73 +3683,73 @@ We use the GetTopWindow to get the top view when an invalid one (an unity) window is focused. -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) PanelMenuView: call the right function on launcher switcher end -2012-03-08 Marco Trevisan (Treviño) +2012-03-08 Marco Trevisan (Trevi?o) PanelMenuView: also connect to the key-switcher ubus events -2012-03-08 Marco Trevisan (Treviño) +2012-03-08 Marco Trevisan (Trevi?o) LauncherController: send the right ubus message depending on the key navigation type -2012-03-08 Marco Trevisan (Treviño) +2012-03-08 Marco Trevisan (Trevi?o) PanelMenuView: show the selected icon name on the panel during key navigation Also, avoid to generate textures with empty labels, just nullify it -2012-03-08 Marco Trevisan (Treviño) +2012-03-08 Marco Trevisan (Trevi?o) LauncherController: send UBus messages when the launcher selection has changed -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelView: don't allow to open menus in an inactive PanelMenuView -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelMenuView: take care of the workarea x when dragging down a window. Fixes the restored position in a multimonitor setup. -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelMenuView: improve debugging strings -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: set invisible by default. -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelMenuView: reduce the risk of getting an empty panel -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: use area visibility as well. Disable the appmenu when not in use. -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) PanelMenuView: use PanelIndicatorsView as base for introspection data -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) Panel: add more debug introspection informations -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) PanelIndicatorsView: make each menu entry to use the most space it really can @@ -3236,41 +3762,41 @@ This improves a lot the entries collapsing, and make sure that we always use all the horizontal space that we have. -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: improve the drawing of collapsed menus Consider the right_marging as well. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-26 Marco Trevisan (Treviño) +2012-02-26 Marco Trevisan (Trevi?o) PanelTray: update whitelist value on runtime. -2012-02-26 Marco Trevisan (Treviño) +2012-02-26 Marco Trevisan (Trevi?o) PanelTray: main code cleanup, hopefully fix crashes -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) Pushing back removed changes -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/lim -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) Merging trunk -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) Merging trunk -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) WindowButtons: manually manage the clicks on the buttons to be more Fitts conformant @@ -3278,19 +3804,19 @@ automatically, but we redirect the mouse events over them to be more conformant to the Fitt's law. -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) WindowButtons: make the buttons more Fitt's law conformant. -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) WindowButton: add UpdateSize function to define the maximum button size -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) WindowButtons: put win-buttons into the unity namespace. -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: return gboolean FALSE instead of bool false on timeout @@ -3363,7 +3889,7 @@ 2012-04-05 Kevin DuBois Ensure that an animation always takes place after the Shortcut menu is shown - fixes: https://bugs.launchpad.net/unity/+bug/924636. Fixes: https://bugs.launchpad.net/bugs/924636. Approved by Marco Trevisan (Treviño). + fixes: https://bugs.launchpad.net/unity/+bug/924636. Fixes: https://bugs.launchpad.net/bugs/924636. Approved by Marco Trevisan (Trevi?o). 2012-04-05 Kevin DuBois @@ -3373,11 +3899,11 @@ Correct issue where shortcut animation was not taking place while mousing over launcher -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) autopilot, test_launcher: fix error due to missing multiply_scenarios import. Fixes: . Approved by Tim Penhey. -2012-04-06 Marco Trevisan (Treviño) +2012-04-06 Marco Trevisan (Trevi?o) Fix multiply scenarios import @@ -3390,15 +3916,15 @@ * Use proper rendering call for system with no GLSL support. * Removed a printf. -2012-04-05 Marco Trevisan (Treviño) +2012-04-05 Marco Trevisan (Trevi?o) Panel style changes.. Fixes: . Approved by Tim Penhey. -2012-04-02 Marco Trevisan (Treviño) +2012-04-02 Marco Trevisan (Trevi?o) PanelStyle: use &glib::String instead of glib::String.AsOutParam. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) PanelStyle: general cleanup, move to UnityCore glib:: utilities @@ -3409,7 +3935,7 @@ 2012-04-05 Alex Launi - Refactors the launcher tests. Adds a more logical organization, and removes duplicated code.. Fixes: . Approved by Alex Launi, Marco Trevisan (Treviño). + Refactors the launcher tests. Adds a more logical organization, and removes duplicated code.. Fixes: . Approved by Alex Launi, Marco Trevisan (Trevi?o). 2012-04-05 Alex Launi @@ -3441,7 +3967,7 @@ 2012-04-05 Andrea Cimitan - Very subtle card view background. Fixes: . Approved by Marco Trevisan (Treviño). + Very subtle card view background. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-04-05 Andrea Cimitan @@ -3449,7 +3975,7 @@ 2012-04-05 Andrea Cimitan - Removes shadow from the decoration assets.. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Treviño). + Removes shadow from the decoration assets.. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Trevi?o). 2012-04-05 Andrea Cimitan @@ -3465,7 +3991,7 @@ 2012-04-05 Andrea Cimitan - Less opacity on both line and background for search bar. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Treviño). + Less opacity on both line and background for search bar. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Trevi?o). 2012-04-05 Andrea Cimitan @@ -3473,7 +3999,7 @@ 2012-04-05 Jay Taoko - * Fix: rendering of the Dash corners (top-right, bottom-left, bottom-right).. Fixes: https://bugs.launchpad.net/bugs/839476. Approved by Mirco Müller, Andrea Cimitan. + * Fix: rendering of the Dash corners (top-right, bottom-left, bottom-right).. Fixes: https://bugs.launchpad.net/bugs/839476. Approved by Mirco M?ller, Andrea Cimitan. 2012-04-05 Jay Taoko @@ -3504,7 +4030,7 @@ * Fixed rendering of the Dash corners. -2012-03-27 Mirco Müller +2012-03-27 Mirco M?ller Re-merged with trunk @@ -3515,11 +4041,11 @@ * A weird problems remains on the bottom left corner. * Shine and other effects remain to be applied on the corners. -2012-02-24 Mirco Müller +2012-02-24 Mirco M?ller Only use the alpha-channel in the mask-textures. Create the correct blurred texture-parts for the corners. Apply it all. -2012-02-21 Mirco Müller +2012-02-21 Mirco M?ller Added mask-textures for the three color-texture making up the corners of the dash/hud decoration @@ -3593,7 +4119,7 @@ 2012-04-05 Gord Allott - fixes widescreen icons being too small, makes them the correct aspect ratio and size. Fixes: https://bugs.launchpad.net/bugs/878015. Approved by Mirco Müller. + fixes widescreen icons being too small, makes them the correct aspect ratio and size. Fixes: https://bugs.launchpad.net/bugs/878015. Approved by Mirco M?ller. 2012-04-05 Gord Allott @@ -3662,19 +4188,19 @@ * Fixes the rendering of the dash when the "No Blur" option is selected in CCSM. -2012-04-05 Mirco Müller +2012-04-05 Mirco M?ller Implement new card view design. Fixes: https://bugs.launchpad.net/bugs/901164. Approved by Andrea Cimitan. -2012-04-05 Mirco Müller +2012-04-05 Mirco M?ller New input from Design... tiles background tint-color is meant to be like the one used on the lens-nav-bar -2012-04-03 Mirco Müller +2012-04-03 Mirco M?ller Work around a bug in QRP_QuadWireframe() not drawing the bottom-left-most pixel in the black outline around the icon -2012-04-03 Mirco Müller +2012-04-03 Mirco M?ller Fixing the horizontal tile renderer (aka card-view) to comply with the design-specs @@ -3858,7 +4384,7 @@ 2012-04-03 Thomi Richards - Fix several failing assertions in gtk, glib, and dbusmenu.. Fixes: . Approved by Marco Trevisan (Treviño). + Fix several failing assertions in gtk, glib, and dbusmenu.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-04-04 Thomi Richards @@ -3888,81 +4414,81 @@ Should fix a crash bug #971345. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) HudController: use the top-most valid window in the stack to fetch the icon, if an invalid window is focused. Fixes: https://bugs.launchpad.net/bugs/931548, https://bugs.launchpad.net/bugs/932371, https://bugs.launchpad.net/bugs/961161. Approved by Thomi Richards, John Lea. -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, test_hud: removed the unneeded sleep on tests base -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Autopilot: test_showdesktop, remove the hardcoded 'Control+Alt+d' keybinding -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot: test_hud, test_switcher: use the new start_app return value -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, make start_app to return the ran BamfApplication instance -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, test_hud: use self.dash.ensure_visible() -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, test_hud: Check if the BFB icon is shown on empty desktop -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, keybindings: added the window/show_desktop keybinding -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) HudLauncherIcon: fix typo -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, test_hud: Move to the new icon methods -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) autopilot, hud: add icon property to get the current HUD icon -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) HudIcon: rename it as HudEmbeddedIcon for better AP integration -2012-04-03 Marco Trevisan (Treviño) +2012-04-03 Marco Trevisan (Trevi?o) Merging with trunk -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) autpilot, test_hud: added test for Dash/HUD interaction and icon changes -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudController: use the ubuntu icon as fallback if we don't have a valid window focused -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudLauncherIcon: fallback to the BFB icon if the name is empty. -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudController: reset the focused_app_icon_ value on invalid focused view -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) HudController: use the monitor index = -1 to get the windows of all monitors Added also some comments -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) HudController: Check the top window if the active one is an unity window @@ -3970,7 +4496,7 @@ window in the stack, otherwise switching from the Dash to the HUD won't work. -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) HudController: don't change the Hud Icon if unity is the active application @@ -4089,7 +4615,7 @@ waits 100ms before asking for another search -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) Hud: fixed the paddings and geometries, remove the icon glitches @@ -4098,29 +4624,29 @@ HUD before the fix: http://i.imgur.com/b7BO0.png | http://i.imgur.com/9vpmv.png HUD after the fix: http://i.imgur.com/wDxPO.png | http://i.imgur.com/kSLch.png. Fixes: https://bugs.launchpad.net/bugs/931406, https://bugs.launchpad.net/bugs/964061. Approved by Andrea Cimitan, Tim Penhey. -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudView: remove unneeded includes -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudView, HudIcon: removing unneeded includes -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudIcon: add private members -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) HudIcon: simplify the constructor -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) IconTexture: don't try to load 0 sized icons. Otherwise the class won't work even changing the size value... -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) HudView: Fixed the HUD padding, removed some magic numbers. @@ -4130,7 +4656,7 @@ So, fixed all the spaces, removed some spacelayouts and using pure padding. Removed the icon layout, since it is not needed anymore. -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) HudIcon: Don't use a different icon renderer size, than the one provided. @@ -4140,45 +4666,45 @@ Reducing the minimum widh to the default launcher icon size. -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) LauncherEntryRemote: added tests for the entry remote class. Fixes: . Approved by Thomi Richards. -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) Merged with latest lp:~3v1n0/unity/launcher-remote-model-c++ -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) tests: added a test suite for LauncherEntryRemote -2012-04-01 Marco Trevisan (Treviño) +2012-04-01 Marco Trevisan (Trevi?o) LauncherRemoteModel rewritten to be more C++ friendly. Fixes: . Approved by Michal Hruby, Thomi Richards. -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) Merging with trunk. -2012-03-31 Marco Trevisan (Treviño) +2012-03-31 Marco Trevisan (Trevi?o) tests: test_desktop_utilities added test for TestGetDataDirectory -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) tests, added test for DesktopUtilities functions -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) FavoriteStoreGSettings, FavoriteStorePrivate: Move to DesktopUtilities::GetDesktopID And tests disabled -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) BamfLauncherIcon, LauncherEntryRemote: move to DesktopUtilities::GetDesktopID -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) UnityCore, added the DesktopUtilities class @@ -4186,47 +4712,47 @@ Plus an utility to get the desktop ID from a desktop path for the given data directories. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) LauncherEntryRemote: moving out the useless .get() from Ptr check... -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemoteModel: more code cleanup... -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemoteModel: use nullptr and move to more nice names for cb functions -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemoteModel: use glib::String to parse the removed parameters -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemoteModel:: use smart pointer for emitting signals Code updated against this. -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemoteModel, more LauncherEntryRemote::Ptr usage -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemote: move to shared_ptr Using the simpler std::shared_ptr ensures all the functionalities and more clean code. -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemoteModel: rewritten to be more C++ friendly @@ -4247,35 +4773,35 @@ * Re-worked the hud emulator and added a Hud class * Added CJK test for the Hud -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) LauncherRemoteEntry: code rewritten to be more C++ friendly, and moved into unity namespace. Fixes: . Approved by Thomi Richards. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) LauncherEntryRemote: Added missing ';'... Ops! -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) LauncherEntryRemote: glib::Variant explained -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemote: Quicklist returns the glib::Object Plus both accepts variant strings and objects paths for QL. -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemote: making some methods const -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherEntryRemote: More C++ friendly and moved into unity namespace 2012-03-30 Andrea Azzarone - Inserting items into launcher makes unnecessary animations on other monitors. Fixes: https://bugs.launchpad.net/bugs/925021. Approved by Marco Trevisan (Treviño). + Inserting items into launcher makes unnecessary animations on other monitors. Fixes: https://bugs.launchpad.net/bugs/925021. Approved by Marco Trevisan (Trevi?o). 2012-03-26 Andrea Azzarone @@ -4289,11 +4815,11 @@ Merge prerequiste branch. -2012-03-30 Marco Trevisan (Treviño) +2012-03-30 Marco Trevisan (Trevi?o) LauncherIcon: use std::string for RemoteUri. Fixes: . Approved by Thomi Richards. -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) LauncherIcon: use std::string for RemoteUri @@ -4347,7 +4873,7 @@ ignored when it shoudn't * Autopilot test coming! -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) LauncherIcon_ added MonitorVisibility property and subclass SingleMonitorLauncherIcon @@ -4357,71 +4883,71 @@ Plus, don't desaturate the icons placed in a launcher that has no an overalay attached.. Fixes: . Approved by Andrea Azzarone. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) autopilot, test_hud: updated against the new support for monitor-visible icons -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) autopilot, launcher: added method to get the icons for each monitor -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) autopilot, icons: add monitor visibility related methods -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) HudLauncherIcon: always set it invisible on autohide setting changed -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) Merging again with: lp:~3v1n0/unity/hud-lock-out-monitors-tests -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) LauncherIcon: add monitor visibility informations to the debug introspection -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/hud-lock-out-monitors-tests -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) test: added SingleMonitorLauncherIcon unit-test -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) MockLauncherIcon: implemented missing methods -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/hud-lock-out-monitors-tests -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) Launcher: only desaturate icons on the monitor where there's an overlay opened -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) Launcher: don't show icons invisible on the launcher's monitor -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) HudLauncherIcon: subclass SingleMonitorLauncherIcon, show only on target monitor -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) BFBLauncherIcon: hide the BFB icon only on the monitor where there's an HUD open -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) SingleMonitorLauncherIcon: new class to control icons visible only in one monitor -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) AbstractLauncherIcon: add support for icons visible only on selected monitors @@ -4439,7 +4965,7 @@ 2012-03-29 Andrea Azzarone - Makes the dash search entry horizontally extensible.. Fixes: https://bugs.launchpad.net/bugs/841907. Approved by Marco Trevisan (Treviño), Andrea Cimitan. + Makes the dash search entry horizontally extensible.. Fixes: https://bugs.launchpad.net/bugs/841907. Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-03-27 Andrea Azzarone @@ -4451,202 +4977,202 @@ 2012-03-29 Thomi Richards - Fixed a memory leak in the file-system lens - we were leaking LensFileData objects.. Fixes: . Approved by Jason Smith, Marco Trevisan (Treviño). + Fixed a memory leak in the file-system lens - we were leaking LensFileData objects.. Fixes: . Approved by Jason Smith, Marco Trevisan (Trevi?o). 2012-03-29 Thomi Richards Filesystem lens no longer leaks LensFileData objects. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Added HUD_TYPE for Icons, this allow to draw the active triangle on that only (and not on BFB).. Fixes: https://bugs.launchpad.net/bugs/961230. Approved by Gord Allott. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Fixing previous merge... -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/hud-lock-out-monitors-tests changes -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot: test_hudm, added active icon status check -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) AbstractLauncherIcon: Add TYPE_HUD icon type This fixes the visual issue causing that both the BFB and HUD to draw a right triangle. -2012-03-29 Marco Trevisan (Treviño) +2012-03-29 Marco Trevisan (Trevi?o) HudController: Fixed geometries for single-launcher mode. And added tests for multimonitor in HUD, with lock-out support.. Fixes: https://bugs.launchpad.net/bugs/963577. Approved by Thomi Richards. -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) autopilot, updated changes following thomi's review -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) BamfLauncherIcon: add GetDesktopID function to perform the common operations -2012-03-28 Marco Trevisan (Treviño) +2012-03-28 Marco Trevisan (Trevi?o) autopliot, test_hud: check that the HUD icon is not desaturated -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot, use start_app with one more locale parameter, more than start_app_c_locale -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot, test_showdesktop: be more locale friendly -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot, test_switcher: use BAMF application names, to work with different locales -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot, switcher: update against new introspection values -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot: allow to launch applications with C locale And use it for gedit HUD test -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) BamfLauncherIcon: use GVariantBuilder to build the xids array -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) BamfLauncherIcon: g_variant_new_array can compute the array size automatically -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot, test_hud: test splitted in multiple parts, use multiply_scenarios -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot: default tests, use C locale to launch applications. -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) autopilot, hud: Removed unneeded print -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) autopilot: test_hud some cleanups -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) autopilot, launcher: allow to get the bfb launcher icon from LauncherModel -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) autopilot, X11: fix typo... actually use rect when checking for monitor geo! -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) HudController: make the HUD relayout if the monitor has changed -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) HudView: no need to remove the introspection child on destruction -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) autopilot, hud: add test to check if the hud icon shows the proper emblem -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) autopilot, test_hud: updated the tests against the new embedded icon introspection -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) HudView: set the icon as introspectable child. And add and remove it when needed. -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) HudIcon: make it Introspectable, and use the new IconTexture API -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) IconTexture: move to std::string -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) SimpleLauncherIcon: add the icon_name to the introspection properties -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: use the GetWindows function when we can -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, test_hud: simplify the desaturated test -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, hud emulator: removing deprecated get_geometry method -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) HudController: removed typo -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) unityshell: make sure we initialize the HudController multiple_launchers property -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, test_hud: Check if the launcher icons (except the HUD one) are desaturated -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, test_hud: get icon by desktop id, not by tooltip_text It fixes internationalization issues. -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, launcher emulator: update against icon introspection changes Allow to get an icon by its desktop id -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot: update icon properties against new quirkless names -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, test HUD: added checks for the HUDLauncherIcon -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) LauncherIcon: added autopilot introspection friendly properties -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) HudController: oops... g_strcmp != 0 => str1 != str2 ;) -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, hud: added new HudController / HudView properties @@ -4655,48 +5181,48 @@ Added an extra assert to check if hud_monitor equals hud.monitor -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) HudView: simplify the embedded icon showing API, add some introspection -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) HudController: some code cleanup, use functions to reduce code duplication -2012-03-24 Marco Trevisan (Treviño) +2012-03-24 Marco Trevisan (Trevi?o) autopilot, test_hud: added checks for geometry for both locked and unlocked status -2012-03-24 Marco Trevisan (Treviño) +2012-03-24 Marco Trevisan (Trevi?o) HudController: add support for the multiple launchers feature The HUD should show at the left edge of the screen when multiple launchers are disabled and the mouse pointer is on a non-primary screen. -2012-03-24 Marco Trevisan (Treviño) +2012-03-24 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-24 Marco Trevisan (Treviño) +2012-03-24 Marco Trevisan (Trevi?o) autopilot, tests: updated against Thomi's suggestions -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) autopilot: test_hud, correctly check the window geometry on multimonitor -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) Hud: add geometry introspection informations -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) autopilot: added hud monitor-aware tests 2012-03-29 Thomi Richards - Don't leak shortcut hints.. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Treviño). + Don't leak shortcut hints.. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Trevi?o). 2012-03-29 Thomi Richards @@ -5020,7 +5546,7 @@ 2012-03-28 Andrea Cimitan - 1px subtle change: 1st pixel of shadow from (0, 0, 0, 0.58f) to (0, 0, 0, 0.60f). Fixes: . Approved by Marco Trevisan (Treviño). + 1px subtle change: 1st pixel of shadow from (0, 0, 0, 0.58f) to (0, 0, 0, 0.60f). Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-28 Andrea Cimitan @@ -5040,7 +5566,7 @@ 2012-03-27 Andrea Cimitan - Smaller but sharper panel shadow, from design. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Treviño). + Smaller but sharper panel shadow, from design. Fixes: . Approved by Andrea Azzarone, Marco Trevisan (Trevi?o). 2012-03-27 Andrea Cimitan @@ -5062,11 +5588,11 @@ Disconnect smoothing_handle_ on PointerBarrierWrapper destruction. -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) Autopilot: added tests for the primary-monitor aware LauncherController. Fixes: . Approved by Thomi Richards. -2012-03-27 Marco Trevisan (Treviño) +2012-03-27 Marco Trevisan (Trevi?o) Merging with thomi's multiply_scenarios branch @@ -5074,39 +5600,39 @@ Launcher tests now use multiply_scenarios to generate test scenarios. -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, launcher: added tests to check the number of launchers -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, X11: get the glxinfo output only once. -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) test_launcher: code updated to follow the thomi's suggestions ;) -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) autopilot, X11: add BlacklistedDriverError -2012-03-25 Marco Trevisan (Treviño) +2012-03-25 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) autopilot, test_launcher: skip the tests if we can't set the primary monitor. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) autopilot: X11 emulator, add blacklist of drivers to skip the primary monitor set -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) autopilot: test launcher, added scenarios to test with more configurations -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) autpilot, X11: allow to set the primary monitor via xrandr @@ -5154,13 +5680,13 @@ * Disable alt+f1 when the dash is open -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) Launcher: Connect the already present icons to signals when setting the model. When a new launcher is added, we need to connect the icons that are already on the model to the needs_redraw signal, or the new launcher won't redraw when they ask that.. Fixes: https://bugs.launchpad.net/bugs/964851. Approved by Thomi Richards. -2012-03-26 Marco Trevisan (Treviño) +2012-03-26 Marco Trevisan (Trevi?o) Launcher: Connect the already present icons to signals when setting the model. @@ -5184,7 +5710,7 @@ 2012-03-26 Andrea Cimitan - Set 0.2 as new alpha value for dimmed icons, apply tweaks to edges. Fixes: https://bugs.launchpad.net/bugs/938620. Approved by Marco Trevisan (Treviño). + Set 0.2 as new alpha value for dimmed icons, apply tweaks to edges. Fixes: https://bugs.launchpad.net/bugs/938620. Approved by Marco Trevisan (Trevi?o). 2012-03-22 Andrea Cimitan @@ -5192,7 +5718,7 @@ 2012-03-26 Andrea Azzarone - Fix the alignment of the dash window buttons.. Fixes: https://bugs.launchpad.net/bugs/963019. Approved by Marco Trevisan (Treviño), Andrea Cimitan. + Fix the alignment of the dash window buttons.. Fixes: https://bugs.launchpad.net/bugs/963019. Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-03-23 Andrea Azzarone @@ -5210,7 +5736,7 @@ Release\ 5.8.0 -2012-03-23 Marco Trevisan (Treviño) +2012-03-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: implement WindowsOnViewport to get only windows on visible VP @@ -5219,19 +5745,19 @@ to remove code duplication, using the new GetWindows function to perform filtering via the WindowFilterMask.. Fixes: https://bugs.launchpad.net/bugs/961977. Approved by Thomi Richards, Jason Smith. -2012-03-23 Marco Trevisan (Treviño) +2012-03-23 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-23 Marco Trevisan (Treviño) +2012-03-23 Marco Trevisan (Trevi?o) manual-tests, Launcher: improved the launcher multimonitor/workspace tests -2012-03-22 Marco Trevisan (Treviño) +2012-03-22 Marco Trevisan (Trevi?o) manual-tests: added a Launcher manual test to check the "pips" changes -2012-03-22 Marco Trevisan (Treviño) +2012-03-22 Marco Trevisan (Trevi?o) BamfLauncherIcon: implement WindowsOnViewport to get only windows on visible VP @@ -5271,24 +5797,24 @@ 2012-03-22 Tim Penhey - Make sure the decay function callback is removed on object destruction.. Fixes: https://bugs.launchpad.net/bugs/962693. Approved by Marco Trevisan (Treviño). + Make sure the decay function callback is removed on object destruction.. Fixes: https://bugs.launchpad.net/bugs/962693. Approved by Marco Trevisan (Trevi?o). 2012-03-23 Tim Penhey Add a destructor to the Decaymulator to remove the on timeout function call. -2012-03-22 Marco Trevisan (Treviño) +2012-03-22 Marco Trevisan (Trevi?o) Open the Menus Indicators on ButtonPress avoiding flickers Now the indicator menus shows once Alt+F10 keybinding has been pressed, and is not anymore needed to release the Alt key. Also, fixed the panel issue reported in bug #948522 that could happen when using menus. To avoid it we use now a timeout to filter the events that we can ignore not to make unity-panel-service crazy.. Fixes: https://bugs.launchpad.net/bugs/943223, https://bugs.launchpad.net/bugs/948522. Approved by Tim Penhey. -2012-03-22 Marco Trevisan (Treviño) +2012-03-22 Marco Trevisan (Trevi?o) PanelIndicators: added Alt+F10 manual test -2012-03-22 Marco Trevisan (Treviño) +2012-03-22 Marco Trevisan (Trevi?o) UnityShell: show First indicator menu on key-down, also remove the flickering issue @@ -5354,27 +5880,27 @@ Fix regression of search bar border opacity -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) LauncherController: show a launcher in the primary monitor if set This ensures that the launcher is shown only on the primary one, not on the one at the left.. Fixes: https://bugs.launchpad.net/bugs/961281. Approved by Andrea Azzarone. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) LauncherController: ensures we have a valid launchers[0] It shouldn't ever happen, btw. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) LauncherController: ensure that the primary monitor is used when using only one launcher -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) Launcher manual test: added test to check the launcher monitors. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) LauncherController: be aware of the primary monitor. @@ -5384,7 +5910,7 @@ Fixing current dash layout which doesn't match the wanted design. - Moreover the dash code is full of magic number.. Fixes: . Approved by Andrea Cimitan, Marco Trevisan (Treviño). + Moreover the dash code is full of magic number.. Fixes: . Approved by Andrea Cimitan, Marco Trevisan (Trevi?o). 2012-03-21 Andrea Cimitan @@ -5398,15 +5924,15 @@ Merge trunk -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) Re-Remerge trunk -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) Re-merging with trunk. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) Merging with trunk @@ -5436,7 +5962,7 @@ 2012-03-21 Gord Allott - Hud wasn't sending its monitor with the OVERLAY_HIDDEN message, corrects that, fixes lp:961169. Fixes: . Approved by Marco Trevisan (Treviño). + Hud wasn't sending its monitor with the OVERLAY_HIDDEN message, corrects that, fixes lp:961169. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-21 Gord Allott @@ -5452,7 +5978,7 @@ 2012-03-21 Gord Allott - Fixes the incorrect item count in See x more results. see lp:934944. Fixes: https://bugs.launchpad.net/bugs/934944. Approved by Mirco Müller. + Fixes the incorrect item count in See x more results. see lp:934944. Fixes: https://bugs.launchpad.net/bugs/934944. Approved by Mirco M?ller. 2012-03-21 Gord Allott @@ -5480,7 +6006,7 @@ 2012-03-21 Gord Allott - Removes the focus forcing hack in the HUD.. Fixes: . Approved by Gord Allott, Alex Launi, Marco Trevisan (Treviño), Michal Hruby. + Removes the focus forcing hack in the HUD.. Fixes: . Approved by Gord Allott, Alex Launi, Marco Trevisan (Trevi?o), Michal Hruby. 2012-03-21 Gord Allott @@ -5496,7 +6022,7 @@ 2012-03-21 Daniel van Vugt - Fix the autoscroll timer waking up 50 times per sec when no scrolling needs to be done (LP: #917210). Fixes: https://bugs.launchpad.net/bugs/917210. Approved by Marco Trevisan (Treviño). + Fix the autoscroll timer waking up 50 times per sec when no scrolling needs to be done (LP: #917210). Fixes: https://bugs.launchpad.net/bugs/917210. Approved by Marco Trevisan (Trevi?o). 2012-03-14 Daniel van Vugt @@ -5513,18 +6039,18 @@ Also removed some unused variables. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) unity-panel-service: don't crash if the parsed a11y indicator entry is not valid Entries with invalid parent_object have been removed from the indicator so we shouldn't really care about them.. Fixes: https://bugs.launchpad.net/bugs/937119. Approved by Didier Roche. -2012-03-21 Marco Trevisan (Treviño) +2012-03-21 Marco Trevisan (Trevi?o) Manual Test: Added Panel Service test -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) PanelindicatorEntryAccessible: don't crash if the parsed entry is not valid @@ -5537,7 +6063,7 @@ from pressing Enter during any action (holding Alt). Those calls are spurious (a long-standing design bug in compiz) and do not come with a valid options[] vector. So accessing options[] would crash (LP: #960957) - . Fixes: https://bugs.launchpad.net/bugs/960957. Approved by Marco Trevisan (Treviño), Gord Allott. + . Fixes: https://bugs.launchpad.net/bugs/960957. Approved by Marco Trevisan (Trevi?o), Gord Allott. 2012-03-21 Daniel van Vugt @@ -5548,7 +6074,7 @@ 2012-03-21 Tim Penhey - Adapt the HUD visuals to look nice with a locked out launcher.. Fixes: https://bugs.launchpad.net/bugs/921506. Approved by Gord Allott, Marco Trevisan (Treviño). + Adapt the HUD visuals to look nice with a locked out launcher.. Fixes: https://bugs.launchpad.net/bugs/921506. Approved by Gord Allott, Marco Trevisan (Trevi?o). 2012-03-21 Tim Penhey @@ -5628,7 +6154,7 @@ If ccp is not used, g_type_init() is not called by the time UBusServer gets initialized, leading to a crash. This patch ensures that the GType system has been initialized before using UBusServer (it is safe to call g_type_init() - multiple times).. Fixes: . Approved by Marco Trevisan (Treviño), Jay Taoko. + multiple times).. Fixes: . Approved by Marco Trevisan (Trevi?o), Jay Taoko. 2012-03-16 Alexandros Frantzis @@ -5644,7 +6170,7 @@ 2012-03-20 Gord Allott - Fixes issue with hud not emitting a signal when results change. Fixes: https://bugs.launchpad.net/bugs/956480. Approved by Marco Trevisan (Treviño). + Fixes issue with hud not emitting a signal when results change. Fixes: https://bugs.launchpad.net/bugs/956480. Approved by Marco Trevisan (Trevi?o). 2012-03-16 Gord Allott @@ -5654,7 +6180,7 @@ don't store average-bg-color in GSettings - This is now exported by libgnome-desktop as an X property on the root window. Interested applications can pick it up from there.. Fixes: https://bugs.launchpad.net/bugs/949277. Approved by Ryan Lortie, Mirco Müller. + This is now exported by libgnome-desktop as an X property on the root window. Interested applications can pick it up from there.. Fixes: https://bugs.launchpad.net/bugs/949277. Approved by Ryan Lortie, Mirco M?ller. 2012-03-09 Ryan Lortie @@ -5713,49 +6239,49 @@ * Fix for bug #956878: The hud is designed such that if the first valid option is always selected. When the activated signal is detected early in hud::View::FindKeyFocusArea, the selected button is emitted, and the text entry is still selected as the focus area. Therefore, the hud should not reacted to the search_bar_->activated signal since it alreacdy acted in hud::View::FindKeyFocusArea. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Unity panel service: fix a small memory leak, the duplicated keystr should be free'd. Fixes: . Approved by Michal Hruby. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) PanelService: fix keystr memory leak -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) tests: added gtests for the unity::indicator::Indicators class. Fixes: . Approved by Tim Penhey. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/dbus-indicators-proxy -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) Indicators: emit a null on_entry_activated signal if the entry is not valid. This fixes a regression, tests updated. -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) UnityCore/Indicators: be simpler in GetEntry -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) test_indicators: Moving SetupTestIndicators to MockIndicators::SetupTestChildren Reducing some more code duplication -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) test_indicators: Splitted IndicatorEntriesEvents into smaller tests. Adding SetupTestIndicators to fill the indicators with values. -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) tests: added a test suite for the unity::indicator::Indicators class @@ -5764,23 +6290,23 @@ Added tests to check that is really doing what it was supposed to do. -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) DBusIndicators: emit the on_entry_activated signal only if the entry has really been found. -2012-03-15 Marco Trevisan (Treviño) +2012-03-15 Marco Trevisan (Trevi?o) Indicators: don't re-add an indicator if already present. Just return the known one. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) DBusIndicators code rewritten to use glib::DBusProxy instead of raw gdbus calls. Fixes: . Approved by Michal Hruby. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/indicators-p (and trunk) -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) Merging with Michal's branch @@ -5790,27 +6316,27 @@ Make sure we keep correct connection state -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) Indicators: move to std::unique_ptr based pimpl -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) DBusIndicators: Use safer idle and move to glib::Variant in CallData -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) DBusIndicators: avoid to run the reconnect timeout twice. -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/dbus-proxy-name-owner-watch changes -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) DBusIndicators: sync against DBusProxy changes, add reconnection support here -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) GLibDBusProxy: fix pimpl, and use "notify::g-name-owner" to check the connection status. @@ -5818,17 +6344,17 @@ Also, remove the autoconnection support, this can be now done easily by clients. -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) Reverting changes of the latest two revisions, putting them on a different branch. -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) DBusIndicators: sync against DBusProxy changes, add reconnection support here Plus, when clearing the indicators, we also clear the cached entries locations. -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) GLibDBusProxy: fix pimpl, and use "notify::g-name-owner" to check the connection status. @@ -5836,11 +6362,11 @@ Also, remove the autoconnection support, this can be now done easily by clients. -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) DBusIndicators: cleaning up -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) DBusIndicators: code rewritten to make it use glib::DBusProxy @@ -5848,267 +6374,267 @@ and reduce the usage of C-code. Also, improved the pimpl idiom, using the std::unique_ptr and setting everything private -2012-03-14 Marco Trevisan (Treviño) +2012-03-14 Marco Trevisan (Trevi?o) GLibDBusProxy: add support for auto-reconnection If enabling the auto_reconnect value, the proxy tries to reconnect to the service when the connection is lost. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Updated unity-panel-service and libunity-core against the libindicator API changes. Fixes: https://bugs.launchpad.net/bugs/878492, https://bugs.launchpad.net/bugs/926330, https://bugs.launchpad.net/bugs/938890, https://bugs.launchpad.net/bugs/938895. Approved by Thomi Richards, Tim Penhey, Andrea Azzarone, Michal Hruby. -2012-03-20 Marco Trevisan (Treviño) +2012-03-20 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-19 Marco Trevisan (Treviño) +2012-03-19 Marco Trevisan (Trevi?o) Oops, resetting back the exec property to autopilot -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) DBusIndicators: use glib::Object to handle the dbus proxy, so we have ref-counting for free -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) DBusIndicators: ref/unref proxy when using idle... -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) PanelService: remove unneeded include -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) PanelService: make sure we don't try to show an entry that is not shown on the panel using the key navigation. Or at least, an entry with not synced geometries. -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) Indicators: avoid to cast the AppmenuIndicator when not needed. -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: c_str() is not needed in GetName -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) PanelService: close the menu if the related entry has been removed. -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) PanelIndicatorsView: don't activate invisible views on mouse movement. -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) PanelService: removed the workaround to look for wrongly-removed entries -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) AppmenuIndicator: removing the LIM-related code -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) IndicatorEntry: add also the ShowMenu method with no Xid parameter as fallback -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) PanelService: store a keycode instead of a keysym. -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) Reverting changes wrongly pushed to lp:~3v1n0/unity/lim They come from the lim-panel branch... Sorry for that. -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: increase the mouse-down timeout to 150ms -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) PanelView: On opacity toggle redraw the panel on expo changes Fixes bug #940683 -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) PanelService: merging with lp:~3v1n0/lim fixes -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) PanelService: don't hardcode F10 keybinding to hide the menus, use the gconf key value. Also hide them on KeyPress -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) Panelservice: Fixed coverity warning -2012-02-24 Marco Trevisan (Treviño) +2012-02-24 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: add a workaround to disable the menus only on few cases Right now it's better to stop the false-negatives more than the false-positives -2012-02-24 Marco Trevisan (Treviño) +2012-02-24 Marco Trevisan (Trevi?o) PanelView: fix the evil red panel It happened with bluish backgrounds... Damned double/float conversion! ;) -2012-02-24 Marco Trevisan (Treviño) +2012-02-24 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/lim -2012-02-24 Marco Trevisan (Treviño) +2012-02-24 Marco Trevisan (Trevi?o) Merging with upstream -2012-02-24 Marco Trevisan (Treviño) +2012-02-24 Marco Trevisan (Trevi?o) PanelService: update the entry_activated callback signature to fix a crash -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) Merging with trunk. -2012-02-23 Marco Trevisan (Treviño) +2012-02-23 Marco Trevisan (Trevi?o) PanelIndicatorsView: don't activate an unfocused entry on keyboard Alt+F10 -2012-02-23 Marco Trevisan (Treviño) +2012-02-23 Marco Trevisan (Trevi?o) unityshell: Alt+F10 should be triggeted on ButtonPress. -2012-02-23 Marco Trevisan (Treviño) +2012-02-23 Marco Trevisan (Trevi?o) PanelView: always set the monitor. -2012-02-23 Marco Trevisan (Treviño) +2012-02-23 Marco Trevisan (Trevi?o) Merging trunk -2012-02-23 Marco Trevisan (Treviño) +2012-02-23 Marco Trevisan (Trevi?o) PanelView: add monitor getter. -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: don't try to draw an invalid flair, and re-draw it Flair wasn't drawn anymore... Fixing it, and possible glitches. -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelMenuView: removing unneeded includes -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelView -> PanelIndicatorAppmenu: don't always open menus on keyboard shortcuts We need to check that the current appmenu is actually focused. -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelMenuView: use geometry in DrawText -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelMenuView: no need to register interest for dash status, let's use the parent -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelView: some more cleanup -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelView: move to UBusWrapper -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelView: no need to resync on remote synced signal, entries will notify the panel -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelView: cleanup the API -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: sync geometries also for unfocused items. It could gives wrong results when opening an unfocused menu. -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelIndicators: don't activate them if unfocused or invisible on mouse-over -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) WindowButton: no need to add an extra _enabled variable, ViewEnabled can be enough We need the nux branch lp:~3v1n0/nux/view-enable-logic-fix to be merged as well. -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) WindowButtons: if the managed window is not minimizable, disable the minimize button -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) WindowManager: add getter to check if a window is minimizable. -2012-02-22 Marco Trevisan (Treviño) +2012-02-22 Marco Trevisan (Trevi?o) PanelMenuView: make the WindowButtons handle their operation, just update their xid -2012-02-21 Marco Trevisan (Treviño) +2012-02-21 Marco Trevisan (Trevi?o) WindowButtons: add one more button for restore state, and swap it with the maximize one Also handle internally the maximization / restore of the dash. -2012-02-21 Marco Trevisan (Treviño) +2012-02-21 Marco Trevisan (Trevi?o) WindowButtons: improved a lot the code, using more the WindowButtons container -2012-02-20 Marco Trevisan (Treviño) +2012-02-20 Marco Trevisan (Trevi?o) PanelMenuView: restore a grabbed window, handling it in a position relative to the panel size So this is shared between integrated and global modes. -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) PanelStyle: fallback buttons, make them smaller, except for HighContrast themes -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) PanelMenuView: update the layout padding on sytle changes, according to buttons size -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) PanelStyle: fallback-buttons, handle the case of an unfocused close button -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) Unione con il tronco... [cit. Jason] -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) Panel*.h classes, move introspection methods in protect field. -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) PanelMenuView: Make the grabbing of a maximized window from the panel better. @@ -6127,7 +6653,7 @@ Added also misc improvements to the PanelMenuView code. -2012-02-18 Marco Trevisan (Treviño) +2012-02-18 Marco Trevisan (Trevi?o) WindowManager: add some utility functions to handle window geometries @@ -6140,13 +6666,13 @@ RestoreAt: restores a window and move it at the given x, y position keeping the standard geometry. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: use the Cimi's cairo flair instead of the asset Thanks -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: ignore the grabs if during the timeout we got a small movement @@ -6155,69 +6681,69 @@ As design wanted. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelStyle: add myself as author. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelStyle: make GetFallbackWindowButton public It was GetWindowButtonForTheme before. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelStyle: implement unfocused/disabled state on GetWindowButtonForTheme -2012-02-16 Marco Trevisan (Treviño) +2012-02-16 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: fixed compiler warning -2012-02-16 Marco Trevisan (Treviño) +2012-02-16 Marco Trevisan (Trevi?o) Merging with LIM fixes from lp:~3v1n0/unity/lim -2012-02-16 Marco Trevisan (Treviño) +2012-02-16 Marco Trevisan (Trevi?o) services/CMakeLists: fixed typo. -2012-02-14 Marco Trevisan (Treviño) +2012-02-14 Marco Trevisan (Trevi?o) PanelService renamed the *_actually_show_entry* function to something better -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelService: fixed dbus parameter name -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Some code cleanup requested by andyrock -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelMenuView: avoid to get an invalid maximized window -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelMenuView: fix the items padding values according to the design specs Making the panel pixel-perfect as well! ;) -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: setting the right padding value to 7 pixels The value has been computed using design mokups -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: add support for left/right padding protected parameters -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) unityshell, resources: added the LIM flair assets from design -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: Consider the entry with when drawing the flair @@ -6225,89 +6751,89 @@ Also using cairo_translate to correctly draw without being dependent on the source geometry. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelMenuView: make sure that the window buttons are middle-aligned on the panel. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: including the has_menu property to the introspect. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: reduced the spacing to 2px -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: allow to define the spacing per each view. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) UnityCore, Variant: added wrappers for long long types as well. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelMenuView: remove the right layout padding Otherwise there would be a small area at the right of the menus that won't be grabbable. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) WindowButtons: don't leak memory when allocating the textures. We need to use the ObjectPtr's Adopt facility here. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) unityshell: always draw the destkop shadow when integrated menus are enabled. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PluginAdapter: Consider window in showdesktop mode when checking for visibility or obscured -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: check if the target window has a menu, when setting the window xid. If a window has not menus we don't need to draw the indicator entry icon. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: implement IsLabelSensitive and IsIconSensitive The they should be both sensitive unless there's a window that exports the ubuntu menus atoms. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: add new getters (overridable) to define the label/icon status Also, draw an unfocused icon as insensitive -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelMenuView: added some comments to explain how we manage the events of the integrated menus -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: implement the Activate method. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelMenuView: use the new PanelTitlebarGrabArea features to handle the panel grabbing / signals Maximized windows are now handled using the new code, no more cursor change when not needed! :) -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: keep track of the mouse-down button, to check it while dragging. Also add restore_request signal on double-click. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: redesigned, to getter grabbed event using a timeout @@ -6317,120 +6843,120 @@ This allows to improve the way we handle the grab event in the panel, and allow to avoid to change the mouse cursor if not needed. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: implement the DrawEntryPrelight method to draw the menu flair When an appmenu is active, we draw this small shadow, using the design-provided assets. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) UnityWindow: don't draw the panel shadow over a window if the integrated menus are enabled. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelStyle: Add a integrated_menus property to get the current panel status -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Indicators: Updating the geometry before than the active status! -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) UnityCore, Indicators: set the geometry before than the active status. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/lim changes -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) UnityCore, IndicatorEntry: add support for entry geometry. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) UnityCore: add first basic support to the geometry on EntryActivated -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelSerivice: Emit EntryActivated signal including the opened menu geometries -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Use everywhere on the panel land the panel::Style's panel_height. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Merging with thomi's branch from trunk that adds the panel-height to panel::style -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Merging with thomi's cleanup branch from trunk -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: as first stage, activate the related window on click. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/lim changes -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelService: avoid to do unneeded loops when looking for an entry -2012-02-10 Marco Trevisan (Treviño) +2012-02-10 Marco Trevisan (Trevi?o) Panel-Service: added workaround to check if a removed entry is really invalid This is needed due to an indicator-appmenu issue, I hope to remove this soon. -2012-02-09 Marco Trevisan (Treviño) +2012-02-09 Marco Trevisan (Trevi?o) PanelService: resetg the static service on finalize. -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) Panel-service: Merging with changes from lp:~3v1n0/unity/lim-panel -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) panel-service: fixed a typo Eeekk! It caused menus not to swtich on keypress! -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) panel-service: don't use the "evil hack" to get the entry value... Going back to HashTable Using IO could lead to unexpected troubles and is slower, Hashtables are better :) -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: don't activate during expo and scale and cut with fade long entries This will apply to both APPMENU entry and other entries, even if with different values. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelMenuView: set the maximum space that the child entries can use So applications with a lot of menu entries can be drawn correctly. -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelIndicatorsView: allow to define the maximum area to be used by entries -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelMenuView: Add a setter and geter for the integrated mode Plus, add right padding to the layout to avoid drawing issues and cleanup the methods types newlin -2012-02-11 Marco Trevisan (Treviño) +2012-02-11 Marco Trevisan (Trevi?o) PanelMenuView: remove the extra layout, use the parent layout. @@ -6439,11 +6965,11 @@ Removed the post-layout computation, and added a small pre-layout computation to adjust the grab area size. -2012-02-10 Marco Trevisan (Treviño) +2012-02-10 Marco Trevisan (Trevi?o) PanelMenuView: avoid to do unnededed computation if the integrated menus are enabled -2012-02-10 Marco Trevisan (Treviño) +2012-02-10 Marco Trevisan (Trevi?o) PanelMenuView: correctly handle unmapped windows, using Bamf @@ -6452,17 +6978,17 @@ our sets and redraw the panel (without this, when closing unfocused windows, this was never happening). -2012-02-10 Marco Trevisan (Treviño) +2012-02-10 Marco Trevisan (Trevi?o) PanelMenuView: on restored, immediately update _maximized_set Otherwise we get the wrong maximized window. -2012-02-09 Marco Trevisan (Treviño) +2012-02-09 Marco Trevisan (Trevi?o) PanelMenuView: fill the decoration set on init, make the window to activate before being retsored -2012-02-09 Marco Trevisan (Treviño) +2012-02-09 Marco Trevisan (Trevi?o) PanelMenuView: Make the menus / label show when they really are needed @@ -6471,45 +6997,45 @@ Also, use BAMF again to get the application name. -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelMenuView: Use the window title for maximized windows in integrated menus too Fallback to application name if it's not available. -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: neve draw appmenu entry as prelighted -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelMenuView: update the integrated menu focused state according to the current status -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: add support for focused state. The entries marked as unfcoused will use the gtk style contex state GTK_STATE_FLAG_BACKDROP -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: use new PanelStyle features, draw differently APPMENU entries -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelMenuView: use PanelStyle to get the font settings, fix crash on distroy And other various fixes... -2012-02-08 Marco Trevisan (Treviño) +2012-02-08 Marco Trevisan (Trevi?o) PanelStyle: allow to get text for each panel entry type and monitor title changes PanelStyle now monitors also gconf changes to the title key and allow to easily get the theme for each panel entry -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelMenuView: First working stub of integrated menus @@ -6520,7 +7046,7 @@ The view is also updated everytime the panel title or the active window changes. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelIndicatorAppmenuView: added indicator-entry subclass to store the Appmenu Entry @@ -6528,37 +7054,37 @@ window associated and a label to make sure we're showing a menu for that given window. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: Improve the class to make it usable as base for our Appmenu entry -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelIndicatorsView: add more versatile functions for protected guests So it's possible to add an entry by its view, not only by indicator::Entry -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Variant: added more int wrappers -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: removing the evil define's -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/lim updates (and with trunk too) -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Panel-service: Fix dispose errors. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelMenuView: added preliminary code for LIM, support for integrated window buttons @@ -6569,140 +7095,140 @@ when pressing them the changes are applied to the maximized window in top of the stack. Also they are correctly draw as active or inactive. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) WindowButtons: addSupport for focused/unfocused buttons. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelStyle: fix a typo to get unfocused button texture -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) PanelStyle: add support for unfocused window buttons style -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) WindowButtons: use more wrapper classes to be safer and cleaner -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelMenuView: fill the maximized set once that the monitor has been set -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelMenuView: override Add/Remove indicator methods to connect to Appmenu signals Used to update the _is_integrated value -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelIndicatorsView: added IsAppmenu method. -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelMenuView: added more private or protected members -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelMenuView: using UBusManager for handling events -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelStyle: emit the changed singal also when the text dpi changed So, when the scaling factor value is changed the panel gets immediately updated. -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelMenuView: don't re-draw the panel text if it's not needed If the geometry, the text or the style have not changed, there's no need re-draw the cairo text layout. -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: don't listen to font changes Also, no need to disconnect to signals connected with sigc::mem_fun -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) PanelStyle: emit the changed signal also when the font has changed. -2012-02-05 Marco Trevisan (Treviño) +2012-02-05 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: avoid to use unneeded memory to store a TextureLayer -2012-02-05 Marco Trevisan (Treviño) +2012-02-05 Marco Trevisan (Trevi?o) PanelMenuView: don't use a TextureLayer, we can just use a BaseTexture -2012-02-05 Marco Trevisan (Treviño) +2012-02-05 Marco Trevisan (Trevi?o) PanelMenuView: cleanup the DrawText code -2012-02-05 Marco Trevisan (Treviño) +2012-02-05 Marco Trevisan (Trevi?o) Panel-Service: Some indentation fixes. -2012-02-05 Marco Trevisan (Treviño) +2012-02-05 Marco Trevisan (Trevi?o) Panel-Service: If the gometries of the current opened entry have changed, we need to update the menu postion This fixes some issues with menu entries that changes the label while the menu is showing. -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) PanelMenuView: Move GetActiveViewName to std::string -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) PanelMenuView: first slot of code cleanup... Moving out pointers -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) PanelStyle: Cleanup the code, and use the new wrappers -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) No commit message -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: the indicators aren't blurred anymore when dash is opened :( By design... I really loved them! -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: merging with some code refactoring I did few weeks ago. Coming from the "legendary" lp:~3v1n0/unity/dash-glow branch... -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) DBusIndicators: Removing debug code -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: if an entry is not visible, don't draw it and set it as invisible. This fixes bug #926330 -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) IndicatorEntry: the image_type should be valid as well to make an entry visible -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) panel-service: check if we know the parent indicator and reduce writes... -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) IndicatorEntry: remove the UNUSED_ID support, and add the visible property @@ -6711,166 +7237,166 @@ An entry is visible when has valid label or valid image. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) UnityCore, AppmenuIndicator: don't emit a signal on ShowAppmenu if the indicator is not integrated -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) PanelService: added a g_warning message if we try to parse an invalid IndicatorEntryObject -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) tests, IndicatorAppmenu, added one more construction test. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) tests, TestAppmenuIndicator: added ShowAppmenu signal test. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) tests, IndicatorAppmenu, testing gsettings changes. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) tests: add preliminary test for IndicatorAppmenu -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) tests: Added a test for checking the Indicator class Plus, moving indicator-entry tests to xless, they don't need DBus. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) UnityCore, Indicator: disconnect from entry signals when they are removed from an indicator. Otherwise a removed entry was able to emit a signal through the old indicator. -2012-01-31 Marco Trevisan (Treviño) +2012-01-31 Marco Trevisan (Trevi?o) Merging with trunk fixes -2012-01-30 Marco Trevisan (Treviño) +2012-01-30 Marco Trevisan (Trevi?o) Merging with upstream -2012-01-28 Marco Trevisan (Treviño) +2012-01-28 Marco Trevisan (Trevi?o) AppmenuIndicator: using the changed:: signal -2012-01-28 Marco Trevisan (Treviño) +2012-01-28 Marco Trevisan (Trevi?o) AppmenuIndicator: keys/values names updated to the final ones -2012-01-28 Marco Trevisan (Treviño) +2012-01-28 Marco Trevisan (Trevi?o) DBusIndicators, using unsigned int for button too. -2012-01-28 Marco Trevisan (Treviño) +2012-01-28 Marco Trevisan (Trevi?o) AppmenuIndicator: update to use the real key, not the supposed one. -2012-01-28 Marco Trevisan (Treviño) +2012-01-28 Marco Trevisan (Trevi?o) Indicators: Oops, inverted logic. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) AppmenuIndicator: correctly emit the integrated_changed signal -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) Merging with remote branch -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) UnityCore: Implement OnShowAppMenu on DBusIndicators When the signal is emitted by an AppmenuIndicator, a dbus call is made to ShowAppMenu -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) UnityCore: Implement OnShowAppMenu on DBusIndicators When the signal is emitted by an AppmenuIndicator, a dbus call is made to ShowAppMenu -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) Indicators: add ShowAppMenu virtual function and call it when AppmenuIndicator is added. Only AppmenuIndicator's are connected to that function. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) AppmenuIndicator: Update ShowAppmenu to emit a signal when called. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) PanelView: use IsAppmenu to check the nature of the indicator. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) UnityCore: Added AppmenuIndicator class, subclass of Indicator to keep track of setting changes Modified also Indicator, to get the type of the indicator. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) PanelView, PanelIndicatorEntry: update against the new Indicator API -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) DBusIndicators: updated also the on_entry_show_menu signal. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) Tests, PanelService: re-enabled the test and fixed the compilation and execution. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) tests: Updated IndicatorEntry test against new API -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) UnityCore: update Entry ShowMenu related methods against the services changes. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) PanelService: reordering the ShowEntry parameters -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) PanelService: using unsigned int for sending the button -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) panel-service: implemented the method ShowAppMenu Plus some code cleanup, factorizing the show-menu function in panel_service_actually_show_entry -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) PanelService: don't close the pipe's read fd, or also writing will fail. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) PanelService: add xid parameter to ShowEntry -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) panel-service: make sure we remove invalid entries when syncing the geometry hash. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) panel-service: get_indicator_entry_by_id must be static, improving the comments. -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) panel-service: remove the entry2indicator_hash, moving using the entry parent_object field @@ -6881,7 +7407,7 @@ crashing, so we can finally be pretty sure if the pointed entry is an IndicatorObjectEntry if it has a valid parent IndicatorObject -2012-01-25 Marco Trevisan (Treviño) +2012-01-25 Marco Trevisan (Trevi?o) Unity: Depends on newer indicator3-0.4 0.4.90 @@ -6952,7 +7478,7 @@ 2012-03-20 Tim Penhey - Refactor a number of autopilot tests to reduce the likelihood of timing based failures.. Fixes: . Approved by Thomi Richards, Marco Trevisan (Treviño). + Refactor a number of autopilot tests to reduce the likelihood of timing based failures.. Fixes: . Approved by Thomi Richards, Marco Trevisan (Trevi?o). 2012-03-20 Tim Penhey @@ -7012,7 +7538,7 @@ 2012-03-19 Daniel van Vugt - Use more accurate timing to detect key taps (for Super or Alt).. Fixes: https://bugs.launchpad.net/bugs/953089. Approved by Marco Trevisan (Treviño), Mirco Müller. + Use more accurate timing to detect key taps (for Super or Alt).. Fixes: https://bugs.launchpad.net/bugs/953089. Approved by Marco Trevisan (Trevi?o), Mirco M?ller. 2012-03-17 Daniel van Vugt @@ -7067,7 +7593,7 @@ 2012-03-18 Tim Penhey - Make sure the launchers are cleaned up appropriately on shutdown.. Fixes: . Approved by Mirco Müller. + Make sure the launchers are cleaned up appropriately on shutdown.. Fixes: . Approved by Mirco M?ller. 2012-03-16 Tim Penhey @@ -7160,27 +7686,27 @@ add file -2012-03-15 Mirco Müller +2012-03-15 Mirco M?ller Fix alignment and padding of scrollbars. Fixes: https://bugs.launchpad.net/bugs/608124. Approved by Andrea Cimitan. -2012-03-15 Mirco Müller +2012-03-15 Mirco M?ller fixed bloody anjuta-induced spacing issues -2012-03-14 Mirco Müller +2012-03-14 Mirco M?ller Clean up and remove debug-rects -2012-03-13 Mirco Müller +2012-03-13 Mirco M?ller Added andyrock's suggestion regarding the Min/Max-size for the VScrollBar to fix the issue with the right scrollbar (when filters are expanded) -2012-03-13 Mirco Müller +2012-03-13 Mirco M?ller Fixed horizontal padding between scrollbar of results-view and expanded filters... also made sure the right edge of search-bar right-aligns with this -2012-03-12 Mirco Müller +2012-03-12 Mirco M?ller Still hunting for the right spot to tweak the padding for dash-scollbars... added debug-rects again @@ -7244,7 +7770,7 @@ 2012-03-14 Thomi Richards - Fix AutoPilotTestCase class so launcher tests pass again.. Fixes: . Approved by Marco Trevisan (Treviño). + Fix AutoPilotTestCase class so launcher tests pass again.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-15 Thomi Richards @@ -7256,7 +7782,7 @@ Test ==== - Already in trunk.. Fixes: https://bugs.launchpad.net/bugs/955296. Approved by Marco Trevisan (Treviño). + Already in trunk.. Fixes: https://bugs.launchpad.net/bugs/955296. Approved by Marco Trevisan (Trevi?o). 2012-03-14 Andrea Azzarone @@ -7264,7 +7790,7 @@ 2012-03-14 Andrea Azzarone - Fix a stupid regression. . Fixes: https://bugs.launchpad.net/bugs/955160. Approved by Mirco Müller. + Fix a stupid regression. . Fixes: https://bugs.launchpad.net/bugs/955160. Approved by Mirco M?ller. 2012-03-14 Andrea Azzarone @@ -7279,7 +7805,7 @@ Fix minor coding error (use min instead of max) == Testing == - Fixes existing tests that now fail. Fixes: . Approved by Marco Trevisan (Treviño). + Fixes existing tests that now fail. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-14 Jason Smith @@ -7291,7 +7817,7 @@ Added a manual test as an autopilot one will require more pocking (firefox API) Please poke me before merging it, I need to revert this to the package (it's already - published as a distro-patch). Fixes: . Approved by Daniel van Vugt, Marco Trevisan (Treviño). + published as a distro-patch). Fixes: . Approved by Daniel van Vugt, Marco Trevisan (Trevi?o). 2012-03-14 Didier Roche @@ -7401,7 +7927,7 @@ * Test for Multi_Key/Composition characters -2012-03-13 Marco Trevisan (Treviño) +2012-03-13 Marco Trevisan (Trevi?o) Added support for Up/Down arrow keys to change the selected launcher icon when using the Super+Tab @@ -7409,14 +7935,14 @@ On the test sides, I've used autopilot to test this particular fix, also I've made some changes to the launcher emulator, to make it handle in a better way the Launcher key navigation and the Launcher Switcher as two different kinds of key navigation. This should avoid any confusion and cleans the code.. Fixes: https://bugs.launchpad.net/bugs/950404. Approved by Andrea Azzarone, Thomi Richards. -2012-03-10 Marco Trevisan (Treviño) +2012-03-10 Marco Trevisan (Trevi?o) autopilot: added the tests for the Up/Down arrow keys during launcher switcher Plus, redesigned the launcher emulator, underlining the differece between the Launcher Switcher and the Launcher Key navigation. -2012-03-09 Marco Trevisan (Treviño) +2012-03-09 Marco Trevisan (Trevi?o) unityshell: make Launcher switcher to work also with arrow keys @@ -7437,7 +7963,7 @@ http://ubuntuone.com/1a4mdRPJ8tgFrg4bMuNiQE - I've merged lp:~sladen/unity/unity-drunken-spinner-lp943656.. Fixes: https://bugs.launchpad.net/bugs/927710, https://bugs.launchpad.net/bugs/942508. Approved by John Lea, Andrea Cimitan, Mirco Müller. + I've merged lp:~sladen/unity/unity-drunken-spinner-lp943656.. Fixes: https://bugs.launchpad.net/bugs/927710, https://bugs.launchpad.net/bugs/942508. Approved by John Lea, Andrea Cimitan, Mirco M?ller. 2012-03-13 Andrea Azzarone @@ -7463,7 +7989,7 @@ Update the dash font settings. -2012-03-13 Mirco Müller +2012-03-13 Mirco M?ller Trying to understand how and where changes to an icons alpha- and saturation-value are taking place is material to get insane. By now I've spent many many many hours trying to get behind what's going on. I can't say I fully grasp the intricate ways of icons opacity and saturation in class Launcher. @@ -7488,11 +8014,11 @@ If anybody ever causes this to regress, I'll ... !. Fixes: https://bugs.launchpad.net/bugs/863230. Approved by Tim Penhey. -2012-02-29 Mirco Müller +2012-02-29 Mirco M?ller Added a manual-test for the bug -2012-02-15 Mirco Müller +2012-02-15 Mirco M?ller Best attempt yet, trying to fix LP: #863230 @@ -7524,7 +8050,7 @@ = Testing = - None.. Fixes: https://bugs.launchpad.net/bugs/942515. Approved by Marco Trevisan (Treviño). + None.. Fixes: https://bugs.launchpad.net/bugs/942515. Approved by Marco Trevisan (Trevi?o). 2012-03-05 Andrea Azzarone @@ -7546,7 +8072,7 @@ = Testing = - Added.. Fixes: https://bugs.launchpad.net/bugs/939517. Approved by Mirco Müller. + Added.. Fixes: https://bugs.launchpad.net/bugs/939517. Approved by Mirco M?ller. 2012-02-28 Andrea Azzarone @@ -7588,7 +8114,7 @@ = Testing = - AP test: ./tools/autopilot run autopilot.tests.test_dash.DashVisualTests.test_see_more_result_alignment. Fixes: https://bugs.launchpad.net/bugs/748101. Approved by Alex Launi, Marco Trevisan (Treviño), Thomi Richards, Andrea Cimitan. + AP test: ./tools/autopilot run autopilot.tests.test_dash.DashVisualTests.test_see_more_result_alignment. Fixes: https://bugs.launchpad.net/bugs/748101. Approved by Alex Launi, Marco Trevisan (Trevi?o), Thomi Richards, Andrea Cimitan. 2012-03-13 Andrea Azzarone @@ -7671,7 +8197,7 @@ = Test coverage = - There is an autopilot test for this now!. Fixes: https://bugs.launchpad.net/bugs/711199. Approved by Tim Penhey, Alex Launi, Michal Hruby, Marco Trevisan (Treviño), Brandon Schaefer. + There is an autopilot test for this now!. Fixes: https://bugs.launchpad.net/bugs/711199. Approved by Tim Penhey, Alex Launi, Michal Hruby, Marco Trevisan (Trevi?o), Brandon Schaefer. 2012-03-08 Brandon Schaefer @@ -7745,39 +8271,39 @@ Cleaned up, and fixed conflicts -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) Added tests for SwitcherController changes done in lp:~3v1n0/unity/alt+tab-background-load, enabled the SwitcherModel tests as well.. Fixes: https://bugs.launchpad.net/bugs/942634. Approved by Tim Penhey, Andrea Azzarone. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) test_switcher_controller: make the construction test to really test something -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) test_switcher_controller: removing the redoundant Test prefix in functions -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) test_switcher_controller: reduce the time to use to perform the test -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/alt+tab-background-load changes -2012-02-28 Marco Trevisan (Treviño) +2012-02-28 Marco Trevisan (Trevi?o) tests: added test_switcher_controller to check construction and lazy load -2012-02-28 Marco Trevisan (Treviño) +2012-02-28 Marco Trevisan (Trevi?o) Tests, enabling test_switcher_model -2012-02-28 Marco Trevisan (Treviño) +2012-02-28 Marco Trevisan (Trevi?o) Merging with trunk -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) Add some background operations to the SwitcherController to make the Alt+Tab to show-up quicker @@ -7788,93 +8314,93 @@ Tests included into the branch lp:~3v1n0/unity/alt+tab-background-load.tests. Fixes: https://bugs.launchpad.net/bugs/942634. Approved by Andrea Azzarone. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) SwitcherController: allow to define the load timeout on construction -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) SwitcherController: use protected member to set the construct timeout So it will be possible to test it. -2012-02-27 Marco Trevisan (Treviño) +2012-02-27 Marco Trevisan (Trevi?o) SwitcherController: setting the load timeout to 20s -2012-02-26 Marco Trevisan (Treviño) +2012-02-26 Marco Trevisan (Trevi?o) SwitcherController: use SetOpacity instead of SetVisible -2012-02-26 Marco Trevisan (Treviño) +2012-02-26 Marco Trevisan (Trevi?o) SwitcherController: move to UBusManager -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) SwitcherController: add an idle to construct the view when waiting for the show timeout -2012-02-25 Marco Trevisan (Treviño) +2012-02-25 Marco Trevisan (Trevi?o) SwitcherController: add a lazy loader to create the Alt+Tab window on background This should improve the startup time of the first Alt+Tab session. -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) Partly fixes bug #824965 enabling scroll wheel on Alt+Tab to switch the active application.. Fixes: https://bugs.launchpad.net/bugs/824965. Approved by Alex Launi, Thomi Richards. -2012-03-07 Marco Trevisan (Treviño) +2012-03-07 Marco Trevisan (Trevi?o) Merging with trunk changes. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) UnityScreen: add / remove scroll actions in compiz screen This is not strictly needed here since compiz seems to grab them already, but this should ensure that they're managed. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Autopilot, switcher: split mouse-wheel tests -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) unityshell: support both horizontal and vertical scroll events on AltTab -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) unityshell: remove unneeded space. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Added autopilot test for switcher mouse-wheel support. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-27 Marco Trevisan (Treviño) +2012-02-27 Marco Trevisan (Trevi?o) UnityScreen: igonore quick scroll events, use a limit of 150ms -2012-02-26 Marco Trevisan (Treviño) +2012-02-26 Marco Trevisan (Trevi?o) unityshell: inverting the scrolling direction to for the switcher -2012-02-26 Marco Trevisan (Treviño) +2012-02-26 Marco Trevisan (Trevi?o) unityshell: allow to change Switcher selected icon via mouse-wheel 2012-03-12 Thomi Richards Problem: Several of the test_shortcut_hint autopilot tests fail. - Solution: Update tests. One issue was that the autopilot API had changed, another was a typo in the test.. Fixes: . Approved by Marco Trevisan (Treviño). + Solution: Update tests. One issue was that the autopilot API had changed, another was a typo in the test.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-13 Thomi Richards @@ -7884,15 +8410,15 @@ Merged branch that fixes unity crash in shortcut hint controller. -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) Avoid autopilot to crash unity when the shortcut hint view has not been initialized.. Fixes: . Approved by Thomi Richards. -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) ShortcutController: avoid to crash during autopilot if view_window_ has not been initialized. -2012-03-12 Marco Trevisan (Treviño) +2012-03-12 Marco Trevisan (Trevi?o) Add support to hide the shortcut hint view by Escape key. @@ -7905,17 +8431,17 @@ Added autopilot support for the Shortcut hint controller, and a first bunch of tests.. Fixes: https://bugs.launchpad.net/bugs/943422. Approved by Andrea Azzarone, Thomi Richards. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) autopilot, test_shortcut_hint.py: set the default size on constructor. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) autopilot: test_shortcut_hint.py check if all the shortcut hints are showing together Shortcut hints view and the launcher icon hint should be shown at the same time -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) Merging again with thomi's fixed tests @@ -7931,53 +8457,53 @@ Various test cleanups. -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) autopilot, test_shortcut_hint: added ShortcutHints integration tests. They tests the interaction between the shortcut hints and other unity parts, especially the LauncherSwitcher and the other Super keybindings -2012-03-02 Marco Trevisan (Treviño) +2012-03-02 Marco Trevisan (Trevi?o) autopilot: test launcher switcher cancel by Escape key -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) autopilot, test_shortcut_hint: added first basic shortcut hint tests -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) autopilot: ShortcutHint emulator, misc code fixes -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) autopilot, X11 emulator: allow to get the primary monitor -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) ShortcutController: add more introspection data. Setting it as visible when the view is really visible. Also include the FADE duration into the timeout. -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) unityshell: add the shortcut controller as an introspectable child. -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) Merging with autopilot fixes included into lp:~3v1n0/unity/super+tab-shortcut-fixes -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) autopilot: add first shortcut_hint.py emulator scheleton -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) ShortcutController: added introspection support -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) UnityScreen: EnableCancelAction, add support for multiple targets @@ -8027,7 +8553,7 @@ The test === - Adds a unit test for the logic side.. Fixes: https://bugs.launchpad.net/bugs/850984. Approved by Marco Trevisan (Treviño). + Adds a unit test for the logic side.. Fixes: https://bugs.launchpad.net/bugs/850984. Approved by Marco Trevisan (Trevi?o). 2012-03-09 Andrea Azzarone @@ -8055,7 +8581,7 @@ 2012-03-12 Tim Penhey - Added some manual tests for the launcher reorder animations.. Fixes: . Approved by Mirco Müller. + Added some manual tests for the launcher reorder animations.. Fixes: . Approved by Mirco M?ller. 2012-03-05 Tim Penhey @@ -8063,7 +8589,7 @@ 2012-03-12 Lorenzo Mattei - . Fixes: https://bugs.launchpad.net/bugs/891818. Approved by Marco Trevisan (Treviño), Mirco Müller. + . Fixes: https://bugs.launchpad.net/bugs/891818. Approved by Marco Trevisan (Trevi?o), Mirco M?ller. 2012-03-07 Lorenzo Mattei @@ -8094,7 +8620,7 @@ Make sure a Search call can restart a lens just as GlobalSearch can. == Testing == - Added a manual test for the issue.. Fixes: https://bugs.launchpad.net/bugs/947301. Approved by Mirco Müller, Gord Allott. + Added a manual test for the issue.. Fixes: https://bugs.launchpad.net/bugs/947301. Approved by Mirco M?ller, Gord Allott. 2012-03-06 Michal Hruby @@ -8106,11 +8632,11 @@ 2012-03-12 Paolo Rotolo - Fix typo in plugins/unityshell/unityshell.xml.in: stoped → stopped. Fixes LP: #931382.. Fixes: https://bugs.launchpad.net/bugs/931382. Approved by Marco Trevisan (Treviño). + Fix typo in plugins/unityshell/unityshell.xml.in: stoped ? stopped. Fixes LP: #931382.. Fixes: https://bugs.launchpad.net/bugs/931382. Approved by Marco Trevisan (Trevi?o). 2012-03-07 Paolo Rotolo - Fix typo in plugins/unityshell/unityshell.xml.in: stoped → stopped. Fixes LP: #931382. + Fix typo in plugins/unityshell/unityshell.xml.in: stoped ? stopped. Fixes LP: #931382. 2012-03-12 Martin Mrazik @@ -8127,17 +8653,17 @@ 2012-03-12 Thomi Richards - Adds the ability in autopilot to get a launcher icon with a specified desktop file.. Fixes: . Approved by Marco Trevisan (Treviño). + Adds the ability in autopilot to get a launcher icon with a specified desktop file.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-09 Thomi Richards Added functionality to launcher model class - you can now retrieve icons by their desktop icon. -2012-03-12 Thomas Voß +2012-03-12 Thomas Vo? Introduces a cached variable to handle the Google Test source dir.. Fixes: . Approved by Didier Roche. -2012-03-09 Thomas Voß +2012-03-09 Thomas Vo? Introduced a cached variable for google-test source path. @@ -8309,7 +8835,7 @@ fixes issue with hud not returning focus correctly, hack was bad. - UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/934061. Approved by Gord Allott, Mirco Müller. + UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/934061. Approved by Gord Allott, Mirco M?ller. 2012-03-05 Gord Allott @@ -8395,7 +8921,7 @@ * Revert composition character support in Unity. It introduced a regression in Unity. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) UnityScreen: don't ungrab the keyboard on Alt press if switcher is active @@ -8404,11 +8930,11 @@ UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/948227. Approved by Tim Penhey, Thomi Richards. -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) autopilot, test_switcher.py: added tests for switcher escaping, and lazy invocation -2012-03-06 Marco Trevisan (Treviño) +2012-03-06 Marco Trevisan (Trevi?o) UnityScreen: don't ungrab the keyboard on Alt press if switcher is active @@ -8432,7 +8958,7 @@ Videos are stored in /tmp/autopilot. This feature is intended for use on the jenkins slave machines. - UNBLOCK. Fixes: . Approved by Marco Trevisan (Treviño), Tim Penhey. + UNBLOCK. Fixes: . Approved by Marco Trevisan (Trevi?o), Tim Penhey. 2012-03-07 Thomi Richards @@ -8464,7 +8990,7 @@ 2012-03-06 Jay Taoko - * Simulate 'ô' in a test. + * Simulate '?' in a test. 2012-03-05 Jay Taoko @@ -8476,7 +9002,7 @@ 2012-03-05 Jay Taoko - * Adding Autopilot test for composition characters (â,ô,ĩ,î,ã) typing in the dash. + * Adding Autopilot test for composition characters (?,?,?,?,?) typing in the dash. 2012-03-05 Jay Taoko @@ -8500,7 +9026,7 @@ 2012-03-06 Gord Allott - UNBLOCK resolves a silly glib issue, glib is C not C++ ;). Fixes: . Approved by Michał Sawicz. + UNBLOCK resolves a silly glib issue, glib is C not C++ ;). Fixes: . Approved by Micha? Sawicz. 2012-03-06 Gord Allott @@ -8592,7 +9118,7 @@ Also includes some other safeguards around the same issue. - UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/942625. Approved by Marco Trevisan (Treviño). + UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/942625. Approved by Marco Trevisan (Trevi?o). 2012-03-01 Daniel d'Andrada @@ -8653,13 +9179,13 @@ Two changes to the key the Keyboard emulator handles multi-key combos: We insert a delay between pressing and releasing individual keys, and always release keys in the reverse order they were pressed. - UNBLOCK. Fixes: . Approved by Marco Trevisan (Treviño), Alex Launi. + UNBLOCK. Fixes: . Approved by Marco Trevisan (Trevi?o), Alex Launi. 2012-03-02 Thomi Richards Keyboard emulator now inserts a delay between each key in a multi-key press or release action. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) The launcher icons can be shown during the Super Tab Launcher switcher. @@ -8671,19 +9197,19 @@ UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/943372, https://bugs.launchpad.net/bugs/943377. Approved by Thomi Richards. -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) autopilot, more test_launcher.py fixes -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) Merging with lp:~thomir/unity/fix-ap-test-stability -2012-03-01 Marco Trevisan (Treviño) +2012-03-01 Marco Trevisan (Trevi?o) test_launcher.py: fixed some errors in tests -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Merging with lp:~thomir/unity/super+tab-shortcut-fixes-bettertests @@ -8691,68 +9217,68 @@ Split apart launcher tests into many smaller tests. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) autopilot, test_launcher.py: Added the switcher starts on zero test -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) autopilot, test_launcher.py: Fixing the docstrings Plus use self.keyboard. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Merging with trunk. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) manual-tests: SuperTab, removed the tests now covered by autopilot -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) autopilot, test_launcher: added Super+Tab cycling tests -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) autopilot, test_launcher: added tests for bug #943372 and bug #943372 We both check the interaction with the launcher icon shortcuts, both from a visual and logical point of view. -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) autopilot, launcher emulator: add getters for shortcuts status and keyboard target launcher -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) LauncherController: add introspection to get the keyboard target launcher -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Launcher: add introspect to check if the shortcuts overlays are showing -2012-02-29 Marco Trevisan (Treviño) +2012-02-29 Marco Trevisan (Trevi?o) Merging with trunk -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) No need to terminate the Key navigation releasing super. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) manual-tests: SuperTab, one more test to check the interaction with the unity shortcuts -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) manual-test: added missing manual test for SuperTab and launcher icons shortcuts interaction -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) UnityScreen: if a valid shortcut key is pressed and the keynavigation is active, terminate it -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) LauncherController: don't hide the icon shortcuts on KeyNavigation @@ -8781,7 +9307,7 @@ * Keyboard and mouse release methods will log a warning when asked to release a key that wasn't pressed, rather than crashing. This shouldn't normally happen, but crashing is never the right thing to do. * Revealing the dash, or any lens will now clear the old search text by default. - UNBLOCK. Fixes: . Approved by Marco Trevisan (Treviño). + UNBLOCK. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-03-01 Thomi Richards @@ -8829,7 +9355,7 @@ 2012-02-29 Tim Penhey - Uses the new modifier-tap ability in compiz to only show the HUD if someone hasn't used another key with alt (or the associated key).. Fixes: https://bugs.launchpad.net/bugs/923410. Approved by Thomi Richards, Mirco Müller. + Uses the new modifier-tap ability in compiz to only show the HUD if someone hasn't used another key with alt (or the associated key).. Fixes: https://bugs.launchpad.net/bugs/923410. Approved by Thomi Richards, Mirco M?ller. 2012-02-29 Tim Penhey @@ -8877,7 +9403,7 @@ 2012-02-28 Thomi Richards - Fixed a bug in the new autopilot keybindings API which would fail to hold down single-key keybindings.. Fixes: . Approved by Marco Trevisan (Treviño). + Fixed a bug in the new autopilot keybindings API which would fail to hold down single-key keybindings.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-02-29 Thomi Richards @@ -8915,7 +9441,7 @@ run_autopilot script now warns sensibly about missing dependancies, allows users to list all tests, and run specific test(s) as well as run the entire suite. Script is now in /tools/autopilot - UNBLOCK. Fixes: . Approved by Marco Trevisan (Treviño). + UNBLOCK. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-02-29 Thomi Richards @@ -9404,7 +9930,7 @@ 2012-02-25 Jeremy Bicha - . Fixes: https://bugs.launchpad.net/bugs/926213. Approved by Marco Trevisan (Treviño), Matthew Paul Thomas, Sam Spilsbury. + . Fixes: https://bugs.launchpad.net/bugs/926213. Approved by Marco Trevisan (Trevi?o), Matthew Paul Thomas, Sam Spilsbury. 2012-02-03 Jeremy Bicha @@ -9569,7 +10095,7 @@ 2012-02-23 Andrea Cimitan - New asses from design, looks nicer!. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Cimitan. + New asses from design, looks nicer!. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-02-23 Andrea Cimitan @@ -9683,7 +10209,7 @@ = Test coverage = - Clean compile.. Fixes: . Approved by Mirco Müller. + Clean compile.. Fixes: . Approved by Mirco M?ller. 2012-02-23 Tim Penhey @@ -9721,7 +10247,7 @@ Makes bghash only change the gsettings key once per wallpaper change, instead of on every frame it transitions to the next wallpaper. - No test as gsettings is not sandboxable and this change is *only* gsettings key change related.. Fixes: . Approved by Mirco Müller. + No test as gsettings is not sandboxable and this change is *only* gsettings key change related.. Fixes: . Approved by Mirco M?ller. 2012-02-22 Gord Allott @@ -10056,14 +10582,14 @@ Updated unity introspection tree display script to use new autopilot API. -2012-02-20 Mirco Müller +2012-02-20 Mirco M?ller Fixed artwork-assets to be correctly cropped to intended size. Replaced procedural vector drawing methods with newly added artwork-textures. Updated sizes and margins to adapt to new artwork. Added FIXME-hint for keyboard-navigation highlight implementation. Also see size/gap verification in gimp for screenshot of newly implemented rating-stars: http://people.canonical.com/~mmueller/fix-924884.png. Fixes: https://bugs.launchpad.net/bugs/924884. Approved by Andrea Azzarone, Andrea Cimitan. -2012-02-20 Mirco Müller +2012-02-20 Mirco M?ller Added new artwork-assets for rating-stars. Replace old procedural vector-drawing with new textures. Adjusted sizes and gaps/margins. Added fixme-hint for later keyboard-navigation highlight implementation. @@ -10124,7 +10650,7 @@ Release\ 5.4.0 -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) Fix crash on missing dash WindowButton files @@ -10135,33 +10661,33 @@ 1) remove your $prefix/share/unity/5/unmaximize_dash* $prefix/share/unity/5/maximize_dash* and so 2) restart unity, but it will always crash.. Fixes: https://bugs.launchpad.net/bugs/921130. Approved by Tim Penhey. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) WindowButtonType: use fallback buttons if no one is valid, fix crash. Fixes LP: #921130, code improved to avoid duplication. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelStyle: add MAXIMIZE state and draw an unmaximized version as well -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) PanelStyle: move to GetFallbackWindowButton and support disabled status -2012-02-16 Marco Trevisan (Treviño) +2012-02-16 Marco Trevisan (Trevi?o) Fix crash on viewport switch, caused by http://is.gd/nOfPl5 UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/933456. Approved by Tim Penhey. -2012-02-17 Marco Trevisan (Treviño) +2012-02-17 Marco Trevisan (Trevi?o) Fix crash that can happen on viewport switch after deleting a Launcher 2012-02-16 Thomi Richards - Autopilot test log messages now include file and line number, date, time and severity information.. Fixes: . Approved by Marco Trevisan (Treviño). + Autopilot test log messages now include file and line number, date, time and severity information.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-02-17 Thomi Richards @@ -10294,11 +10820,11 @@ Don't unset the minimize and unminimize callbacks when mMinimizeHandler gets destroyed, we really only wanted to do that when the window was destroyed. -2012-02-13 Marco Trevisan (Treviño) +2012-02-13 Marco Trevisan (Trevi?o) Correctly draw the tooltip tex to fix bug #930043. Fixes: https://bugs.launchpad.net/bugs/930043. Approved by Tim Penhey. -2012-02-14 Marco Trevisan (Treviño) +2012-02-14 Marco Trevisan (Trevi?o) Tooltip: make the tooltip text draw correctly. @@ -10427,7 +10953,7 @@ - Added shadows on launcher icons and alt-tab icons - Tweaked BFB edges - Tweaked background tile color for wallpaper-colorized launcher icons (including BFB) - - Added device and show-desktop launcher icons to the list of wallpaper-colorized launcher icons. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Cimitan. + - Added device and show-desktop launcher icons to the list of wallpaper-colorized launcher icons. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-02-13 Andrea Cimitan @@ -10443,7 +10969,7 @@ 2012-02-13 Tim Penhey - Fixes the hud crashing when you open hud on an empty desktop. Fixes: https://bugs.launchpad.net/bugs/931405. Approved by Marco Trevisan (Treviño). + Fixes the hud crashing when you open hud on an empty desktop. Fixes: https://bugs.launchpad.net/bugs/931405. Approved by Marco Trevisan (Trevi?o). 2012-02-14 Tim Penhey @@ -10807,7 +11333,7 @@ 2012-02-10 Andrea Azzarone - Implements the highlight for the filter expanders.. Fixes: . Approved by Marco Trevisan (Treviño), John Lea, Andrea Cimitan. + Implements the highlight for the filter expanders.. Fixes: . Approved by Marco Trevisan (Trevi?o), John Lea, Andrea Cimitan. 2012-02-10 Andrea Azzarone @@ -10903,7 +11429,7 @@ 2012-02-09 Andrea Cimitan - Removing glow, new assets. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Cimitan. + Removing glow, new assets. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-02-09 Andrea Cimitan @@ -10957,7 +11483,7 @@ 2012-02-08 Tim Penhey - Fix some leaking textures.. Fixes: . Approved by Marco Trevisan (Treviño). + Fix some leaking textures.. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-02-09 Tim Penhey @@ -11445,7 +11971,7 @@ 2012-02-07 Andrea Cimitan - Fixes a couple of pixel misalignments, and enlarge menuitem separators by 2px. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Cimitan. + Fixes a couple of pixel misalignments, and enlarge menuitem separators by 2px. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-02-07 Andrea Cimitan @@ -11463,7 +11989,7 @@ For the designers: I'm just applying a white (0.50 alpha) overlay to the focused segment... If you find other visual bugs in the mulirange filter widget please don't report them here :) Open a new bug, etc. etc. - P.S. You cannot test it, because the filter key navigation doesn't work in trunk.. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Cimitan. + P.S. You cannot test it, because the filter key navigation doesn't work in trunk.. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-02-07 Andrea Azzarone @@ -11481,23 +12007,23 @@ Implement multirange filter focus state. -2012-02-07 Mirco Müller +2012-02-07 Mirco M?ller The updated Unity-part of fixing LP: #810325. This makes sure the average color - computed after a change of wallpaper - is exposed via Unity's GSettings schema. That in turn can get picked up by other applications... notify-osd in this case.. Fixes: https://bugs.launchpad.net/bugs/810325. Approved by Gord Allott. -2012-02-07 Mirco Müller +2012-02-07 Mirco M?ller doh -2012-02-07 Mirco Müller +2012-02-07 Mirco M?ller Gord gets no beer from me :) -2012-02-07 Mirco Müller +2012-02-07 Mirco M?ller Use client member-variable, be more C++-ish -2012-02-07 Mirco Müller +2012-02-07 Mirco M?ller Make fix for LP: #810325 work again with latest trunk @@ -11509,41 +12035,41 @@ new default on design request: launcher never hides (LP: #928153) -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Some updates to tooltips and quicklist... New visuals, positioning (Cimi, already signed-off by design), padding, some code refactoring by Marco including a standalone test program and fixes to StaticCairoText that now can use a pango_layout with a size different of the text extents (this allows to both draw cut text and to position it as requested). Also added CairoBaseWindow class that is used by both tooltip and quicklists to draw their cairo items avoiding code duplication.. Fixes: . Approved by Andrea Azzarone, Andrea Cimitan. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Quicklist: adding quicklists to unity namespace Plus fix tests build issues. -2012-02-07 Marco Trevisan (Treviño) +2012-02-07 Marco Trevisan (Trevi?o) Merging with upstream -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) CairoBaseWindow: added a virtual destructor. -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) Tooltip: use const& to get geometry. -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) QuicklistView: some more cleanup, removing unneeded pointers -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) CairoBaseWindow: use post-fixed member variables. Updating the depending code. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) CairoBaseWindow: added new class to create a nux base window with cairo elements @@ -11551,58 +12077,58 @@ Code merged from lp:~3v1n0/unity/cairo-base-window -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) CairoBaseWindow: make sure that we clear the background when drawing. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) LauncherIcon: move the quicklist 1px to the left -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) Tooltip, Quicklist: use the CairoBaseWindow as parent, so we can factorize lot of drawing code -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) CairoBaseWindow: added new class to create nux base windows with cairo elements -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) LauncherIcon: again, move the quicklist 1 px more to the left -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) LauncherIcon: move also the quicklist on to the left -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) LauncherIcon: move the tooltip position one more pixel left. As requested by Cimi, it's mostly need the after the merge with this branch: lp:~unity-team/unity/launcher-design-fixes -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) StaticCairoText, Tooltip: using const& parameters... -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip: even more cleanup, and move to new nux layout values -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) QuicklistMenuItem: use const& to pass colors -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) LauncherIcon: remove unneeded members, and use ObjectPtr to handle tooltip and quicklist -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip, removing comments -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) QuicklistView: setting a minimum width for the item vertical layout. @@ -11610,7 +12136,7 @@ Revert previous commit -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Launcher: Set launcher right-line transparency at 0.15% @@ -11618,61 +12144,61 @@ Shifted tooltips and quicklist position, set minimum dimension to 100px -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Uncommit some unwanted changes... -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip fixed comments. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip: always use nux::ObjectPtr when possible. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip: no need to use the nux namespace, plus more cleanup. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip: consider the padding when checking the minimum width. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip: Moved into the unity namespace, and using a Text padding and a fixed minimum width Plus some code cleanup. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) standalone-clients, added the TestTooltip code! It allows to easily check how an unity tooltip is drawn -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) StaticCairoText: update the cached texture if the base geometry has changed This makes sure that the cairo text is redrawn when the Base size has changed, and the pango layout is updated against the new values. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) StaticCairoText: make the pango_layout to use all the available space when requested Updating the pango layout size using the requested size. Now, the alignment values are properly used. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Tooltip: added standalone client. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) Tooltip: Blur the tooltip background. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) QuicklistMenuItem*: add a shared function to Draw the Prelight that applies a blurred glow @@ -11685,7 +12211,7 @@ Patch imported from lp:~3v1n0/unity/quicklist-item-glow-selection r:1803 -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) Merged with lp:~3v1n0/unity/fixed-bad-quicklist-items-drawing @@ -11720,7 +12246,7 @@ Mockup - https://chinstrap.canonical.com/~sabdfl/12_04/desktop_and_netbook/dash/video_lens_v1.2_2.png Branch - http://ubuntuone.com/4CwCQGcAuejfjQAY4Ky7Ry - http://ubuntuone.com/3vHehMXz1KoBWKQ2uugZzL. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Cimitan. + http://ubuntuone.com/3vHehMXz1KoBWKQ2uugZzL. Fixes: . Approved by Marco Trevisan (Trevi?o), Andrea Cimitan. 2012-02-07 Andrea Azzarone @@ -11736,7 +12262,7 @@ 2012-02-07 Andrea Azzarone - . Fixes: . Approved by Sam Spilsbury, Marco Trevisan (Treviño). + . Fixes: . Approved by Sam Spilsbury, Marco Trevisan (Trevi?o). 2012-02-02 Andrea Azzarone @@ -12061,7 +12587,7 @@ unity introspection tree debugging script now can write output to any format supported by dot, and has the option to display the image with the 'eog' app. -2012-02-06 Marco Trevisan (Treviño) +2012-02-06 Marco Trevisan (Trevi?o) Fixed the drawing of the radios or checkmarks quicklist menu items @@ -12076,81 +12602,81 @@ I've not added a manual test since for the graphic nature of the issue, I guess it's hard to automatically test it (and autopilot doesn't help at all, clearly). So, let me know if this is ok.. Fixes: https://bugs.launchpad.net/bugs/910286. Approved by Andrea Azzarone. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) TestQuicklistVisuals: fix compilation issues -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) Merging with upstream -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) Fixed the compilation of /some/ other standalone clients. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) TestQuicklist: rewritten using the nux test framework to check the events. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) Including the nux test framework into the standalone-clients. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) tests, TestQuicklistMenuitems: added check for GetChildren() -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) QuicklistView: GetChildren should return the list of children. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) Merging with upstream. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklist: readded the item-activated tests -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklist: fixed a typo. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklist: added more visual tests for all the quicklist possible cases -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklistVisuals: the application name now should be bold. Updating the visual test. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklistVisuals: allow to create disabled label items, and use it -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklistVisuals: the checked/unchecked status shouldn't be inverted. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) TestQuicklist: fix the test using the expected checked/unchecked state -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) StandaloneClients: use aubergine background color for quicklist tests. It makes them a little bit more real ;) -2011-12-31 Marco Trevisan (Treviño) +2011-12-31 Marco Trevisan (Trevi?o) QuicklistMenuItemRadio: fix the rendering of the active/unactive and disabled states Fixing bug #910286 caused the menuitem to be drawn incorrectly -2011-12-31 Marco Trevisan (Treviño) +2011-12-31 Marco Trevisan (Trevi?o) QuicklistMenuItemCheckmark: fix the rendering of the active/unactive and disabled states @@ -12550,7 +13076,7 @@ 2012-02-05 Andrea Cimitan - New visual assets for dash buttons. Fixes: . Approved by Marco Trevisan (Treviño). + New visual assets for dash buttons. Fixes: . Approved by Marco Trevisan (Trevi?o). 2012-01-30 Andrea Cimitan @@ -12560,7 +13086,7 @@ Adding a simple comment for translators to disambiguate the meaning of the 'Format...' message. This comment will be automatically extracted by the build system, put into the translation template (.pot file) and be visible to translators in Launchpad, providing them more context (bug 926339). - I would suggest following this practice for any translatable string that might be prone to confusion, or if anything needs clarifying to translators. It's just a matter of adding a comment above the line where the translatable string appears - the gettext machinery takes care of all the rest.. Fixes: https://bugs.launchpad.net/bugs/926339. Approved by Marco Trevisan (Treviño), Marco Biscaro. + I would suggest following this practice for any translatable string that might be prone to confusion, or if anything needs clarifying to translators. It's just a matter of adding a comment above the line where the translatable string appears - the gettext machinery takes care of all the rest.. Fixes: https://bugs.launchpad.net/bugs/926339. Approved by Marco Trevisan (Trevi?o), Marco Biscaro. 2012-02-04 David Planella @@ -12609,7 +13135,7 @@ Make AbstractIconRenderer inherit from IconTextureSource Make IconRenderer use IconTextureSource to limit coupling with Launcher types -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) As shown in the design mockups and as requested by Cimi, I've fixed some visual issues of the launcher and dash: @@ -12626,51 +13152,51 @@ Launcher right line opacity 0.15f -2012-02-04 Marco Trevisan (Treviño) +2012-02-04 Marco Trevisan (Trevi?o) unityshell: explain the -1 magic number. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) OverlayRenderer: Draw inner rounded corner only if needed. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) OverlayRenderer: use transparent color for our lines... -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) OverlayRenderer: some math cleanup... -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) OverlayRenderer: enable blending when drawing the top and right lines -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) OverlayRenderer: make the dash to use the top and right lines that matches the launcher Also, these lines are now drawn under the background, to get them properly masked. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) Launcher: make the right-line using a 22% opaque white. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) DashController / Unity: adjust the dash position using the launcher geometry. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Launcher: put the right-line to a position relative to the one of the launcher Fixes the "always-showing" line issue. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Launcher: be aware of the right-line and don't consider it as part of the launcher. -2012-02-02 Marco Trevisan (Treviño) +2012-02-02 Marco Trevisan (Trevi?o) Launcher: changing right-line color opacity @@ -12699,7 +13225,7 @@ * Fixing key nav -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) BamfLauncherIcon: a lot of code cleanup using more C++ friendly members to fix memory leaks and improve our work. @@ -12709,190 +13235,190 @@ Plus fixed the bug #921102 that was caused by the fact that the remote dbusmenu was unreferenced by the icon, and bug #925839 that was caused by the fact that after the multi-monitor branch, an icon was not redrawn on EnsureWindowState until there was a monitor / vp change, now we force the redraw.. Fixes: https://bugs.launchpad.net/bugs/921102, https://bugs.launchpad.net/bugs/925839. Approved by Jason Smith. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) MockLauncherIcon: make GetQuirk const to match the parent. Fixes tests -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) BamfLauncherIcon: always make the icon redraw when children are added, removed and so on!. -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) Merging with trunk changes. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) SoftwareCenterLauncherIcon: small cleanup... -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: remove some const methods to avoid weird results... -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't make ShowInSwitcher() const or it won't work! -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) SoftwareCenterLauncherIcon: more cleanup... -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) SoftwareCenterLauncherIcon: cleaning-up the whole patch... Using std::string and fixing indentation. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) Merging with upstream, optimize a little LauncherController -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: removing the last static method, adding OnDndHovered() that is called by timeout lambda. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) BamfLauncherIcon: GetQuirk dependent methods can be const now, making them constant! -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) LauncherIcon: making GetQuirk const -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: no need to duplicate the checks... -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't use C casts, check for type and use static_cast Fixes also a leak... Every click the children list were not free'd. -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: making DesktopFile to return a std::string. -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: Using std::string for _desktop_file, plus add more const members. -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: using glib:Object for _menu_clients too Also fixing bug #921102 -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: More glib::Object and glib::Error usage -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: FillSupportedTypes can be a member function, using a lambda to call it. -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: removing the evil ShortcutData struct, we can do the same without it. -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: use glib::Object instead of a pointer on ShortcutData, plus fix a memory leak. The desktop_shortcuts value was unreferenced too few times, so it wasn't ever destroyed. Using a glib::Object for it, fixes the issue. -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: Desktop shortcuts, using more C++ facilities -2012-01-24 Marco Trevisan (Treviño) +2012-01-24 Marco Trevisan (Trevi?o) BamfLauncherIcon: Use glib::String when getting the window name. -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: use a lambda function to free the temporary struct. -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: make ShortcutData a little more C++ friendly -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: no need to add a new ref, when saving the menuitems -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: use glib::Object to store local dbusmenuitems -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: using glib::Signal to handle the default quicklist item callbacks -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: use std::string to handle _remote_uri, it also fixes a leak. -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: add more getter functions and avoid to use too much bamf calls when we have cached values Plus more usage of glib::String -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: no need to cache the name as well... -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: putting the constructor at the top of the file, as expected. -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: no need to cache the desktop file, libbamf owns and caches it -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: use glib::Object and glib::Signal for handling the desktop file changes -2012-01-23 Marco Trevisan (Treviño) +2012-01-23 Marco Trevisan (Trevi?o) BamfLauncherIcon: moving to glib::SignalManager and using lamba function callbacks. -2012-01-22 Marco Trevisan (Treviño) +2012-01-22 Marco Trevisan (Trevi?o) BamfLauncherIcon: more cleanup, fixed a crash. -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) Use glib::Object for handling the menu desktop shortcuts -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncher: rerganizing the header file to improve readability. -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: stripping tralinig spaces -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: use glib::Object to handle _bamf_app -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: s/m_App/_bamf_app/g -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: use an initialization list -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: s/NULL/nullptr/g -2012-01-21 Marco Trevisan (Treviño) +2012-01-21 Marco Trevisan (Trevi?o) BamfLauncherIcon: removed unneeded member, update only the application whose window has been moved! @@ -12902,7 +13428,7 @@ Small spring cleaning of the ubus message UBUS_PLACE_VIEW_SHOWN/HIDDEN Replaces it with UBUS_OVERLAY_SHOWN/HIDDEN - also sends along a gvariant that ID's the overlay and sends whether it can - be maximised or not. Fixes: . Approved by Mirco Müller. + be maximised or not. Fixes: . Approved by Mirco M?ller. 2012-01-31 Gord Allott @@ -12920,15 +13446,15 @@ Renames PLACE_VIEW to OVERLAY, also includes a gvariant along with the ubus message -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) Fixed the wording the Launcher manual-test. Fixes: https://bugs.launchpad.net/bugs/923996. Approved by Thomi Richards. -2012-01-31 Marco Trevisan (Treviño) +2012-01-31 Marco Trevisan (Trevi?o) manual-test: fixed the Launcher manual test wording -2012-02-03 Marco Trevisan (Treviño) +2012-02-03 Marco Trevisan (Trevi?o) Due to wrong syntax in cmake pkgconfig settings unity configuration gave these warnings. @@ -12941,7 +13467,7 @@ Fixed removing the unwanted spaces. Fixes: https://bugs.launchpad.net/bugs/919248. Approved by Andrea Azzarone. -2012-02-01 Marco Trevisan (Treviño) +2012-02-01 Marco Trevisan (Trevi?o) CMake: pkg_config check needs doesn't support spaces between package and version. @@ -13073,7 +13599,7 @@ cap max velocity -2012-01-30 Marco Trevisan (Treviño) +2012-01-30 Marco Trevisan (Trevi?o) Making the panel service to attach its menus to a MenuBar to make the new lp:light-themes to correctly draw them. @@ -13081,25 +13607,25 @@ UNBLOCK. Fixes: . Approved by Andrea Cimitan. -2012-01-30 Marco Trevisan (Treviño) +2012-01-30 Marco Trevisan (Trevi?o) Added manual test. -2012-01-30 Marco Trevisan (Treviño) +2012-01-30 Marco Trevisan (Trevi?o) PanelService: go back to use gtk_window_set_attached_to -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) PanelService: we don't need anymore gtk+-3.0 3.3... -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) PanelService: Moving to gtk_menu_attach_to_widget It doesn't need to get the indicator toplevel window, and is here since long time -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) PanelService: add created menus to a menubar, to fix styling @@ -13167,7 +13693,7 @@ - Dash follows mouse - Keybindings follow mouse - Focus and raising windows is monitor aware - - Launchers are monitor and workspace aware. Fixes: . Approved by Thomi Richards, Marco Trevisan (Treviño). + - Launchers are monitor and workspace aware. Fixes: . Approved by Thomi Richards, Marco Trevisan (Trevi?o). 2012-01-29 Jason Smith @@ -13237,21 +13763,21 @@ prepare for doing some sort of progress indication -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) UnityScreen: reimplementing some lost features to disable the switcher on key / button press. And also to avoid to send the cancel event if not requested. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) Opps. damned bzr: removing duplicated values. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) Merging with upstream. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) Merging with jason changes @@ -13259,37 +13785,37 @@ merge trunk -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) LauncherController: don't show the shortcuts if the key_nav is active. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) Go back to use TYPE_BEGIN for the DesktopLauncherIcon or it will mess around with the switcher. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) AbstractLauncherIcon: reducing the priority of the desktop icon on switcher. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) UnityScreen: Don't show the switcher if the desktop icon is the only available. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) DesktopLauncherIcon: don't set as running. This fix the issue that was causing an arrow indicator to show next to it. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) SwitcherView: add monitor property and use it to get the number of windows indicators to draw -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't return window invisible windows on WindowsForMonitor -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) BamfLauncherIcon: WindowsForMonitor should take care of the viewport too. @@ -13475,39 +14001,39 @@ Fixed a bug that would cause unity to crash sometimes on exit due to Introspectable keeping stale pointers to parents. -2012-01-27 Marco Trevisan (Treviño) +2012-01-27 Marco Trevisan (Trevi?o) Improved the Super+Tab switcher making possible to escape from it using the Esc key and making the selection circular. This branch mostly fixes bug #919018 and bug #919019 as requested by design on recent updates of the main bug #891620. Fixes: https://bugs.launchpad.net/bugs/891620, https://bugs.launchpad.net/bugs/919018, https://bugs.launchpad.net/bugs/919019. Approved by Sam Spilsbury. -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) manual-tests, SuperTab: added more manual tests for circular switcher and escaping. -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) UnityScreen: ignore the Escape key when looking for shortcuts. This also avoids the shortcut-hint to be hidden when pressing Escape -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) UnityScreen: don't consider the Escape key as releasing the Super key -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) UnityScreen: add the EnableCancelAction utility function It allows to enable or disable the Escape action. -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) UnityScreen: Cancel the Launcher KeySwitcher on Escape and on ButtonPress Also now we actually use the terminate callback fuction. -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) Launcher: add KeySwitcherCancel function to terminate the switcher without effects @@ -13533,13 +14059,13 @@ 2012-01-27 Michal Hruby - Coalesce results coming from the background icon loader threads, so we don't update the UI after each icon loaded.. Fixes: . Approved by Mirco Müller. + Coalesce results coming from the background icon loader threads, so we don't update the UI after each icon loaded.. Fixes: . Approved by Mirco M?ller. 2012-01-26 Michal Hruby Coalesce results from the IconLoader, so we don't repaint the UI after each result -2012-01-26 Mirco Müller +2012-01-26 Mirco M?ller Remaining issues for LP: #863246 (and also LP: #863240) fixed. @@ -13553,65 +14079,65 @@ One glitch remaining is the separator-rendering being too thick/missing occasionally (on some systems). A solution for fixing this, is available. It's reverted in this branch, as some blending issues with this remain. But that can be added afterwards, to avoid all the other fixes being blocked on just that.. Fixes: https://bugs.launchpad.net/bugs/863246. Appoved by Andrea Azzarone, Andrea Cimitan. -2012-01-26 Mirco Müller +2012-01-26 Mirco M?ller Use unnamed namespace instead of static variable declaration -2012-01-26 Mirco Müller +2012-01-26 Mirco M?ller Tweak the outline-opacity as per request, make sure the top/bottom-padding for the ratings-widget is 12px also -2012-01-26 Mirco Müller +2012-01-26 Mirco M?ller Remove the layout debug-rects -2012-01-26 Mirco Müller +2012-01-26 Mirco M?ller Revert the separator-drawing to the Draw2DLine approach for now, make sure the filter-results text is the same size as the filter-genre caption-text -2012-01-25 Mirco Müller +2012-01-25 Mirco M?ller Don't forget about the removal of the separator when getting rid of a filter -2012-01-25 Mirco Müller +2012-01-25 Mirco M?ller Use a TextureArea as part of the filter-layout for drawing the separators between filter-categories -2012-01-23 Mirco Müller +2012-01-23 Mirco M?ller Replace text-based expander-arrow with correct image-file based artwork from Design, tweak outline highlight-opacity for selected buttons -2012-01-23 Mirco Müller +2012-01-23 Mirco M?ller Fix right edge alignment for all-, toggle- and multirange-buttons. -2012-01-23 Mirco Müller +2012-01-23 Mirco M?ller Padding gap between adjacent filter-categories is always 12px now thus complying with the Design -2012-01-23 Mirco Müller +2012-01-23 Mirco M?ller Fix vertical padding to be 12px between All-button and previous separator line -2012-01-23 Mirco Müller +2012-01-23 Mirco M?ller Fix vertical padding to be 12px between All-button and first button of filters -2012-01-23 Mirco Müller +2012-01-23 Mirco M?ller Fix position of filter-expander heading, solve issue with trailing separators in filters -2012-01-20 Mirco Müller +2012-01-20 Mirco M?ller fixed all-button size, disabled debug-rects for the moment -2012-01-19 Mirco Müller +2012-01-19 Mirco M?ller Add colored debug-rectangles, remove drawing of trailing separator lines 2012-01-26 Andrea Azzarone - Add FavoriteStore external change support.. Fixes: https://bugs.launchpad.net/bugs/681503. Appoved by Mirco Müller. + Add FavoriteStore external change support.. Fixes: https://bugs.launchpad.net/bugs/681503. Appoved by Mirco M?ller. 2012-01-26 Andrea Azzarone @@ -13661,46 +14187,46 @@ First step to fix bug #681503. -2012-01-26 Marco Trevisan (Treviño) +2012-01-26 Marco Trevisan (Trevi?o) Add support to middle-click pasting on the dash search bar. When the XA_PRIMARY clipboard has some content, that is pasted by middle click over the dash search bar. This is for consistency with the rest of the system. - I've also added the proper glib::Object support to the class.. Fixes: https://bugs.launchpad.net/bugs/842462. Appoved by Mirco Müller, Andrea Azzarone. + I've also added the proper glib::Object support to the class.. Fixes: https://bugs.launchpad.net/bugs/842462. Appoved by Mirco M?ller, Andrea Azzarone. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) IMTextEntry: always use glib:: namespace for casting To improve read-ability. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) IMTextEntry: some more code cleanup. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) No need to initialize empty glib::Object. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) IMTextEntry IM shouldn't be enabled to allow paste-by-middle-click. -2012-01-03 Marco Trevisan (Treviño) +2012-01-03 Marco Trevisan (Trevi?o) Dash: added middle-click manual test. -2012-01-03 Marco Trevisan (Treviño) +2012-01-03 Marco Trevisan (Trevi?o) IMTextEntry: don't crash when there's no text to paste. -2012-01-03 Marco Trevisan (Treviño) +2012-01-03 Marco Trevisan (Trevi?o) IMTextEntry: moving to glib::Object -2012-01-03 Marco Trevisan (Treviño) +2012-01-03 Marco Trevisan (Trevi?o) IMTextEntry: add support for middle-click over the dash search bar to paste content. @@ -13709,7 +14235,7 @@ 2012-01-26 Andrea Azzarone - Window auto-maximise functionality should be disabled on monitors with a resolution above 1024 x 600.. Fixes: https://bugs.launchpad.net/bugs/797808. Appoved by Mirco Müller, Marco Biscaro. + Window auto-maximise functionality should be disabled on monitors with a resolution above 1024 x 600.. Fixes: https://bugs.launchpad.net/bugs/797808. Appoved by Mirco M?ller, Marco Biscaro. 2012-01-18 Andrea Azzarone @@ -14002,11 +14528,11 @@ I'm wondering if we should avoid the same also when pressing over the workspace switcher.. Fixes: https://bugs.launchpad.net/bugs/918453. Appoved by Andrea Azzarone, Tim Penhey. -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) UnityScreen: use ubus_manager_ also to send messages. -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) ShortcutController: always use UBusWrapper (also for sending messages) @@ -14215,7 +14741,7 @@ 2012-01-25 Tim Penhey - Don't assign null to a std::string. Fixes: https://bugs.launchpad.net/bugs/865840. Appoved by Marco Trevisan (Treviño), Sam Spilsbury. + Don't assign null to a std::string. Fixes: https://bugs.launchpad.net/bugs/865840. Appoved by Marco Trevisan (Trevi?o), Sam Spilsbury. 2012-01-24 Tim Penhey @@ -14374,7 +14900,7 @@ * Trigger Unity build -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) Make the launcher be aware of the window's workspace @@ -14384,41 +14910,41 @@ Manual tests included.. Fixes: https://bugs.launchpad.net/bugs/689733, https://bugs.launchpad.net/bugs/690143. Appoved by . -2012-01-20 Marco Trevisan (Treviño) +2012-01-20 Marco Trevisan (Trevi?o) manual-tests: Launcher, removing old test. -2012-01-19 Marco Trevisan (Treviño) +2012-01-19 Marco Trevisan (Trevi?o) Merging again with trunk -2012-01-15 Marco Trevisan (Treviño) +2012-01-15 Marco Trevisan (Trevi?o) Merging with upstream -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) manual-tests: added a test for spread windows in current workspace -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) manual-tests: added test for launcher icon. -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) PluginAdapter: some code cleanup Avoid extra computation of the VP, we already checked for that. -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) BamfLauncherIcon: spread only windows available on the current workspace. -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) Merging with upstream -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) BamfLauncherIcon: show only windows on current workspace on the launcher pips @@ -14515,7 +15041,7 @@ 2012-01-19 Gord Allott - Adds alignment options in to DashStyle, only enabled for DashStyle::Button right now. Fixes: . Appoved by Mirco Müller. + Adds alignment options in to DashStyle, only enabled for DashStyle::Button right now. Fixes: . Appoved by Mirco M?ller. 2012-01-19 Gord Allott @@ -14528,18 +15054,18 @@ 2012-01-19 Daniel van Vugt Log messages from unity should say "unity", not "glib" which is totally misleading (LP: #908004) - . Fixes: https://bugs.launchpad.net/bugs/908004. Appoved by Marco Trevisan (Treviño). + . Fixes: https://bugs.launchpad.net/bugs/908004. Appoved by Marco Trevisan (Trevi?o). 2011-12-23 Daniel van Vugt Log messages from unity should say "unity", not "glib" which is totally misleading (LP: #908004) -2012-01-19 Thomas Voß +2012-01-19 Thomas Vo? Fixes a dependency issue for unity-mt-grab-handles. Fixes: . Appoved by . -2012-01-19 Thomas Voß +2012-01-19 Thomas Vo? Fixed dependency issue on nux-1 instead of nux-2. @@ -14582,17 +15108,17 @@ Convert the launcher ubus work over to ubus manager and add the LOCK_HIDE quirk -2012-01-18 Mirco Müller +2012-01-18 Mirco M?ller Fourth of fifth time I fix my stuff after the stuff in trunk changed below my feet after it was approved... having a fun wasting time :/ "The actual unity-part of the fix for LP: #841902. It needs lp:~macslow/libunity/libunity.fix-841902 and lp:~macslow/unity-lens-music/unity-lens-music.fix-841902 to be merged first.". Fixes: . Appoved by Michal Hruby. -2012-01-18 Mirco Müller +2012-01-18 Mirco M?ller Oops -2012-01-18 Mirco Müller +2012-01-18 Mirco M?ller Fixing the the unity-part of my patch for LP: #841902 for the fourth of fifth time... after it got approved everytime before... seriously WTF @@ -14612,33 +15138,33 @@ Added unity::glib::Variant wrapper -2012-01-17 Mirco Müller +2012-01-17 Mirco M?ller Fixes the position, alignment, spacing and arrow-artwork for the "Filter results". See... http://people.canonical.com/~mmueller/fix-863240.png. Fixes: https://bugs.launchpad.net/bugs/863240. Appoved by Gord Allott. -2012-01-17 Mirco Müller +2012-01-17 Mirco M?ller Correct right gap between expander-arrow and inner Dash edge to be 14 px -2012-01-11 Mirco Müller +2012-01-11 Mirco M?ller Fix vertical expander-arrow position with an insane nux-layout setup -2012-01-11 Mirco Müller +2012-01-11 Mirco M?ller Make Filter-text follow right edge when dash is expanded to fullscreen -2012-01-11 Mirco Müller +2012-01-11 Mirco M?ller Add callback to expander-arrow, fix initial display of just the expander-arrow -2012-01-11 Mirco Müller +2012-01-11 Mirco M?ller Disabled colored debug-rectangles, make it flush to the right -2012-01-11 Mirco Müller +2012-01-11 Mirco M?ller First set of fixes for patching LP: #863240 @@ -14680,7 +15206,7 @@ 2012-01-17 Michal Hruby - Dispatch search to lenses faster and add a timeout for animating the spinner (otherwise it would just flicker now).. Fixes: . Appoved by Mikkel Kamstrup Erlandsen, Mirco Müller. + Dispatch search to lenses faster and add a timeout for animating the spinner (otherwise it would just flicker now).. Fixes: . Appoved by Mikkel Kamstrup Erlandsen, Mirco M?ller. 2012-01-16 Michal Hruby @@ -14731,41 +15257,41 @@ Merging with upstream. -2012-01-13 Marco Trevisan (Treviño) +2012-01-13 Marco Trevisan (Trevi?o) Super+Tab manual-test: fixed a typo. -2012-01-13 Marco Trevisan (Treviño) +2012-01-13 Marco Trevisan (Trevi?o) Updated the manual test -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) manual-tests: Added test for Super-Tab switcher -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) UnityAccesibile: register interest for launcher on key-switcher. -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) Launcher: added UBUS support for KeySwitcher. -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) Launcher: add SelectPreviousIcon() and SelectNextIcon() to factorize code This code can be shared both by the key navigation and by the Super+Tab -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) unityshell: launcher swticher code cleanup. -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) SuperTab, rename it to Launcher Key Switcher, as the keybinding can change -2012-01-07 Marco Trevisan (Treviño) +2012-01-07 Marco Trevisan (Trevi?o) unityshell, Launcher: add first support for Super+Tab launcher switcher @@ -14784,7 +15310,7 @@ Visual diff: http://ubuntuone.com/014zDKCoxaQYmtm8mS5pp8 - Keep in mind that something is different because the shortcuts values are not hardcoded.. Fixes: https://bugs.launchpad.net/bugs/855532. Appoved by Marco Trevisan (Treviño), John Lea, Tim Penhey. + Keep in mind that something is different because the shortcuts values are not hardcoded.. Fixes: https://bugs.launchpad.net/bugs/855532. Appoved by Marco Trevisan (Trevi?o), John Lea, Tim Penhey. 2012-01-13 Andrea Azzarone @@ -14914,7 +15440,7 @@ First draft of a shortcuts hint overlay... -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller Since the bug LP: #863246 states so many issues, I'm splitting up the work into a series of branches/fixes. This first part corrects pixel-grid alignment of selected/unselected button-outlines, opacity-values (outline, filling) and vertical and horizontal spacing between buttons. @@ -14924,31 +15450,31 @@ http://people.canonical.com/~mmueller/fix-863246-part-4.png http://people.canonical.com/~mmueller/fix-863246-part-5.ogv. Fixes: https://bugs.launchpad.net/bugs/863246. Appoved by Andrea Azzarone. -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller - Jenkins reported conflicts... merged with branch again and solved conflicts... *sigh³* + Jenkins reported conflicts... merged with branch again and solved conflicts... *sigh?* -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller Fixed the vertical and horizontal spacing between buttons to comply with the design -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller Fix pixel-grid alignment of curved parts of the multi-range widgets outline -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller more value tweaking of opacities to fit the design -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller Fix pixel-grid alignment of selected/unselected button-outline, corrected outline color-opacity according to design -2012-01-12 Mirco Müller +2012-01-12 Mirco M?ller Align outline of selected multirange-widget elements to pixel-grid -2012-01-12 Mirco Müller +2012-01-12 Mirco M?ller Fixed the pixel-grid alignment of the outline of the unselected multirange-widget/buttons @@ -15033,7 +15559,7 @@ plugins/unityshell/src/FilterBasicButton.cpp plugins/unityshell/src/FilterBasicButton.h -2012-01-13 Marco Trevisan (Treviño) +2012-01-13 Marco Trevisan (Trevi?o) Making unity be aware of user-invisible windows, and manage them correctly. @@ -15044,13 +15570,13 @@ Read more cases in the provided manual-tests. - This branch also fixes the management of the urgent windows, that with some latest commits were not managed anymore as they should (now they get again priority when the parent application is focused).. Fixes: https://bugs.launchpad.net/bugs/784804. Appoved by Mirco Müller. + This branch also fixes the management of the urgent windows, that with some latest commits were not managed anymore as they should (now they get again priority when the parent application is focused).. Fixes: https://bugs.launchpad.net/bugs/784804. Appoved by Mirco M?ller. -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) manual-tests: added test for UserInvisibleWindows -2012-01-06 Marco Trevisan (Treviño) +2012-01-06 Marco Trevisan (Trevi?o) BamfLauncherIcon: manage user-invisible windows @@ -15066,66 +15592,66 @@ When an application with user-invisible windows is closed, we show it on the launcher only if that is pinned. -2012-01-13 Marco Trevisan (Treviño) +2012-01-13 Marco Trevisan (Trevi?o) Update the top panel title with the current alt+tab focused application title. - Fixed bug #855516, using ubus messages to make the switcher notify of events.. Fixes: https://bugs.launchpad.net/bugs/855516, https://bugs.launchpad.net/bugs/913889. Appoved by Mirco Müller. + Fixed bug #855516, using ubus messages to make the switcher notify of events.. Fixes: https://bugs.launchpad.net/bugs/855516, https://bugs.launchpad.net/bugs/913889. Appoved by Mirco M?ller. -2012-01-12 Marco Trevisan (Treviño) +2012-01-12 Marco Trevisan (Trevi?o) PanelMenuView: added the "paranoia"-checks ;) -2012-01-10 Marco Trevisan (Treviño) +2012-01-10 Marco Trevisan (Trevi?o) manual-test: added Panel manual test for Alt+Tab interaction -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: set the show-now delay to the previous value. -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: set show_now as disactive when showing the switcher. -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: reduce the risk of not hiding the menus. -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: update the mouse position when the switcher has been hidden Since the switcher grabs the pointer, we need to update the mouse position to check if the the pointer is over the panel or not. -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: Never shows menus or window buttons when the switcher is showing -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: use a vector instead of signal guint values to save ubus interests -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) PanelMenuView: be aware of the switcher status and update the title on switcher changes This fixes bug #855516, making the Alt+Tab switcher to update the unity panel title. -2012-01-08 Marco Trevisan (Treviño) +2012-01-08 Marco Trevisan (Trevi?o) SwitcherController: send new UBusMessages when switcher changes visibility or selection So clients can easily get what's happening on the switcher without using class signals. -2012-01-13 Mirco Müller +2012-01-13 Mirco M?ller Changed rendering of filling of Dash's search-bar according to design-suggestion... http://people.canonical.com/~mmueller/fix-913717.png. Fixes: https://bugs.launchpad.net/bugs/913717. Appoved by John Lea, Andrea Cimitan, Andrea Azzarone. -2012-01-12 Mirco Müller +2012-01-12 Mirco M?ller Fix color/opacity of Dash's search-bar filling. Fix LP: #913717 @@ -15133,13 +15659,13 @@ Release\ 5.0.0 -2012-01-11 Marco Trevisan (Treviño) +2012-01-11 Marco Trevisan (Trevi?o) Fixed bug #914251, local variables should be passed by value. UNBLOCK. Fixes: https://bugs.launchpad.net/bugs/914251. Appoved by Andrea Azzarone. -2012-01-11 Marco Trevisan (Treviño) +2012-01-11 Marco Trevisan (Trevi?o) LauncherIcon: pass quicklist positions by value on expo-terminated lambda. @@ -15164,7 +15690,7 @@ 2012-01-09 Michal Hruby Add --debug option to unity wrapper script, which will start compiz in gdb and print the backtrace if it crashes. - panel-service now also checks SILENT_PANEL_SERVICE environment variable and discard all debug messages if set.. Fixes: . Appoved by Mirco Müller. + panel-service now also checks SILENT_PANEL_SERVICE environment variable and discard all debug messages if set.. Fixes: . Appoved by Mirco M?ller. 2011-12-20 Michal Hruby @@ -15176,7 +15702,7 @@ 2012-01-09 Gord Allott - removes g_thread_init from the unity codebase. Fixes: . Appoved by Mirco Müller. + removes g_thread_init from the unity codebase. Fixes: . Appoved by Mirco M?ller. 2012-01-09 Gord Allott @@ -15228,7 +15754,7 @@ 2012-01-07 Andrea Azzarone - Quit a running application on drag and drop on trash icon.. Fixes: https://bugs.launchpad.net/bugs/870143. Appoved by Marco Trevisan (Treviño). + Quit a running application on drag and drop on trash icon.. Fixes: https://bugs.launchpad.net/bugs/870143. Appoved by Marco Trevisan (Trevi?o). 2012-01-07 Andrea Azzarone @@ -15248,7 +15774,7 @@ * Removed reference to NUX_STATE_META in unity-util-accessible.cpp. NUX_STATE_META wasn't generated by Nux. * Removed reference to e_length in unity-util-accessible.cpp. No longer generated in Nux. - Depend on this Nux branch: https://code.launchpad.net/~jaytaoko/nux/nux-renamed-event-members/+merge/87426. Fixes: . Appoved by Mirco Müller. + Depend on this Nux branch: https://code.launchpad.net/~jaytaoko/nux/nux-renamed-event-members/+merge/87426. Fixes: . Appoved by Mirco M?ller. 2012-01-03 Jay Taoko @@ -15413,7 +15939,7 @@ Read the manual test to learn how to test it. - It replaces https://code.launchpad.net/~andyrock/unity/dont-focus-me-on-mouse-down/+merge/86176 because it had some problems with gettext.. Fixes: https://bugs.launchpad.net/bugs/867548, https://bugs.launchpad.net/bugs/905921. Appoved by Mirco Müller. + It replaces https://code.launchpad.net/~andyrock/unity/dont-focus-me-on-mouse-down/+merge/86176 because it had some problems with gettext.. Fixes: https://bugs.launchpad.net/bugs/867548, https://bugs.launchpad.net/bugs/905921. Appoved by Mirco M?ller. 2012-01-02 Andrea Azzarone @@ -15447,11 +15973,11 @@ Doesn't give focus on mouse down to category headers, home dash tiles, and dash icons. Fixes bug #867548 too. -2012-01-05 Marco Trevisan (Treviño) +2012-01-05 Marco Trevisan (Trevi?o) - IconRenderer: make progress_y position relative to the fill_y, so they will be always close. Fixes: https://bugs.launchpad.net/bugs/911553. Appoved by Mirco Müller. + IconRenderer: make progress_y position relative to the fill_y, so they will be always close. Fixes: https://bugs.launchpad.net/bugs/911553. Appoved by Mirco M?ller. -2012-01-04 Marco Trevisan (Treviño) +2012-01-04 Marco Trevisan (Trevi?o) IconRenderer: make progress_y position relative to the fill_y, so they will be always joined @@ -15471,53 +15997,53 @@ 2012-01-03 Andrea Azzarone - Add a missing break.. Fixes: . Appoved by Marco Trevisan (Treviño). + Add a missing break.. Fixes: . Appoved by Marco Trevisan (Trevi?o). 2012-01-02 Andrea Azzarone Add a missing "break". -2012-01-03 Alejandro Piñeiro +2012-01-03 Alejandro Pi?eiro . Fixes: https://bugs.launchpad.net/bugs/856392. Appoved by Alex Launi. -2011-11-07 Alejandro Piñeiro +2011-11-07 Alejandro Pi?eiro a11y: Support for the switcher -2011-09-27 Alejandro Piñeiro +2011-09-27 Alejandro Pi?eiro a11y: Support for the switcher -2011-09-22 Alejandro Piñeiro +2011-09-22 Alejandro Pi?eiro a11y: cleaning g_debug -2011-09-22 Alejandro Piñeiro +2011-09-22 Alejandro Pi?eiro a11y: Support for the switcher -2012-01-03 Alejandro Piñeiro +2012-01-03 Alejandro Pi?eiro . Fixes: https://bugs.launchpad.net/bugs/842033. Appoved by Alex Launi. -2011-11-07 Alejandro Piñeiro +2011-11-07 Alejandro Pi?eiro a11y: Simplify basewindow:(activate/deactivate) emission -2011-09-27 Alejandro Piñeiro +2011-09-27 Alejandro Pi?eiro a11y: Simplify basewindow:(activate/deactivate) emission -2011-09-16 Alejandro Piñeiro +2011-09-16 Alejandro Pi?eiro a11y: missing one state-change notification on the quicklistview -2011-09-16 Alejandro Piñeiro +2011-09-16 Alejandro Pi?eiro a11y: moving to use AtkWindow interface -2011-09-16 Alejandro Piñeiro +2011-09-16 Alejandro Pi?eiro a11y: Simplify basewindow:(activate/deactivate) emission @@ -15563,7 +16089,7 @@ 2012-01-02 Sam Spilsbury - Adds test for animation code. Fixes: . Appoved by Thomas Voß. + Adds test for animation code. Fixes: . Appoved by Thomas Vo?. 2011-12-23 Sam Spilsbury @@ -15611,7 +16137,7 @@ 2012-01-02 Sam Spilsbury - Adds test for conditional show/hide. Fixes: . Appoved by Thomas Voß. + Adds test for conditional show/hide. Fixes: . Appoved by Thomas Vo?. 2011-12-23 Sam Spilsbury @@ -15647,7 +16173,7 @@ 2012-01-02 Sam Spilsbury - Added Google Test and Google Mocks for layout algorithm. Fixes: . Appoved by Thomas Voß. + Added Google Test and Google Mocks for layout algorithm. Fixes: . Appoved by Thomas Vo?. 2011-12-23 Sam Spilsbury @@ -15677,15 +16203,15 @@ Added Google Test and Google Mock tests for unity::MT::GrabHandle -2012-01-02 Alejandro Piñeiro +2012-01-02 Alejandro Pi?eiro . Fixes: https://bugs.launchpad.net/bugs/772573. Appoved by Alex Launi. -2011-11-07 Alejandro Piñeiro +2011-11-07 Alejandro Pi?eiro a11y: Implement AtkAction for LauncherIcon -2011-09-25 Alejandro Piñeiro +2011-09-25 Alejandro Pi?eiro a11y: Implement atkaction for LauncherIcon @@ -15703,7 +16229,7 @@ 2012-01-02 Jay Taoko - * Fix broken rendering and text search entry: After typing some characters in the search entry, interaction with the mouse produces incorrect rendering.. Fixes: . Appoved by Mirco Müller. + * Fix broken rendering and text search entry: After typing some characters in the search entry, interaction with the mouse produces incorrect rendering.. Fixes: . Appoved by Mirco M?ller. 2011-12-19 Jay Taoko @@ -15725,7 +16251,7 @@ This is a fix for https://bugs.launchpad.net/unity/+bug/873765 The problem was that when no RGBA antialiasing was set for "gtk-xft-rgba", unity shell assumed that no font antialiasing should be used at all, even if grayscale antialiasing is selected by user e.g. in gnome-tweak-tool. This resulted in non-antialiased text in unity panel, launcher and lenses even though text in windows is properly grayscale antialiased. - I added further check for "gtk-xft-antialias" value in case when "gtk-xft-rgba" is "none". If "gtk-xft-antialias" is true, then set antialiasing to CAIRO_ANTIALIAS_GRAY instead of CAIRO_ANTIALIAS_NONE.. Fixes: https://bugs.launchpad.net/bugs/873765. Appoved by Marco Trevisan (Treviño). + I added further check for "gtk-xft-antialias" value in case when "gtk-xft-rgba" is "none". If "gtk-xft-antialias" is true, then set antialiasing to CAIRO_ANTIALIAS_GRAY instead of CAIRO_ANTIALIAS_NONE.. Fixes: https://bugs.launchpad.net/bugs/873765. Appoved by Marco Trevisan (Trevi?o). 2011-12-09 Andrey Logvinov - Splits code into files. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Voß. + Splits code into files. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Vo?. 2011-12-23 Sam Spilsbury @@ -15785,7 +16311,7 @@ 2011-12-23 Sam Spilsbury - s/Unity/unity. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Voß. + s/Unity/unity. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Vo?. 2011-12-22 Sam Spilsbury @@ -15797,7 +16323,7 @@ 2011-12-23 Sam Spilsbury - Refactors the code to make it testable. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Voß. + Refactors the code to make it testable. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Vo?. 2011-12-22 Sam Spilsbury @@ -15838,7 +16364,7 @@ This merge propose comes from this one (https://code.launchpad.net/~andyrock/unity/fix-875467/+merge/79638). In that merge proposal I've created a mini (very very mini) icon loader implementation. Reading unity code I noticed that we already use two icon loader implementations (the dash icon loader and the launcher ones) so... - Because unity::IconLoader has already been tested and in a unit test we should not test an external module (osd notification library), i don't know if we need a unit test for this change. In the case let me know.. Fixes: https://bugs.launchpad.net/bugs/875467. Appoved by Tim Penhey, Marco Trevisan (Treviño). + Because unity::IconLoader has already been tested and in a unit test we should not test an external module (osd notification library), i don't know if we need a unit test for this change. In the case let me know.. Fixes: https://bugs.launchpad.net/bugs/875467. Appoved by Tim Penhey, Marco Trevisan (Trevi?o). 2011-12-16 Andrea Azzarone @@ -15927,36 +16453,36 @@ 2011-12-16 Daniel van Vugt - Fix uninitialized variable causing the dash search spinner to sometimes not spin (LP: #901610) (LP: #903090). Fixes: https://bugs.launchpad.net/bugs/901610, https://bugs.launchpad.net/bugs/903090. Appoved by Andrea Azzarone, Marco Trevisan (Treviño). + Fix uninitialized variable causing the dash search spinner to sometimes not spin (LP: #901610) (LP: #903090). Fixes: https://bugs.launchpad.net/bugs/901610, https://bugs.launchpad.net/bugs/903090. Appoved by Andrea Azzarone, Marco Trevisan (Trevi?o). 2011-12-08 Daniel van Vugt Fix uninitialized variable (LP: #901610) -2011-12-16 Mirco Müller +2011-12-16 Mirco M?ller http://people.canonical.com/~mmueller/when-we-say-precise-we-mean-it.ogv. Fixes: https://bugs.launchpad.net/bugs/838904. Appoved by Mikkel Kamstrup Erlandsen. -2011-12-16 Mirco Müller +2011-12-16 Mirco M?ller Don't draw text entered beyond the region of the search-bar -2011-12-16 Mirco Müller +2011-12-16 Mirco M?ller Finally search-bar is now exactly matching size and position of the mockup -2011-12-14 Mirco Müller +2011-12-14 Mirco M?ller merge with trunk -2011-12-14 Mirco Müller +2011-12-14 Mirco M?ller Adjust position, padding, width and height of Dash' search-bar to exactely match the mockups... second round of fixes for LP: #838904 2011-12-16 Daniel van Vugt Fix uninitialized variable read (LP: #901603) - . Fixes: https://bugs.launchpad.net/bugs/901603. Appoved by Marco Trevisan (Treviño). + . Fixes: https://bugs.launchpad.net/bugs/901603. Appoved by Marco Trevisan (Trevi?o). 2011-12-08 Daniel van Vugt @@ -15964,28 +16490,28 @@ 2011-12-16 Daniel van Vugt - Fix uninitialized variable read (LP: #901602). Fixes: https://bugs.launchpad.net/bugs/901602. Appoved by Marco Trevisan (Treviño). + Fix uninitialized variable read (LP: #901602). Fixes: https://bugs.launchpad.net/bugs/901602. Appoved by Marco Trevisan (Trevi?o). 2011-12-08 Daniel van Vugt Fix uninitialized variable read (LP: #901602) -2011-12-16 Marco Trevisan (Treviño) +2011-12-16 Marco Trevisan (Trevi?o) Use Nux InputArea mouse_double_click signal on PanelTitlebarGrabAreaView. Fixes: . Appoved by Tim Penhey, Andrea Azzarone. -2011-12-16 Marco Trevisan (Treviño) +2011-12-16 Marco Trevisan (Trevi?o) No commit message -2011-12-15 Marco Trevisan (Treviño) +2011-12-15 Marco Trevisan (Trevi?o) manual-tests: added manual test for Panel double-clicks. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: removed unneeded includes. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) PanelTitlebarGrabAreaView: removed the workaround code to emit a double-click signal @@ -16088,23 +16614,23 @@ Fixes LP #871801 and LP #899932 -2011-12-15 Mirco Müller +2011-12-15 Mirco M?ller The left-, right-, top- and bottom-padding has been changed to comply with the three-pixel-margin seen in the mockups. For the edge-case of one-item Quicklists (e.g. Launcher Trashcan) the padding is fixed now too. Also the opacity of the background-tint has been tweaked in dialog with Design. Fixes LP: #767063. Fixes: https://bugs.launchpad.net/bugs/767063. Appoved by Sam Spilsbury. -2011-12-13 Mirco Müller +2011-12-13 Mirco M?ller use self-explanatory variable-names instead of magic numbers -2011-12-12 Mirco Müller +2011-12-12 Mirco M?ller After much discussion and ping-ponging screenshots with Design (Rosie) this is the tint-opacity-value that should be used -2011-12-12 Mirco Müller +2011-12-12 Mirco M?ller Fix left-, right-, top- and bottom-padding in Quicklists... also for edge-case with one-item Quicklist (e.g. Trashcan-Quicklist) -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) glib::Object: review to support more operators and to improve operations @@ -16122,59 +16648,59 @@ Including tests.. Fixes: . Appoved by Tim Penhey. -2011-12-12 Marco Trevisan (Treviño) +2011-12-12 Marco Trevisan (Trevi?o) LauncherController: use glib::Object to handle BamfMatcher. -2011-12-11 Marco Trevisan (Treviño) +2011-12-11 Marco Trevisan (Trevi?o) Merging with lp:~3v1n0/unity/globalmenu-discovery-new-apps -2011-12-11 Marco Trevisan (Treviño) +2011-12-11 Marco Trevisan (Trevi?o) PanelMenuView: ref the temporary object that we had to the list. Otherwise on removal we'll get an extra-unref. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) tests, glib::Object added check for self assignment. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) glib::Object, fixed some bugs and tests improved. Thanks to the new Tim's review. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) tests: glib::Object, check for object destruction on swap test. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) tests: glib_object, using better object initializers. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) glib::Object: some code cleanup and improvements -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Merging with latest lp:~3v1n0/unity/globalmenu-discovery-new-apps -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) PanelMenuView: use glib::Object for managing BamfApplication list -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) glib::Object: removing the move constructor, as it should be too confusing. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) tests: added glib::Object tests -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) glib::Object: review to support more operators and to improve operations @@ -16188,7 +16714,7 @@ All these features allows, amongs the others, to add glib::Object's to standard containers such as lists and to lookup and remove items. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) Implemented the design bug #874254 to make a newly opened application to quickly show its menus when firstly mapped using a slightly longer fade effect (now set to 200ms to fade in and 300ms to fade out). To work properly, this feature, requires the merge of the BAMF branch lp:~3v1n0/bamf/always-notify-view otherwise sticky applications won't be show their menus when opened. @@ -16199,72 +16725,72 @@ Tests for this will be done when the autopilot system will be ready.. Fixes: https://bugs.launchpad.net/bugs/874254, https://bugs.launchpad.net/bugs/875472. Appoved by Tim Penhey. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) Merging with upstream, to resolve conflicts. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) manual-tests: Added test for Panel menus revelation. -2011-12-12 Marco Trevisan (Treviño) +2011-12-12 Marco Trevisan (Trevi?o) PanelMenuView: don't ref the BamfMatcher, libbamf does that already for us -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Merging with upstream. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) PanelMenuView: moving to glib::Signal to be more C++ friendly. All the g_signal_connect functions moved to glib::Signal's, it allows to get more clean code. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Animator: Using an initialization list. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Animator: coding style fixes -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Animator: make it non-copyable. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) tests: Add missing test_animator.cpp to test-gtest-xless -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Reverting temporary modification. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Merging with upstream -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) tests: Animator, use scope instead of dinamically allocated objects. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) Animator: emit Stop signal on object destruction. Update the test accordingly. -2011-12-02 Marco Trevisan (Treviño) +2011-12-02 Marco Trevisan (Trevi?o) Merging with upstream. -2011-12-02 Marco Trevisan (Treviño) +2011-12-02 Marco Trevisan (Trevi?o) tests: Animator, added simulation with duration = 0 -2011-12-02 Marco Trevisan (Treviño) +2011-12-02 Marco Trevisan (Trevi?o) test: Animator, added more Animation simulations @@ -16272,74 +16798,74 @@ Using the Utils::WaitUntil function -2011-12-02 Marco Trevisan (Treviño) +2011-12-02 Marco Trevisan (Trevi?o) Animator: Emit the startedd signal on animation start. That's why testing helps! :) -2011-12-02 Marco Trevisan (Treviño) +2011-12-02 Marco Trevisan (Trevi?o) tests: Moving WaitUntil and ScheduleTimeout to test_utils They can be useful for other tests too. -2011-12-01 Marco Trevisan (Treviño) +2011-12-01 Marco Trevisan (Trevi?o) Test: animator, simulate an animation step. -2011-12-01 Marco Trevisan (Treviño) +2011-12-01 Marco Trevisan (Trevi?o) Tests: Added a first basic test for Animator class. -2011-12-01 Marco Trevisan (Treviño) +2011-12-01 Marco Trevisan (Trevi?o) Animator: return the correct value of rate Thanks to tests! :) -2011-11-30 Marco Trevisan (Treviño) +2011-11-30 Marco Trevisan (Trevi?o) Animator: Add a public DoStep() method for unit testing purposes. -2011-11-30 Marco Trevisan (Treviño) +2011-11-30 Marco Trevisan (Trevi?o) Animator: using trailing underscore for class members -2011-11-30 Marco Trevisan (Treviño) +2011-11-30 Marco Trevisan (Trevi?o) Animator: Using const getters -2011-11-30 Marco Trevisan (Treviño) +2011-11-30 Marco Trevisan (Trevi?o) Animator: don't use #include Implicitly add the needed includes. -2011-11-30 Marco Trevisan (Treviño) +2011-11-30 Marco Trevisan (Trevi?o) Animator: Remove FadableObject2 class It was added for testing purposes, and committed by mistake. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Using CLAMP in gradient generation... -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: gradient, use a bigger color increment to reduce the visibility So the gap is less visible. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: remove the color gap between the maks and the title. The color gradient used to fade the title now updates its color to make the switch between the end of the title the start of the fade smoother. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: no need to redraw the begin of the title, the gradient can do that @@ -16348,24 +16874,24 @@ we only have to make sure that we're using a white mask on the first pixels. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Small cleanup -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Improved the fading between the buttons / menus for maximized windows Or for those with no menus. The rendering should be finally "precise" and pixel-perfect (I hope! :|). -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Cache the DrawMenus and DrawWindowButtons results This avoid to recompute the check too many times. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Never draw the window title when we have menus and we need to draw them @@ -16373,33 +16899,33 @@ to quickly show-up when clicking on the top-panel to focus the maximized window. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: use glib::Object where possible. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) Animator: be more explicit about the duration check... -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) Animator: Allow duration = 0, to disable the animation. This allows to use the animator also when the animations have been disabled. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: don't allow negative values in SetMenuShowTimings -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) UnityShell: correcly initialize the menu-fading options. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Always use nullptr -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) unityshell -> PanelMenuView: Make menu timings configurable. @@ -16407,7 +16933,7 @@ Fixes bug #875472 -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Use the new Animator Start to use different fade timings @@ -16417,14 +16943,14 @@ By the way we need a boolean variable to track when we need to fade-out slowly. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: some optimizations on the Draw function. Now when a window with menus is restored, the application title behind the buttons is correctly faded-in. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) Animator: Add temporary animation duration support. @@ -16432,7 +16958,7 @@ used only per that animation, once the animation has completed, just reset back to the default value. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelMenuView: Reduce the Fade-in/out timings for the menu discovery @@ -16441,24 +16967,24 @@ New values: fade-in 200ms, fade-out: 300ms -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) Animator: correctly return the real animation duration value. -2011-11-24 Marco Trevisan (Treviño) +2011-11-24 Marco Trevisan (Trevi?o) LauncherController: Check if the added bamf view is sticky. This check was previously included in libbamf itself, but we removed it to make it working better with PanelMenuView. -2011-11-24 Marco Trevisan (Treviño) +2011-11-24 Marco Trevisan (Trevi?o) PanelMenuView: OnNewViewOpened, don't check for user visibility. This could lead to some issues. BAMF should be fixed on this side. -2011-11-24 Marco Trevisan (Treviño) +2011-11-24 Marco Trevisan (Trevi?o) PanelMenuView: Add a small delay before showing menus on new applications. @@ -16469,17 +16995,17 @@ amount of time, keeping sure that a menu is not shown if the application has not been kept on focus for a minimum time. -2011-11-24 Marco Trevisan (Treviño) +2011-11-24 Marco Trevisan (Trevi?o) PanelMenuView: Tune some title opacity levels. -2011-11-24 Marco Trevisan (Treviño) +2011-11-24 Marco Trevisan (Trevi?o) PanelMenuView: Use the BAMF "active-application-changed" signal to check when draw menus This should save some CPU time. -2011-11-23 Marco Trevisan (Treviño) +2011-11-23 Marco Trevisan (Trevi?o) PanelMenuView: display the appmenu when an application has been firstly launched. @@ -16494,7 +17020,7 @@ This code doesn't support the favorite applications yet. -2011-12-14 Marco Trevisan (Treviño) +2011-12-14 Marco Trevisan (Trevi?o) In the current unity implementation when an indicator is opened, there's no way to send it scroll or middle-click events. @@ -16502,15 +17028,15 @@ Testing this with autopilot plus a fake indicator which reports events should be doable in the near future.. Fixes: https://bugs.launchpad.net/bugs/722082. Appoved by Tim Penhey. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Manual Tests: added manual test for sending events over the active indicators. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Merging with upstream -2011-11-16 Marco Trevisan (Treviño) +2011-11-16 Marco Trevisan (Trevi?o) PanelService: improved clicks handling when indicator menus are opened @@ -16527,7 +17053,7 @@ 2011-12-14 Andrea Azzarone - Removes shows-on-edge setting.. Fixes: https://bugs.launchpad.net/bugs/853086. Appoved by Tim Penhey, Marco Trevisan (Treviño). + Removes shows-on-edge setting.. Fixes: https://bugs.launchpad.net/bugs/853086. Appoved by Tim Penhey, Marco Trevisan (Trevi?o). 2011-12-12 Andrea Azzarone @@ -16762,7 +17288,7 @@ 2011-12-13 Andrea Azzarone - Uses a two state item (Lock to launcher/Unlock from launcher) instead of the current checkbox option.. Fixes: https://bugs.launchpad.net/bugs/874380. Appoved by Mirco Müller, Marco Trevisan (Treviño). + Uses a two state item (Lock to launcher/Unlock from launcher) instead of the current checkbox option.. Fixes: https://bugs.launchpad.net/bugs/874380. Appoved by Mirco M?ller, Marco Trevisan (Trevi?o). 2011-12-13 Andrea Azzarone @@ -16776,7 +17302,7 @@ Changes "Keep in launcher" checkbox item to "Lock to launcher"/"Unlock from launcher". -2011-12-12 Mirco Müller +2011-12-12 Mirco M?ller This fixes the alignment of the baseline of both text-labels (both on the same baseline now), uses updated/correct artwork-assets for the expander-arrows and corrects the spacing between icon, name, expander-label and expander-arrows. @@ -16785,71 +17311,71 @@ http://people.canonical.com/~mmueller/748101-before.png http://people.canonical.com/~mmueller/748101-after.png. Fixes: https://bugs.launchpad.net/bugs/748101. Appoved by Sam Spilsbury. -2011-12-12 Mirco Müller +2011-12-12 Mirco M?ller Removed the left-over debug-functions and some tweaks from another branch, which should not have been in here -2011-12-08 Mirco Müller +2011-12-08 Mirco M?ller yet more tweaks -2011-12-08 Mirco Müller +2011-12-08 Mirco M?ller new/updated artwork-asset added, more postition-tweaks -2011-12-07 Mirco Müller +2011-12-07 Mirco M?ller Screw the wrong icon-size for the expander... grrrr -2011-12-07 Mirco Müller +2011-12-07 Mirco M?ller Trying to figure out why layouts don't work as they should -2011-12-09 Marco Trevisan (Treviño) +2011-12-09 Marco Trevisan (Trevi?o) - QuicklistMenuItem code cleanup and support for markup text and bold application titles.. Fixes: https://bugs.launchpad.net/bugs/899677, https://bugs.launchpad.net/bugs/900400. Appoved by Mirco Müller, Tim Penhey. + QuicklistMenuItem code cleanup and support for markup text and bold application titles.. Fixes: https://bugs.launchpad.net/bugs/899677, https://bugs.launchpad.net/bugs/900400. Appoved by Mirco M?ller, Tim Penhey. -2011-12-09 Marco Trevisan (Treviño) +2011-12-09 Marco Trevisan (Trevi?o) Merging with upstream. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) BamfLauncherIcon: Let's move string printf to C++! :) -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) BFBLauncherIcon: don't use markup escape anymore. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) TestQuicklistMenuitems: added tests for the markup support. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) QuicklistMenuItem: Add Initialize function to avoid code duplication. -2011-12-07 Marco Trevisan (Treviño) +2011-12-07 Marco Trevisan (Trevi?o) QuicklistMenuItem: Ref/unref the dbus menuitem. -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) QuicklistMenuItem: Use the dbus-menuitem property to set the markup usage -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) QuicklistMenuItem*: removed some code duplication and better text initialization -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) BamfLauncherIcon s/false/FALSE/ -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't allow clients to use markup on quicklists. -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) BamfLauncherIcon and LauncherIcon: support markup when requested. @@ -16858,7 +17384,7 @@ This fixes bug #899677 -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) QuicklistMenuItem: factorize some initialization code and support text markup @@ -16866,7 +17392,7 @@ EnableLabelMarkup function. Pango Markup support is disabled by default for all the menu items. -2011-12-06 Marco Trevisan (Treviño) +2011-12-06 Marco Trevisan (Trevi?o) BamfLauncherIcon: Making the application title on the quicklist bold @@ -16874,7 +17400,7 @@ 2011-12-08 Daniel van Vugt - Fix SIGSEGV after SwitcherController desctruction (LP: #887465). Fixes: https://bugs.launchpad.net/bugs/887465. Appoved by Marco Trevisan (Treviño). + Fix SIGSEGV after SwitcherController desctruction (LP: #887465). Fixes: https://bugs.launchpad.net/bugs/887465. Appoved by Marco Trevisan (Trevi?o). 2011-12-08 Daniel van Vugt @@ -16884,7 +17410,7 @@ Fix SIGSEGV after SwitcherController desctruction (LP: #887465) -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Fixing bug #888650 and bug #890970 which caused the global menubar to not correctly react to mouse events when an indicator menu is open. @@ -16892,19 +17418,19 @@ Tests for this code will come as soon as possible (i.e when the autopilot will be completed).. Fixes: https://bugs.launchpad.net/bugs/888650, https://bugs.launchpad.net/bugs/890970. Appoved by Tim Penhey. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Manual Tests: added manual test for testing the PanelMenuView on mouse grabbed by indicators -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Merging with upstream. -2011-11-25 Marco Trevisan (Treviño) +2011-11-25 Marco Trevisan (Trevi?o) PanelView and PanelIndicatorsView: Using C++11 nullptr instead of NULL -2011-11-22 Marco Trevisan (Treviño) +2011-11-22 Marco Trevisan (Trevi?o) PanelMenuView: add SetMousePosition function to set mouse position when grabbed @@ -16916,43 +17442,43 @@ Fixes bug #888650 and bug #890970 -2011-11-22 Marco Trevisan (Treviño) +2011-11-22 Marco Trevisan (Trevi?o) PanelIndicatorsView: changed interface to activate entries. Renamed OnPointerMoved to ActivateEntryAt and make it and ActivateEntry to return the activated view. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) As requested on bug #807891 I've added an option to toggle the panel opacity if a window is currently maximized (and visible) in the current workspace. Test is missing, it will be added once the autopilot will be available.. Fixes: https://bugs.launchpad.net/bugs/807891. Appoved by Tim Penhey. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Manual Tests: added manual test for Panel Opacity Toggle. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Merging with upstream -2011-11-16 Marco Trevisan (Treviño) +2011-11-16 Marco Trevisan (Trevi?o) PanelView: get maximized window just once. -2011-11-16 Marco Trevisan (Treviño) +2011-11-16 Marco Trevisan (Trevi?o) Merging with upstream. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelView: avoid to connect to unneeded WindowManager signals Connect to the needed window manager signals only if the panel maximized opacity toggle option has been enabled. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelView: add maximized opacity toggle option @@ -16960,21 +17486,21 @@ unity to always draw an opaque panel when a maximized window is currently visible. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) Doing work to fix bug #791810 properly. When a quicklist is opened when the expo is currently running, we just wait it to be closed, before showing the quicklist itself.. Fixes: https://bugs.launchpad.net/bugs/791810. Appoved by Tim Penhey. -2011-12-08 Marco Trevisan (Treviño) +2011-12-08 Marco Trevisan (Trevi?o) LauncherIcon: don't use auto operator when the type is not explicit -2011-12-05 Marco Trevisan (Treviño) +2011-12-05 Marco Trevisan (Trevi?o) manual-tests: Added manual test for quicklists when on Expo. -2011-12-05 Marco Trevisan (Treviño) +2011-12-05 Marco Trevisan (Trevi?o) LauncherIcon: If expo is active, wait it to be terminated before showing a quicklist @@ -17044,7 +17570,7 @@ 2011-12-06 Andrea Azzarone - Display a list of the lenses in the bfb quicklist. It tries to fix bug #825037 too.. Fixes: https://bugs.launchpad.net/bugs/825037, https://bugs.launchpad.net/bugs/868452. Appoved by Mirco Müller, Marco Trevisan (Treviño). + Display a list of the lenses in the bfb quicklist. It tries to fix bug #825037 too.. Fixes: https://bugs.launchpad.net/bugs/825037, https://bugs.launchpad.net/bugs/868452. Appoved by Mirco M?ller, Marco Trevisan (Trevi?o). 2011-12-06 Andrea Azzarone @@ -17060,7 +17586,7 @@ 2011-12-05 Andrea Azzarone - Fixes: «Plus, if you open the dash, and you right-click on the BFB, all the quicklist items works, except the "Dash Home" item.» + Fixes: ?Plus, if you open the dash, and you right-click on the BFB, all the quicklist items works, except the "Dash Home" item.? 2011-12-05 Andrea Azzarone @@ -17090,7 +17616,7 @@ Bumps up the unity version to 5.0 and nux dep to 2.0 - also ignores a file in POTFILES and adds unity-core-5 dependecy checking to tests that were missing it as all this was required to get a clean build of 5.0. Fixes: . Appoved by Didier Roche, Marco Trevisan (Treviño), Jay Taoko, Tim Penhey. + also ignores a file in POTFILES and adds unity-core-5 dependecy checking to tests that were missing it as all this was required to get a clean build of 5.0. Fixes: . Appoved by Didier Roche, Marco Trevisan (Trevi?o), Jay Taoko, Tim Penhey. 2011-12-06 Gord Allott @@ -17229,23 +17755,23 @@ Bug #863246: Fix filter results label alignment and margins -2011-12-05 Marco Trevisan (Treviño) +2011-12-05 Marco Trevisan (Trevi?o) This is needed after the merge of lp:~ismise/unity/fix-864708 due that caused a bug similar to the bug #870844 that I previously fixed (before the merging of the previously mentioned branch) with the lp:~3v1n0/unity/fix-panel-dash-interactions branch. I'm proposing the fix against lp:unity, however maybe for consistency it should be backported to lp:unity/4.0 too.. Fixes: https://bugs.launchpad.net/bugs/873100. Reviewed by Tim Penhey. -2011-10-13 Marco Trevisan (Treviño) +2011-10-13 Marco Trevisan (Trevi?o) PanelMenuView: Don't raise the maximized window on panel click when the dash is open The panel shouldn't react either to clicks when the dash is open. -2011-12-05 Thomas Voß +2011-12-05 Thomas Vo? - Added an Eclipse CDT style setup to the tools-folder. Eases formatting code according to coding convention.. Fixes: . Reviewed by Marco Trevisan (Treviño). + Added an Eclipse CDT style setup to the tools-folder. Eases formatting code according to coding convention.. Fixes: . Reviewed by Marco Trevisan (Trevi?o). -2011-11-08 Thomas Voß +2011-11-08 Thomas Vo? ADDED: Eclipse style setup to support default C++ style guidelines. @@ -17316,7 +17842,7 @@ 2011-12-05 Jason Conti - The array indicator_order in services/panel-service.c has 2 columns but specifies 13 columns. It does have 13 rows though, which is probably where the current value originated.. Fixes: . Reviewed by Marco Trevisan (Treviño). + The array indicator_order in services/panel-service.c has 2 columns but specifies 13 columns. It does have 13 rows though, which is probably where the current value originated.. Fixes: . Reviewed by Marco Trevisan (Trevi?o). 2011-11-25 Jason Conti @@ -17332,7 +17858,7 @@ 2011-12-05 Andrea Azzarone - Add a ccsm option to display a "Show Desktop" icon in the launcher. . Fixes: https://bugs.launchpad.net/bugs/681348. Reviewed by Mirco Müller. + Add a ccsm option to display a "Show Desktop" icon in the launcher. . Fixes: https://bugs.launchpad.net/bugs/681348. Reviewed by Mirco M?ller. 2011-11-30 Andrea Azzarone @@ -17482,23 +18008,23 @@ merge a11y quicklis branch -2011-11-07 Alejandro Piñeiro +2011-11-07 Alejandro Pi?eiro a11y: implemented a11y support for quicklists -2011-09-27 Alejandro Piñeiro +2011-09-27 Alejandro Pi?eiro a11y: implemented a11y support for quicklists -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro a11y: implemented a11y support for quicklists -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro a11y: I forgot some commits -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro a11y: implemented a11y support for quicklists @@ -17506,7 +18032,7 @@ merge internal dash a11y branch -2011-11-07 Alejandro Piñeiro +2011-11-07 Alejandro Pi?eiro a11y: Implement a11y support for Dash internals @@ -17514,7 +18040,7 @@ * a11y objects for most parts of the Dash. * BaseWindow are added to the root window-list by the a11y code -2011-09-27 Alejandro Piñeiro +2011-09-27 Alejandro Pi?eiro a11y: Implement a11y support for Dash internals @@ -17522,7 +18048,7 @@ * a11y objects for most parts of the Dash. * BaseWindow are added to the root window-list by the a11y code -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro a11y: Implement a11y support for Dash internals @@ -17530,11 +18056,11 @@ * a11y objects for most parts of the Dash. * BaseWindow are added to the root window-list by the a11y code -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro Code style review -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro a11y: Implement a11y support for Dash internals @@ -17542,7 +18068,7 @@ * a11y objects for most parts of the Dash. * BaseWindow are added to the root window-list by the a11y code -2011-09-13 Alejandro Piñeiro +2011-09-13 Alejandro Pi?eiro a11y: BaseWindow are added to the root window-list by the a11y code @@ -17553,7 +18079,7 @@ This is also required after the change to make Dash creation under-demand -2011-09-12 Alejandro Piñeiro +2011-09-12 Alejandro Pi?eiro a11y: BaseWindow are added to the root window-list by the a11y code @@ -17564,71 +18090,71 @@ This is also required after the change to make Dash creation under-demand -2011-09-12 Alejandro Piñeiro +2011-09-12 Alejandro Pi?eiro a11y: Implementation of the a11y support for Dash internals -2011-09-06 Alejandro Piñeiro +2011-09-06 Alejandro Pi?eiro a11y: Implementation of the a11y support for Dash internals -2011-08-30 Alejandro Piñeiro +2011-08-30 Alejandro Pi?eiro a11y: Implementation of the a11y support for Dash internals -2011-08-30 Alejandro Piñeiro +2011-08-30 Alejandro Pi?eiro Polishing details -2011-08-30 Alejandro Piñeiro +2011-08-30 Alejandro Pi?eiro Added text entry -2011-08-30 Alejandro Piñeiro +2011-08-30 Alejandro Pi?eiro Setting the proper name and role on the search bar text entry -2011-08-29 Alejandro Piñeiro +2011-08-29 Alejandro Pi?eiro a11y: Dash a11y support -2011-08-29 Alejandro Piñeiro +2011-08-29 Alejandro Pi?eiro Rvgrid manages the selection -2011-08-29 Alejandro Piñeiro +2011-08-29 Alejandro Pi?eiro Adding UnityResultAccessible -2011-08-26 Alejandro Piñeiro +2011-08-26 Alejandro Pi?eiro Starting selection stuff -2011-08-26 Alejandro Piñeiro +2011-08-26 Alejandro Pi?eiro Using UBusManager to check some window activate/deactivate changes -2011-08-25 Alejandro Piñeiro +2011-08-25 Alejandro Pi?eiro Added SimpleTile and PlacesGroup -2011-08-25 Alejandro Piñeiro +2011-08-25 Alejandro Pi?eiro Merging -2011-08-25 Alejandro Piñeiro +2011-08-25 Alejandro Pi?eiro ResultViewGrid skeleton -2011-08-25 Alejandro Piñeiro +2011-08-25 Alejandro Pi?eiro Search bar back on the accessible factory -2011-08-25 Alejandro Piñeiro +2011-08-25 Alejandro Pi?eiro Getting UnitySearchBarAccessible back -2011-08-25 Alejandro Piñeiro +2011-08-25 Alejandro Pi?eiro Adding some debug messages, StaticCairoText and enabled Dash @@ -17672,11 +18198,11 @@ Merge stacking branch from 4.0 branch (manual merge) -2011-10-26 Mirco Müller +2011-10-26 Mirco M?ller Add an out-of-bounds check to the DetailXids vector. -2011-10-26 Mirco Müller +2011-10-26 Mirco M?ller Add an out-of-bounds check to the DetailXids vector. Fixes LP: #834630 @@ -17688,19 +18214,19 @@ Fix for lp:702989 -2011-10-26 Mirco Müller +2011-10-26 Mirco M?ller Be properly unref'ing _tray the FilterTrayCallback should be correctly unregistered and not called again. -2011-10-26 Mirco Müller +2011-10-26 Mirco M?ller Be properly unref'ing _tray the FilterTrayCallback should be correctly unregistered and not called again. Fixes LP: 832151 -2011-10-26 Mirco Müller +2011-10-26 Mirco M?ller _root_instance was never checked for NULL... not in unity and not in geis. Now it's at least checked in unity. -2011-10-25 Mirco Müller +2011-10-25 Mirco M?ller _root_instance was never checked for NULL... not in unity and not in geis. Now it's at least checked in unity... should fix LP: #850623 @@ -18153,11 +18679,11 @@ modified: UnityCore/MultiRangeFilter.cpp -2011-10-12 Jay Ó Broin +2011-10-12 Jay ? Broin Clicking blank space on top panel doesn't raise maximized window to front -2011-10-10 Jay Ó Broin +2011-10-10 Jay ? Broin Add handler to raise maximized window on left-click on panel (LP: #864708) @@ -18179,47 +18705,47 @@ Fixes LP#843958 -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) Bug #869196: unity panel menus don't stay open when clicked on second monitor with different geometry -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelService: Code spacing fix -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelService: entry2geometry_hash free the keys as well. -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelService: reset the use_event variable on menu-hidden This fixes the bug which caused the menus to re-close when opening one after that the previous one has been closed using the "ESC" button. -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelView: Sync geometries on panel window destruction This clears the indicators and menus entries geometries cached in unity panel service. -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelView: always sync geometries for indicators. Don't sync menus only if they aren't available in the current panel window for the given monitor. -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelView: When syncing geometries send a different panel name for each panel window Thanks to the new unity-panel-service code, this finally fixes bug #869196 for unity. -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelService: Order the entries geometry per-panel to fix multi-monitor issues @@ -18243,7 +18769,7 @@ Merge lp:~robertcarr/unity/filtertweaks -2011-10-10 Mirco Müller +2011-10-10 Mirco M?ller Bug #841750: Dash - horizental divider line in between categories incorrectly drawn @@ -18317,25 +18843,25 @@ showdesktop list, so disable focus handlers such that CompWindow::focus will return false -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) Bug #870844: Double-click on the dash top panel is taken effect on the window underneith -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelMenuView: don't react to middle-click when the dash is opened. -2011-10-11 Marco Trevisan (Treviño) +2011-10-11 Marco Trevisan (Trevi?o) PanelMenuView: don't react to double-click when the dash is opened. Fixes bug #870844 -2011-10-10 Mirco Müller +2011-10-10 Mirco M?ller Bug #841750: Dash - horizental divider line in between categories incorrectly drawn -2011-10-10 Mirco Müller +2011-10-10 Mirco M?ller Fixed additional issues (opacity, margin) added to LP: #841750 @@ -18359,7 +18885,7 @@ Bug #839480: Dash - When the Dash is open and there is a maximised app in the background, the top bar background should not disappear -2011-10-07 Mirco Müller +2011-10-07 Mirco M?ller Don't replace top-bar when dash is opened and there's a maximized window. Fix LP: #839480 @@ -18455,15 +18981,15 @@ Fix: bug #868293 Fix: bug #869028 -2011-10-06 Alejandro Piñeiro +2011-10-06 Alejandro Pi?eiro Fix bug 843280 -2011-10-05 Alejandro Piñeiro +2011-10-05 Alejandro Pi?eiro Avoid a shadowed variable -2011-10-05 Alejandro Piñeiro +2011-10-05 Alejandro Pi?eiro a11y: Solves bug 843280 @@ -18675,19 +19201,19 @@ NULL check windows the layout system gives us -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Fix rendernig of the scrollbar in the scrolled views of the Dash, LP: #836656 -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Fix the rendering as much as possible in the remaining 15 minutes -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Don't make it crash -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Trying to fight g++... ehm... fix #836656 @@ -18727,15 +19253,15 @@ removes unneeded variables -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Fixed LP: #851359 -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Revert the pixel-grid alignment for the multi-range widget for the moment -2011-09-29 Mirco Müller +2011-09-29 Mirco M?ller Add dynamic left/right padding to text-drawing, use pango-markups small-tag to help fix LP: #851359 @@ -18809,17 +19335,17 @@ Super+number shortcuts should work with numpad. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) This is based on the design bug #690143 and bug #688117. Basically when we click on a launcher icon that controls windows that are all in different workspaces, we need to check where is the first valid window (not minimized, if any is not minimized) and then activate that window and all the other windows of the same application that are in the same viewport. This patch fix this issue and should also fix bug #838766. Al this is based on my old branch lp:~3v1n0/unity/fix-688117 -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) BamfLauncherIcon: don't mix urgent and non-urgent windows. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) PluginAdapter: correctly map the windows in other viewports @@ -18827,7 +19353,7 @@ window in a different viewport, we should first find the window to map and then map also all the other windows that are in the same viewport. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) BamfLauncherIcon: Focus, some code cleanup @@ -18839,72 +19365,72 @@ prefer visual glitches in multi-monitor to single monitor until real fix is found -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) merge branch of win from Marco that fixes a bug where global menus wont show up with awkward window positioning (50% offscreen) -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) PanelMenuView: disable the menus entries when they aren't shown. This fixes the bug that caused to switch VP and to see a window menu when clicking in the panel. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: Add disabled support If an entryview is disabled, it doesn't get any mouse event. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) PanelMenuView: Don't use the timeout to re-show the window controls when hidden So if we move a window not handled in the panel, as soon as we reach the minimum visible partition, the controls are shown back in the panel. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) PanelMenuView: Hide the panel content (menus and title) if 1/4 of the window is out If 1/4 of a winndow height or a 1/4 of a window width is not viewable in the current viewport, then don't handle that in the panel. -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) PanelMenuView: Check for window position when resized. This fixes bug #861279 caused by grid plugin: so now when we resize a window we also check that it's currently visible in the current viewport. -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) merge branch to make sure viewport indication updates when moving window via alternative means -2011-09-29 Marco Trevisan (Treviño) +2011-09-29 Marco Trevisan (Trevi?o) BamfLauncherIcon: Use a timeout when checking for VP on window move. If we're moving a window, don't perform any check until we stopped moving for 250ms. -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) BamfLauncherIcon: use the OnWindowMoved code also for OnViewPortSwitchEnded Better not to duplicate the code... -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) BamfLauncherIcon: some code optimizations, avoid to duplicate loops -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) BamfLauncherIcon: we should check that every launcher window is on current VP Otherwise just moving one would cause the indicator to change. -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) BamfLauncherIcon: check for viewport on window moved to update the indicator @@ -19071,64 +19597,64 @@ make desaturation time match dash show time -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) Merge panel fading branch -2011-09-28 Marco Trevisan (Treviño) +2011-09-28 Marco Trevisan (Trevi?o) IndicatorEntryView and WindowButtons: no need to set the blending again It's controlled at upper levels. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: correctly use _we_control_active Otherwise it could have lead to wrong drawing. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: don't use the switch viewport signal, go back to _we_control_active -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: don't draw the window title if it's not viewable Fixes bad panel title on viewport switch. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: don't draw any title if we're focussing the panel -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: always force draw the panel content when requested Othewise buttons could hide while dragging a maximized window. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) Merging with upstream -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) Always use CLAMP when we can. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: add an indicator typed as a MENU This allows to disable some unneeded features like secondary activate and scrolling. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelIndicatorsView: support for indicator view typing Default type is (like it was before) an Indicator. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: Add typing support for indicators view @@ -19147,35 +19673,35 @@ and the MENU for the panelmenu menus, that now will act exactly like the menus of a gtk-menubar. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: cache the texture layer, and use it to draw. This code was missing in the previous versions by mistake. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: redraw panel after pressing a window button. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) Animator: clamp progress value. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: Clamp on fade-out to get nice value. -2011-09-27 Marco Trevisan (Treviño) +2011-09-27 Marco Trevisan (Trevi?o) PanelMenuView: Full-redraw on init. It fixes the issue of the first menu-over. -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) Fixing compilation issues, due to bad merge. -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) PanelMenuView: improving the cross-fade between title and menus @@ -19183,21 +19709,21 @@ to a title bar (for maximized windows). We increase the fade-out of the showing item and the fade-in of the hiding one. -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) PanelMenuView: setting the fade in/out values as requested by design Setting the fadein title timing at 100ms and fadeout timing at 120ms as discussed with JohnLea -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) PanelMenuView: tuning the title gradient fade-out If we're fading-out the title, it's better to quickly hide the transparent right-most area. -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) PanelMenuView: Avoid crashes when unlocking/locking the title gradient. @@ -19205,25 +19731,25 @@ and requesting to apply a gradient mask to the window title. This should fix the crash. -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) Merging with upstream changes. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: correctly reset the fade-out duration effect If we changed the fade-out duration it should be reset in any case. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: Increasing the fade-in/fade-out durations -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: Don't show a window title when the dash is on! -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: quickly hide the window buttons if menus aren't hiding @@ -19231,14 +19757,14 @@ or clicking over the restore button of a maximized window), we need to do this in a quicker way. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: on fade-out quickly show the cut title part When fading-out the title we need to quickly show back the menu title part that has been previously cut with fade. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenu: use a cross-fade effect when showing the menus and hiding the title @@ -19248,50 +19774,50 @@ It only happens if we show bot the menus and the buttons and the title is not faded. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenu: When the menus are being shown, update the title gradient on opacity change This allows to get a nice effect, also the title now is cut using a progressive mask which increases its opacity following the menu animation. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) WindowButtons: don't paintbackground, make the parent do it! -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: Don't show anything in the panel if at least the buttons are there If we draw the windowbuttons, then no title should shown in the panel! -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) Animator: small API change to set the default FPS value to 30 So now when creating an animator we must define only the duration. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) IndicatorEntry and WindowButtons: no need to clear the background Since we redraw them from an higher level, we don't have to clear their area when drawing them. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) PanelMenuView: use the new Animator class to show/hide menus and buttons Now we animate the panelmenu items using the Animator timer. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) PanelMenuView: Add DrawMenus and DrawWindowButtons utility functions They allow to check the variables to see if the menus or the window buttons should be drawn. All this for better code readability. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) Remove FadeController, add a more generic Animator class @@ -19300,34 +19826,34 @@ Based on the OsAnimation GObject class by Andrea Cimitan. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) PanelMenuView: Show the buttons when pressing Alt on maximized windows. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) PanelMenu: fade-in / out Menus and Buttons when they're shown. It works well for menus of restored windows, while maximized windows are actually bugged. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) WindowButtons: support for opacity and set them as fadable Objects -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) PanelIndicatorsView: support opacity and set as a FadableObject This allows to make indicators fade in/out easily. -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) FadeController: new class for handling the fading of FadableObjects This class allows to define an object to be faded-in/out using a nux::Timer -2011-09-22 Marco Trevisan (Treviño) +2011-09-22 Marco Trevisan (Trevi?o) PanelIndicatorEntryView: support for drawing items with a different opacity @@ -19535,7 +20061,7 @@ Don't jump during launcher keynav (bug 858469). -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) Fixed lots of other PanelMenuView related bugs (see the linked list of "In Progress bugs" for reference). @@ -19561,93 +20087,93 @@ PS: for the record, this is the previous merge request for this branch: https://code.launchpad.net/~3v1n0/unity/panelmenu-fixes/+merge/73622 -2011-09-25 Marco Trevisan (Treviño) +2011-09-25 Marco Trevisan (Trevi?o) WindowButtons: Fixing bug #823353, re-add pressed form for buttons -2011-09-25 Marco Trevisan (Treviño) +2011-09-25 Marco Trevisan (Trevi?o) PanelMenuView: don't allow to drag windows from panel when the dash is open Fixing bug #858815 -2011-09-24 Marco Trevisan (Treviño) +2011-09-24 Marco Trevisan (Trevi?o) PanelMenuView: Some more optimizations in UpdateShowNow to avoid false-positive We now use also the status and we avoid to do unneeded computation when we just requested to hide the menus. -2011-09-24 Marco Trevisan (Treviño) +2011-09-24 Marco Trevisan (Trevi?o) PanelMenuView: Add a delay before showing the menus when we press the ALT key This fixes bug #855521 preventing the menus to be shown when doing an alt+tab. The delay is actually set to 180ms and seems to work well. -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) Remove conflicts with lp:~3v1n0/unity/menus-switching-hacks -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelMenuView: move to foreach to iterate over entries... -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) Merging with upstream to resolve conflicts. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelIndicatorsView: use foreach loops when possible -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelView: change name to UnityPanel not to clash with unity-2d -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelView: sync geometries on indicator entry view Updated. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelView: fixing typo. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelMenuView: correct wrongly changed comment string... -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelView: SyncGeometries doesn't actually sync anything Added missing method to sync geometries with the service. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) Merging with upstream. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelMenuView: we don't need to keep _title_tex, _title_layer is enough Removing _title_tex and using just the saved _title_layer to draw the faded application title. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelMenuView: Code cleanup Disabling some old code, fixed some spacing and updating some lines around. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelMenuView: check if we're inside the panel after a drag event. If we release the mouse inside the panel, after dragging it around we need to draw it properly. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelMenuView: Use all the panel size to check when we have to start dragging @@ -19655,7 +20181,7 @@ we're outside the menuview. In fact, this would cause the grid plugin to start when we're over the indicators (for example). -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelTitleGrabArea: control the grabbed status @@ -19666,14 +20192,14 @@ Also we directly uses the signals eredited from InputArea in the grab area with no more code duplication. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelMenuView: avoid code duplication in OnEntryAdded Use the new PanelIndicatorsWidget functions to add an entry to the panel menu view, without code duplication. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelIndicatorsView: Add AddEntry / RemoveEntry APIs to allow better code reusability @@ -19681,11 +20207,11 @@ PanelMenuView. Entries can be added in any position, or automatically (by priority). -2011-09-17 Marco Trevisan (Treviño) +2011-09-17 Marco Trevisan (Trevi?o) panel-service: remove an implicit check. -2011-09-17 Marco Trevisan (Treviño) +2011-09-17 Marco Trevisan (Trevi?o) panel-service: re-open a menu if clicking over its title after a keyboard navigation @@ -19693,7 +20219,7 @@ and now we click over the indicator under the mouse, we must force it to show back again, not make all the menus close. -2011-09-17 Marco Trevisan (Treviño) +2011-09-17 Marco Trevisan (Trevi?o) PanelView: track mouse position only when it has been changed @@ -19705,14 +20231,14 @@ always checked for opening a menu. Now it's relevant only if it has been changed. -2011-09-17 Marco Trevisan (Treviño) +2011-09-17 Marco Trevisan (Trevi?o) Go back (again) to auto mouse = nux::GetGraphicsDisplay()->GetMouseScreenCoord() Since Jay fixed it for us in Nux (commit 453), now we can use it safely here with no more crashes ;) -2011-09-17 Marco Trevisan (Treviño) +2011-09-17 Marco Trevisan (Trevi?o) Ignore keyboard events when the mouse is over a menu title @@ -19720,7 +20246,7 @@ issue that is happening when using the keyboard arrows when the mouse is over an indicator. -2011-09-17 Marco Trevisan (Treviño) +2011-09-17 Marco Trevisan (Trevi?o) panel-service: Remove id2entry_hash and go back to a direct hash entry2geometry_hash @@ -19732,7 +20258,7 @@ using the direct access and doesn't use memory to duplicate the entry_id string -2011-09-16 Marco Trevisan (Treviño) +2011-09-16 Marco Trevisan (Trevi?o) Use a string based hash-table for geometry and don't remove values on entry-removed @@ -19749,7 +20275,7 @@ when the client asked to do that to avoid errors, however we use more memory and a slower hashtable since we need to use strings. -2011-09-15 Marco Trevisan (Treviño) +2011-09-15 Marco Trevisan (Trevi?o) Fixing for good the Redecorate maximized windows issue. @@ -19766,15 +20292,15 @@ The old code has been left there, with a FIXME statement. -2011-09-14 Marco Trevisan (Treviño) +2011-09-14 Marco Trevisan (Trevi?o) Code cleanup... -2011-09-13 Marco Trevisan (Treviño) +2011-09-13 Marco Trevisan (Trevi?o) panel-service: Fixed coding style. -2011-09-13 Marco Trevisan (Treviño) +2011-09-13 Marco Trevisan (Trevi?o) Panel-service: cache the entry geometries and use them for parsing mouse events @@ -19788,7 +20314,7 @@ menu title, then the release event is ignored, otherwise we use it to close the menus. -2011-09-11 Marco Trevisan (Treviño) +2011-09-11 Marco Trevisan (Trevi?o) panel-service: Don't remove all release events outside the menu area on first click @@ -19802,11 +20328,11 @@ the release event is ignored and so the menu doesn't close, otherwise the menu closes. -2011-09-11 Marco Trevisan (Treviño) +2011-09-11 Marco Trevisan (Trevi?o) Merging missing changes... -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) Don't consider unmapped and unviewable windows in IsWindowObscured @@ -19818,51 +20344,51 @@ This should fix bugs like #781215 and #774121 -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) WindowManager: don't StartMove with negative coordinates Otherwise unity will crash. -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) Panel: Show the menu after maximizing using the window title drag When a window is maximized we force to check for the mouse position to draw correctly the panel. -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) nux::GetGraphicsDisplay()->GetMouseScreenCoord() is buggy, let's move back to GDK It's better to avoid crashes here. Always check mouse position using GDK. -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) PanelView, never use nux::GetGraphicsDisplay()->GetMouseScreenCoord(); It's too unstable, it could causes crashes when the mouse pointer is grabbed. Reverting to the default implementation, including a FIXME. -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) Fallback to Gdk display if nux::GetGraphicsDisplay() is null Sometimes nux doesn't seem to work as expected, leading to crashes in the previous implementation. So adding a gdk fallback if needed. -2011-09-07 Marco Trevisan (Treviño) +2011-09-07 Marco Trevisan (Trevi?o) Put back AllMenuClosed and check for new mouse position using Nux This allows to properly fix bug #843670 hiding menus only when the mouse pointer is outside the top menu panel. -2011-09-07 Marco Trevisan (Treviño) +2011-09-07 Marco Trevisan (Trevi?o) Merging with upstream -2011-09-26 Marco Trevisan (Treviño) +2011-09-26 Marco Trevisan (Trevi?o) This is a set of hacks to improve the reaction of the panel on fast menus switching @@ -19879,17 +20405,17 @@ [1] https://code.launchpad.net/~3v1n0/unity/panelmenu-fixes/+merge/76133 -2011-09-24 Marco Trevisan (Treviño) +2011-09-24 Marco Trevisan (Trevi?o) Don't draw white indicators when a menu entry is active. Patch suggested by Andrea Cimitan. -2011-09-24 Marco Trevisan (Treviño) +2011-09-24 Marco Trevisan (Trevi?o) Don't use the IsActive getter when modifying the private value -2011-09-23 Marco Trevisan (Treviño) +2011-09-23 Marco Trevisan (Trevi?o) PanelIndicatorEntryView always use the IsActive() function @@ -19962,19 +20488,19 @@ tmp -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) PanelIndicatorsView: use foreach loops in OnPointerMoved. -2011-09-20 Marco Trevisan (Treviño) +2011-09-20 Marco Trevisan (Trevi?o) Merging with upstream. -2011-09-13 Marco Trevisan (Treviño) +2011-09-13 Marco Trevisan (Trevi?o) DBusIndicators: re-use computed rect value. -2011-09-12 Marco Trevisan (Treviño) +2011-09-12 Marco Trevisan (Trevi?o) DBusIndicators: cache locations per each different caller @@ -19984,7 +20510,7 @@ Also fix a typo causing the file not compile. -2011-09-11 Marco Trevisan (Treviño) +2011-09-11 Marco Trevisan (Trevi?o) DBusIndicators: don't spam the service, just send really changed geometries @@ -19995,13 +20521,13 @@ When an entry has been removed, we just send to the service invalid width and height values. -2011-09-09 Marco Trevisan (Treviño) +2011-09-09 Marco Trevisan (Trevi?o) PanelView: SyncGeometries doesn't actually sync anything Added missing method to sync geometries with the service. -2011-09-09 Marco Trevisan (Treviño) +2011-09-09 Marco Trevisan (Trevi?o) This is a set of hacks to improve the reaction of the panel on fast menus switching @@ -20083,11 +20609,11 @@ update switcher view glow to match design (minor tweak) -2011-09-22 Mirco Müller +2011-09-22 Mirco M?ller Fix regression in pixel-grid aligned drawing. -2011-09-22 Mirco Müller +2011-09-22 Mirco M?ller Fix regression from DashStyle refactoring messing up the pixel-grid alignment @@ -20149,16 +20675,16 @@ Optimized effects creation -2011-09-21 Mirco Müller +2011-09-21 Mirco M?ller Fixed LP: #838904 -2011-09-21 Mirco Müller +2011-09-21 Mirco M?ller Fixed height and alignment relative to the top-most launcher icon of the dash-search-bar. -2011-09-20 Mirco Müller +2011-09-20 Mirco M?ller position, size and glow of the search-bar outline fixed @@ -20208,7 +20734,7 @@ 2011-09-19 Gord Allott - do the lazy loading of the dash into 8ms chucks, before queuing to the next frame£ + do the lazy loading of the dash into 8ms chucks, before queuing to the next frame? 2011-09-21 Gord Allott @@ -20475,15 +21001,15 @@ Use plain black #000000, instead #333333, as dark dash layer -2011-09-16 Alejandro Piñeiro +2011-09-16 Alejandro Pi?eiro Adding NUX_[DECLARE/IMPLEMENT]_OBJECT_TYPE macros for LauncherIcon -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro Fixing a type on LauncherIcon NUX_DECLARE_TYPE -2011-09-15 Alejandro Piñeiro +2011-09-15 Alejandro Pi?eiro Adding the NUX_DECLARE/IMPLEMENT macros for LauncherIcon @@ -20515,7 +21041,7 @@ Makes the icons in the dash scale instead of tile -2011-09-15 Mirco Müller +2011-09-15 Mirco M?ller Mirco's branch to adjust spacing and solve lp:844889 @@ -20530,11 +21056,11 @@ - The the font size of the text underneath each icon in the search results is too large - The size and shape of the arrow that points to the currently selected Dash Lens is incorrect -2011-09-15 Mirco Müller +2011-09-15 Mirco M?ller reverted the attempt in changing the dash-size, made category font smaller -2011-09-15 Mirco Müller +2011-09-15 Mirco M?ller Numerous fixes for LP: #844889... about 50% of the states issues still to do @@ -20958,11 +21484,11 @@ remove unity-preferences, we will need to add some blessed option as a g-c-c capplet (LP: #847599) -2011-09-12 Alejandro Piñeiro +2011-09-12 Alejandro Pi?eiro a11y: atk-bridge location path changed his format -2011-09-09 Alejandro Piñeiro +2011-09-09 Alejandro Pi?eiro a11y: atk-bridge location path changed format @@ -21063,57 +21589,57 @@ Revert Robert's spacer from the DashSearchBar as it's causing the filters to be pushed off the edge of the Dash on some resolutions -2011-09-08 Marco Trevisan (Treviño) +2011-09-08 Marco Trevisan (Trevi?o) To implement the Desktop DX Indicators Review blueprint [1] and to implement the system indicators ordering requested by design team [2], I've redesigned the way the indicators work in unity. -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) Correctly unref floating indicator objects. -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) Removing old PanelTray code -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) Merging with upstream -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) PanelView: notify indicators and menu views on indicator object removed When the signal is fired the indicators will be removed from unity. -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) PanelIndicatorsView: support indicator removal -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) UnityCore: added Indicator::GetEntries() and notify on removal -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) panel-service: reduce close-timeout to 1 second. -2011-09-06 Marco Trevisan (Treviño) +2011-09-06 Marco Trevisan (Trevi?o) DbusIndicators: kill panel service if needed -2011-09-05 Marco Trevisan (Treviño) +2011-09-05 Marco Trevisan (Trevi?o) UnityCore: adding Indicators::RemoveIndicator and Indicators::GetIndicators() They both allow to remove indicators when they have been lost. -2011-09-05 Marco Trevisan (Treviño) +2011-09-05 Marco Trevisan (Trevi?o) Better Indicator and Indicators APIs Using Indicator:Ptr everywhere and reduced loops when syncing. -2011-09-05 Marco Trevisan (Treviño) +2011-09-05 Marco Trevisan (Trevi?o) Add a timeout to the Indicator Remove API @@ -21122,21 +21648,21 @@ Currently set to 3 seconds, maybe it could be set to a lower value. -2011-09-04 Marco Trevisan (Treviño) +2011-09-04 Marco Trevisan (Trevi?o) Make unity to remove the indicators when the panel service has been closed Not killed, that needs to update the unity side. -2011-09-03 Marco Trevisan (Treviño) +2011-09-03 Marco Trevisan (Trevi?o) PanelService small api change... -2011-09-03 Marco Trevisan (Treviño) +2011-09-03 Marco Trevisan (Trevi?o) Merging with upstream. -2011-09-03 Marco Trevisan (Treviño) +2011-09-03 Marco Trevisan (Trevi?o) PanelService: fix keynavigation on priority based indicators. @@ -21148,31 +21674,31 @@ Bug fixed by reoreding the indicator entries considering their priority and using the temporary generated list to select which menu should be opened. -2011-09-01 Marco Trevisan (Treviño) +2011-09-01 Marco Trevisan (Trevi?o) Merging with upstream, fixing the small conflict with TrayIcon -2011-08-30 Marco Trevisan (Treviño) +2011-08-30 Marco Trevisan (Trevi?o) Cleaning up another missed comment. -2011-08-29 Marco Trevisan (Treviño) +2011-08-29 Marco Trevisan (Trevi?o) More cleanups... -2011-08-29 Marco Trevisan (Treviño) +2011-08-29 Marco Trevisan (Trevi?o) Removing unneeded and commented code -2011-08-29 Marco Trevisan (Treviño) +2011-08-29 Marco Trevisan (Trevi?o) Merging with Upstream. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Some optimizations for clearing empty indicators. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Indicator entries should always be resynced, also if they're empty. @@ -21181,13 +21707,13 @@ This fixes the issue that I introduced which caused the menus not to be removed when a window had no menus at all. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Menus already arrive in the correct order, no need to check for priority. Also if that could be a nice extra check, I prefer not to waste time here. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Including name_hint parameter in the IndicatorEntry. @@ -21196,7 +21722,7 @@ Updated also the entry tests. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Added PanelIndicatorsView to move to the priority-based system for ordering entries @@ -21209,7 +21735,7 @@ to order them. Thanks to this now the indicators can be also in a mixed order and the entries aren't anymore ordered just per-IndicatorObject. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) UnityCore: Support for prioritized indicator entries @@ -21227,7 +21753,7 @@ Finally, now we use have an indicator entry priority flag, we don't need to order all the entries per-indicator. -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Panel service: Add priority flag to indicators @@ -21247,7 +21773,7 @@ * All the others appindicators * The application menus -2011-08-09 Marco Trevisan (Treviño) +2011-08-09 Marco Trevisan (Trevi?o) Enable debugging symbols in Debug mode. @@ -21371,7 +21897,7 @@ - Some memory optimizations and fix of memory leaks - Fixed a bug causing unity to crash if removing launcher with an open quicklist (bug #801413) -2011-09-07 Marco Trevisan (Treviño) +2011-09-07 Marco Trevisan (Trevi?o) LauncherIcon: Hide a visible quicklist when removing the Icon @@ -21381,7 +21907,7 @@ This fixes bug #801413 -2011-09-07 Marco Trevisan (Treviño) +2011-09-07 Marco Trevisan (Trevi?o) BamfLauncherIcon: Fixed some MenuItems memory leaks @@ -21392,7 +21918,7 @@ All the used menu_items are now also unreferenced when the Launcher Icon is destructed. -2011-09-07 Marco Trevisan (Treviño) +2011-09-07 Marco Trevisan (Trevi?o) Update .desktop file quicklist on file modification @@ -21403,14 +21929,14 @@ Plus, don't update the cached desktop file if not needed and always use DesktopFile() to get it. -2011-09-07 Marco Trevisan (Treviño) +2011-09-07 Marco Trevisan (Trevi?o) BamfLauncherIcon: Don't show quicklist items if they aren't visible. A quicklist menu or a quicklist menuitem shouldn't be considered if not visible at all. This would cause to show just a separator leading to bug #843425 -2011-09-08 Mirco Müller +2011-09-08 Mirco M?ller This fixes a lot of the issues stated in the mega-bug LP: #841945. But since it is so much not everything is done yet. Still already done fixes should @@ -21436,23 +21962,23 @@ - the 'All' button's shape is very wrong - the filter results category headers are with wrong font size and weight -2011-09-08 Mirco Müller +2011-09-08 Mirco M?ller Merge with trunk again -2011-09-08 Mirco Müller +2011-09-08 Mirco M?ller Made font-weight of filter-caption text bold, added drawing of separators to the genre- and multi-range-widgets -2011-09-07 Mirco Müller +2011-09-07 Mirco M?ller Fixed spacing between filter-header and actual filter-widget -2011-09-07 Mirco Müller +2011-09-07 Mirco M?ller fixed the horizontal position and alignment of SeachBar and result-captions... gave up on the icon-sizes of the result-views for now -2011-09-06 Mirco Müller +2011-09-06 Mirco M?ller first bunch of fixes on the filter-page for the mega-bug LP: #841945 @@ -21734,7 +22260,7 @@ Removes the 1px of padding. -2011-09-07 Mirco Müller +2011-09-07 Mirco M?ller Added sheen-asset for dash provided by Design @@ -21778,13 +22304,13 @@ replace ubuntuonecontrol-panel-gtk with ubuntuone-installer as requested per ubuntuone team -2011-09-06 Alejandro Piñeiro +2011-09-06 Alejandro Pi?eiro a11y: Adding a missing g_object_ref and some extra NULL checks Fixes launchpad bug 817477 -2011-09-02 Alejandro Piñeiro +2011-09-02 Alejandro Pi?eiro a11y: Adding a missing g_object_ref and some extra NULL checks @@ -21986,19 +22512,19 @@ Different window button styles with opened dash -2011-09-02 Marco Trevisan (Treviño) +2011-09-02 Marco Trevisan (Trevi?o) This branch includes some fixes for PanelMenuView which in current trunk has often some visual issues (menus are not hidden, title is not faded out). -2011-09-02 Marco Trevisan (Treviño) +2011-09-02 Marco Trevisan (Trevi?o) Always restore the mouse cursor on grab end. -2011-09-02 Marco Trevisan (Treviño) +2011-09-02 Marco Trevisan (Trevi?o) PanelTitlebarGrabArea: send mouse_down only on left-click. -2011-09-02 Marco Trevisan (Treviño) +2011-09-02 Marco Trevisan (Trevi?o) Add a workaround to avoid the compiz grid plugin to show the full-screen effect @@ -22016,13 +22542,13 @@ This doesn't fix completely the bug #838923, since that is mostly caused by an X race in updating the Window X properties. -2011-09-01 Marco Trevisan (Treviño) +2011-09-01 Marco Trevisan (Trevi?o) Don't hide menus and windowcontrols (if shown) when closing the menus. Fixes bug #838759 -2011-09-01 Marco Trevisan (Treviño) +2011-09-01 Marco Trevisan (Trevi?o) Track the mouse enter/leave for WindowButtons too @@ -22031,7 +22557,7 @@ to check where the mouse is instead of checking it twice with nux::GetWindowCompositor().GetMousePosition() -2011-09-01 Marco Trevisan (Treviño) +2011-09-01 Marco Trevisan (Trevi?o) Fixing bug #838021 causing the menus not to hide after a double-click in the panel @@ -22040,7 +22566,7 @@ value to true, and _is_grabbed to false to make _is_inside to be reverted to true when the MouseEnter event happens. -2011-09-01 Marco Trevisan (Treviño) +2011-09-01 Marco Trevisan (Trevi?o) When drawing the PanelMenuView always check for current pointer position. @@ -22048,7 +22574,7 @@ or the double-click over the panel, the application title text wasn't faded out correctly). -2011-09-01 Marco Trevisan (Treviño) +2011-09-01 Marco Trevisan (Trevi?o) Fixing again bug #820293 (using a cleaner way) and #835637 @@ -22254,11 +22780,11 @@ Fix sizing of the dash content -2011-09-01 Mirco Müller +2011-09-01 Mirco M?ller Make sure overlay-effects (glow) on buttons are not cut off (since they currently can't bleed into space-allocations of adjacent widgets). Added API to query DashStyle for additional space-requirements. This is used for the genre-buttons in FilterGenreWidget. -2011-09-01 Mirco Müller +2011-09-01 Mirco M?ller Made sure the glowing overlay of buttons are not cut off, added API for querying additional space-requirements @@ -22334,7 +22860,7 @@ Merge filled/unfilled arrow branch -2011-08-30 Marco Trevisan (Treviño) +2011-08-30 Marco Trevisan (Trevi?o) WindowManager / PluginAdapter add compiz_event signal @@ -22343,7 +22869,7 @@ It's actually not used anywhere but it could be useful for future usage. -2011-08-30 Marco Trevisan (Treviño) +2011-08-30 Marco Trevisan (Trevi?o) MinimizedHandler: Add static variable to check if we have to handle compiz events or not @@ -22351,7 +22877,7 @@ all the UnityShell plugin at all when setting to handle or not compiz events. -2011-08-30 Marco Trevisan (Treviño) +2011-08-30 Marco Trevisan (Trevi?o) CompizMinimizedWindowHandler: don't disable compiz event dispatching. @@ -22361,19 +22887,19 @@ As side effect the launcher would hide/show on viewport switch and it would be impossible to detect a viewport switch event. -2011-08-30 Marco Trevisan (Treviño) +2011-08-30 Marco Trevisan (Trevi?o) Merging with upstream changes. -2011-08-01 Marco Trevisan (Treviño) +2011-08-01 Marco Trevisan (Trevi?o) BamfLauncher: check for win -2011-08-01 Marco Trevisan (Treviño) +2011-08-01 Marco Trevisan (Trevi?o) Merge with upstream -2011-07-29 Marco Trevisan (Treviño) +2011-07-29 Marco Trevisan (Trevi?o) Add two more options to Icon BackLight Illumination @@ -22390,14 +22916,14 @@ The second of this option has been designed with JohnLea -2011-07-29 Marco Trevisan (Treviño) +2011-07-29 Marco Trevisan (Trevi?o) Change indicator when an app instance is not running on the current view-port In the case that an application is not running on the current viewport we need to draw just an empty arrow. This finally fixes bug #690143 -2011-07-29 Marco Trevisan (Treviño) +2011-07-29 Marco Trevisan (Trevi?o) BamfLauncherIcon: check windows's viewport on viewport change @@ -22406,7 +22932,7 @@ visible on the current viewport. In that case we must update the UI accordingly. -2011-07-29 Marco Trevisan (Treviño) +2011-07-29 Marco Trevisan (Trevi?o) Launcher: when a viewport switch event occurs do the needed things. @@ -22414,7 +22940,7 @@ are emitted the launcher should disable and re/enable the launcher showing. -2011-07-29 Marco Trevisan (Treviño) +2011-07-29 Marco Trevisan (Trevi?o) PluginAdapter: suport compiz_screen_viewport_switch_{started,ended} signals @@ -22509,7 +23035,7 @@ fixes referencing too much in the dash with dnd and a scope error -2011-08-26 Mirco Müller +2011-08-26 Mirco M?ller should fix the glitch of the button-outline @@ -22759,33 +23285,33 @@ changed Any string to All -2011-08-25 Mirco Müller +2011-08-25 Mirco M?ller Added correct separator-rendering, fixed text-positioning on buttons, updated active- and prelight-state button-rendering, updated multi-range rendering to reflect a new design-change -2011-08-25 Mirco Müller +2011-08-25 Mirco M?ller Defined a subtle look for hover/prelight -2011-08-24 Mirco Müller +2011-08-24 Mirco M?ller Switched outline for buttons and multi-range to regular rounded-rect, updated multi-range to new design, fixed some formatting -2011-08-24 Mirco Müller +2011-08-24 Mirco M?ller got rid of unused variables -2011-08-24 Mirco Müller +2011-08-24 Mirco M?ller Enable the pixel-grid alignment for the button-outline again -2011-08-24 Mirco Müller +2011-08-24 Mirco M?ller Fix text-position in buttons -2011-08-24 Mirco Müller +2011-08-24 Mirco M?ller Added rendering of separators, changed look of button-states @@ -24304,67 +24830,67 @@ Add 1px of horizontal padding, maybe not the right fix but works for the moment. Added a FIXME to remember -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller [merge] DashStyle -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller crap -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller turns out we need ARROW_NONE after all -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller Added API-stubs for TrackView and Separators -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller make arrows of the MultiRange-widget align to pixel-grid, corrected their fill-color -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller swapped the order of ACTIVE and NORMAL -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller Changed API for the rating-stars -2011-08-10 Mirco Müller +2011-08-10 Mirco M?ller Added arrow-rendering for MultiRange widget, use the normal state from Nux/View.h, use correct install-path for .json file -2011-08-09 Mirco Müller +2011-08-09 Mirco M?ller make sure left and right edges of the multi-range widget touch each other -2011-08-09 Mirco Müller +2011-08-09 Mirco M?ller Shapes of the multi-range widget-parts are correct now -2011-08-09 Mirco Müller +2011-08-09 Mirco M?ller Made button-outline use absolute cairo-API, thus were able to add pixel-grid alignment for line-drawing... started MultiRange-widget after agreement on API with Gordon -2011-08-08 Mirco Müller +2011-08-08 Mirco M?ller make .json file install correctly, make sure the ratings-bar scales correctly -2011-08-08 Mirco Müller +2011-08-08 Mirco M?ller fix order of entries in font-weight enum, implemented ReadWeightArray() and ReadModeArray(), tweaked .json file -2011-08-08 Mirco Müller +2011-08-08 Mirco M?ller make the test-case closer to real-world usage, hook up drawing of some text-attributes -2011-08-05 Mirco Müller +2011-08-05 Mirco M?ller remove obsolete style-definitions due to design updates, focus on button (with label) drawing -2011-08-05 Mirco Müller +2011-08-05 Mirco M?ller rebase on trunk, adapting to latest designs, beginning of porting custom button outline shape from SVG to real code @@ -24392,7 +24918,7 @@ quick snapshot of style- and asset-handover-process -2011-06-26 Mirco Müller +2011-06-26 Mirco M?ller added: src/DashStyle.cpp @@ -25125,15 +25651,15 @@ Fix bug #810971 -2011-08-01 Alejandro Piñeiro +2011-08-01 Alejandro Pi?eiro [a11y] Code style review using tools/apply_unity_formatting.sh -2011-08-01 Alejandro Piñeiro +2011-08-01 Alejandro Pi?eiro [a11y] Cleaning g_debug calls -2011-08-01 Alejandro Piñeiro +2011-08-01 Alejandro Pi?eiro [a11y] Improve the shared focus management on the Launcher/Dash @@ -25154,7 +25680,7 @@ * Document all this stuff on BaseWindowAccessible developer documentation -2011-07-21 Alejandro Piñeiro +2011-07-21 Alejandro Pi?eiro [a11y] Improve the shared focus management on the Launcher/Dash @@ -25175,7 +25701,7 @@ * Document all this stuff on BaseWindowAccessible developer documentation -2011-07-19 Alejandro Piñeiro +2011-07-19 Alejandro Pi?eiro [a11y] Improve the shared focus management on the Launcher/Dash @@ -25196,7 +25722,7 @@ * Document all this stuff on BaseWindowAccessible developer documentation -2011-07-12 Alejandro Piñeiro +2011-07-12 Alejandro Pi?eiro [a11y] Improve the shared focus management on the Launcher/Dash @@ -25215,11 +25741,11 @@ * In order to do that it implements a pending notification proces * Document all this stuff on BaseWindowAccessible developer documentation -2011-05-03 Alejandro Piñeiro +2011-05-03 Alejandro Pi?eiro [a11y] Fixing BaseWindowAccessible developer documentation -2011-05-02 Alejandro Piñeiro +2011-05-02 Alejandro Pi?eiro [a11y] Improve the shared focus management on the Launcher/Dash @@ -25235,28 +25761,28 @@ prior this commit those signals were emitted but in a wrong order * In order to do that it implements a pending notification process -2011-05-02 Alejandro Piñeiro +2011-05-02 Alejandro Pi?eiro Changing the virtual method to just a pending notification Children now told the parent that it is active -2011-05-01 Alejandro Piñeiro +2011-05-01 Alejandro Pi?eiro Added a virtual nuxarea virtual methods -2011-04-25 Alejandro Piñeiro +2011-04-25 Alejandro Pi?eiro Work in progress -2011-04-12 Alejandro Piñeiro +2011-04-12 Alejandro Pi?eiro Work in progress -2011-04-06 Alejandro Piñeiro +2011-04-06 Alejandro Pi?eiro Work in progress .... -2011-04-06 Alejandro Piñeiro +2011-04-06 Alejandro Pi?eiro Work in progress @@ -25304,7 +25830,7 @@ merge branch to prevent mapping of minimized window when not needed -2011-07-28 Marco Trevisan (Treviño) +2011-07-28 Marco Trevisan (Trevi?o) BamfLauncherIcon: Don't map minimized windows if a mapped one is available @@ -25336,7 +25862,7 @@ merge launcher edge reveal branch -2011-07-28 Marco Trevisan (Treviño) +2011-07-28 Marco Trevisan (Trevi?o) Added configurable option to define the launcher edge-show timeout @@ -25345,7 +25871,7 @@ Default value set to 150 ms. -2011-07-28 Marco Trevisan (Treviño) +2011-07-28 Marco Trevisan (Trevi?o) Edge launcher reveal: reduce the timeout and reduce unwanted revelations @@ -25557,7 +26083,7 @@ Changed to signal OnKeyEvent declaration -2011-07-28 Marco Trevisan (Treviño) +2011-07-28 Marco Trevisan (Trevi?o) Scrolling in the indicators: sync with latest Nux changes @@ -25567,29 +26093,29 @@ Plus, the nux delta value now is less than 0 when down, and greater when it's up. Updating the panel service. -2011-07-22 Marco Trevisan (Treviño) +2011-07-22 Marco Trevisan (Trevi?o) panel-service: nux scroll delta has been inverted. Syncing with the new value when sending signal. -2011-07-22 Marco Trevisan (Treviño) +2011-07-22 Marco Trevisan (Trevi?o) PanelIndicatorObjectEntry: accept mouse wheel events. A Nux Area now needs to explicitly accept the mouse wheel events otherwise they will be ignored. -2011-07-28 Marco Trevisan (Treviño) +2011-07-28 Marco Trevisan (Trevi?o) Added support to "secondary-activate" event on middle-click, which is needed to fix LP: #609860 and LP: #812933 -2011-07-21 Marco Trevisan (Treviño) +2011-07-21 Marco Trevisan (Trevi?o) Merging branches (upstream and local) -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) panel-service: Support for the "secondary-activate" indicator signal @@ -25597,7 +26123,7 @@ method call, it redirects it to libindicator signal using the "secondary-activate" glib signal defined in libindicator -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) unityshell: Send SecondaryActivate signal on indicator middle click @@ -25608,32 +26134,32 @@ (so the mouse click can be canceled releasing the mouse click outside the indicator entry space). -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) UnityCore: support for SecondaryActivate on indicators Secondary activation can be done by middle click and is needed to implement the StatusNotifierItem specification. -2011-07-21 Marco Trevisan (Treviño) +2011-07-21 Marco Trevisan (Trevi?o) Indicator: Don't use anymore the x,y position on secondary-activation All the tree is updated to use the new signal. -2011-07-21 Marco Trevisan (Treviño) +2011-07-21 Marco Trevisan (Trevi?o) Merging with Upstream -2011-07-21 Marco Trevisan (Treviño) +2011-07-21 Marco Trevisan (Trevi?o) Merging with Upstream -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) Support for seconday activate -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) Get back fading @@ -25849,27 +26375,27 @@ Bug #809907: Title fade effect no longer works -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) attach cairo_mask to pattern craetion too keep a logical separation between "creation" and "destruction" of the elements (again) -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) Keep the space before gtk_style_context_restore too keep a logical separation between "creation" and "destruction" of the elements -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) Use always cairo_pattern_add_color_stop_rgba For better readability... -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) Just use a cairo mask to fade the title @@ -25880,7 +26406,7 @@ This should work fine with GTK theming and Cimi likes it ;) -2011-07-17 Marco Trevisan (Treviño) +2011-07-17 Marco Trevisan (Trevi?o) Fix panel title fading for long titles @@ -25904,15 +26430,15 @@ Fixed dead code in Launcher::OnUpdateDragManagerTimeout (LP: #805327) -2011-07-21 Marco Trevisan (Treviño) +2011-07-21 Marco Trevisan (Trevi?o) Merged Marco's branch fix the opengl detection code for locales that use , instead of . -2011-07-13 Marco Trevisan (Treviño) +2011-07-13 Marco Trevisan (Trevi?o) Added missing parenthesis. -2011-07-13 Marco Trevisan (Treviño) +2011-07-13 Marco Trevisan (Trevi?o) OpenGL version string can be divided by a "comma" too @@ -25921,15 +26447,15 @@ Also, we check that the char after the float divsor is a digit. -2011-07-13 Marco Trevisan (Treviño) +2011-07-13 Marco Trevisan (Trevi?o) Merging with upstream -2011-07-21 Marco Trevisan (Treviño) +2011-07-21 Marco Trevisan (Trevi?o) Merged Marco's branch to send the entry-scrolled signal in the indicators -2011-07-02 Marco Trevisan (Treviño) +2011-07-02 Marco Trevisan (Trevi?o) Use the "entry-scrolled" signal instead of the old ones @@ -26337,11 +26863,11 @@ * Fix unity for the new event architecture -2011-07-18 Alejandro Piñeiro +2011-07-18 Alejandro Pi?eiro [a11y] Checking if a11y is enabled using gsettings instead of gconf -2011-07-13 Alejandro Piñeiro +2011-07-13 Alejandro Pi?eiro [a11y] Checking if a11y is enabled using gsettings instead of gconf @@ -26609,11 +27135,11 @@ inside the event filter fixes graphics glitches seen in the panel menus (LP: #687567) -2011-07-13 Rafał Cieślak +2011-07-13 Rafa? Cie?lak - Merged in Rafałs branch to fix lp:734010 + Merged in Rafa?s branch to fix lp:734010 -2011-07-11 Rafał Cieślak +2011-07-11 Rafa? Cie?lak [fix 734010] spacing between indicators should be 5 pixels @@ -26621,11 +27147,11 @@ plugins/unityshell/src/PanelIndicatorObjectEntryView.h - changed default indicator padding to 5px -2011-07-13 Rafał Cieślak +2011-07-13 Rafa? Cie?lak - Merged in Rafałs branch to fix lp:691808 + Merged in Rafa?s branch to fix lp:691808 -2011-07-10 Rafał Cieślak +2011-07-10 Rafa? Cie?lak [fix #691808] Don't switch title to menu when hovering window buttons @@ -26633,7 +27159,7 @@ plugins/unityshell/src/PanelMenuView.cpp - Check whether the window is maximized, and do not exclude the buttons' area in case it's not. -2011-07-10 Rafał Cieślak +2011-07-10 Rafa? Cie?lak [fix #691808] Don't switch title to menu when hovering window buttons @@ -26641,7 +27167,7 @@ plugins/unityshell/src/PanelMenuView.cpp - Extended appropriate if statement checking for pointer location to exclude window buttons' area. -2011-07-12 Mirco Müller +2011-07-12 Mirco M?ller modified: CMakeLists.txt @@ -26668,7 +27194,7 @@ Eject an "eject-able" device when drag and drop it into the trash. -2011-07-12 Mirco Müller +2011-07-12 Mirco M?ller modified: plugins/unityshell/src/Launcher.cpp @@ -26683,7 +27209,7 @@ Tries to solve bug #733425 (Moving a launcher icon around generates lots of disk write activity). -2011-07-12 Mirco Müller +2011-07-12 Mirco M?ller modified: plugins/unityshell/src/BamfLauncherIcon.cpp @@ -26775,7 +27301,7 @@ updated copyright in unityshell.cpp/h -2011-06-30 Aurélien Gâteau +2011-06-30 Aur?lien G?teau Merge fix to block NULL indicators from sending signals @@ -26783,9 +27309,9 @@ Do not emit signals for invalid indicator entries. -2011-06-30 Aurélien Gâteau +2011-06-30 Aur?lien G?teau - Merge Aurélien's updates to Indicator* class documentation + Merge Aur?lien's updates to Indicator* class documentation 2011-06-30 Aurelien Gateau @@ -26947,7 +27473,7 @@ Use the same default that you provide to compiz -2011-06-22 Aurélien Gâteau +2011-06-22 Aur?lien G?teau correct libunity-core pc file @@ -27404,7 +27930,7 @@ important for eSATA mounts which don't have Eject or Remove options (LP: #773946) -2011-06-09 Mirco Müller +2011-06-09 Mirco M?ller added: dialog/ @@ -27618,7 +28144,7 @@ Enables doxygen documentation building, for internal use only. use make doxygen -2011-06-03 Mirco Müller +2011-06-03 Mirco M?ller modified: src/Tooltip.cpp @@ -27941,7 +28467,7 @@ Adding some glib wrappers, and updating FavoriteStore to use strings. -2011-06-01 Mirco Müller +2011-06-01 Mirco M?ller modified: src/Launcher.cpp @@ -27954,7 +28480,7 @@ Menu key should open quicklist for the selected item in the launcher. -2011-06-01 Mirco Müller +2011-06-01 Mirco M?ller modified: src/PanelMenuView.cpp @@ -28102,7 +28628,7 @@ Fix issue where left edge of launcher is sometimes unresponsive on first run of unity -2011-05-26 Mirco Müller +2011-05-26 Mirco M?ller modified: src/PanelIndicatorObjectEntryView.cpp @@ -28117,7 +28643,7 @@ -- Manuel Nicetto Tue 03 May 2011 00:12 -2011-05-26 Mirco Müller +2011-05-26 Mirco M?ller modified: src/Launcher.cpp @@ -28142,7 +28668,7 @@ Do not leak pixbuf in indicator update (LP: #779717). -2011-05-26 Mirco Müller +2011-05-26 Mirco M?ller modified: src/Tooltip.cpp @@ -28152,7 +28678,7 @@ the destructor of the Tooltip. Should fix any remaining issue regarding LP: #762801 -2011-05-26 Mirco Müller +2011-05-26 Mirco M?ller Correctly remove any signal-connections (sigc) used for the StaticCairoText in the destructor of the Tooltip. Should fix any remaining @@ -28415,7 +28941,7 @@ I still think it's an improvment (see Charline's report in maverick for double clicking on bfb and people being puzzled) and the last described glitch only - impact people double clicking on a place LauncherIcon for closing it… + impact people double clicking on a place LauncherIcon for closing it? 2011-04-20 Didier Roche @@ -28434,7 +28960,7 @@ I still think it's an improvment (see Charline's report in maverick for double clicking on bfb and people being puzzled) and the last described glitch only - impact people double clicking on a place LauncherIcon for closing it… + impact people double clicking on a place LauncherIcon for closing it? 2011-04-20 Didier Roche @@ -28458,7 +28984,7 @@ [release] 3.8.10 -2011-04-19 Loïc Molinari +2011-04-19 Lo?c Molinari Don't unref GTK+ widget since ownership's been given to its GTK+ container @@ -28490,15 +29016,15 @@ Correctly unreference PanelViews -2011-04-19 Mirco Müller +2011-04-19 Mirco M?ller attempt to fix lp:#761211 by adding pointer checks before using any member-methods -2011-04-19 Mirco Müller +2011-04-19 Mirco M?ller *sigh* don't try to do to many things at the same time -2011-04-19 Mirco Müller +2011-04-19 Mirco M?ller Best attempt to fix LP: #761211 without a more telling stacktrace @@ -28518,11 +29044,11 @@ Fix LP: #759886 where indicator fonts does not update when changing fonts in appearance preferences. -2011-04-19 Loïc Molinari +2011-04-19 Lo?c Molinari Merged branch unity-fix-756951 -2011-04-18 Loïc Molinari +2011-04-18 Lo?c Molinari Relayout right after launcher initialization in order to have a first render at the right position @@ -28692,15 +29218,15 @@ [release] 3.8.8 -2011-04-14 Loïc Molinari +2011-04-14 Lo?c Molinari Merged branch unity-clean-up-at-destruction-2 -2011-04-14 Loïc Molinari +2011-04-14 Lo?c Molinari Re-added the launcher window unref at destruction and removed the refsink that seemed to be there to workaround ref counting issue -2011-04-14 Loïc Molinari +2011-04-14 Lo?c Molinari Plugged several memory leaks and removed some signal connections at destruction @@ -28748,7 +29274,7 @@ fixes a few small memleaks -2011-04-14 Mirco Müller +2011-04-14 Mirco M?ller modified: src/LauncherIcon.cpp @@ -28891,7 +29417,7 @@ revert more asset after a discussion with Neil -2011-04-13 Mirco Müller +2011-04-13 Mirco M?ller modified: src/PlacesVScrollBar.cpp @@ -28900,15 +29426,15 @@ Adapt to late design-change. Remove state-handling for vertical Dash-scrollbar Change rendering of said scrollbar. Fixes LP: #750374 -2011-04-13 Mirco Müller +2011-04-13 Mirco M?ller Avoid potential segfaults and check against NULL-pointers being returned -2011-04-12 Mirco Müller +2011-04-12 Mirco M?ller Remove state-handling for vertical Dash-scrollbar. Change rendering of said scrollbar. Fixes LP: #750374 -2011-04-13 Mirco Müller +2011-04-13 Mirco M?ller modified: src/Launcher.cpp @@ -28929,11 +29455,11 @@ Correctly unregister all registered interests with the ubus-server in a class' destructor. Fixes LP: #757588 -2011-04-13 Mirco Müller +2011-04-13 Mirco M?ller Make use of G_N_ELEMENTS-macro to harden ubus-handles juggling -2011-04-12 Mirco Müller +2011-04-12 Mirco M?ller Correctly unregister all registered interests with the ubus-server. Fixes LP: #757588 @@ -29006,7 +29532,7 @@ 2011-04-11 Didier Roche - g_dngettext is nice, thanks for thinking about our poor non english soul… However adding the file to po/POTFILES.in is even better :) (LP: #757663) + g_dngettext is nice, thanks for thinking about our poor non english soul? However adding the file to po/POTFILES.in is even better :) (LP: #757663) 2011-04-11 Neil Jagdish Patel @@ -29085,7 +29611,7 @@ ensure panel shadow gets redrawn when expo ends (evil but effective style) -2011-04-11 Mirco Müller +2011-04-11 Mirco M?ller modified: src/StaticCairoText.cpp @@ -29093,15 +29619,15 @@ Take non-zero x- and y-offsets for GetTextExtents() into account. Fixes LP: #750350 -2011-04-11 Mirco Müller +2011-04-11 Mirco M?ller *cough.cough* -2011-04-11 Mirco Müller +2011-04-11 Mirco M?ller fixed now for real, removed debugging-related calls -2011-04-11 Mirco Müller +2011-04-11 Mirco M?ller trying to fix LP: #750350 @@ -29294,7 +29820,7 @@ decorate/undecorate using compiz display -2011-04-08 Mirco Müller +2011-04-08 Mirco M?ller modified: src/IndicatorObjectEntryProxyRemote.cpp @@ -29305,7 +29831,7 @@ Didier. Added more NULL-pointer checks and variables-initializations. This fixes LP: #752293. -2011-04-08 Mirco Müller +2011-04-08 Mirco M?ller initialize values, check for NULL before trying to duplicate, should fix LP: #752293 @@ -29380,7 +29906,7 @@ 2011-04-06 Neil Jagdish Patel - Der er ingen ko på isen (så længe halen er på land). + Der er ingen ko p? isen (s? l?nge halen er p? land). 2011-04-06 Neil Jagdish Patel @@ -29434,7 +29960,7 @@ fixes misalignment in tile rendering, lp:748588 -2011-04-07 Mirco Müller +2011-04-07 Mirco M?ller modified: services/panel-service.c @@ -29446,7 +29972,7 @@ Setting indicator environment for panel service -2011-04-07 Mirco Müller +2011-04-07 Mirco M?ller modified: src/PanelMenuView.cpp @@ -29491,7 +30017,7 @@ reverted unity so i can actually build it -2011-04-06 Mirco Müller +2011-04-06 Mirco M?ller modified: src/QuicklistView.cpp @@ -29502,19 +30028,19 @@ items and also checks for the edge-case of first or last item being a separator. Fixes LP: #741657 -2011-04-01 Mirco Müller +2011-04-01 Mirco M?ller Re-merged with trunk and fixed merge-conflicts -2011-04-01 Mirco Müller +2011-04-01 Mirco M?ller Protect against key-nav edge-case of first or last item being a separator -2011-03-31 Mirco Müller +2011-03-31 Mirco M?ller Make code more readable -2011-03-30 Mirco Müller +2011-03-30 Mirco M?ller Skip over separator items in Quicklists, if walking them with keyboard-navigation. Fixes LP: #741657 @@ -29738,7 +30264,7 @@ Ensure correct stacking of Tooltips. Fixes LP: #729093 -2011-03-30 Mirco Müller +2011-03-30 Mirco M?ller Ensure correct stacking of Tooltips. Fixes LP: #729093 @@ -29750,7 +30276,7 @@ Since it is not clear, if adding the needed defines for the num. keypad cursor-keys to nux breaks ABI, I've added them locally to Launcher.cpp and QuicklistView.cpp as a temp. workaround. -2011-03-30 Mirco Müller +2011-03-30 Mirco M?ller Add support for launcher/quicklist keyboard-navigation to also react on cursor-keys of numeric keypad. Fixes LP: #741154 @@ -29802,7 +30328,7 @@ 2011-03-31 Jay Taoko - On Behalf of: Alejandro Piñeiro + On Behalf of: Alejandro Pi?eiro This branch provides the base support for the Dash. @@ -29820,43 +30346,43 @@ NOTE: with the alt+f2 thing, we get a extra notification or orca. I will try to fix it while Rodrigo reviews the branch -2011-03-28 Alejandro Piñeiro +2011-03-28 Alejandro Pi?eiro [a11y] Starting a11y support for the dash (run command dialog) -2011-03-28 Alejandro Piñeiro +2011-03-28 Alejandro Pi?eiro [a11y] finishing -2011-03-28 Alejandro Piñeiro +2011-03-28 Alejandro Pi?eiro [a11y] Dash basic a11y support -2011-03-25 Alejandro Piñeiro +2011-03-25 Alejandro Pi?eiro [a11y] Dash basic a11y support -2011-03-24 Alejandro Piñeiro +2011-03-24 Alejandro Pi?eiro [a11y] Restoring tests -2011-03-24 Alejandro Piñeiro +2011-03-24 Alejandro Pi?eiro [a11y] Removing the nux-view focus support not based on focusable, use ad-hoc on Launcher -2011-03-23 Alejandro Piñeiro +2011-03-23 Alejandro Pi?eiro [a11y] Starting a11y support on the dash view -2011-03-23 Alejandro Piñeiro +2011-03-23 Alejandro Pi?eiro [a11y] More dummy objects and start to use Focusable on nux-view -2011-03-22 Alejandro Piñeiro +2011-03-22 Alejandro Pi?eiro [a11y] ATK dummy implementation for PlacesView -2011-03-10 Alejandro Piñeiro +2011-03-10 Alejandro Pi?eiro [a11y] ATK dummy implementation for PlacesView @@ -29929,22 +30455,22 @@ avoid race condition with LauncherEntryRemote objects by checking if one exists when we register a LauncherIcon -2011-03-30 Loïc Molinari +2011-03-30 Lo?c Molinari Merged branch unity-relayout-timeout-fixes -2011-03-30 Loïc Molinari +2011-03-30 Lo?c Molinari Removed trailing line feed from the last commit -2011-03-30 Loïc Molinari +2011-03-30 Lo?c Molinari relayout timeout source fixes - Ensured the source is not queued in the mainloop more than once. - Removed the source from the mainloop at screen destruction. -2011-03-30 Mirco Müller +2011-03-30 Mirco M?ller A std:: was missing for a successful compile @@ -29972,7 +30498,7 @@ remove texture cache signals -2011-03-30 Mirco Müller +2011-03-30 Mirco M?ller modified: src/BamfLauncherIcon.cpp @@ -30002,15 +30528,15 @@ Didier. This is a major clean-sweep of fixing numerous missing signal-disconnects. Fixes LP: #741961 -2011-03-30 Mirco Müller +2011-03-30 Mirco M?ller Reverted some overly paranoid signal-disconnects -2011-03-29 Mirco Müller +2011-03-29 Mirco M?ller Re-merged with trunk -2011-03-29 Mirco Müller +2011-03-29 Mirco M?ller Added tons of storage for signal-handler connections to allow their proper disconnection upon object destruction. Hopefully fixes numerous segfaults also relating to LP: #741961 @@ -30038,14 +30564,14 @@ Merge from trunk -2011-03-29 Mirco Müller +2011-03-29 Mirco M?ller modified: src/IconLoader.cpp Should fix LP: #742091 -2011-03-28 Mirco Müller +2011-03-28 Mirco M?ller Should fix LP: #742091 @@ -30143,7 +30669,7 @@ Fix for LP: #731212 where 'Applications' and 'Files & Folders' keyboard shortcuts did not align properly Fix for LP: #741346 where shortcut labels did not scale properly -2011-03-28 Mirco Müller +2011-03-28 Mirco M?ller modified: src/SimpleLauncherIcon.cpp @@ -30154,7 +30680,7 @@ the constructor of SimpleLauncherIcon, so they the can be cleanly disconnected upon destruction of SimpleLauncherIcon. Fixing LP: #742110 -2011-03-28 Mirco Müller +2011-03-28 Mirco M?ller Hopefully fixing LP: #742110 @@ -30172,11 +30698,11 @@ - disable all icon popout animations - make all windows minimize to 0,0 -2011-03-25 Alejandro Piñeiro +2011-03-25 Alejandro Pi?eiro [a11y] Added extra states to view and launcher icon accessible objects -2011-03-24 Alejandro Piñeiro +2011-03-24 Alejandro Pi?eiro [a11y] Added extra states to view and launcher icon accessible objects @@ -30375,7 +30901,7 @@ fix magical color changing tiles when setting an icon emblem -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller modified: src/BamfLauncherIcon.cpp @@ -30386,19 +30912,19 @@ application-name label also allows to start/focus the app... just like the launcher-icon itself. Fixes LP: #723877 -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller Ok, let's try that again... *sigh* -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller Make sure app-label in quicklist does start/focus application -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller Use correct order of items. Don't add first separator, if not needed -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller Fix LP: 723877 @@ -30470,11 +30996,11 @@ Beginnings of multiple panel support -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller Oops, forgot to get rid of the debug-output. -2011-03-23 Mirco Müller +2011-03-23 Mirco M?ller added: src/PlacesVScrollBar.cpp @@ -30487,35 +31013,35 @@ implements the styled states (off, hover, pressed) of the scrollbar for the dash according to the mockups from the design-team. Fixes LP: #608124. -2011-03-22 Mirco Müller +2011-03-22 Mirco M?ller Re-merge again with unity trunk... -2011-03-22 Mirco Müller +2011-03-22 Mirco M?ller Adapt to newer API of nux::CairoGraphics -2011-03-21 Mirco Müller +2011-03-21 Mirco M?ller Remove debug-output and png-dumps, use Nux::CairoGraphics::DrawRoundedRectangle() -2011-03-18 Mirco Müller +2011-03-18 Mirco M?ller added the pattern to the over-state of the slider, added the triple stripes to all states of the slider -2011-03-18 Mirco Müller +2011-03-18 Mirco M?ller get the glow going for the different slider-states and the track -2011-03-18 Mirco Müller +2011-03-18 Mirco M?ller textures for track and slider finally match, but redraw on enter/leave still doesn't work and expanding a group causes the track and slider to be cut off at the bottom -2011-03-17 Mirco Müller +2011-03-17 Mirco M?ller checking if textures for scrollbar-slider and track are correctly updated -2011-03-15 Mirco Müller +2011-03-15 Mirco M?ller Derive from nux::VScrollBar so we can overload the drawing later @@ -30551,7 +31077,7 @@ unitymtgrabhandles to require imgpng -2011-03-22 Mirco Müller +2011-03-22 Mirco M?ller modified: src/SimpleLauncherIcon.cpp @@ -30584,7 +31110,7 @@ enables subpixel rendering for StaticCairoText -2011-03-22 Mirco Müller +2011-03-22 Mirco M?ller modified: src/Launcher.cpp @@ -30607,11 +31133,11 @@ which were recently added to nux. Quicklists, Tooltips, Dash, Place-Tiles all still render correctly. -2011-03-22 Mirco Müller +2011-03-22 Mirco M?ller oops, typo -2011-03-22 Mirco Müller +2011-03-22 Mirco M?ller Remove lots of redundant code by adapting to newly added API in nux::CairoGraphics @@ -30625,8 +31151,8 @@ issues, which are covered in bug #716177. With this branch, Unity's PanelMenuView maintains a list of maximized windows. - (Note: When I say “maximized window,” I really mean “a window that Unity has - started decorating instead of the window decorator.” Right now, that is limited + (Note: When I say ?maximized window,? I really mean ?a window that Unity has + started decorating instead of the window decorator.? Right now, that is limited to maximized windows). When the user clicks the top panel, that click affects the front-most of the @@ -30694,29 +31220,29 @@ add a fade and slide option (LP: #739567), ensure that FADE on BFB and slide otherwise is still the defaul -2011-03-22 Alejandro Piñeiro +2011-03-22 Alejandro Pi?eiro [a11y] Emission of children-changed on View and Layout -2011-03-21 Alejandro Piñeiro +2011-03-21 Alejandro Pi?eiro [a11y] Emission of children-changed on View and Layout -2011-03-21 Alejandro Piñeiro +2011-03-21 Alejandro Pi?eiro [a11y] Emission of "children-changed" on View and Layout -2011-03-21 Alejandro Piñeiro +2011-03-21 Alejandro Pi?eiro [a11y] Emission of "children-changed" on View and Layout -2011-03-22 Alejandro Piñeiro +2011-03-22 Alejandro Pi?eiro [a11y] Manual exploration of any BaseWindow children when added Fixes LB#739689 -2011-03-21 Alejandro Piñeiro +2011-03-21 Alejandro Pi?eiro [a11y] Manual exploration of any BaseWindow children when added @@ -30883,7 +31409,7 @@ * Fixed DND; see #727647 -2011-03-18 Loïc Molinari +2011-03-18 Lo?c Molinari Fixed the build renaming file names in POTFILES.in @@ -31114,13 +31640,13 @@ Attach to bug -2011-03-17 Alejandro Piñeiro +2011-03-17 Alejandro Pi?eiro [a11y] Implement atk_[add/remove]_key_event_listener Fixes LB#702672 -2011-03-16 Alejandro Piñeiro +2011-03-16 Alejandro Pi?eiro [a11y] Implement atk_[add/remove]_key_event_listener @@ -31356,7 +31882,7 @@ 2011-03-15 Didier Roche - intermediate commit: X doesn't want to be my friend and show this systray on top, getting a badwindow for an existing value corresponding to the systray… I'm sad + intermediate commit: X doesn't want to be my friend and show this systray on top, getting a badwindow for an existing value corresponding to the systray? I'm sad 2011-03-16 Mikkel Kamstrup Erlandsen @@ -31370,19 +31896,19 @@ We need to do - to / substitution if we don't find the right file by desktop id. Note that the fix is not 110% tight as certain kinds of folder structures will be ignored (the eager reader should experiment with exotic combinations of nested dirs and -'s in folder names :-)). These exotic folder structure have yet to be observed in the wild though - so hopefully no biggie -2011-03-16 Loïc Molinari +2011-03-16 Lo?c Molinari Merged branch unity-ensure-opengl-extensions-availability-at-plugin-init -2011-03-16 Loïc Molinari +2011-03-16 Lo?c Molinari Added OpenGL version check at plugin init -2011-03-16 Loïc Molinari +2011-03-16 Lo?c Molinari Fixed ARB_vertex_program extension name typo -2011-03-15 Loïc Molinari +2011-03-15 Lo?c Molinari Ensured at plugin init that the required OpenGL extensions are supported by the implementation @@ -31404,7 +31930,7 @@ all devices and no devices. I have used gsettings. -2011-03-16 Mirco Müller +2011-03-16 Mirco M?ller modified: resources/round_glow_hl_62x62.png @@ -31414,11 +31940,11 @@ Fixes LP: #728935. Uses design-artwork from LP: #733154. Note #728935 was falsely marked as a duplicate of #733154 -2011-03-11 Mirco Müller +2011-03-11 Mirco M?ller Implemented new launcher key-nav highlight to stand out more clearly. Fixes LP: #728935. Uses design-artwork from LP: #733154 -2011-03-15 Mirco Müller +2011-03-15 Mirco M?ller added: tests/ui/TestQuicklistVisuals.cpp @@ -31432,7 +31958,7 @@ Fixed rendering of disabled Quicklist-items (Label, Checkmark, Radio). Added new visual test-case to ui-tests. Fixes LP: #676928 -2011-03-11 Mirco Müller +2011-03-11 Mirco M?ller Correct rendering of disabled quicklist-items. Add visual-test-case for verification. Fixes LP: #676928 @@ -31476,7 +32002,7 @@ Connect to accessible_desc_update signal on indicatorObject -2011-03-14 Alejandro Piñeiro +2011-03-14 Alejandro Pi?eiro [a11y] Emitting the signal 'children-changed' @@ -31484,7 +32010,7 @@ * UnityRootAccessible: each time a window is added * UnityLauncherAccessible: each time a launcher icon is added/removed -2011-03-14 Alejandro Piñeiro +2011-03-14 Alejandro Pi?eiro [a11y] Emitting the signal 'children-changed' @@ -31492,11 +32018,11 @@ * UnityRootAccessible: each time a window is added * UnityLauncherAccessible: each time a launcher icon is added/removed -2011-03-14 Alejandro Piñeiro +2011-03-14 Alejandro Pi?eiro [a11y] Removing a g_debug -2011-03-14 Alejandro Piñeiro +2011-03-14 Alejandro Pi?eiro [a11y] Emitting the signal 'children-changed' @@ -31512,7 +32038,7 @@ Set the correct ATK parent on A11Y objects -2011-03-14 Alejandro Piñeiro +2011-03-14 Alejandro Pi?eiro [a11y] Revamping a11y unit tests @@ -31520,7 +32046,7 @@ * Moving them to a specific cpp, to maintain unitya11y.cpp with the core a11y support -2011-03-10 Alejandro Piñeiro +2011-03-10 Alejandro Pi?eiro [a11y] Revamping a11y unit tests @@ -31528,14 +32054,14 @@ * Moving them to a specific cpp, to maintain unitya11y.cpp with the core a11y support -2011-03-10 Alejandro Piñeiro +2011-03-10 Alejandro Pi?eiro [a11y] Moving the a11y unit tests to a specific file The idea is maintain unitya11y.cpp for the core of the accessibility support. -2011-03-10 Alejandro Piñeiro +2011-03-10 Alejandro Pi?eiro [a11y] Replacing Quicklist for nux::Layout on one of the unit tests @@ -31753,7 +32279,7 @@ [merge] mircos work -2011-03-08 Mirco Müller +2011-03-08 Mirco M?ller Fix LP: #731096 @@ -31765,7 +32291,7 @@ * Fixed resolution change -2011-03-09 Alejandro Piñeiro +2011-03-09 Alejandro Pi?eiro [a11y] Exposing as ACTIVE and FOCUSED the launcher icon selected @@ -31778,7 +32304,7 @@ Fixes https://bugs.launchpad.net/unity/+bug/727133 Fixes https://bugs.launchpad.net/ubuntu/+source/unity/+bug/729165 -2011-03-09 Alejandro Piñeiro +2011-03-09 Alejandro Pi?eiro [a11y] Exposing as ACTIVE and FOCUSED the launcher icon selected @@ -31791,11 +32317,11 @@ Fixes https://bugs.launchpad.net/unity/+bug/727133 Fixes https://bugs.launchpad.net/ubuntu/+source/unity/+bug/729165 -2011-03-09 Alejandro Piñeiro +2011-03-09 Alejandro Pi?eiro [a11y] Fix the atkobject child-parent hierarchy -2011-03-04 Alejandro Piñeiro +2011-03-04 Alejandro Pi?eiro [a11y] Fix the atkobject child-parent hierarchy @@ -31817,7 +32343,7 @@ [release] 3.6.2 -2011-03-07 Mirco Müller +2011-03-07 Mirco M?ller modified: src/Launcher.cpp @@ -31828,11 +32354,11 @@ duration is set to 1000 ms. We might need to tweak that value depending on user-feedback. Fixes LP: #702486 -2011-03-07 Mirco Müller +2011-03-07 Mirco M?ller protect against application launching if user releases LMB (single finger hold) after the single-finger-hold duration-threshold was passed -2011-03-07 Mirco Müller +2011-03-07 Mirco M?ller and commit the same stuff a third or fourth time... :( @@ -31840,7 +32366,7 @@ Bug #727840: Launcher selection can move past the launchers into nowhere -2011-03-07 Артём Попов +2011-03-07 ????? ????? Don't move Launcher selection below the last launcher. @@ -31883,9 +32409,9 @@ 2011-03-07 Gord Allott - Merging in a branch for Артём Попов - fixes lp:730638 - busy devices now eject properly on the launcher + Merging in a branch for ????? ????? - fixes lp:730638 - busy devices now eject properly on the launcher -2011-03-07 Артём Попов +2011-03-07 ????? ????? Call g_volume_eject_with_operation with a GtkMountOperation (fixes LP: #730638). @@ -32058,7 +32584,7 @@ First bits of sections choosing -2011-03-01 Mirco Müller +2011-03-01 Mirco M?ller removed: resources/bfb.png @@ -32081,7 +32607,7 @@ src/PanelStyle.cpp - Using start-here for Ambience too (and not bfb.png) -2011-03-01 Mirco Müller +2011-03-01 Mirco M?ller modified: src/Launcher.cpp @@ -32092,7 +32618,7 @@ brings different window to the front using Launcher key-nav. Fixes LP: #721811 -2011-02-28 Mirco Müller +2011-02-28 Mirco M?ller Avoid setting the focus back to the previously focused window, when user brings different window to the front using Launcher key-nav. Fixes LP: #721811 @@ -32124,11 +32650,11 @@ Stop breaking my stuff -2011-02-28 Alejandro Piñeiro +2011-02-28 Alejandro Pi?eiro When the keynavmode starts it is also required to emit selection_change -2011-02-28 Alejandro Piñeiro +2011-02-28 Alejandro Pi?eiro When the keynavmode starts it is also required to emit selection_change @@ -32374,17 +32900,17 @@ Use the accessible name from the entries to set the name for PanelIndicatorAccessible class -2011-02-28 Alejandro Piñeiro +2011-02-28 Alejandro Pi?eiro [a11y] AtkSelection implementation Solves: 722660, 723804, 723806 -2011-02-27 Alejandro Piñeiro +2011-02-27 Alejandro Pi?eiro [a11y] Added more type-safed casting, avoiding the previous crashes -2011-02-27 Alejandro Piñeiro +2011-02-27 Alejandro Pi?eiro [a11y] AtkSelection implementation @@ -32490,7 +33016,7 @@ Do not cast guchar pointer to another pointer that requires strict alignment on ARM. Fixes armel FTBFS (LP: #724615) -2011-02-25 Mirco Müller +2011-02-25 Mirco M?ller modified: src/unityshell.cpp @@ -32503,7 +33029,7 @@ https://code.launchpad.net/~mathieu-tl/unity/multimonitor/+merge/50234. This fixes LP: #675862 -2011-02-24 Mirco Müller +2011-02-24 Mirco M?ller This is based on Mathieu Trudel-Lapierre' branch lp:~mathieu-tl/unity/multimonitor and re-merged with trunk and adapted to @@ -32621,17 +33147,17 @@ increase super key tap duration -2011-02-24 Alejandro Piñeiro +2011-02-24 Alejandro Pi?eiro [a11y] Use gconf to check if the accessibility is enabled -2011-02-23 Alejandro Piñeiro +2011-02-23 Alejandro Pi?eiro [a11y] Use gconf to check if the accessibility is enabled Fixes https://bugs.launchpad.net/unity/+bug/723699 -2011-02-24 Mirco Müller +2011-02-24 Mirco M?ller modified: src/Launcher.cpp @@ -32645,23 +33171,23 @@ places-icons get dynamic labels read from localized .place files. Fixes LP: #646712 -2011-02-24 Mirco Müller +2011-02-24 Mirco M?ller make the code more readable, unref textures of superkey-labels in Launcher's destructor -2011-02-24 Mirco Müller +2011-02-24 Mirco M?ller make superkey-shortcuts dynamic for special/places icons, so they automatically adapt to a localized shortcut-binding from .place file -2011-02-23 Mirco Müller +2011-02-23 Mirco M?ller Re-merge with trunk, fixed merge-conflict -2011-02-23 Mirco Müller +2011-02-23 Mirco M?ller made the alpha of the superkey-label bg a bit more opaque -2011-02-23 Mirco Müller +2011-02-23 Mirco M?ller first working version of dynamic superkey-labels for launcher-icons @@ -32777,11 +33303,11 @@ plug a million leaks -2011-02-23 Alejandro Piñeiro +2011-02-23 Alejandro Pi?eiro [a11y] sanity commit meanwhile we move the a11y enabled check to gconf -2011-02-23 Alejandro Piñeiro +2011-02-23 Alejandro Pi?eiro [a11y] sanity commit meanwhile we move the a11y enabled check to gconf @@ -32797,11 +33323,11 @@ I'm stupid -2011-02-22 Alejandro Piñeiro +2011-02-22 Alejandro Pi?eiro [a11y] updating method definition for nux::Object OnDestroyed signal -2011-02-22 Alejandro Piñeiro +2011-02-22 Alejandro Pi?eiro [a11y] Object destruction management @@ -32814,7 +33340,7 @@ Add some temporal custom unit tests. When the issue on the Launcher gets solved will be moved to the unit test framework (with some adaptations). -2011-02-16 Alejandro Piñeiro +2011-02-16 Alejandro Pi?eiro [a11y] Object destruction management @@ -32867,7 +33393,7 @@ Fix for bug #718880 -2011-02-21 Mirco Müller +2011-02-21 Mirco M?ller modified: src/Launcher.cpp @@ -32894,11 +33420,11 @@ no longer crashing on ESC... phew, all UBus-control goes via UnityScreen now, renamed the UBus-signals for key-nav -2011-02-17 Mirco Müller +2011-02-17 Mirco M?ller Merge with trunk -2011-02-17 Mirco Müller +2011-02-17 Mirco M?ller Removed debugging output, got rid of FocusIn/Out callbacks, hooked up ql-key-nav with real functionality, switching from ql-key-nav back to launcher-key-nav still failing, disabled menu-items in ql are not dealt with atm for ql-key-nav @@ -32910,7 +33436,7 @@ Hook up callback to watch the Focus-state on the launcher and quicklist -2011-02-21 Mirco Müller +2011-02-21 Mirco M?ller modified: src/Launcher.cpp @@ -33109,27 +33635,27 @@ [merge] mirco's panel style branch -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller hook up changed-signal -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller fix some of the color-shades, use those in PanelView, base PanelStyle on nux::Object and do ref-counting -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller applied some requested style-changes to the code -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller re-merge with trunk -2010-12-08 Mirco Müller +2010-12-08 Mirco M?ller trying to hooking up the correct colors -2010-12-08 Mirco Müller +2010-12-08 Mirco M?ller new style-handling class for the panel implemented as a singleton @@ -33165,7 +33691,7 @@ Don't pop down the old menu 'till the new menu is up -2011-02-17 Mirco Müller +2011-02-17 Mirco M?ller modified: src/PanelMenuView.cpp @@ -33486,7 +34012,7 @@ Exits launcher keyboard navigation when a launcher icon is dragged (fixes lp:713642). -2011-02-14 Mirco Müller +2011-02-14 Mirco M?ller modified: src/Launcher.cpp @@ -33507,7 +34033,7 @@ Add bug fix from Marc Trevisan to fix minor bugs with long titles -2011-02-10 Marco Trevisan (Treviño) +2011-02-10 Marco Trevisan (Trevi?o) Fading title: consider padding for long titles, don't fade the title too early @@ -33711,7 +34237,7 @@ Merge branch from Marco Trevisan to fade long titles -2011-02-09 Marco Trevisan (Treviño) +2011-02-09 Marco Trevisan (Trevi?o) Using fade effect to cut the window Title when it's longer than the panel @@ -33784,14 +34310,14 @@ merge Marco Trevisan's branch to implement additional hiding modes -2011-02-09 Marco Trevisan (Treviño) +2011-02-09 Marco Trevisan (Trevi?o) Plugin Adapter Focussed window is not needed, using Compiz activeWindow() Compiz already knows which is the focussed / active window, using it instead of my PluginAdapter implementation! -2011-02-09 Marco Trevisan (Treviño) +2011-02-09 Marco Trevisan (Trevi?o) Improved the Always and When Need Hide modes @@ -33801,7 +34327,7 @@ When the hide mode is on on "When Needed", don't consider invalid focussed windows as the ones that could make it show again. -2011-02-08 Marco Trevisan (Treviño) +2011-02-08 Marco Trevisan (Trevi?o) Support for multiple tipes of Hidding modes @@ -33813,11 +34339,11 @@ Plus the AutoHide* functions are now called Hide functions... -2011-02-08 Marco Trevisan (Treviño) +2011-02-08 Marco Trevisan (Trevi?o) Better Autohide option, using the LauncherAutohideMode enum. -2011-02-08 Marco Trevisan (Treviño) +2011-02-08 Marco Trevisan (Trevi?o) Add IntelliHide as an option, to select when enabling AutoHide with intellihide or less @@ -33826,17 +34352,17 @@ - Always (always autohide the bar when there's a window below it) - When needed (autohide the bar only if the focussed window is below it) -2011-02-08 Marco Trevisan (Treviño) +2011-02-08 Marco Trevisan (Trevi?o) Enable real IntelliHide, always for now! :P -2011-02-08 Marco Trevisan (Treviño) +2011-02-08 Marco Trevisan (Trevi?o) Use just the window id as PluginAdapter focussed parameter It's used everywhere, so it's best to keep that! -2011-02-08 Marco Trevisan (Treviño) +2011-02-08 Marco Trevisan (Trevi?o) Add support for focussed window in WindowManager and PluginAdapter @@ -33844,7 +34370,7 @@ merge ATK focus management -2011-02-05 Alejandro Piñeiro +2011-02-05 Alejandro Pi?eiro [a11y] Basic ATK focus management support @@ -33970,11 +34496,11 @@ Ease out of dnd return -2011-02-03 Loïc Molinari +2011-02-03 Lo?c Molinari Fixed the build after merge r818 -2011-02-03 Mirco Müller +2011-02-03 Mirco M?ller added: resources/round_glow_hl_62x62.png @@ -34000,23 +34526,23 @@ for this isn't merged yet), ESC (or opening Quicklist) exits keyboard-navigation of launcher. Fixes LP: #701546 -2011-02-03 Mirco Müller +2011-02-03 Mirco M?ller Re-merge again with unity trunk *sigh* -2011-02-03 Mirco Müller +2011-02-03 Mirco M?ller give callback a better name -2011-02-03 Mirco Müller +2011-02-03 Mirco M?ller Re-merge with unity trunk -2011-02-03 Mirco Müller +2011-02-03 Mirco M?ller Use UBus to cleanly exit from launcher-keyboard-navigation and set input focus back to window, which previously had the input-focus before entering key-nav -2011-02-03 Mirco Müller +2011-02-03 Mirco M?ller modified: src/Launcher.cpp @@ -34029,43 +34555,43 @@ What the hell is going on here with the includes? -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller Rename DoQuicklist() to OpenQuicklist(), extract RecvMouseDown() into OpenQuicklist() -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller Use better separation for methods Activate() and OnMouseClick() -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller remove debug-printfs -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller Merged with current unity trunk -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller Use KeyPressed signal, not KeyReleased one -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller updated commets -2011-02-02 Mirco Müller +2011-02-02 Mirco M?ller Hook up opening a quicklist on keyboard-navigation, keyboard-navigation of the quicklist itself will come from a separate branch -2011-02-01 Mirco Müller +2011-02-01 Mirco M?ller Better preserve state during leaving and entering keyboard-navigation mode -2011-02-01 Mirco Müller +2011-02-01 Mirco M?ller add some preliminary highlight for the launcher keyboard-navigation -2011-02-01 Mirco Müller +2011-02-01 Mirco M?ller modified: src/BamfLauncherIcon.cpp @@ -34087,7 +34613,7 @@ merge pre-multiplied alpha branch -2011-02-01 Loïc Molinari +2011-02-01 Lo?c Molinari Made sure blending is enabled before setting the blend factors @@ -34104,19 +34630,19 @@ src/WindowButtons.cpp - Added calls to SetBlend before setting the blend factors. -2011-02-01 Loïc Molinari +2011-02-01 Lo?c Molinari Merged from main branch -2011-02-01 Loïc Molinari +2011-02-01 Lo?c Molinari Updated to the new SetPremultipliedBlend signature -2011-01-28 Loïc Molinari +2011-01-28 Lo?c Molinari Merge from main branch -2011-01-21 Loïc Molinari +2011-01-21 Lo?c Molinari [rendering] Simplified premultiplied blend states definition @@ -34134,7 +34660,7 @@ src/WindowButtons.cpp - Switched code to the new nux SetPremultipliedBlend() function. -2011-01-21 Loïc Molinari +2011-01-21 Lo?c Molinari [rendering] Switched the panel menu gradient to premultiplied alpha @@ -34142,11 +34668,11 @@ src/PanelMenuView.cpp - Converted menu gradient to premultiplied pixels -2011-01-21 Loïc Molinari +2011-01-21 Lo?c Molinari Merge from main branch -2011-01-20 Loïc Molinari +2011-01-20 Lo?c Molinari [rendering] Switched the rendering to premultiplied alpha blending @@ -34285,11 +34811,11 @@ Add initial stubs to support the com.canonical.Unity.LauncherEntry DBus API in Unity -2011-02-01 Loïc Molinari +2011-02-01 Lo?c Molinari [merge] sigc-trackable-base-class -2011-01-28 Loïc Molinari +2011-01-28 Lo?c Molinari Adapted to new nux::Object API @@ -34366,11 +34892,11 @@ kill unity-panel-service to get the menu back at unity restart (LP: #711289) -2011-02-01 Loïc Molinari +2011-02-01 Lo?c Molinari [merge] disable-lighting-bit -2011-01-31 Loïc Molinari +2011-01-31 Lo?c Molinari [rendering] Disabled the OpenGL lighting bit @@ -34396,7 +34922,7 @@ add scroll event support to the panel service -2011-01-27 Marco Trevisan (Treviño) +2011-01-27 Marco Trevisan (Trevi?o) panel-service: emit "scroll-entry" signal on scroll over an entry @@ -34558,7 +35084,7 @@ Implement edge scrolling on launcher Make expose work reliably -2011-01-31 Alejandro Piñeiro +2011-01-31 Alejandro Pi?eiro [a11y] Added init check system (reintegrating fix reverted in r790) @@ -34702,7 +35228,7 @@ commiting what i have to merge into a different branch -2011-01-27 Mirco Müller +2011-01-27 Mirco M?ller modified: src/Launcher.cpp @@ -34715,7 +35241,7 @@ don't wait for the autohide delay on launcher trigger (key press or dash) if we have already waited the launcher trigger time (LP: #705805) -2011-01-27 Mirco Müller +2011-01-27 Mirco M?ller modified: src/PanelMenuView.cpp @@ -34729,11 +35255,11 @@ Fixes LP: #691651. -2011-01-26 Mirco Müller +2011-01-26 Mirco M?ller correctly disconnect registered callback from old-view before connecting it to new-view -2011-01-26 Mirco Müller +2011-01-26 Mirco M?ller Hooked up the name-changed signal so window-titles of maximized windows get correctly updated, when a tab-focus occurs. Fixes LP: #691651 @@ -34765,7 +35291,7 @@ 2011-01-26 Didier Roche - make unity able to speak sane languages… like French (LP: #697166) + make unity able to speak sane languages? like French (LP: #697166) 2011-01-27 Gord Allott @@ -34775,7 +35301,7 @@ create stub menus when scrubbing over entries without their own menu -2011-01-26 Loïc Molinari +2011-01-26 Lo?c Molinari [a11y] Fixed a NULL pointer critical assertion @@ -34985,7 +35511,7 @@ merge fix for a11y warning on launcher when a11y is not initialized -2011-01-20 Alejandro Piñeiro +2011-01-20 Alejandro Pi?eiro Add the Launcher BaseWindow to the a11y component only if a11y was initialized @@ -34995,7 +35521,7 @@ Make sure we show the launcher before running a test -2011-01-21 Mirco Müller +2011-01-21 Mirco M?ller Make background of PlacesHomeView use proper arc-drawing, thus matching design closer @@ -35124,7 +35650,7 @@ Menus are now redrawn if the mouse is hovering over them during PanelMenuView::PostLayoutManagement (fixes lp:698061) -2011-01-20 Mirco Müller +2011-01-20 Mirco M?ller modified: src/PanelIndicatorObjectEntryView.cpp @@ -35136,11 +35662,11 @@ different paddings for appmenu-items (6 px) and indicators (3 px). Fixes LP: #684114 -2011-01-20 Mirco Müller +2011-01-20 Mirco M?ller Actually make use of the new parameter of the constructor now -2011-01-20 Mirco Müller +2011-01-20 Mirco M?ller Use a padding of 6px for the appmenu and 3px for the other indicators. Fixes LP: #684114 @@ -35284,7 +35810,7 @@ Initial place bits -2011-01-19 Mirco Müller +2011-01-19 Mirco M?ller last obsolete dependency on libunity removed from cmake-list, now compilation works as expected @@ -35314,7 +35840,7 @@ Merge fix for a11y warning -2011-01-14 Alejandro Piñeiro +2011-01-14 Alejandro Pi?eiro [a11y] Little fix to avoid a warning on compilation @@ -35466,7 +35992,7 @@ Merge initial unity atk implementation -2011-01-13 Alejandro Piñeiro +2011-01-13 Alejandro Pi?eiro Initial unity/nux atk module implementation @@ -35514,7 +36040,7 @@ Merge branch to load ATK brige, and dummy atk implementation -2011-01-12 Alejandro Piñeiro +2011-01-12 Alejandro Pi?eiro Initialize the accessibility support if the accessibility is enabled @@ -35556,7 +36082,7 @@ 2011-01-04 Didier Roche - after three, there is four… + after three, there is four? 2011-01-04 Didier Roche @@ -35746,7 +36272,7 @@ fix bug #696780: MAXIMIZE_STATE is a mask composed of horizontal and vertical maximization. Do a real comparison -2011-01-06 Mirco Müller +2011-01-06 Mirco M?ller modified: src/StaticCairoText.cpp @@ -35755,11 +36281,11 @@ Removed some old and commented out code. Corrected slight alignment-issue of text position. Fixes LP: #697791 -2011-01-06 Mirco Müller +2011-01-06 Mirco M?ller Corrected slight alignment-issue of text position. Fixes LP: #697791 -2011-01-06 Mirco Müller +2011-01-06 Mirco M?ller removed lots of old and commented out code @@ -35801,7 +36327,7 @@ added a --replace switch it works the same as unity without switches (runs unity) its only cosmetic to use the same syntax as gnome-panel --replace and gnome-shell --replace -2011-01-06 Mirco Müller +2011-01-06 Mirco M?ller modified: src/QuicklistMenuItem.cpp @@ -35809,7 +36335,7 @@ Make sure the underscore is correctly places under the corresponding accelerator-key. Fixes LP: #683427 -2011-01-06 Mirco Müller +2011-01-06 Mirco M?ller Make sure an underscore is correctly placed under the corresponding accelerator-key. Fixes LP: #683427 @@ -36573,7 +37099,7 @@ respect xdg_config_home -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller modified: src/QuicklistMenuItemRadio.cpp @@ -36584,7 +37110,7 @@ the rendering of the quicklist-radio-item. It also adapts the UI-test for quicklist. Fixes LP: #684048. -2010-12-07 Mirco Müller +2010-12-07 Mirco M?ller fixed drawing of broken ql-radio-item rendering by removing obsolete local member-variables shadowing member-variables of parent-class @@ -36638,17 +37164,17 @@ 2010-12-08 Didier Roche - first unity binary version, still quite hackish on some point, but well… it's a start (LP: #599716) + first unity binary version, still quite hackish on some point, but well? it's a start (LP: #599716) -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller make gcc on natty happy -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller Introspection files needed to be added to the test-quicklist make-target -2010-12-09 Mirco Müller +2010-12-09 Mirco M?ller added: tests/ui/ @@ -36664,39 +37190,39 @@ the first iteration of automated UI-test functionality in unity... starting with Quicklists. Fixes LP: #676040. -2010-12-03 Mirco Müller +2010-12-03 Mirco M?ller added assertions verifying that the fake events actually were received by the underlying dbusmenu-items -2010-12-03 Mirco Müller +2010-12-03 Mirco M?ller use separate thread to inject fake events (mouse-clicks) into event-loop -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller argl -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller trying to get the click-events triggered -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller hookup dummy callback -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller oops -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller got rid of critical-warning from dbusmenu *cough* -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller compiling at least -2010-12-02 Mirco Müller +2010-12-02 Mirco M?ller working on LP: #676040, EventFaker, Quicklist UI-test @@ -36879,7 +37405,7 @@ [modified] src/LauncherIcon.cpp -  src/LauncherIcon.h + ? src/LauncherIcon.h src/QuicklistMenuItem.cpp src/QuicklistMenuItem.h src/QuicklistMenuItemCheckmark.cpp @@ -36906,7 +37432,7 @@ [modified] src/LauncherIcon.cpp -  src/LauncherIcon.h + ? src/LauncherIcon.h src/QuicklistMenuItem.cpp src/QuicklistMenuItem.h src/QuicklistMenuItemCheckmark.cpp @@ -36925,7 +37451,7 @@ [modified] src/LauncherIcon.cpp -  src/LauncherIcon.h + ? src/LauncherIcon.h src/QuicklistMenuItem.cpp src/QuicklistMenuItem.h src/QuicklistMenuItemCheckmark.cpp @@ -37061,27 +37587,27 @@ Don't print debug stuff -2010-11-30 Mirco Müller +2010-11-30 Mirco M?ller merged with trunk, fixed conflicts, got rid of debug-output -2010-11-30 Mirco Müller +2010-11-30 Mirco M?ller really don't call FillInDefaultItems() -2010-11-30 Mirco Müller +2010-11-30 Mirco M?ller make outline-gradient correctly adapt to width of quicklist, don't call FillInDefaultItems() -2010-11-30 Mirco Müller +2010-11-30 Mirco M?ller fix the padding and intensity of the separator, fix the gradient on the outline -2010-11-30 Mirco Müller +2010-11-30 Mirco M?ller fix padding around radiobutton point -2010-11-30 Mirco Müller +2010-11-30 Mirco M?ller fix padding around items and checkmarks @@ -37321,7 +37847,7 @@ Remove useless comments, this is not an example plugin -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller added: src/QuicklistMenuItem.cpp @@ -37353,31 +37879,31 @@ (minus pending visual polish) and solves the comma-vs-decimal-point issues with Tooltips seen on some non-english locales. -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller make StaticCairoText use GtkSettings for pulling system-wide font-settings, removed unneeded SetFontWeight() & Co -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller even more removal of code-redundancy, moved DrawText() to parrent-class QuicklistMenuItem, got rid of custom SetFontName() & Co -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller more code-redundancy removal, keep GetTextExtents() only within parent-class QuicklistMenuItem -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller move DrawRoundedRectangle() to parent-class QuicklistMenuItem to avoid code-redundancy -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller time-stamp fix to avoid conflict with trunk during merge -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller Got rid of GetDPI() and _fontOpts, now using GtkSettings to pull screen's DPI and font-options from system -2010-11-25 Mirco Müller +2010-11-25 Mirco M?ller Merge back with changes from Jay. @@ -37434,7 +37960,7 @@ * Fixes and corrections -2010-11-24 Mirco Müller +2010-11-24 Mirco M?ller got rid of conditional compiler-directives @@ -37476,11 +38002,11 @@ Merged -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller added rounded rect. for Label-item -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller rounded rectangle for active/prelight item working now @@ -37492,19 +38018,19 @@ Merged -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller fixed indentation issue -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller trying to fix the text-indentation -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller re-merge with branch -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller implemented rendering for the radio-button-ql-menuitems, fixed some mem-leaks @@ -37516,11 +38042,11 @@ * Quicklist check mark -2010-11-23 Mirco Müller +2010-11-23 Mirco M?ller implemented rendering for Checkmark-quicklist-item -2010-11-22 Mirco Müller +2010-11-22 Mirco M?ller temp. test for trying to see if we get the different item-types via the dbusmenu @@ -37535,11 +38061,11 @@ * YOU NEED TO UPDATE NUX * Fixed QuicklistMenuItem tests -2010-11-19 Mirco Müller +2010-11-19 Mirco M?ller merge back with changes from Jay -2010-11-19 Mirco Müller +2010-11-19 Mirco M?ller added thread-helpers to make testing the QuicklistMenuItems work, before they failed with a segfault because the nux-event-loop wasn't in place @@ -37551,15 +38077,15 @@ * Merged with Mirco's separator -2010-11-19 Mirco Müller +2010-11-19 Mirco M?ller Added commented code-section for later use. -2010-11-19 Mirco Müller +2010-11-19 Mirco M?ller Remerged with parent branch. -2010-11-19 Mirco Müller +2010-11-19 Mirco M?ller Separator is rendered now, width and allocated space still need some work @@ -37583,15 +38109,15 @@ * Merged Mirco's QuicklistMenuItem work with trunk. -2010-11-18 Mirco Müller +2010-11-18 Mirco M?ller get the other tests in place, add the sigc-callback for the debugging -2010-11-18 Mirco Müller +2010-11-18 Mirco M?ller missed the View-related calls -2010-11-18 Mirco Müller +2010-11-18 Mirco M?ller inital commit, doesn't compile atm, still missing much @@ -37617,7 +38143,7 @@ 2010-11-25 Didier Roche - final list of natty defaults… for now + final list of natty defaults? for now 2010-11-24 Didier Roche @@ -38006,8 +38532,8 @@ src/LauncherIcon.h src/QuicklistView.cpp src/QuicklistView.h -  src/StaticCairoText.cpp -  src/StaticCairoText.h + ? src/StaticCairoText.cpp + ? src/StaticCairoText.h src/Tooltip.cpp src/Tooltip.h src/unity.cpp @@ -38376,7 +38902,7 @@ [merge] trunk -2010-11-11 Mirco Müller +2010-11-11 Mirco M?ller modified: src/LauncherIcon.cpp @@ -38387,7 +38913,7 @@ them visually distinct from quicklists. Thus users don't feel they are meant to be clickable. -2010-11-10 Mirco Müller +2010-11-10 Mirco M?ller make tooltips look more like notify-osd (visually distinct from quicklists) to prevent users thinking they can click them @@ -38875,7 +39401,7 @@ * Use Gee to manage lists of GObjects instead of G*List which have unclear memory semantics - * There are still leaks. Sorry :´-| + * There are still leaks. Sorry :?-| 2010-09-29 Mikkel Kamstrup Erlandsen @@ -39020,7 +39546,7 @@ Fix crasher when place daemons failed to start up on DBus activation. -2010-09-24 Mirco Müller +2010-09-24 Mirco M?ller modified: unity-private/panel/panel-home-button.vala @@ -39030,11 +39556,11 @@ panel's home-button. This needs to go alongside unity-asset-pool rev. 48 Fixes LP: #644686 -2010-09-24 Mirco Müller +2010-09-24 Mirco M?ller Use an updated cof-logo icon for the home-button. This needs a newer version of unity-asset-pool (rev. 48). Fixes LP: #644686 -2010-09-24 Mirco Müller +2010-09-24 Mirco M?ller modified: unity-private/launcher/scroller-view.vala @@ -39044,7 +39570,7 @@ box. Rounded corners are a bit smaller. This is for the Maverick RC. Fixes LP: #633069 -2010-09-24 Mirco Müller +2010-09-24 Mirco M?ller Make keyboard-shortcut overlays a bit nicer. Rounded corners are a bit smaller now. Text is crisper and centered. Fixes LP: #633069 @@ -39287,7 +39813,7 @@ Ensure we dont process any window that is already too big for the stage -2010-09-22 Mirco Müller +2010-09-22 Mirco M?ller modified: unity-private/places/places-place-search-navigation.vala @@ -39297,11 +39823,11 @@ lowered opacity to better indicate being insensitive, thus the user does not accidentally assume they can be pressed. Fixes LP: #638285 -2010-09-21 Mirco Müller +2010-09-21 Mirco M?ller Made the insensitive state of the forward- and back-button more obvious by decreasing their opacity, thus users don't assume they are actually clickable. Fixes LP: #638285 -2010-09-22 Mirco Müller +2010-09-22 Mirco M?ller modified: targets/mutter/window-management.vala @@ -39312,7 +39838,7 @@ restore force activate function using timeout of 0 instead of idle. This seems to eliminate the crash -2010-09-22 Mirco Müller +2010-09-22 Mirco M?ller modified: unity-private/places/places-button.vala @@ -39378,7 +39904,7 @@ being safe when people are using crazy caracters in desktop file (LP: #644114, #635156) -2010-09-22 Mirco Müller +2010-09-22 Mirco M?ller modified: unity-private/panel/panel-indicator-object-entry-view.vala @@ -39388,11 +39914,11 @@ no longer reactive, thus the user can't activate them with the mouse or keyboard as intended. Fixes LP: #604505 -2010-09-21 Mirco Müller +2010-09-21 Mirco M?ller Make insensitive menu really inactive, when window is initially focused (program is started). Fixes LP: #604505 -2010-09-22 Mirco Müller +2010-09-22 Mirco M?ller modified: unity-private/launcher/quicklist-menu-item.vala @@ -39402,7 +39928,7 @@ the clutter-warning about relayout happening during an allocation cycle. Fixes LP: #643315 -2010-09-21 Mirco Müller +2010-09-21 Mirco M?ller use timeout again, fixes LP: #643315 (quicklist items having different widths) and the other regression of clutter spitting out warnings about relayout being performed during an allocation cycle @@ -39454,7 +39980,7 @@ unity-private/launcher/quicklist-radio-menu-item.vala unity-private/launcher/quicklist-seperator-menu-item.vala -2010-09-21 Mirco Müller +2010-09-21 Mirco M?ller modified: unity-private/launcher/quicklist-controller.vala @@ -39463,7 +39989,7 @@ Make sure the anchor-position/offset of label and quicklist is really the same. Fixes LP: #631446. -2010-09-21 Mirco Müller +2010-09-21 Mirco M?ller use same offset for label and quicklist, should fix LP: #631446 for real now @@ -39572,7 +40098,7 @@ fix issue where youtube videos did not stay fullscreen -2010-09-16 Mirco Müller +2010-09-16 Mirco M?ller modified: unity-private/panel/panel-indicator-object-entry-view.vala @@ -39582,15 +40108,15 @@ are correctly handled, thus the menu (parent) gets correctly shown or hidden and no "gap" is left on the global menu. Fixes LP: #600191 -2010-09-16 Mirco Müller +2010-09-16 Mirco M?ller cover all possible cases of image and label being shown or not, removed debug ouput -2010-09-16 Mirco Müller +2010-09-16 Mirco M?ller getting closer -2010-09-16 Mirco Müller +2010-09-16 Mirco M?ller trying to fix the gap issue @@ -39637,7 +40163,7 @@ Remove inappropriate comment string -2010-09-15 Mirco Müller +2010-09-15 Mirco M?ller modified: .bzrignore @@ -39649,23 +40175,23 @@ opacity. It also makes sure insensitive menus can't be accessed by the mouse or keyboard-navigation. Fixes LP: #604505 -2010-09-15 Mirco Müller +2010-09-15 Mirco M?ller make sure the insensitive menu is also skipped if the user navigates with the cursor-keys -2010-09-15 Mirco Müller +2010-09-15 Mirco M?ller don't allow mouse-clicks on insensitive entries/menus -2010-09-15 Mirco Müller +2010-09-15 Mirco M?ller handle changes/updates to the state of the sensitive-flag for label and image -2010-09-15 Mirco Müller +2010-09-15 Mirco M?ller render insensitive menu-labels/images with only a quarter of the normal opacity -2010-09-15 Mirco Müller +2010-09-15 Mirco M?ller ignore intermediate C-files @@ -39689,7 +40215,7 @@ Beginnings of a context stack -2010-09-14 Mirco Müller +2010-09-14 Mirco M?ller modified: unity-private/launcher/scroller-controller.vala @@ -39698,11 +40224,11 @@ This avoids the crash on Super-key-shortcuts with places. Fixes LP: #632460 -2010-09-14 Mirco Müller +2010-09-14 Mirco M?ller add a warning() and FIXME-remark for the failure-case -2010-09-14 Mirco Müller +2010-09-14 Mirco M?ller Added some debug-output for testing @@ -39754,7 +40280,7 @@ Update POTFILES.in with missing source files with translatable strings. This fixes bug #637128: "lot of strings can't be translated..." -2010-09-14 Mirco Müller +2010-09-14 Mirco M?ller added: unity-private/panel/panel-divider.vala @@ -39769,15 +40295,15 @@ hold the dividing groove artwork. Fixes LP: #636602. This needs unity-asset-pool rev. 44. -2010-09-13 Mirco Müller +2010-09-13 Mirco M?ller make sure the divider/groove is not visible when the shell is shown -2010-09-13 Mirco Müller +2010-09-13 Mirco M?ller removed unused boolean flag -2010-09-13 Mirco Müller +2010-09-13 Mirco M?ller Add class Unity.Panel.Divider to extract the groove from the home-button to a separate actor. This branch needs to go along with lp:~unity-team/unity-asset-pool/unity-asset-pool.fix-636602 because of new artwork. Fixes LP: #636602 @@ -39819,7 +40345,7 @@ This fixes bug #632203: "Log apps launched via unity-place-applications" -2010-09-13 Mirco Müller +2010-09-13 Mirco M?ller modified: unity-private/launcher/quicklist-controller.vala @@ -39829,11 +40355,11 @@ launcher-icon/tile and fully aligns with the triangle indicating the focused application. Fixes LP: #631446. -2010-09-13 Mirco Müller +2010-09-13 Mirco M?ller make sure the anchor-arrow aligns with the focused-triangle indicating the current app. -2010-09-13 Mirco Müller +2010-09-13 Mirco M?ller Correct the offset of the quicklist so it doesn't jump to the right when expanding from a tooltip. Fixes LP: #631446 @@ -39903,7 +40429,7 @@ add migrate favorite script and distribute it -2010-09-09 Mirco Müller +2010-09-09 Mirco M?ller modified: unity-private/panel/panel-home-button.vala @@ -39913,7 +40439,7 @@ edge of the launcher. It was off by two pixels. By adding two to the to the query of the launcher-width this is now corrected. Fixes LP: #630031. -2010-09-08 Mirco Müller +2010-09-08 Mirco M?ller Fix width of home-button on panel, so groove aligns with right edge of launcher, fixes LP: #630031 @@ -39953,11 +40479,11 @@ Some batchprocessing for pixbuf loading -2010-09-03 Mirco Müller +2010-09-03 Mirco M?ller Forgot to remove the debug()-calls -2010-09-03 Mirco Müller +2010-09-03 Mirco M?ller Merged Neil's fix-places-memleaks branch after review and approval. Fixes numerous mem-leaks in Places and Quicklists. @@ -40043,7 +40569,7 @@ fixes the scroller so that its scrolls correctly for the use case of having not enough icons to fill the launcher -2010-08-30 Mirco Müller +2010-08-30 Mirco M?ller modified: unity-private/places/places-default-renderer.vala @@ -40051,19 +40577,19 @@ Merged (with small suggested fixes) after review and approval from Mikkel into trunk. This brings the scrollbar closer to the mockups from Design. -2010-08-28 Mirco Müller +2010-08-28 Mirco M?ller add glow to slider -2010-08-28 Mirco Müller +2010-08-28 Mirco M?ller support drawing the three different styles for the slider depending on its 'state': normal, prelight, active... 'state'-handling should be done properly in Ctk.ScrollView -2010-08-27 Mirco Müller +2010-08-27 Mirco M?ller forgot to use update() instead of do_queue_redraw() for Unity.CairoCanvas -2010-08-27 Mirco Müller +2010-08-27 Mirco M?ller added missing background-pattern to trough, added striped pattern to prelight slider, work-around state-handling for slider still not working @@ -40374,7 +40900,7 @@ Beginnings of gesture dispatcher -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller modified: unity-private/launcher/scrollerchild-controller.vala @@ -40391,7 +40917,7 @@ quick fix to stop places segfaulting unity -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller modified: unity-private/launcher/quicklist-controller.vala @@ -40417,7 +40943,7 @@ new scroller animations finished -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller modified: unity-private/places/places-default-renderer.vala @@ -40425,19 +40951,19 @@ Merged branch unity.fix-608124 into trunk after review and approval from Jason. Fixes LP: #608124. -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller put custom rendering of slider and trough into place, different states are not supported by Ctk.ScrollView yet, more pixel-tweaking could be done -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller hm... state-changes are not triggered -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller make sure stuff is actually visible -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller just see if the boiler-plate for the new scrollbar-rendering works @@ -40491,7 +41017,7 @@ disable rectangle -2010-08-26 Mirco Müller +2010-08-26 Mirco M?ller modified: unity-private/testing/background.vala @@ -40500,7 +41026,7 @@ picture-options for wallpaper and gradients are now taken into account. This fixes LP: #605788. Also fixes LP: #617084. -2010-08-25 Mirco Müller +2010-08-25 Mirco M?ller Using different approach to pull wallpaper/gradient from GnomeBG. Fixes LP: #605788. Also fixes LP: #617084 @@ -40634,7 +41160,7 @@ Add an error trap around the offending X call -2010-08-23 Mirco Müller +2010-08-23 Mirco M?ller modified: unity-private/panel/panel-home-button.vala @@ -40643,7 +41169,7 @@ there are problems with the effect-caching, which sometimes don't switch off the glow or do not allow it to appear in the first place. -2010-08-20 Mirco Müller +2010-08-20 Mirco M?ller re-submit the patch for LP: #592787 @@ -40739,7 +41265,7 @@ beginnings of home place -2010-08-19 Mirco Müller +2010-08-19 Mirco M?ller modified: unity-private/launcher/quicklist-check-menu-item.vala @@ -40757,15 +41283,15 @@ a tooltip is now also indented (balanced with a gap on the right side too... this was done after consulting Design). -2010-08-18 Mirco Müller +2010-08-18 Mirco M?ller After consultation with Otto about the issue with the item-indentation between tooltips and quicklists - in regards to the expand-animation - I added a larger margin on the right side for tooltips too so they look a bit more balanced. This is an intermediate solution until we have something better from design. -2010-08-18 Mirco Müller +2010-08-18 Mirco M?ller change checkmark- and radiobutton-rendering again, indent all items labels -2010-08-19 Mirco Müller +2010-08-19 Mirco M?ller modified: targets/mutter/Makefile.am @@ -40826,7 +41352,7 @@ Show workspaces tooltip -2010-08-19 Mirco Müller +2010-08-19 Mirco M?ller modified: configure.ac @@ -40880,14 +41406,14 @@ ensure we prelight properly to give hints as to where drags will land -2010-08-18 Mirco Müller +2010-08-18 Mirco M?ller Merged branch unity.fix-592787-2 after review and approval from Gordon. This needs to go alongside unity-asset-pool rev. 36, which provides up- dated visuals for the ubuntu-home-button. Fixing regression of former fix of LP: #592787 -2010-08-18 Mirco Müller +2010-08-18 Mirco M?ller reverted commit 412, thus re-enabling rendering different backgrounds for different button-states, this needs to go along with unity-asset-pool rev. 36, fixing LP: #592787 @@ -41085,7 +41611,7 @@ Release 0.2.24 -2010-08-05 Mirco Müller +2010-08-05 Mirco M?ller modified: unity-private/launcher/quicklist-check-menu-item.vala @@ -41099,35 +41625,35 @@ This implements new custom rendering for radiobutton- and checkmark-items in quicklists according to mockups from the Design-team. -2010-08-05 Mirco Müller +2010-08-05 Mirco M?ller Resolved a diversion between my branch unity.fix-607251 and trunk. -2010-08-05 Mirco Müller +2010-08-05 Mirco M?ller using the indentation-value Otto told me during the sprint in Prague -2010-08-05 Mirco Müller +2010-08-05 Mirco M?ller doh, my brain doesn't work sometimes -2010-08-04 Mirco Müller +2010-08-04 Mirco M?ller clean up, further tweak and polish radio- and checkmark-item rendering -2010-08-04 Mirco Müller +2010-08-04 Mirco M?ller clean up -2010-08-04 Mirco Müller +2010-08-04 Mirco M?ller tried to make warning more verbose, but type-reporting doesn't work... only get (null) printed out -2010-08-04 Mirco Müller +2010-08-04 Mirco M?ller clean up, abuse for debugging radio-button item because no app is using radio-buttons in their exposed menu-definitions, trying to write a stand-alone test-app which does this is not possible as dbusmenu reports errors if one uses GtkToggleActionEntry -2010-07-28 Mirco Müller +2010-07-28 Mirco M?ller add radiobutton item, with guess-work @@ -41652,7 +42178,7 @@ fixes the launcher focus problem also sets the focus to the active -2010-07-23 Mirco Müller +2010-07-23 Mirco M?ller modified: unity-private/launcher/quicklist-check-menu-item.vala @@ -41665,7 +42191,7 @@ from any quicklist-items. Putting checkmark- and radio-buttons on the left side of labels. -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller added regex-based string-replacement for labels, strip underscores from any quicklist-items, put checkmarks and radio-buttons on the left side of labels @@ -41857,49 +42383,49 @@ implement workspace overview -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller Merged unity.fix-592787 after review and approval from Jason. This fixes LP: #592787 providing the user with a visual hint that the COF/BFB is clickable. -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller Got rid of temp. local file in branch. Will be part of unity-asset-pool. -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller Got rid of temp. local file in this branch. Will be part of unity-asset-pool. -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller properly catch exceptions for loading state-background texture-images, don't use the glow for now as it does not correctly update on state-changes of the button, load texture-images from correct system-wide path -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller adding missed normal-texture -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller added self-drawn artwork not provided by the design-team until we can move it into unity-asset-pool -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller revert the fiddling around with class ThemeImage -2010-07-22 Mirco Müller +2010-07-22 Mirco M?ller Made theme_image a Ctk.Image to restrict the glow only to the logo and avoid the glow being applied to the rectangular area of the button. -2010-07-21 Mirco Müller +2010-07-21 Mirco M?ller set a different background depending on state to mimick the pressed-down status of the button -2010-07-21 Mirco Müller +2010-07-21 Mirco M?ller There was actually a bug in theme.vala, initially preventing CtkEffects to work with a CtkButton. Now switched back to using CtkEffectGlow on the home-button. -2010-07-21 Mirco Müller +2010-07-21 Mirco M?ller change using different texture for the three different button-states @@ -41915,11 +42441,11 @@ 2010-07-22 Didier Roche - More i18n love and remove … + More i18n love and remove ? 2010-07-22 Didier Roche - More i18n love and remove … + More i18n love and remove ? 2010-07-22 Didier Roche @@ -41929,12 +42455,12 @@ because Gord is a i18n hater :) -2010-07-19 Mirco Müller +2010-07-19 Mirco M?ller Merged unity.fix-592817-resolved after review and approval from Gordon, which is actually unity.fix-592817 conflict-resolved. Fixes LP: #592817 -2010-07-16 Mirco Müller +2010-07-16 Mirco M?ller solving merge-conflict by reworking patch, because trunk completely again under the feet of this branch @@ -41954,7 +42480,7 @@ move window clones to be above window group to avoid clipping issues -2010-07-16 Mirco Müller +2010-07-16 Mirco M?ller Merged unity.fix-599718-resolved into trunk after review and approval from Gordon. This is an extended "resolve merge conflicts" of the @@ -41973,21 +42499,21 @@ unity-private/launcher/quicklist-seperator-menu-item.vala unity-private/launcher/quicklist-view.vala -2010-07-16 Mirco Müller +2010-07-16 Mirco M?ller Resolved merge-conflicts between trunk and unity.fix-599718 and adapted all new quicklist-menu-items (radio, checkmark, image) to use the timeout approach for updating their backgrounds when their allocation changed. -2010-07-15 Mirco Müller +2010-07-15 Mirco M?ller Added queueing up redraws for quicklist-items again. -2010-07-13 Mirco Müller +2010-07-13 Mirco M?ller Extract the remaining background-creation calls for separators and items in a timeout-handler -2010-07-13 Mirco Müller +2010-07-13 Mirco M?ller trying to fix LP: #599718, still segfaulting though @@ -42227,7 +42753,7 @@ make sure to queue relayout after re-ordering children -2010-07-15 Mirco Müller +2010-07-15 Mirco M?ller Merged branch unity.fix-594232 into trunk after review and approval from Neil. With this GNOME background-settings (gradient, wallpaper) are now @@ -42235,31 +42761,31 @@ to be implemented are filed as 605788 (support all picture-options) and 605442 (wallpaper-slideshow support). Fixes LP: #594232 -2010-07-15 Mirco Müller +2010-07-15 Mirco M?ller updated fallback-color to provided values by design-team, only picture-options tiled and scaled work -2010-07-15 Mirco Müller +2010-07-15 Mirco M?ller no matter what I try I can't get the image to change its size, altering the size of the parent container yields a whole other can of worms -2010-07-14 Mirco Müller +2010-07-14 Mirco M?ller trigger first update of either image or gradient upon allocation-change of Ctk.Bin -2010-07-14 Mirco Müller +2010-07-14 Mirco M?ller pulling from image/gradient background-settings from gconf work now, also upon startup -2010-07-14 Mirco Müller +2010-07-14 Mirco M?ller why on earth isn't _on_changed() called -2010-07-14 Mirco Müller +2010-07-14 Mirco M?ller only use Gnome.BG, trying to hook up to the changed- and transitioned-signals -2010-07-13 Mirco Müller +2010-07-13 Mirco M?ller trying to hook up monitoring background gradient-shading values with cairo-texture-generation @@ -42267,7 +42793,7 @@ Add libgnomeui-2.0 dep and fix vapi -2010-07-13 Mirco Müller +2010-07-13 Mirco M?ller trying to get gnome_bg_*() calls accessable via vala @@ -42522,7 +43048,7 @@ fixes not being able to drag to the end of the scroller bug #595819 -2010-06-30 Mirco Müller +2010-06-30 Mirco M?ller modified: unity-private/launcher/quicklist-view.vala @@ -42548,7 +43074,7 @@ * second optional dynamic part which can grow (using texture-repeating) * bottom -2010-06-30 Mirco Müller +2010-06-30 Mirco M?ller added new texture-parts rendering for the quicklist/tooltip background, old calls not been deleted intentionally, that removal will come with hooking these new calls up to CtkMenuExpandable, added temp. image-dumps in constructor for verification of rendering @@ -42657,7 +43183,7 @@ - Call do_queue_redraw when the mouse leaves or enters an item -2010-06-28 Mirco Müller +2010-06-28 Mirco M?ller modified: targets/mutter/plugin.vala @@ -42666,7 +43192,7 @@ Neil. This fixes LP: #578545 where the wrong strut caused windows to be positioned slightly under the launcher. -2010-06-25 Mirco Müller +2010-06-25 Mirco M?ller set the correct values for the desktop-strut, fixes LP: #578545 @@ -42793,7 +43319,7 @@ small fix to unity icon rendering to have less fuzzy text -2010-06-24 Mirco Müller +2010-06-24 Mirco M?ller modified: unity-private/panel/panel-indicator-object-entry-view.vala @@ -43080,7 +43606,7 @@ Remove dependency on toplevel patch -2010-06-21 Mirco Müller +2010-06-21 Mirco M?ller Merged unity.fix-595880-2 branch into trunk after review and approval from Jay. @@ -43094,7 +43620,7 @@ Completes fix for LP: #595880. -2010-06-21 Mirco Müller +2010-06-21 Mirco M?ller Really make sure clicks on home-button, empty launcher-area and launcher-icon also close any open panel/indicator menu @@ -43118,11 +43644,11 @@ debugging -2010-06-18 Mirco Müller +2010-06-18 Mirco M?ller Merged branch unity.fix-595880 after review and approval from Jay. -2010-06-18 Mirco Müller +2010-06-18 Mirco M?ller added popdown_current_menu() to MenuManager so clicks in empty panel-areas close any open menu, fixes LP: #595880 @@ -43148,7 +43674,7 @@ [release] 0.2.10 -2010-06-17 Mirco Müller +2010-06-17 Mirco M?ller fixed segfault in on_leave for quicklists, removed superfluous calls to queue-redraw @@ -43557,16 +44083,16 @@ Remove large section of out commented obsolete code -2010-06-07 Mirco Müller +2010-06-07 Mirco M?ller updated cogl vala-bindings to cover cogl_clip_push_rectangle(), parameter-names have been kept in line with generated names to trim possible diffs (for Gordon's sake :) in the future -2010-06-07 Mirco Müller +2010-06-07 Mirco M?ller Merged unity.quicklist-visual-tweaks branch after review and approval from Neil. -2010-06-04 Mirco Müller +2010-06-04 Mirco M?ller tweaked corner-radii/anchor-size/spacing/positioning for tooltips and quicklists to fulfill design-requirements, pulling screen-dpi from GtkSettings since Xorg doesn't provide right one @@ -43762,27 +44288,27 @@ Merge + Work on indicator menu scrubbing -2010-06-03 Mirco Müller +2010-06-03 Mirco M?ller merged in branch unity.panel-home-button -2010-06-03 Mirco Müller +2010-06-03 Mirco M?ller finally made the added shell-interface-API work by adding/renaming the calls get_panel_height_foobar() and get_launcher_width_foobar() so they don't clash with what's already defined in unity/targets/mutter/main.c -2010-06-02 Mirco Müller +2010-06-02 Mirco M?ller added get_panel_height() to shell interface and implemented it for mutter-target and tests, used in PanelHomeButton -2010-06-01 Mirco Müller +2010-06-01 Mirco M?ller make sure the new test for the panel-home-button gets called -2010-06-01 Mirco Müller +2010-06-01 Mirco M?ller source files need to be specified in alphabetical order -2010-06-01 Mirco Müller +2010-06-01 Mirco M?ller added test for new panel-home-button @@ -43936,7 +44462,7 @@ Merge -2010-05-31 Mirco Müller +2010-05-31 Mirco M?ller panel-home-button added @@ -44486,12 +45012,12 @@ big re-arch to new mvc pattern for launcher -2010-04-27 Mirco Müller +2010-04-27 Mirco M?ller Merged move-ql-rendering-in-libunity branch into trunk after review and approval from Gordon. -2010-04-26 Mirco Müller +2010-04-26 Mirco M?ller refactoring work for UI-layer, move all cairo-rendering from Quicklist into libunity @@ -45031,41 +45557,41 @@ modified: libunity/chrome-handler.vala -2010-03-30 Mirco Müller +2010-03-30 Mirco M?ller Merged my unity_fix-550961 branch after review and approval from Gordon. Fixes LP: #550961. -2010-03-30 Mirco Müller +2010-03-30 Mirco M?ller After a lot of ping-pong-ing screenshots with Design (Otto, Michael) of different settings being applied to background, blur, highlight/sheen and position, the Quicklists are now as Design wants them to look. Fixes LP: #550961. -2010-03-29 Mirco Müller +2010-03-29 Mirco M?ller Use an opacity of 50% for the background tint of the Quicklist. This improves the contrast of the white text of Quicklist-entries (and Tooltips) against any potential bright areas behind the Quicklist/Tooltip. Fixes LP: #550961. -2010-03-29 Mirco Müller +2010-03-29 Mirco M?ller Merged my unity_fix-550966 branch after review and approval from Jay and Gordon. This fixes LP: #550966. -2010-03-29 Mirco Müller +2010-03-29 Mirco M?ller Don't mark any Quicklist/Tooltip entry as in-sensitive. Only Droplists will use that later. Fixes LP: #550966. -2010-03-29 Mirco Müller +2010-03-29 Mirco M?ller Merged my unity_fix-550964 branch after review and approval from Jay. This fixes LP: #550964. -2010-03-29 Mirco Müller +2010-03-29 Mirco M?ller Fix alignment of quicklist/tooltip anchor-arrow with running/focused arrow of quicklauncher-icon. Fixes LP: #550964. @@ -45107,22 +45633,22 @@ tiny change to the desktop file string that chromium-webapp support uses so that we open in a new tab not a new webapp -2010-03-26 Mirco Müller +2010-03-26 Mirco M?ller Merged my unity_fix-54700 branch after review and approval from Gordon. This fixes LP: #54700. -2010-03-25 Mirco Müller +2010-03-25 Mirco M?ller Increase thickness of outline and separator a bit to make them render cleaner. Fixes LP: #54700. -2010-03-26 Mirco Müller +2010-03-26 Mirco M?ller Merged my unity_fix-538989 branch after review and approval from Gordon. This fixes LP: #538989. -2010-03-16 Mirco Müller +2010-03-16 Mirco M?ller make insensitive QuickList-entries italic and half transparent, main label/tooltip is insensitive by default now @@ -45208,16 +45734,16 @@ mutter-plugin/plugin.vala src/quicklauncher/quicklauncher-manager.vala -2010-03-25 Mirco Müller +2010-03-25 Mirco M?ller Merged my unity_fix-531448 branch after review and approval from Gordon. This fixes LP: #531448. -2010-03-24 Mirco Müller +2010-03-24 Mirco M?ller forgot to remove the debug-output -2010-03-24 Mirco Müller +2010-03-24 Mirco M?ller Comply to the "Activating a Launcher entry with the cursor"-use-case hiding the label when the user clicks a launcher, fixes LP: #531448 @@ -45318,12 +45844,12 @@ small fix into unity ql-view, calls base.allocate only after the check to see if we need to allocate -2010-03-24 Mirco Müller +2010-03-24 Mirco M?ller Merged my unity_fix-542016 branch after review and approval from Gordon. This fixes LP: #542016. -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller using absolute values for margin and border, this breaks resolution-independence, Design stated 19px although the mockup provided showed 18px, I split it 14px for margin and 5px for border thus 19px altogether, fixes LP: #542016 @@ -45451,31 +45977,31 @@ few small updates into the launcher, scroller now disconnects drag mode on mouse up properly, launcher sensitivity increased and the scroller background repeats on the x axis -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller Merged my unity_fix-542006 branch after review and approval from Jay. This fixes LP: #542006. Still needed a small tweak for the left side of the Quicklist-outline. -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller using absolute values for corner-radius, item-corner-radius, anchor-width/height at the cost of resolution-independence, this will break if font-sizes become very small, absolute values for item-corner-radius, anchor-width/height still have not been provided by Design, so I'm doing best-guessing here, fixes LP: #542009 -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller Merged my unity_fix-542008 branch after review and approval form Jay. This fixes LP: #542008. -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller changed the highlight background texture to be less intense, fixes LP: #542008 -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller Merged my unity_fix-542006 branch after review and approval from Jay. This fixes LP: #542006. -2010-03-23 Mirco Müller +2010-03-23 Mirco M?ller Best attempt to do pixel-grid aligned drawing of outline and separators, adjusting outline- and separator opacity to match design-mockups (not values), fixes LP: #542006 @@ -45507,7 +46033,7 @@ [merge] fix gconf -2010-03-18 Mirco Müller +2010-03-18 Mirco M?ller removed the double quotes from the search_template key, fixes LP: #540870 @@ -45616,25 +46142,25 @@ set non sticky launchers to be +10000 priority instead of minus -2010-03-11 Mirco Müller +2010-03-11 Mirco M?ller Merged my unity_fix-526334-2 branch implementing the separator for the Quicklist. Made the horizontal pixel-grid alignment more robust. This fixes LP: #526334 -2010-03-11 Mirco Müller +2010-03-11 Mirco M?ller improved the pixel-grid-alignment method -2010-03-11 Mirco Müller +2010-03-11 Mirco M?ller force the separator-line to be one pixel thick and align to the pixel-grid -2010-03-11 Mirco Müller +2010-03-11 Mirco M?ller believe it or not, the separators work now, only opacity/color is a bit off still... too transparent -2010-03-11 Mirco Müller +2010-03-11 Mirco M?ller another go at fixing LP: #526334 @@ -45703,13 +46229,13 @@ fixed missing focused indicator -2010-03-10 Mirco Müller +2010-03-10 Mirco M?ller Merged my fix-526335 branch into unity trunk after review and approval from Gordon. This corrects the alignment of tooltips, quicklist and launcher icons, thus fixing LP: #526335. -2010-03-10 Mirco Müller +2010-03-10 Mirco M?ller correctly align anchor of tooltips/quicklist with icons on quicklauncher, fixes LP: #526335 @@ -46315,12 +46841,12 @@ mutter-plugin/expose-manager.c mutter-plugin/maximus.c -2010-02-25 Mirco Müller +2010-02-25 Mirco M?ller Merged my unity_fix-525909 branch into unity trunk after review and approval from Jay. -2010-02-25 Mirco Müller +2010-02-25 Mirco M?ller enforce correct positioning of anchor-arrow for tooltip- and quicklist-case, fixes LP: #525909 @@ -46344,7 +46870,7 @@ updates plugin.vala to the proper launcher size -2010-02-25 Mirco Müller +2010-02-25 Mirco M?ller Merge with trunk. @@ -46356,11 +46882,11 @@ fixes indicators being in the wrong place -2010-02-25 Mirco Müller +2010-02-25 Mirco M?ller Merged my unity_fix-525905 branch after review and approval from Gordon. -2010-02-24 Mirco Müller +2010-02-24 Mirco M?ller For some unknown reason correcting the tooltip/quicklist x-offset in build_menu() isn't always executed, so to avoid the x-offset to be wrong after one scrubbed the quicklauncher, the initial x-offset-value is cached in the quicklist-view and enforced if it diverges, fixes LP: #525905 @@ -46555,15 +47081,15 @@ added urlify function to escape uri strings nicely -2010-02-23 Mirco Müller +2010-02-23 Mirco M?ller Merged my branch fixing LP: #521065 after review and approval from Neil. -2010-02-23 Mirco Müller +2010-02-23 Mirco M?ller don't save the temp. cairo-surface to a PNG-file -2010-02-23 Mirco Müller +2010-02-23 Mirco M?ller only use two layers for Tooltip/Quicklist to avoid the lag in drawing, fixes LP: #521065 @@ -46869,19 +47395,19 @@ vapi/clutk-0.3.vapi updated vapi file -2010-02-18 Mirco Müller +2010-02-18 Mirco M?ller made the fill-layer a bit darker, emphasized the hightlight-layer a bit more -2010-02-18 Mirco Müller +2010-02-18 Mirco M?ller added two comment sections FIXME00 and FIXME01 for two different approaches on how to update the blurred bg-texture, using the FIXME00 for now... more robust, but harder on the GPU -2010-02-18 Mirco Müller +2010-02-18 Mirco M?ller Make Ctk.surface_blur() work again after updating the .vapi file, thus drop-shadows work again for Tooltip/Quicklist -2010-02-18 Mirco Müller +2010-02-18 Mirco M?ller typo fix for get_framebuffer_background() @@ -46994,34 +47520,34 @@ fixes the menu order in the quicklists -2010-02-17 Mirco Müller +2010-02-17 Mirco M?ller Finally after the third attempt and a mix of lp and lucid screwing up I am able to merge my quicklist-dropshadow branch into unity trunk... after review and approval form Jay. -2010-02-17 Mirco Müller +2010-02-17 Mirco M?ller some opacity-fixes, position the arrow-anchor correctly again -2010-02-17 Mirco Müller +2010-02-17 Mirco M?ller Update .vapi file for clutk with the binding for the new call Ctk.surface_blur() -2010-02-17 Mirco Müller +2010-02-17 Mirco M?ller first working version of drop-shadow for quicklist/tooltip, fixes LP: #521071, LP: #521068, LP: #521058 -2010-02-17 Mirco Müller +2010-02-17 Mirco M?ller Don't used fixed pixel-size for offsetting the Tooltip/Quicklist slightly over the quicklauncher -2010-02-16 Mirco Müller +2010-02-16 Mirco M?ller Merged my move-flatten-to-paint branch after review and approval from Gordon. -2010-02-15 Mirco Müller +2010-02-15 Mirco M?ller move flattening of layers in a Quicklist to the overloading paint() method, otherwise we can't paint offscreen thanks to clutter @@ -47176,25 +47702,25 @@ src/places/cairo-drawing.vala - Text entry background rendering with Cairo -2010-02-11 Mirco Müller +2010-02-11 Mirco M?ller Merged my unity_quicklist-menu-item-tweaks branch after review and approval from Gordon. Had to tweak/remove a line from vapi/clutk-0.3.vapi as there was a double mentioning set_swallow_clicks(). -2010-02-11 Mirco Müller +2010-02-11 Mirco M?ller needed to update the .vapi bindings-file for clutk to expose ctk_menu_get_num_items() inside unity -2010-02-11 Mirco Müller +2010-02-11 Mirco M?ller make use of the new Ctk.Menu.get_num_items() to differentiate between Tooltip and Quicklist and place the arrow correctly -2010-02-11 Mirco Müller +2010-02-11 Mirco M?ller move the Tooltip/Quicklist a bit closer (over) the Quicklauncher-bar like shown in the visual-specs -2010-02-11 Mirco Müller +2010-02-11 Mirco M?ller tweak some EM-values, make use of CORNER_RADIUS, make all mask-generation functions use anchor_y instead of item-index, deleted some commented out code, added a note about workaround regarding spacing between menu-items and a potential bug in parent-class CtkMenu regarding that @@ -47291,20 +47817,20 @@ mutter-plugin/plugin.vala src/window.vala -2010-02-10 Mirco Müller +2010-02-10 Mirco M?ller Merged additional fixes from my unity_quicklist-menu-item-tweaks branch into trunk after review and approval from Jay. -2010-02-10 Mirco Müller +2010-02-10 Mirco M?ller Make sure the correct spacing is used between QuicklistMenuItems -2010-02-10 Mirco Müller +2010-02-10 Mirco M?ller use correct calculation and size-negotiation for QuicklistMenuItems by overriding get_prefered_width/height() methods, QuicklistMenuItems are pixel-perfect now -2010-02-09 Mirco Müller +2010-02-09 Mirco M?ller Use pangocairo to create the text for normal and selected menu-items in the QuickList. @@ -47396,12 +47922,12 @@ Add layout algorithm -2010-02-05 Mirco Müller +2010-02-05 Mirco M?ller Merged my quicklist-menu-item-tweaks branch after review and approval from Jay. -2010-02-05 Mirco Müller +2010-02-05 Mirco M?ller started fixing some of placing and spacing of the QuickList menu-items @@ -47467,32 +47993,32 @@ use scale-foo instead of foo-scale -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller Merged my ctk-menu-item-subclass branch after review and approval from Jay. -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller comment out writing out debug-PNGs for surfaces, trigger queue-redraw when layers are switched between normal and selected state -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller updated .vapi file for clutk to also include bindings for CtkLayer and CtkLayerActor -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller merged with trunk to keep delta with ctk-menu-item-subclass branch small -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller added event-handling for enter/leave, added rendering of normal/selected states -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller Make the QuickList controller use the new QuickListMenuItem. -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller starting to subclass Ctk.MenuItem to be used for custom rendering in Quicklist-items @@ -47680,7 +48206,7 @@ modified: mutter-plugin/plugin.vala -2010-02-04 Mirco Müller +2010-02-04 Mirco M?ller Merged my quicklist-background-fixes branch after review and approval from Neil. @@ -47692,7 +48218,7 @@ modified: src/quicklauncher/quicklist-view.vala -2010-02-03 Mirco Müller +2010-02-03 Mirco M?ller first few fixes for correcting the quicklist-background, arrow of quicklist still off @@ -47712,16 +48238,16 @@ Add support for moving unity offscreen when fullscreen window is present -2010-02-03 Mirco Müller +2010-02-03 Mirco M?ller Merged my unity_quicklist-rendering branch after review and approval from Gordon. -2010-02-02 Mirco Müller +2010-02-02 Mirco M?ller exit early from allocate() if width/height didn't change for the Quicklist, use the right left-padding for the menu-entries -2010-02-02 Mirco Müller +2010-02-02 Mirco M?ller overriding base-class' allocate(), moved creation of quicklist-background to allocate() @@ -47734,35 +48260,35 @@ Merging with trunk to make the get rid of the unresolved symbol error for launcher_application_get_wnckapps() -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller initial version of the dotted-layer for the quicklist-background rendering, not really dotted atm :) -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller added drawing of highlight-layer to quicklist-background rendering -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller added generation of negative-mask needed for the shadow-layer drawing later, added shadow-layer stub -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller added rendering of fill-layer to quicklist-bg rendering -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller first part of outline-layer of custom quicklist-background rendered via CtkLayerActor visible -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller added EM-constants for quicklist rendering -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller initial stubs for rendering different quicklist bg-layers -2010-01-28 Mirco Müller +2010-01-28 Mirco M?ller update clutk vapi-file with bindings for CtkLayer and CtkLayerActor @@ -47770,12 +48296,12 @@ Flush xbuffer -2010-02-03 Mirco Müller +2010-02-03 Mirco M?ller Merged my remove-tooltipmanager branch after review and approval from Grodon. -2010-02-03 Mirco Müller +2010-02-03 Mirco M?ller removed deprecated code for TooltipManager, we now use the CtkMenu-based Quicklist for combining Tooltip, Quicklist and Droplist rendering @@ -49378,7 +49904,7 @@ Jay Taoko 2010-01-05 Moved Places bar code to view.vala Jay Taoko 2010-01-04 Fix public struct Jay Taoko 2010-01-04 Improved cairo rendering for the Places bar. - Mirco Müller 2010-01-06 [merge] Merged Gordon's menu-improvement branch ... + Mirco M?ller 2010-01-06 [merge] Merged Gordon's menu-improvement branch ... Gord Allott 2010-01-05 removed tab from data/makefile.am Gord Allott 2010-01-05 updated to support latest ctk menu background col... Gord Allott 2010-01-04 [merge] enabled opacity for the menu texture, mer... @@ -49476,11 +50002,11 @@ Jay Taoko 2009-12-21 Added Cairo rendenring for Places background Jay Taoko 2009-12-21 Updated vapi Jay Taoko 2009-12-21 [merge] Merge: Add Places bar and new icons art - Mirco Müller 2009-12-11 changed max. glow-factor since this changed in c... - Mirco Müller 2009-12-10 just add a few more icons to the bar - Mirco Müller 2009-12-10 don't keep generated files under version-control - Mirco Müller 2009-12-10 make use of newer icons, add a glow to them, mak... - Mirco Müller 2009-12-10 add preliminary icons for places-bar + Mirco M?ller 2009-12-11 changed max. glow-factor since this changed in c... + Mirco M?ller 2009-12-10 just add a few more icons to the bar + Mirco M?ller 2009-12-10 don't keep generated files under version-control + Mirco M?ller 2009-12-10 make use of newer icons, add a glow to them, mak... + Mirco M?ller 2009-12-10 add preliminary icons for places-bar Gordon Allott 2009-12-18 [merge] Adds support for latest clutk and renam... Gordon Allott 2009-12-18 seperated offline shortcuts from generic action... Gordon Allott 2009-12-18 renamed files from store->model @@ -49672,7 +50198,7 @@ Improved cairo rendering for the Places bar. -2010-01-06 Mirco Müller +2010-01-06 Mirco M?ller Merged Gordon's menu-improvement branch after review and approval from Neil and myself. @@ -49760,23 +50286,23 @@ Merge: Add Places bar and new icons art -2009-12-11 Mirco Müller +2009-12-11 Mirco M?ller changed max. glow-factor since this changed in clutk, we really should map the min/max defines for effect-limit-values to vala -2009-12-10 Mirco Müller +2009-12-10 Mirco M?ller just add a few more icons to the bar -2009-12-10 Mirco Müller +2009-12-10 Mirco M?ller don't keep generated files under version-control -2009-12-10 Mirco Müller +2009-12-10 Mirco M?ller make use of newer icons, add a glow to them, make sure they get installed -2009-12-10 Mirco Müller +2009-12-10 Mirco M?ller add preliminary icons for places-bar @@ -50209,87 +50735,87 @@ inital import -2009-12-10 Mirco Müller +2009-12-10 Mirco M?ller Merged home-screen branch after review and approval from Neil. -2009-12-10 Mirco Müller +2009-12-10 Mirco M?ller fix/understand the way how allocation, placement and sizing is meant to be dealt with, places-bar and default-view are now correctly positioned -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller blarg -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller WTF is wrong with placing actors? Been trying to get close to the mockup for the past three hours and give up now. -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller at last something shows up again -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller Added trash-place -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller don't keep generated files under version-control -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller bootstrapped new places implementation -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller added new implementation of homescreen/places, using hardcoded contents for now -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller got rid of old implementation -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller don't keep generated .c files under version-control -2009-12-09 Mirco Müller +2009-12-09 Mirco M?ller restructuring homescreen implementation to more strictly follow MVC design-pattern, added (abstract) callback to show default-view (still needs signal) -2009-12-08 Mirco Müller +2009-12-08 Mirco M?ller Secondary label now correctly justifies -2009-12-08 Mirco Müller +2009-12-08 Mirco M?ller placement of the primary or secondary label centered now, but primary label is forced to use line-wrapping now otherwise center-alignment would not work... Pango is a mistery to me there -2009-12-08 Mirco Müller +2009-12-08 Mirco M?ller secondary label only visible when mouse enters ActivityWidget -2009-12-08 Mirco Müller +2009-12-08 Mirco M?ller not getting anywhere with text formatting as requested by the spec -2009-12-08 Mirco Müller +2009-12-08 Mirco M?ller can't really make placement of ActivityWidgets work -2009-12-04 Mirco Müller +2009-12-04 Mirco M?ller figure out how positioning works -2009-12-04 Mirco Müller +2009-12-04 Mirco M?ller make sure the homescreen shows up -2009-12-04 Mirco Müller +2009-12-04 Mirco M?ller don't keep temp. files of IDE under version-control -2009-12-04 Mirco Müller +2009-12-04 Mirco M?ller bootstrap new homescreen module @@ -50735,29 +51261,29 @@ latest unity -2009-11-03 Mirco Müller +2009-11-03 Mirco M?ller Merged fix for glow- and tooltip-callbacks, after "manual" review and approval from njpatel. LP didn't even update the branch 2 h after it being pushed *sigh* -2009-11-03 Mirco Müller +2009-11-03 Mirco M?ller fixed enter/leave signal-handers so glow- and tooltip-triggers can coexist -2009-11-03 Mirco Müller +2009-11-03 Mirco M?ller Merged my TooltipManager branch after review and approval. -2009-11-03 Mirco Müller +2009-11-03 Mirco M?ller removed superfluous comments and code -2009-11-03 Mirco Müller +2009-11-03 Mirco M?ller needed for fix offset-calculation, moved "setup" of TooltipManager from main.vala to window.vala due to some valac fishyness -2009-11-03 Mirco Müller +2009-11-03 Mirco M?ller created new branch against more current unity trunk and trying to port my TooltipManager work over diff -Nru unity-5.12/CMakeLists.txt unity-5.14.0/CMakeLists.txt --- unity-5.12/CMakeLists.txt 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/CMakeLists.txt 2012-07-18 11:12:56.000000000 +0000 @@ -8,7 +8,7 @@ # set (PROJECT_NAME "unity") set (UNITY_MAJOR 5) -set (UNITY_MINOR 12) +set (UNITY_MINOR 14) set (UNITY_MICRO 0) set (UNITY_VERSION "${UNITY_MAJOR}.${UNITY_MINOR}.${UNITY_MICRO}") set (UNITY_API_VERSION "5.0") diff -Nru unity-5.12/debian/changelog unity-5.14.0/debian/changelog --- unity-5.12/debian/changelog 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/debian/changelog 2012-07-20 17:50:58.000000000 +0000 @@ -1,3 +1,66 @@ +unity (5.14.0-0ubuntu1) precise-proposed; urgency=low + + * New upstream release. + - Unity launcher shows internal partitions after they have been unmounted + (LP: #994163) + - can't click to dismiss hud in the area where dynamic hud results are + meant to appear (LP: #962651) + - Spread/Scale should exit if Dash is invoked (LP: #944033) + - Searching in the HUD freezes unity (LP: #1016239) + - Dash - The search bar gets the focus when pressing invalid keys + (LP: #931393) + - unity crashed with NameError in reset_unity_compiz_profile(): global name + 'GError' is not defined (LP: #778470) + - When number of workspaces is set to 1, the Spread no longer works + (LP: #996604) + - compiz crashed with SIGSEGV in CompWindow::id() from getPaintMask() + from unity::UnityWindow::glPaint() (LP: #851982) + - "Keyboard Shortcuts" overlay can cause annoyance (LP: #934062) + - padding between last quicklist item and bottom edge is non-deterministic + (changes randomly) (LP: #955158) + - HUD Draws improperly while searching for results (LP: #932531) + - compiz crashed with SIGSEGV in + unity::ui::KeyboardUtil::GetKeycodeAboveKeySymbol() (LP: #920258) + - Launcher - when a user starts dragging a item, any folded launcher icons + that are valid drop receptacles should unfold (LP: #839717) + - Dragging image from firefox/chrome to dock causes lagg/freeze + (LP: #772445) + - dash should open when pressing "super" in scale mode (LP: #1023811) + - Multimonitor, Launcher - When the Launcher is set to autohide and + 'Sticky edges' are turned off, 'Launcher Edge Stop Overcome Pressure' + seems to be broken when revealing the Launcher (LP: #987955) + - Software Center add to launcher icon animation is delayed when the + launcher is in auto-hide mode (LP: #1012896) + - Purchased items are not being added to the Unity launcher (LP: #925014) + - Unity Launcher Fails To Auto-Hide When Enabled & Installing Commercial + Software (LP: #1002440) + - Regression: shift+click on a launcher icon to open a new application + instance gone (LP: #754565) + - Regression: Installing apps causes a terrible visual glitch-- have to + restart X.org. (LP: #981168) + - Duplicated applications icons on quick application restart (LP: #1003574) + - HUD - Formatting of text in the auto-complete is wrong (LP: #939436) + - alt-backtick flickers between windows (LP: #987156) + - [Hud] The result grid is not drawn in proximity of the search entry + (LP: #1008603) + - Dash and Launcher - As soon as a user starts dragging a file from the + Dash, there is a 'flicker' before the Launcher icons that are valid drop + receptacles re-saturate (LP: #863230) + - [hud] The last button is not rounded (LP: #1008656) + - Hud flickers when show up (LP: #1011507) + - Dash maximise button changed location (LP: #987674) + - launcher reordering "line" doesn't go to the bottom slot (LP: #971421) + - Dash/HUD should close on "Spread" (LP: #870284) + - Nothing should be written into the dash/hud searchbar when holding super, + ctrl or Alt (LP: #1013751) + - Dash - when a file is dragged from the Dash (Dash home, file lens, or + music lens) and dropped on a Launcher icon, the Dash should automatically + close (LP: #865168) + - Wrong keyboard focus after opening workspace switcher via keyboard + navigation (LP: #962408) + + -- Łukasz 'sil2100' Zemczak Wed, 18 Jul 2012 13:16:16 +0200 + unity (5.12-0ubuntu1.1) precise-proposed; urgency=low * Cherry pick upstream fixes. diff -Nru unity-5.12/manual-tests/Dash.txt unity-5.14.0/manual-tests/Dash.txt --- unity-5.12/manual-tests/Dash.txt 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/manual-tests/Dash.txt 2012-07-18 11:12:56.000000000 +0000 @@ -190,6 +190,19 @@ this saturation-process should be smooth and without flicker. The tinting of the non-drag-targets should not change. +Dash to Launcher document-file drag +----------------------------------- + +Setup: +#. Open the Dash (Super). +#. Go to the Music Lens. + +Action: +#. Drag any music file into the Firefox icon on the launcher. + +Outcome: + The Dash should close and the music file should open up in Firefox. + Lens Tests ============ @@ -242,4 +255,4 @@ Wrong Outcome: #2 and #4 both produce non-empty result which means the lenses were not - lazy-loaded but they were running before the first dash use. \ No newline at end of file + lazy-loaded but they were running before the first dash use. diff -Nru unity-5.12/manual-tests/Launcher.txt unity-5.14.0/manual-tests/Launcher.txt --- unity-5.12/manual-tests/Launcher.txt 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/manual-tests/Launcher.txt 2012-07-18 11:12:56.000000000 +0000 @@ -540,3 +540,49 @@ Expected Results: * Terminal window will be raised to the top of the stack (over the GIMP window) + + +Test launcher removes device icons +------------------------------------------------------------ +This test makes sure that Unity doesn't shows internal partitions after +they have been unmounted. + +Actions: + * Open Nautilus + * Mount an internal partition using the sidebar + * Make sure the launcher has the launcher icon for the partition + * Unmount that partition using Nautilus + +Expected Results: + * The device launcher icon has been removed. + + +Drag and Drop doesn't freeze Unity +---------------------------------- +Actions: +#. Open Firefox +#. Go to http://launchpad.net/unity +#. Drag around the Unity icon image shown in the top-left corner + of the browser window. +#. Drop it wherever you want. + +Expected Result: +Unity must not freeze during the drag and drop. + + +Test launcher unfolds valid drop icons during dnd +------------------------------------------------------------ +This test makes sure that Unity launcher unfolds valid drop icons during +drag and drop. + +Setup: + * Add icons to the laucnher so that some of them in the bottom are folded. + * Add Nautilus icon too, making sure it is folded. + +Actions: + * Show Desktop + * Drag a folder icon + +Expected Results: + * All the valid drop icons should unfold during the drag and drop. + diff -Nru unity-5.12/manual-tests/SoftwareCenter.txt unity-5.14.0/manual-tests/SoftwareCenter.txt --- unity-5.12/manual-tests/SoftwareCenter.txt 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/manual-tests/SoftwareCenter.txt 2012-07-18 11:12:56.000000000 +0000 @@ -1,16 +1,104 @@ -The SoftwareCenter Launcher Integration cancel ----------------------------------------------- + +Ubuntu Software Center Launcher Integration, installing an application from the Ubuntu archives +----------------------------------------------------------------------------------------------- + +Setup: +#. Launch Ubuntu Software Center + +Actions: +#. In Software Center, click on the "Games" category in the left panel to view the display of game genre icons, "Top Rated Games", etc. +#. Select the "Card Games" icon and then select any uninstalled game in the displayed list. +#. Click the "More Info" button. +#. In the details view for the game, click the "Install" button. +#. Enter the password for the install when prompted. + +Expected Result: + The game begins to install and the progress bar moves in Software Center. + At the very *end* of the installation process (when the progress bar has completed), the icon for the game "flies" into the Unity Launcher. + Verify that the icon that has been added to the launcher and that: + - If the Unity launcher was set to auto-hide, it correctly autohides at the end of the installation and is not "stuck" in a displayed state. + - The launcher icon has the correct icon for the game that was installed. + - Hovering the mouse cursor over the icon displays the name of the application for its tooltip (and that it does *not* display the text "Waiting to install"). + - Clicking the icon launches the newly installed game. + + +Ubuntu Software Center Launcher Integration, cancelling an installation +----------------------------------------------------------------------- + +Setup: +#. Launch Ubuntu Software Center + +Actions: +#. In Software Center, click on the "Games" category in the left panel to view the display of game genre icons, "Top Rated Games", etc. +#. Select the "Card Games" icon and then select any uninstalled game in the displayed list. +#. Click the "More Info" button. +#. In the details view for the game, click the "Install" button. +#. In the dialog that prompts you to enter your password for the install, click the "Cancel" button. + +Expected Result: + The installation is cancelled. Verify that no icon has been added to the Unity launcher integration. + + +Ubuntu Software Center Launcher Integration, installing a purchased application +------------------------------------------------------------------------------- + +Setup: +#. Launch Ubuntu Software Center + +Actions: +#. In Software Center, click the down arrow in the toolbar next to the "All Software" button, and choose the "For Purchase" item. +#. In the list of displayed items for purchase, choose an application (not a magazine or book) that is free (that is, marked as $0 -- unless you wish to purchase something). +#. Click the "More Info" button. +#. In the details view for the application, click the "Buy" button. +#. Follow the purchase process. For a $0 item, you will not be prompted for payment information. +#. Enter the password for the install when prompted. + +Expected Result: + The the progress bar activates in Software Center. Note that for purchased items, it can take a bit of time before the progress bar transitions from intdeterminate to determinate. + At the very *end* of the installation process (when the progress bar has completed), the icon for the purchased item "flies" into the Unity Launcher. + Verify that the icon that has been added to the launcher and that: + - If the Unity launcher was set to auto-hide, it correctly autohides at the end of the installation and is not "stuck" in a displayed state. + - The launcher icon has the correct icon for the application that was installed. + - Hovering the mouse cursor over the icon displays the name of the application for its tooltip (and that it does *not* display the text "Waiting to install"). + - Clicking the icon launches the newly installed application. + + +Ubuntu Software Center Launcher Integration, installing from the "Independent" archives +--------------------------------------------------------------------------------------- + +Setup: +#. Launch Ubuntu Software Center + +Actions: +#. In Software Center, click the down arrow in the toolbar next to the "All Software" button, and choose the "Independent" item. +#. In the list of displayed items, choose an application that is not yet installed. +#. Click the "More Info" button. +#. In the details view for the application, click the "Install" button. +#. Enter the password for the install when prompted. + +xpected Result: + The application begins to install and the progress bar moves in Software Center. + At the very *end* of the installation process (when the progress bar has completed), the icon for the application "flies" into the Unity Launcher. + Verify that the icon that has been added to the launcher and that: + - If the Unity launcher was set to auto-hide, it correctly autohides at the end of the installation and is not "stuck" in a displayed state. + - The launcher icon has the correct icon for the application that was installed. + - Hovering the mouse cursor over the icon displays the name of the application for its tooltip (and that it does *not* display the text "Waiting to install"). + - Clicking the icon launches the newly installed game. + + +Ubuntu Software Center Launcher Integration, uninstalling an application +------------------------------------------------------------------------ Setup: -#. Open software-center +#. Launch Ubuntu Software Center Actions: -#. Click on install on a big application like wesnoth -#. Verify that the icon "flies" into the launcher -#. Wait until the "In Progress" appears in the toplevel toolbar of s-c -#. Click on the "In Progress" button in the toolbar -#. Click on the "cancel" button of the install of the application +#. In Software Center, click the "Installed" toolbar button to access the list of installed applications. +#. Choose an installed application to remove (choose one for which there is a corresponding icon in the Unity launcher). +#. Click the "More Info" button. +#. In the details view for the application, click the "Remove" button. +#. Enter the password for the remove when prompted. Expected Result: - The icon is removed from the launcher again after the download was - canceled. + The uninstall process begins and the progress bar moves in Software Center. + At the very *end* of the installation process, verify that the corresponding icon in the Unity launcher is *removed*. diff -Nru unity-5.12/manual-tests/Switcher.txt unity-5.14.0/manual-tests/Switcher.txt --- unity-5.12/manual-tests/Switcher.txt 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/manual-tests/Switcher.txt 2012-07-18 11:12:56.000000000 +0000 @@ -56,3 +56,42 @@ Outcome The title of the newly created window should be "显示桌面" and *not* "显示桌...". + + +Alt+keyabovetab switching +------------------------------ +This test ensures that alt+keyabovetab switching windows of the application +works as it should. + +Setup: +#. Have a few windows of one application open (e.g. 3 terminal windows). + +Action: +#. Focus one of the opened application windows. +#. Press Alt+keyabovetab (the ~ key on the US and PL keyboard). +#. Keep the Alt key pressed. + +Outcome + The switcher should appear with the detail view for the given application + (e.g. the terminal), with all terminal applications for the workspace + visible. The switcher should look normally. + + +Fast alt+keyabovetab switching +------------------------------ +This test ensures that doing a fast tap does not result in any 'flickering' of +the switcher window. The switcher should not appear during a quick tap, just +during longer alt+keyabovetab presses. + +Setup: +#. Have a few windows of one application open (e.g. 3 terminal windows) + +Action: +#. Focus one of the opened application windows. +#. Quickly tap Alt+keyabovetab (meaning only tap once, do not hold) +#. Repeat at least a few times + +Outcome + On every quick tap, the focus should switch to the next same-application + type window. During that switch the switcher should not appear, not even + for a brief moment (if done fast enough). No 'flickering' of the switcher. diff -Nru unity-5.12/plugins/unityshell/src/AbstractLauncherIcon.h unity-5.14.0/plugins/unityshell/src/AbstractLauncherIcon.h --- unity-5.12/plugins/unityshell/src/AbstractLauncherIcon.h 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/AbstractLauncherIcon.h 2012-07-18 11:12:56.000000000 +0000 @@ -210,9 +210,9 @@ virtual void UnStick() = 0; - sigc::signal mouse_down; - sigc::signal mouse_up; - sigc::signal mouse_click; + sigc::signal mouse_down; + sigc::signal mouse_up; + sigc::signal mouse_click; sigc::signal mouse_enter; sigc::signal mouse_leave; diff -Nru unity-5.12/plugins/unityshell/src/BamfLauncherIcon.cpp unity-5.14.0/plugins/unityshell/src/BamfLauncherIcon.cpp --- unity-5.12/plugins/unityshell/src/BamfLauncherIcon.cpp 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/BamfLauncherIcon.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -191,9 +191,12 @@ /* Removing the unity-seen flag to the wrapped bamf application, on remove * request we make sure that if the bamf application is re-opened while * the removal process is still ongoing, the application will be shown - * on the launcher. */ + * on the launcher. Disconnecting from signals and nullifying the _bamf_app + * we make sure that this icon won't be reused (no duplicated icon). */ + _gsignals.Disconnect(_bamf_app); g_object_set_qdata(G_OBJECT(_bamf_app.RawPtr()), g_quark_from_static_string("unity-seen"), nullptr); + _bamf_app = nullptr; SimpleLauncherIcon::Remove(); } @@ -749,8 +752,8 @@ const gchar** nicks = indicator_desktop_shortcuts_get_nicks(_desktop_shortcuts); int index = 0; - while (nicks[index]) { - + while (nicks[index]) + { // Build a dbusmenu item for each nick that is the desktop // file that is built from it's name and includes a callback // to the desktop shortcuts object to execute the nick diff -Nru unity-5.12/plugins/unityshell/src/compizminimizedwindowhandler.h unity-5.14.0/plugins/unityshell/src/compizminimizedwindowhandler.h --- unity-5.12/plugins/unityshell/src/compizminimizedwindowhandler.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/compizminimizedwindowhandler.h 2012-07-18 11:12:56.000000000 +0000 @@ -104,6 +104,7 @@ template compiz::CompizMinimizedWindowHandler::~CompizMinimizedWindowHandler () { + minimizingWindows.remove (priv->mWindow); minimizedWindows.remove (this); } diff -Nru unity-5.12/plugins/unityshell/src/DashController.cpp unity-5.14.0/plugins/unityshell/src/DashController.cpp --- unity-5.12/plugins/unityshell/src/DashController.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DashController.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -55,7 +55,7 @@ ensure_id_ = g_timeout_add_seconds(60, [] (gpointer data) -> gboolean { static_cast(data)->EnsureDash(); return FALSE; }, this); SetupWindow(); - + Settings::Instance().changed.connect([&]() { if (window_ && view_) @@ -65,6 +65,9 @@ nux::GetWindowCompositor().SetKeyFocusArea(view_->default_focus()); } }); + + auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true); + PluginAdapter::Default()->initiate_spread.connect(spread_cb); } Controller::~Controller() @@ -89,7 +92,7 @@ window_->ShowWindow(false); window_->SetOpacity(0.0f); window_->mouse_down_outside_pointer_grab_area.connect(sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow)); - + /* FIXME - first time we load our windows there is a race that causes the input window not to actually get input, this side steps that by causing an input window show and hide before we really need it. */ PluginAdapter::Default()->saveInputFocus (); window_->EnableInputWindow(true, "Dash", true, false); @@ -373,6 +376,9 @@ std::string lens_id = view_->GetIdForShortcutActivation(std::string(key_string)); if (lens_id != "") { + if (PluginAdapter::Default()->IsScaleActive()) + PluginAdapter::Default()->TerminateScale(); + GVariant* args = g_variant_new("(sus)", lens_id.c_str(), dash::GOTO_DASH_URI, ""); OnActivateRequest(args); g_variant_unref(args); diff -Nru unity-5.12/plugins/unityshell/src/DashStyle.cpp unity-5.14.0/plugins/unityshell/src/DashStyle.cpp --- unity-5.12/plugins/unityshell/src/DashStyle.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DashStyle.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -1640,7 +1640,7 @@ // draw the grid background { cairo_set_line_width(cr, 1); - cairo_move_to(cr, _align(x + width, odd), _align(y, odd)); + cairo_move_to(cr, _align(x + width, odd), y); if (curve_bottom) { LOG_DEBUG(logger) << "curve: " << _align(x + width, odd) << " - " << _align(y + height - radius, odd); @@ -1672,8 +1672,8 @@ else { cairo_line_to(cr, _align(x + width, odd), _align(y + height, odd)); - cairo_line_to(cr, _align(x, odd), _align(x + height, odd)); - cairo_line_to(cr, _align(x, odd), _align(y, odd)); + cairo_line_to(cr, _align(x, odd), _align(y + height, odd)); + cairo_line_to(cr, _align(x, odd), y); } cairo_set_source_rgba(cr, pimpl->button_label_border_color_[nux::ButtonVisualState::VISUAL_STATE_NORMAL]); diff -Nru unity-5.12/plugins/unityshell/src/DashView.cpp unity-5.14.0/plugins/unityshell/src/DashView.cpp --- unity-5.12/plugins/unityshell/src/DashView.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DashView.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -32,6 +32,7 @@ #include "DashStyle.h" #include "DashSettings.h" #include "UBusMessages.h" +#include "KeyboardUtil.h" namespace unity { @@ -804,15 +805,15 @@ } Area* DashView::FindKeyFocusArea(unsigned int key_symbol, - unsigned long x11_key_code, - unsigned long special_keys_state) + unsigned long x11_key_code, + unsigned long special_keys_state) { // Do what nux::View does, but if the event isn't a key navigation, // designate the text entry to process it. + nux::KeyNavDirection direction = KEY_NAV_NONE; bool ctrl = (special_keys_state & NUX_STATE_CTRL); - nux::KeyNavDirection direction = KEY_NAV_NONE; switch (x11_key_code) { case NUX_VK_UP: @@ -850,7 +851,6 @@ break; default: direction = KEY_NAV_NONE; - break; } // We should not do it here, but I really don't want to make DashView @@ -858,7 +858,7 @@ // DashView::KeyNavIteration. nux::InputArea* focus_area = nux::GetWindowCompositor().GetKeyFocusArea(); - if (key_symbol == nux::NUX_KEYDOWN && !search_bar_->im_preedit) + if (direction != KEY_NAV_NONE && key_symbol == nux::NUX_KEYDOWN && !search_bar_->im_preedit) { std::list tabs; for (auto category : active_lens_view_->categories()) @@ -933,7 +933,18 @@ } } - if (direction == KEY_NAV_NONE || search_bar_->im_preedit) + bool search_key = false; + + if (direction == KEY_NAV_NONE) + { + if (ui::KeyboardUtil::IsPrintableKeySymbol(x11_key_code) || + ui::KeyboardUtil::IsMoveKeySymbol(x11_key_code)) + { + search_key = true; + } + } + + if (search_key || search_bar_->im_preedit) { // then send the event to the search entry return search_bar_->text_entry(); @@ -942,7 +953,8 @@ { return next_object_to_key_focus_area_->FindKeyFocusArea(key_symbol, x11_key_code, special_keys_state); } - return NULL; + + return nullptr; } } diff -Nru unity-5.12/plugins/unityshell/src/DeviceLauncherIcon.cpp unity-5.14.0/plugins/unityshell/src/DeviceLauncherIcon.cpp --- unity-5.12/plugins/unityshell/src/DeviceLauncherIcon.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DeviceLauncherIcon.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -40,6 +40,7 @@ nux::logging::Logger logger("unity.launcher"); GduDevice* get_device_for_device_file (const gchar *device_file); +const unsigned int volume_changed_timeout = 500; } @@ -49,6 +50,8 @@ , device_file_(g_volume_get_identifier(volume_, G_VOLUME_IDENTIFIER_KIND_UNIX_DEVICE)) , gdu_device_(get_device_for_device_file(device_file_)) { + signal_volume_changed_.Connect(volume, "changed", sigc::mem_fun(this, &DeviceLauncherIcon::OnVolumeChanged)); + DevicesSettings::GetDefault().changed.connect(sigc::mem_fun(this, &DeviceLauncherIcon::OnSettingsChanged)); // Checks if in favourites! @@ -62,6 +65,55 @@ UpdateVisibility(); } +DeviceLauncherIcon::~DeviceLauncherIcon() +{ + if (changed_timeout_ > 0) + g_source_remove(changed_timeout_); +} + +void DeviceLauncherIcon::OnVolumeChanged(GVolume* volume) +{ + if (!G_IS_VOLUME(volume)) + return; + + if (changed_timeout_ > 0) + g_source_remove(changed_timeout_); + changed_timeout_ = g_timeout_add(volume_changed_timeout, &DeviceLauncherIcon::OnVolumeChangedTimeout, this); +} + +gboolean DeviceLauncherIcon::OnVolumeChangedTimeout(gpointer data) +{ + DeviceLauncherIcon* self = static_cast(data); + + self->UpdateDeviceIcon(); + self->UpdateVisibility(); + return FALSE; +} + +void DeviceLauncherIcon::UpdateVisibility() +{ + switch (DevicesSettings::GetDefault().GetDevicesOption()) + { + case DevicesSettings::NEVER: + SetQuirk(QUIRK_VISIBLE, false); + break; + case DevicesSettings::ONLY_MOUNTED: + if (keep_in_launcher_) + { + SetQuirk(QUIRK_VISIBLE, true); + } + else + { + glib::Object mount(g_volume_get_mount(volume_)); + SetQuirk(QUIRK_VISIBLE, mount); + } + break; + case DevicesSettings::ALWAYS: + SetQuirk(QUIRK_VISIBLE, true); + break; + } +} + void DeviceLauncherIcon::UpdateDeviceIcon() { name_ = glib::String(g_volume_get_name(volume_)).Str(); @@ -440,34 +492,6 @@ NULL); } -void DeviceLauncherIcon::UpdateVisibility(int visibility) -{ - switch (DevicesSettings::GetDefault().GetDevicesOption()) - { - case DevicesSettings::NEVER: - SetQuirk(QUIRK_VISIBLE, false); - break; - case DevicesSettings::ONLY_MOUNTED: - if (keep_in_launcher_) - { - SetQuirk(QUIRK_VISIBLE, true); - } - else if (visibility < 0) - { - glib::Object mount(g_volume_get_mount(volume_)); - SetQuirk(QUIRK_VISIBLE, mount.RawPtr() != NULL); - } - else - { - SetQuirk(QUIRK_VISIBLE, visibility); - } - break; - case DevicesSettings::ALWAYS: - SetQuirk(QUIRK_VISIBLE, true); - break; - } -} - void DeviceLauncherIcon::OnSettingsChanged() { // Checks if in favourites! diff -Nru unity-5.12/plugins/unityshell/src/DeviceLauncherIcon.h unity-5.14.0/plugins/unityshell/src/DeviceLauncherIcon.h --- unity-5.12/plugins/unityshell/src/DeviceLauncherIcon.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DeviceLauncherIcon.h 2012-07-18 11:12:56.000000000 +0000 @@ -25,6 +25,8 @@ G_BEGIN_DECLS #include #include +#include + #include "SimpleLauncherIcon.h" namespace unity @@ -37,18 +39,19 @@ public: DeviceLauncherIcon(glib::Object const& volume); + ~DeviceLauncherIcon(); - void UpdateVisibility(int visibility = -1); void OnRemoved(); bool CanEject(); void Eject(); protected: std::list GetMenus(); - void UpdateDeviceIcon(); std::string GetName() const; private: + void UpdateVisibility(); + void UpdateDeviceIcon(); void ActivateLauncherIcon(ActionArg arg); void ShowMount(GMount* mount); void Unmount(); @@ -63,10 +66,14 @@ static void OnEjectReady(GObject* object, GAsyncResult* result, DeviceLauncherIcon* self); static void OnUnmountReady(GObject* object, GAsyncResult* result, DeviceLauncherIcon* self); static void OnDriveStop(DbusmenuMenuitem* item, int time, DeviceLauncherIcon* self); + static gboolean OnVolumeChangedTimeout(gpointer data); + void OnVolumeChanged(GVolume* volume); void OnSettingsChanged(); void ShowNotification(std::string const&, unsigned, GdkPixbuf*, std::string const&); private: + glib::Signal signal_volume_changed_; + guint changed_timeout_; glib::Object volume_; glib::String device_file_; std::string name_; diff -Nru unity-5.12/plugins/unityshell/src/DeviceLauncherSection.cpp unity-5.14.0/plugins/unityshell/src/DeviceLauncherSection.cpp --- unity-5.12/plugins/unityshell/src/DeviceLauncherSection.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DeviceLauncherSection.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -30,10 +30,6 @@ sig_manager_.Add(new VolumeSignal(monitor_, "volume-added", sigc::mem_fun(this, &DeviceLauncherSection::OnVolumeAdded))); sig_manager_.Add(new VolumeSignal(monitor_, "volume-removed", sigc::mem_fun(this, &DeviceLauncherSection::OnVolumeRemoved))); - typedef glib::Signal MountSignal; - sig_manager_.Add(new MountSignal(monitor_, "mount-added", sigc::mem_fun(this, &DeviceLauncherSection::OnMountAdded))); - sig_manager_.Add(new MountSignal(monitor_, "mount-pre-unmount", sigc::mem_fun(this, &DeviceLauncherSection::OnMountPreUnmount))); - on_device_populate_entry_id_ = g_idle_add([] (gpointer data) { auto self = static_cast(data); self->PopulateEntries(); @@ -96,31 +92,5 @@ } } -/* Keep in mind: we could have a GMount without a related GVolume - * so check everything to avoid unwanted behaviors. - */ -void DeviceLauncherSection::OnMountAdded(GVolumeMonitor* monitor, GMount* mount) -{ - glib::Object volume(g_mount_get_volume(mount)); - - auto volume_it = map_.find(volume); - - if (volume_it != map_.end()) - volume_it->second->UpdateVisibility(1); -} - -/* We don't use "mount-removed" signal since it is received after "volume-removed" - * signal. You should read also the comment above. - */ -void DeviceLauncherSection::OnMountPreUnmount(GVolumeMonitor* monitor, GMount* mount) -{ - glib::Object volume(g_mount_get_volume(mount)); - - auto volume_it = map_.find(volume); - - if (volume_it != map_.end()) - volume_it->second->UpdateVisibility(0); -} - } // namespace launcher } // namespace unity diff -Nru unity-5.12/plugins/unityshell/src/DeviceLauncherSection.h unity-5.14.0/plugins/unityshell/src/DeviceLauncherSection.h --- unity-5.12/plugins/unityshell/src/DeviceLauncherSection.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DeviceLauncherSection.h 2012-07-18 11:12:56.000000000 +0000 @@ -50,8 +50,6 @@ void OnVolumeAdded(GVolumeMonitor* monitor, GVolume* volume); void OnVolumeRemoved(GVolumeMonitor* monitor, GVolume* volume); - void OnMountAdded(GVolumeMonitor* monitor, GMount* mount); - void OnMountPreUnmount(GVolumeMonitor* monitor, GMount* mount); private: glib::SignalManager sig_manager_; diff -Nru unity-5.12/plugins/unityshell/src/DndData.cpp unity-5.14.0/plugins/unityshell/src/DndData.cpp --- unity-5.12/plugins/unityshell/src/DndData.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/DndData.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -33,21 +33,21 @@ Reset(); char* pch = strtok (uris, "\r\n"); - while (pch != NULL) + while (pch) { - glib::Object file(g_file_new_for_uri(pch)); - glib::Object info(g_file_query_info(file, G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE, G_FILE_QUERY_INFO_NONE, NULL, NULL)); - const char* content_type = g_file_info_get_content_type(info); - - uris_.insert(pch); - - if (content_type != NULL) + glib::String content_type(g_content_type_guess(pch, nullptr, 0, nullptr)); + + if (content_type) { - types_.insert(content_type); - uris_to_types_[pch] = content_type; - types_to_uris_[content_type].insert(pch); + std::string const& content_type_str = content_type.Str(); + + types_.insert(content_type_str); + uris_to_types_[pch] = content_type_str; + types_to_uris_[content_type_str].insert(pch); } - + + uris_.insert(pch); + pch = strtok (NULL, "\r\n"); } } diff -Nru unity-5.12/plugins/unityshell/src/EdgeBarrierController.cpp unity-5.14.0/plugins/unityshell/src/EdgeBarrierController.cpp --- unity-5.12/plugins/unityshell/src/EdgeBarrierController.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/EdgeBarrierController.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -143,7 +143,7 @@ if (process && owner->x1 > 0) { decaymulator_->value = decaymulator_->value + event->velocity; - if (decaymulator_->value > edge_overcome_pressure_ || !parent_->options()->edge_resist()) + if (decaymulator_->value > edge_overcome_pressure_ || (!parent_->options()->edge_resist() && !subscribers_[monitor])) { owner->ReleaseBarrier(event->event_id); decaymulator_->value = 0; diff -Nru unity-5.12/plugins/unityshell/src/HudAbstractView.cpp unity-5.14.0/plugins/unityshell/src/HudAbstractView.cpp --- unity-5.12/plugins/unityshell/src/HudAbstractView.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudAbstractView.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,33 @@ +/* + * Copyright (C) 2012 Canonical Ltd + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 3 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + * Authored by: Andrea Azzarone + */ + +#include "HudAbstractView.h" + +namespace unity +{ +namespace hud +{ + +NUX_IMPLEMENT_OBJECT_TYPE(AbstractView); + +AbstractView::AbstractView() + : nux::View(NUX_TRACKER_LOCATION) +{} + +} // namespace hud +} // namespace unity diff -Nru unity-5.12/plugins/unityshell/src/HudAbstractView.h unity-5.14.0/plugins/unityshell/src/HudAbstractView.h --- unity-5.12/plugins/unityshell/src/HudAbstractView.h 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudAbstractView.h 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2012 Canonical Ltd + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 3 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + * Authored by: Andrea Azzarone + */ + +#ifndef UNITYSHELL_HUD_ABSTRACT_VIEW_H +#define UNITYSHELL_HUD_ABSTRACT_VIEW_H + +#include +#include + +#include +#include +#include + +#include "Introspectable.h" + +namespace unity +{ +namespace hud +{ + +class AbstractView : public nux::View, public unity::debug::Introspectable +{ + NUX_DECLARE_OBJECT_TYPE(AbstractView, nux::View); +public: + typedef nux::ObjectPtr Ptr; + + AbstractView(); + + virtual void AboutToShow() = 0; + virtual void AboutToHide() = 0; + virtual void Relayout() = 0; + virtual void ResetToDefault() = 0; + virtual void SearchFinished() = 0; + virtual void SetIcon(std::string const& icon_name, unsigned int tile_size, unsigned int size, unsigned int padding) = 0; + virtual void SetQueries(Hud::Queries queries) = 0; + virtual void SetWindowGeometry(nux::Geometry const& absolute_geo, nux::Geometry const& geo) = 0; + virtual void ShowEmbeddedIcon(bool show) = 0; + + virtual nux::View* default_focus() const = 0; + + // signals + sigc::signal search_changed; + sigc::signal search_activated; + sigc::signal query_activated; + sigc::signal query_selected; +}; + +} // namespace hud +} // namespace unity + +#endif // UNITYSHELL_HUD_ABSTRACT_VIEW_H diff -Nru unity-5.12/plugins/unityshell/src/HudButton.cpp unity-5.14.0/plugins/unityshell/src/HudButton.cpp --- unity-5.12/plugins/unityshell/src/HudButton.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudButton.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -26,6 +26,7 @@ #include #include +#include #include #include #include @@ -33,12 +34,17 @@ #include #include "DashStyle.h" +#include "StaticCairoText.h" #include "HudButton.h" +#include "HudPrivate.h" namespace { nux::logging::Logger logger("unity.hud.HudButton"); + +const int hlayout_left_padding = 46; +const char* const button_font = "Ubuntu 13"; // 17px = 13 } namespace unity @@ -46,44 +52,18 @@ namespace hud { - -HudButton::HudButton (nux::TextureArea *image, NUX_FILE_LINE_DECL) - : nux::Button (image, NUX_FILE_LINE_PARAM) - , is_rounded(false) - , is_focused_(false) -{ - Init(); -} - -HudButton::HudButton (const std::string label_, NUX_FILE_LINE_DECL) - : nux::Button (NUX_FILE_LINE_PARAM) - , is_rounded(false) - , is_focused_(false) -{ - Init(); -} - -HudButton::HudButton (const std::string label_, nux::TextureArea *image, NUX_FILE_LINE_DECL) - : nux::Button (image, NUX_FILE_LINE_PARAM) - , is_rounded(false) - , is_focused_(false) -{ - Init(); -} +NUX_IMPLEMENT_OBJECT_TYPE(HudButton); HudButton::HudButton (NUX_FILE_LINE_DECL) : nux::Button (NUX_FILE_LINE_PARAM) , is_rounded(false) , is_focused_(false) + , skip_draw_(true) { - Init(); -} - -HudButton::~HudButton() { -} + hlayout_ = new nux::HLayout(NUX_TRACKER_LOCATION); + hlayout_->SetLeftAndRightPadding(hlayout_left_padding, -1); + SetLayout(hlayout_); -void HudButton::Init() -{ InitTheme(); key_nav_focus_change.connect([this](nux::Area *area, bool recieving, nux::KeyNavDirection direction) { @@ -96,6 +76,9 @@ }); } +HudButton::~HudButton() { +} + void HudButton::InitTheme() { is_rounded.changed.connect([&] (bool rounded) @@ -119,9 +102,9 @@ void HudButton::RedrawTheme(nux::Geometry const& geom, cairo_t* cr, nux::ButtonVisualState faked_state) { - dash::Style::Instance().SquareButton(cr, faked_state, label_, - is_rounded, 17, - dash::Alignment::LEFT, true); + dash::Style::Instance().SquareButton(cr, faked_state, "", + is_rounded, 17, + dash::Alignment::LEFT, true); } bool HudButton::AcceptKeyNavFocus() @@ -151,7 +134,11 @@ void HudButton::Draw(nux::GraphicsEngine& GfxContext, bool force_draw) { + if (skip_draw_) + return; + nux::Geometry const& geo = GetGeometry(); + GfxContext.PushClippingRectangle(geo); gPainter.PaintBackground(GfxContext, geo); // set up our texture mode nux::TexCoordXForm texxform; @@ -189,20 +176,38 @@ nux::Color(1.0f, 1.0f, 1.0f, 1.0f)); GfxContext.GetRenderStates().SetBlend(alpha, src, dest); -} -void HudButton::DrawContent(nux::GraphicsEngine& GfxContext, bool force_draw) { + GfxContext.PopClippingRectangle(); } -void HudButton::PostDraw(nux::GraphicsEngine& GfxContext, bool force_draw) { - nux::Button::PostDraw(GfxContext, force_draw); +void HudButton::DrawContent(nux::GraphicsEngine& GfxContext, bool force_draw) +{ + if (skip_draw_) + return; + + if (IsFullRedraw()) + { + GfxContext.PushClippingRectangle(GetGeometry()); + hlayout_->ProcessDraw(GfxContext, force_draw); + GfxContext.PopClippingRectangle(); + } } void HudButton::SetQuery(Query::Ptr query) { query_ = query; - label_ = query->formatted_text; label = query->formatted_text; + + auto items(impl::RefactorText(label())); + + hlayout_->Clear(); + for (auto item : items) + { + nux::StaticCairoText* text = new nux::StaticCairoText(item.first); + text->SetTextColor(nux::Color(1.0f, 1.0f, 1.0f, item.second ? 1.0f : 0.5f)); + text->SetFont(button_font); + hlayout_->AddView(text, 0, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FULL); + } } Query::Ptr HudButton::GetQuery() @@ -210,6 +215,12 @@ return query_; } +void HudButton::SetSkipDraw(bool skip_draw) +{ + skip_draw_ = skip_draw; +} + + // Introspectable std::string HudButton::GetName() const { @@ -219,8 +230,8 @@ void HudButton::AddProperties(GVariantBuilder* builder) { variant::BuilderWrapper(builder) - .add("label", label_); + .add("label", label()); } -} -} +} // namespace hud +} // namespace unity diff -Nru unity-5.12/plugins/unityshell/src/HudButton.h unity-5.14.0/plugins/unityshell/src/HudButton.h --- unity-5.12/plugins/unityshell/src/HudButton.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudButton.h 2012-07-18 11:12:56.000000000 +0000 @@ -29,54 +29,62 @@ #include #include #include + #include "Introspectable.h" -namespace unity { -namespace hud { +namespace nux { class HLayout; } + +namespace unity +{ +namespace hud +{ + class HudButton : public nux::Button, public unity::debug::Introspectable { - typedef nux::ObjectPtr BaseTexturePtr; + NUX_DECLARE_OBJECT_TYPE(HudButton, nux::Button); + public: typedef nux::ObjectPtr Ptr; - HudButton (nux::TextureArea *image, NUX_FILE_LINE_PROTO); - HudButton (const std::string label, NUX_FILE_LINE_PROTO); - HudButton (const std::string label, nux::TextureArea *image, NUX_FILE_LINE_PROTO); + HudButton (NUX_FILE_LINE_PROTO); virtual ~HudButton(); void SetQuery(Query::Ptr query); std::shared_ptr GetQuery(); + void SetSkipDraw(bool skip_draw); + nux::Property label; nux::Property hint; nux::Property is_rounded; nux::Property fake_focused; -protected: +protected: virtual bool AcceptKeyNavFocus(); virtual long ComputeContentSize(); virtual void Draw(nux::GraphicsEngine& GfxContext, bool force_draw); virtual void DrawContent(nux::GraphicsEngine& GfxContext, bool force_draw); - virtual void PostDraw(nux::GraphicsEngine& GfxContext, bool force_draw); std::string GetName() const; void AddProperties(GVariantBuilder* builder); - - void Init(); - void InitTheme (); - void RedrawTheme(nux::Geometry const& geom, cairo_t* cr, nux::ButtonVisualState faked_state); - typedef std::unique_ptr NuxCairoPtr; - NuxCairoPtr prelight_; - NuxCairoPtr active_; - NuxCairoPtr normal_; + void InitTheme(); + void RedrawTheme(nux::Geometry const& geom, cairo_t* cr, nux::ButtonVisualState faked_state); private: - std::string label_; + typedef std::unique_ptr NuxCairoPtr; Query::Ptr query_; nux::Geometry cached_geometry_; + bool is_focused_; + bool skip_draw_; + + NuxCairoPtr prelight_; + NuxCairoPtr active_; + NuxCairoPtr normal_; + + nux::HLayout* hlayout_; }; } } diff -Nru unity-5.12/plugins/unityshell/src/HudController.cpp unity-5.14.0/plugins/unityshell/src/HudController.cpp --- unity-5.12/plugins/unityshell/src/HudController.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudController.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -16,12 +16,14 @@ * Authored by: Gord Allott */ +#include + #include "HudController.h" #include #include #include -#include "PluginAdapter.h" +#include "WindowManager.h" #include "PanelStyle.h" #include "UBusMessages.h" #include "UScreen.h" @@ -38,7 +40,7 @@ nux::logging::Logger logger("unity.hud.controller"); } -Controller::Controller() +Controller::Controller(std::function const& function) : launcher_width(64) , launcher_locked_out(false) , multiple_launchers(true) @@ -52,6 +54,7 @@ , view_(nullptr) , monitor_index_(0) , type_wait_handle_(0) + , view_function_(function) { LOG_DEBUG(logger) << "hud startup"; SetupWindow(); @@ -76,7 +79,9 @@ launcher_width.changed.connect([&] (int new_width) { Relayout(); }); - PluginAdapter::Default()->compiz_screen_ungrabbed.connect(sigc::mem_fun(this, &Controller::OnScreenUngrabbed)); + auto wm = WindowManager::Default(); + wm->compiz_screen_ungrabbed.connect(sigc::mem_fun(this, &Controller::OnScreenUngrabbed)); + wm->initiate_spread.connect(sigc::bind(sigc::mem_fun(this, &Controller::HideHud), true)); hud_service_.queries_updated.connect(sigc::mem_fun(this, &Controller::OnQueriesFinished)); EnsureHud(); @@ -109,16 +114,17 @@ window_->mouse_down_outside_pointer_grab_area.connect(sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow)); /* FIXME - first time we load our windows there is a race that causes the input window not to actually get input, this side steps that by causing an input window show and hide before we really need it. */ - PluginAdapter::Default()->saveInputFocus (); + auto wm = WindowManager::Default(); + wm->saveInputFocus (); window_->EnableInputWindow(true, "Hud", true, false); window_->EnableInputWindow(false, "Hud", true, false); - PluginAdapter::Default()->restoreInputFocus (); + wm->restoreInputFocus (); } void Controller::SetupHudView() { LOG_DEBUG(logger) << "SetupHudView called"; - view_ = new View(); + view_ = view_function_(); layout_ = new nux::VLayout(NUX_TRACKER_LOCATION); layout_->AddView(view_, 1, nux::MINOR_POSITION_TOP); @@ -274,7 +280,7 @@ void Controller::ShowHud() { - PluginAdapter* adaptor = PluginAdapter::Default(); + WindowManager* adaptor = WindowManager::Default(); LOG_DEBUG(logger) << "Showing the hud"; EnsureHud(); @@ -397,7 +403,7 @@ restore = true; if (restore) - PluginAdapter::Default ()->restoreInputFocus (); + WindowManager::Default ()->restoreInputFocus (); hud_service_.CloseQuery(); @@ -447,6 +453,7 @@ if (!self->visible_) { self->window_->ShowWindow(false); + self->view_->ResetToDefault(); } else { diff -Nru unity-5.12/plugins/unityshell/src/HudController.h unity-5.14.0/plugins/unityshell/src/HudController.h --- unity-5.12/plugins/unityshell/src/HudController.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudController.h 2012-07-18 11:12:56.000000000 +0000 @@ -16,9 +16,10 @@ * Authored by: Neil Jagdish Patel */ -#ifndef UNITY_HUD_CONTROLLER_H_ -#define UNITY_HUD_CONTROLLER_H_ +#ifndef UNITYSHELL_HUD_CONTROLLER_H +#define UNITYSHELL_HUD_CONTROLLER_H +#include #include #include @@ -42,7 +43,7 @@ public: typedef std::shared_ptr Ptr; - Controller(); + Controller(std::function const& function = []() { return new View; }); ~Controller(); nux::BaseWindow* window() const; @@ -59,6 +60,7 @@ bool IsVisible(); protected: + // Introspectable std::string GetName() const; void AddProperties(GVariantBuilder* builder); @@ -104,16 +106,19 @@ float last_opacity_; gint64 start_time_; - View* view_; + AbstractView* view_; guint ensure_id_; std::string focused_app_icon_; nux::Layout* layout_; uint monitor_index_; guint type_wait_handle_; std::string last_search_; + + std::function view_function_; }; +} // namespace hud +} // namespace unity + +#endif // UNITYSHELL_HUD_CONTROLLER_H -} -} -#endif diff -Nru unity-5.12/plugins/unityshell/src/HudPrivate.cpp unity-5.14.0/plugins/unityshell/src/HudPrivate.cpp --- unity-5.12/plugins/unityshell/src/HudPrivate.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudPrivate.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,78 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Andrea Azzarone + * Tim Penhey + * + */ + +#include "HudPrivate.h" + +namespace unity +{ +namespace hud +{ +namespace impl +{ + +std::vector> RefactorText(std::string const& text) +{ + std::vector> ret; + + static const std::string bold_start(""); + static const std::string bold_end(""); + + std::string::size_type last = 0; + std::string::size_type len = text.length(); + std::string::size_type pos = text.find(bold_start); + + while (pos != std::string::npos) + { + if (pos != last) + { + ret.push_back(std::pair(text.substr(last, pos - last), false)); + } + + // Look for the end + pos += 3; // // to skip the "" + std::string::size_type end_pos = text.find(bold_end, pos); + // We hope we find it, if we don't, just output everything... + if (end_pos != std::string::npos) + { + ret.push_back(std::pair(text.substr(pos, end_pos - pos), true)); + last = end_pos + 4; // the length of "" + pos = text.find(bold_start, last); + } + else + { + ret.push_back(std::pair(text.substr(pos), true)); + pos = std::string::npos; + last = len; + } + } + + if (last < len) + { + ret.push_back(std::pair(text.substr(last), false)); + } + + return ret; +} + +} // namespace unity +} // namespace hud +} // namespace impl diff -Nru unity-5.12/plugins/unityshell/src/HudPrivate.h unity-5.14.0/plugins/unityshell/src/HudPrivate.h --- unity-5.12/plugins/unityshell/src/HudPrivate.h 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudPrivate.h 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,42 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Andrea Azzarone + * + */ + +#ifndef UNITYSHELL_HUD_PRIVATE_H +#define UNITYSHELL_HUD_PRIVATE_H + +#include +#include +#include + +namespace unity +{ +namespace hud +{ +namespace impl +{ + +std::vector> RefactorText(std::string const& text); + +} // namespace impl +} // namespace hud +} // namespace unity + +#endif // UNITYSHELL_HUD_PRIVATE_H diff -Nru unity-5.12/plugins/unityshell/src/HudView.cpp unity-5.14.0/plugins/unityshell/src/HudView.cpp --- unity-5.12/plugins/unityshell/src/HudView.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudView.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -25,9 +25,8 @@ #include #include #include +#include -#include -#include "HudButton.h" #include "UBusMessages.h" #include "DashStyle.h" @@ -38,24 +37,27 @@ namespace { + nux::logging::Logger logger("unity.hud.view"); + const int grow_anim_length = 90 * 1000; const int pause_before_grow_length = 32 * 1000; const int default_width = 960; const int default_height = 276; -const int content_width = 941; +const int content_width = 939; const int top_padding = 11; -const int bottom_padding = 9; +const int bottom_padding = 10; const int left_padding = 11; const int right_padding = 0; + } NUX_IMPLEMENT_OBJECT_TYPE(View); View::View() - : nux::View(NUX_TRACKER_LOCATION) + : AbstractView() , button_views_(NULL) , timeline_id_(0) , start_time_(0) @@ -70,11 +72,6 @@ QueueDraw(); }); - nux::ROPConfig rop; - rop.Blend = true; - rop.SrcBlend = GL_ONE; - rop.DstBlend = GL_ONE_MINUS_SRC_ALPHA; - SetupViews(); search_bar_->key_down.connect (sigc::mem_fun (this, &View::OnKeyDown)); @@ -157,6 +154,11 @@ current_height_ = new_height; } + for (auto button : buttons_) + { + button->SetSkipDraw((button->GetAbsoluteY() + button->GetBaseHeight()) > (GetAbsoluteY() + current_height_)); + } + QueueDraw(); if (diff > grow_anim_length + pause_before_grow_length) @@ -171,6 +173,9 @@ void View::ResetToDefault() { + SetQueries(Hud::Queries()); + current_height_ = content_layout_->GetBaseHeight(); + search_bar_->search_string = ""; search_bar_->search_hint = _("Type your command"); } @@ -213,6 +218,12 @@ return search_bar_->text_entry(); } +std::list const& View::buttons() const +{ + return buttons_; +} + + void View::SetQueries(Hud::Queries queries) { // early exit, if the user is key navigating on the hud, we don't want to set new @@ -231,14 +242,16 @@ buttons_.clear(); button_views_->Clear(); int found_items = 0; - for (auto query = queries.begin(); query != queries.end(); query++) + for (auto query : queries) { if (found_items >= 5) break; HudButton::Ptr button(new HudButton()); buttons_.push_front(button); - button->SetQuery(*query); + button->SetMinimumWidth(content_width); + button->SetMaximumWidth(content_width); + button->SetQuery(query); button_views_->AddView(button.GetPointer(), 0, nux::MINOR_POSITION_LEFT); @@ -246,30 +259,31 @@ query_activated.emit(dynamic_cast(view)->GetQuery()); }); - button->key_nav_focus_activate.connect([&](nux::Area *area) { + button->key_nav_focus_activate.connect([&](nux::Area* area) { query_activated.emit(dynamic_cast(area)->GetQuery()); }); - button->key_nav_focus_change.connect([&](nux::Area *area, bool recieving, KeyNavDirection direction){ + button->key_nav_focus_change.connect([&](nux::Area* area, bool recieving, KeyNavDirection direction){ if (recieving) query_selected.emit(dynamic_cast(area)->GetQuery()); }); - // You should never decrement end(). We should fix this loop. - button->is_rounded = (query == --(queries.end())) ? true : false; - button->fake_focused = (query == (queries.begin())) ? true : false; - - button->SetMinimumWidth(content_width); - found_items++; + ++found_items; } + if (found_items) + { + buttons_.front()->is_rounded = true; + buttons_.back()->fake_focused = true; selected_button_ = 1; + } + QueueRelayout(); QueueDraw(); } -void View::SetIcon(std::string icon_name, unsigned int tile_size, unsigned int size, unsigned int padding) +void View::SetIcon(std::string const& icon_name, unsigned int tile_size, unsigned int size, unsigned int padding) { if (!icon_) return; @@ -349,7 +363,7 @@ { dash::Style& style = dash::Style::Instance(); - nux::VLayout* super_layout = new nux::VLayout(); + nux::VLayout* super_layout = new nux::VLayout(); layout_ = new nux::HLayout(); { // fill layout with icon @@ -393,12 +407,11 @@ LOG_DEBUG(logger) << "got search change"; search_changed.emit(search_string); - std::list::iterator it; - for(it = buttons_.begin(); it != buttons_.end(); ++it) + for (auto button : buttons_) { - (*it)->fake_focused = false; + button->fake_focused = false; } - + if (!buttons_.empty()) buttons_.back()->fake_focused = true; } @@ -417,7 +430,9 @@ void View::OnMouseButtonDown(int x, int y, unsigned long button, unsigned long key) { - if (!content_geo_.IsPointInside(x, y)) + nux::Geometry current_geo(content_geo_); + current_geo.height = current_height_; + if (!current_geo.IsPointInside(x, y)) { ubus.SendMessage(UBUS_HUD_CLOSE_REQUEST); } @@ -443,9 +458,21 @@ renderer_.DrawInner(gfx_context, draw_content_geo, absolute_window_geometry_, window_geometry_); gfx_context.PushClippingRectangle(draw_content_geo); + if (IsFullRedraw()) { nux::GetPainter().PushBackgroundStack(); + + if (!buttons_.empty()) // See bug #1008603. + { + int height = 3; + int x = search_bar_->GetBaseX() + 1; + int y = search_bar_->GetBaseY() + search_bar_->GetBaseHeight() - height; + nux::GetPainter().Draw2DLine(gfx_context, x, y, x, y + height, nux::color::White * 0.13); + x += content_width - 1; + nux::GetPainter().Draw2DLine(gfx_context, x, y, x, y + height, nux::color::White * 0.13); + } + GetLayout()->ProcessDraw(gfx_context, force_draw); nux::GetPainter().PopBackgroundStack(); } @@ -485,7 +512,7 @@ { unsigned num_buttons = buttons_.size(); variant::BuilderWrapper(builder) - .add(GetGeometry()) + .add(content_geo_) .add("selected_button", selected_button_) .add("num_buttons", num_buttons); } diff -Nru unity-5.12/plugins/unityshell/src/HudView.h unity-5.14.0/plugins/unityshell/src/HudView.h --- unity-5.12/plugins/unityshell/src/HudView.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/HudView.h 2012-07-18 11:12:56.000000000 +0000 @@ -16,34 +16,32 @@ * Authored by: Gordon Allott */ -#ifndef UNITY_HUD_VIEW_H_ -#define UNITY_HUD_VIEW_H_ +#ifndef UNITYSHELL_HUD_VIEW_H +#define UNITYSHELL_HUD_VIEW_H #include #include -#include #include -#include -#include "Introspectable.h" - -#include "UBusWrapper.h" +#include "HudAbstractView.h" #include "HudIcon.h" #include "HudButton.h" #include "SearchBar.h" #include "OverlayRenderer.h" +#include "UBusWrapper.h" namespace unity { namespace hud { -class View : public nux::View, public unity::debug::Introspectable +class View : public AbstractView { - NUX_DECLARE_OBJECT_TYPE(HudView, nux::View); - typedef nux::ObjectPtr Ptr; + NUX_DECLARE_OBJECT_TYPE(HudView, AbstractView); public: + typedef nux::ObjectPtr Ptr; + View(); ~View(); @@ -51,9 +49,10 @@ void Relayout(); nux::View* default_focus() const; + std::list const& buttons() const; void SetQueries(Hud::Queries queries); - void SetIcon(std::string icon_name, unsigned int tile_size, unsigned int size, unsigned int padding); + void SetIcon(std::string const& icon_name, unsigned int tile_size, unsigned int size, unsigned int padding); void ShowEmbeddedIcon(bool show); void SearchFinished(); @@ -61,11 +60,6 @@ void AboutToHide(); void SetWindowGeometry(nux::Geometry const& absolute_geo, nux::Geometry const& geo); - - sigc::signal search_changed; - sigc::signal search_activated; - sigc::signal query_activated; - sigc::signal query_selected; protected: virtual Area* FindKeyFocusArea(unsigned int event_type, @@ -75,6 +69,7 @@ void SetupViews(); void OnSearchChanged(std::string const& search_string); virtual long PostLayoutManagement(long LayoutResult); + private: void OnMouseButtonDown(int x, int y, unsigned long button, unsigned long key); void OnKeyDown (unsigned long event_type, unsigned long event_keysym, @@ -120,7 +115,8 @@ bool activated_signal_sent_; }; +} // namespace hud +} // namespace unity + +#endif // UNITYSHELL_HUD_VIEW_H -} -} -#endif diff -Nru unity-5.12/plugins/unityshell/src/IMTextEntry.cpp unity-5.14.0/plugins/unityshell/src/IMTextEntry.cpp --- unity-5.12/plugins/unityshell/src/IMTextEntry.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/IMTextEntry.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -44,52 +44,49 @@ unsigned int keysym, const char* character) { - bool need_to_filter_event = TryHandleSpecial(event_type, keysym, character); - + nux::Event const& event = nux::GetGraphicsDisplay()->GetCurrentEvent(); + bool need_to_filter_event = TryHandleSpecial(event); + if (need_to_filter_event) need_to_filter_event = TextEntry::InspectKeyEvent(event_type, keysym, character); - + return need_to_filter_event; } -bool IMTextEntry::TryHandleSpecial(unsigned int eventType, unsigned int keysym, const char* character) +bool IMTextEntry::TryHandleSpecial(nux::Event const& event) { - nux::Event event = nux::GetWindowThread()->GetGraphicsDisplay().GetCurrentEvent(); - unsigned int keyval = keysym; - bool shift = (event.GetKeyState() & NUX_STATE_SHIFT); - bool ctrl = (event.GetKeyState() & NUX_STATE_CTRL); - /* If there is preedit, handle the event else where, but we want to be able to copy/paste while ibus is active */ if (!preedit_.empty()) return true; - if (eventType != NUX_KEYDOWN) + if (event.type != NUX_KEYDOWN) return false; - if (((keyval == NUX_VK_x) && ctrl && !shift) || - ((keyval == NUX_VK_DELETE) && shift && !ctrl)) + unsigned int keyval = event.GetKeySym(); + bool shift = event.GetKeyModifierState(KEY_MODIFIER_SHIFT); + bool ctrl = event.GetKeyModifierState(KEY_MODIFIER_CTRL); + bool super = event.GetKeyModifierState(KEY_MODIFIER_SUPER); + + if ((ctrl && !shift && keyval == NUX_VK_x) || // Ctrl + X + (shift && !ctrl && keyval == NUX_VK_DELETE)) // Shift + Del { Cut(); } - else if (((keyval == NUX_VK_c) && ctrl && (!shift)) || - ((keyval == NUX_VK_INSERT) && ctrl && (!shift))) + else if (ctrl && !shift && (keyval == NUX_VK_c || keyval == NUX_VK_INSERT)) // Ctrl + C / Ins { Copy(); } - else if (((keyval == NUX_VK_v) && ctrl && (!shift)) || - ((keyval == NUX_VK_INSERT) && shift && (!ctrl))) + else if ((ctrl && !shift && keyval == NUX_VK_v) || // Ctrl + V + (shift && !ctrl && keyval == NUX_VK_INSERT)) // Shift + Ins { Paste(); } - else if (keyval == NUX_VK_TAB || keyval == NUX_VK_LEFT_TAB) - { - return true; - } - else + else if (!super) { return true; } + return false; } @@ -146,10 +143,10 @@ int button = nux::GetEventButton(bflags); if (button == 2) - { + { SetCursor(XYToTextIndex(x,y)); Paste(true); - } + } } bool IMTextEntry::im_preedit() diff -Nru unity-5.12/plugins/unityshell/src/IMTextEntry.h unity-5.14.0/plugins/unityshell/src/IMTextEntry.h --- unity-5.12/plugins/unityshell/src/IMTextEntry.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/IMTextEntry.h 2012-07-18 11:12:56.000000000 +0000 @@ -43,13 +43,14 @@ private: bool InspectKeyEvent(unsigned int eventType, unsigned int keysym, const char* character); - bool TryHandleSpecial(unsigned int eventType, unsigned int keysym, const char* character); - void InsertText(std::string const& text); - void Cut(); - void Copy(); - void Paste(bool primary = false); - void OnMouseButtonUp(int x, int y, unsigned long bflags, unsigned long kflags); + +protected: + bool TryHandleSpecial(nux::Event const& event); + virtual void InsertText(std::string const& text); + virtual void Cut(); + virtual void Copy(); + virtual void Paste(bool primary = false); }; } diff -Nru unity-5.12/plugins/unityshell/src/KeyboardUtil.cpp unity-5.14.0/plugins/unityshell/src/KeyboardUtil.cpp --- unity-5.12/plugins/unityshell/src/KeyboardUtil.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/KeyboardUtil.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -17,29 +17,29 @@ * Authored by: Jason Smith */ +#include #include - -#include #include #include "KeyboardUtil.h" namespace unity { namespace ui { +namespace { + const unsigned int FETCH_MASK = XkbGBN_KeyNamesMask | XkbGBN_ClientSymbolsMask | XkbGBN_GeometryMask; +} KeyboardUtil::KeyboardUtil(Display *display) : display_(display) -{ - unsigned int fetch_mask = XkbGBN_KeyNamesMask | XkbGBN_ClientSymbolsMask | XkbGBN_GeometryMask; - keyboard_ = XkbGetKeyboard (display, fetch_mask, XkbUseCoreKbd); -} + , keyboard_(XkbGetKeyboard(display_, FETCH_MASK, XkbUseCoreKbd)) +{} KeyboardUtil::~KeyboardUtil() { - XkbFreeKeyboard (keyboard_, 0, True); + XkbFreeKeyboard(keyboard_, 0, True); } -bool KeyboardUtil::FindKeyInGeometry(XkbGeometryPtr geo, char *key_name, int& res_section, XkbBoundsRec& res_bounds) +bool KeyboardUtil::FindKeyInGeometry(XkbGeometryPtr geo, char *key_name, int& res_section, XkbBoundsRec& res_bounds) const { // seems that Xkb does not give null terminated strings... was painful int name_length = XkbKeyNameLength; @@ -73,7 +73,7 @@ return false; } -bool KeyboardUtil::CompareOffsets (int current_x, int current_y, int best_x, int best_y) +bool KeyboardUtil::CompareOffsets(int current_x, int current_y, int best_x, int best_y) const { // never EVER prefer something higher on the keyboard than what we have if (current_y > best_y) @@ -85,8 +85,11 @@ return false; } -guint KeyboardUtil::ConvertKeyToKeycode (XkbKeyPtr key) +guint KeyboardUtil::ConvertKeyToKeycode(XkbKeyPtr key) const { + if (!keyboard_) + return 0; + int min_code = keyboard_->min_key_code; int max_code = keyboard_->max_key_code; @@ -95,10 +98,11 @@ if (!strncmp(key->name.name, keyboard_->names->keys[i].name, XkbKeyNameLength)) return i; } + return 0; } -XkbBoundsRec KeyboardUtil::GetAbsoluteKeyBounds (XkbKeyPtr key, XkbRowPtr row, XkbSectionPtr section, XkbGeometryPtr geo) +XkbBoundsRec KeyboardUtil::GetAbsoluteKeyBounds(XkbKeyPtr key, XkbRowPtr row, XkbSectionPtr section, XkbGeometryPtr geo) const { XkbShapePtr shape = XkbKeyShape(geo, key); @@ -117,7 +121,7 @@ y_offset += local_shape->bounds.y2 - local_shape->bounds.y1; else x_offset += local_shape->bounds.x2 - local_shape->bounds.x1; - + i++; } @@ -129,7 +133,7 @@ return result; } -bool KeyboardUtil::FindKeyInSectionAboveBounds (XkbGeometryPtr geo, int section_index, XkbBoundsRec const& target_bounds, guint &keycode) +bool KeyboardUtil::FindKeyInSectionAboveBounds(XkbGeometryPtr geo, int section_index, XkbBoundsRec const& target_bounds, guint &keycode) const { XkbKeyPtr best = NULL; int best_x_offset = G_MAXINT; @@ -155,7 +159,7 @@ int center = (bounds.x1 + bounds.x2) / 2; if (center < target_bounds.x1 || center > target_bounds.x2) continue; - + // make sure the key is actually above our target. int current_y_offset = target_bounds.y1 - bounds.y2; if (current_y_offset < 0) @@ -181,13 +185,13 @@ return false; } -guint KeyboardUtil::GetKeycodeAboveKeySymbol(KeySym key_symbol) +guint KeyboardUtil::GetKeycodeAboveKeySymbol(KeySym key_symbol) const { guint result = 0; int code = XKeysymToKeycode(display_, key_symbol); - if (!code) + if (!code || !keyboard_) return result; if (keyboard_->min_key_code > code || keyboard_->max_key_code < code) @@ -208,9 +212,38 @@ if (found_key) result = maybe; } - + return result; } +bool KeyboardUtil::IsPrintableKeySymbol(KeySym sym) +{ + bool printable_key = false; + + if (sym == XK_Delete || sym == XK_BackSpace || sym == XK_Return) + { + printable_key = true; + } + else + { + unsigned int unicode = gdk_keyval_to_unicode(sym); + printable_key = g_unichar_isprint(unicode); + } + + return printable_key; +} + +bool KeyboardUtil::IsMoveKeySymbol(KeySym sym) +{ + bool move_key = false; + + if (sym >= XK_Home && sym <= XK_Begin) + { + move_key = true; + } + + return move_key; +} + } } \ No newline at end of file diff -Nru unity-5.12/plugins/unityshell/src/KeyboardUtil.h unity-5.14.0/plugins/unityshell/src/KeyboardUtil.h --- unity-5.12/plugins/unityshell/src/KeyboardUtil.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/KeyboardUtil.h 2012-07-18 11:12:56.000000000 +0000 @@ -33,25 +33,26 @@ class KeyboardUtil { - public: - KeyboardUtil(Display *display); - virtual ~KeyboardUtil(); + ~KeyboardUtil(); + + guint GetKeycodeAboveKeySymbol(KeySym key_symbol) const; - guint GetKeycodeAboveKeySymbol(KeySym key_symbol); + static bool IsPrintableKeySymbol(KeySym key_symbol); + static bool IsMoveKeySymbol(KeySym sym); private: - bool CompareOffsets (int current_x, int current_y, int best_x, int best_y); - guint ConvertKeyToKeycode (XkbKeyPtr key); + bool CompareOffsets (int current_x, int current_y, int best_x, int best_y) const; + guint ConvertKeyToKeycode (XkbKeyPtr key) const; - bool FindKeyInGeometry(XkbGeometryPtr geo, char *key_name, int& res_section, XkbBoundsRec& res_bounds); - bool FindKeyInSectionAboveBounds (XkbGeometryPtr geo, int section, XkbBoundsRec const& target_bounds, guint &keycode); + bool FindKeyInGeometry(XkbGeometryPtr geo, char *key_name, int& res_section, XkbBoundsRec& res_bounds) const; + bool FindKeyInSectionAboveBounds (XkbGeometryPtr geo, int section, XkbBoundsRec const& target_bounds, guint &keycode) const; - XkbBoundsRec GetAbsoluteKeyBounds (XkbKeyPtr key, XkbRowPtr row, XkbSectionPtr section, XkbGeometryPtr geo); + XkbBoundsRec GetAbsoluteKeyBounds (XkbKeyPtr key, XkbRowPtr row, XkbSectionPtr section, XkbGeometryPtr geo) const; - XkbDescPtr keyboard_; Display *display_; + XkbDescPtr keyboard_; }; } diff -Nru unity-5.12/plugins/unityshell/src/LauncherController.cpp unity-5.14.0/plugins/unityshell/src/LauncherController.cpp --- unity-5.12/plugins/unityshell/src/LauncherController.cpp 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/LauncherController.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -130,6 +130,8 @@ void OnWindowFocusChanged (guint32 xid); + void OnViewOpened(BamfMatcher* matcher, BamfView* view); + void ReceiveMouseDownOutsideArea(int x, int y, unsigned long button_flags, unsigned long key_flags); void ReceiveLauncherKeyPress(unsigned long eventType, @@ -138,17 +140,14 @@ const char* character, unsigned short keyCount); - /* statics */ - - static void OnViewOpened(BamfMatcher* matcher, BamfView* view, gpointer data); - Controller* parent_; glib::Object matcher_; + glib::Signal view_opened_signal_; LauncherModel::Ptr model_; nux::ObjectPtr launcher_; nux::ObjectPtr keyboard_launcher_; int sort_priority_; - DeviceLauncherSection* device_section_; + DeviceLauncherSection device_section_; LauncherEntryRemoteModel remote_model_; AbstractLauncherIcon::Ptr expo_icon_; AbstractLauncherIcon::Ptr desktop_icon_; @@ -157,7 +156,6 @@ Display* display_; guint bamf_timer_handler_id_; - guint on_view_opened_id_; guint launcher_key_press_handler_id_; guint launcher_label_show_handler_id_; guint launcher_hide_handler_id_; @@ -210,9 +208,7 @@ EnsureLaunchers(primary, monitors); launcher_ = launchers[0]; - - device_section_ = new DeviceLauncherSection(); - device_section_->IconAdded.connect(sigc::mem_fun(this, &Impl::OnIconAdded)); + device_section_.IconAdded.connect(sigc::mem_fun(this, &Impl::OnIconAdded)); num_workspaces_ = WindowManager::Default()->WorkspaceCount(); if (num_workspaces_ > 1) @@ -289,11 +285,6 @@ if (bamf_timer_handler_id_ != 0) g_source_remove(bamf_timer_handler_id_); - - if (matcher_ != nullptr && on_view_opened_id_ != 0) - g_signal_handler_disconnect((gpointer) matcher_, on_view_opened_id_); - - delete device_section_; } void Controller::Impl::EnsureLaunchers(int primary, std::vector const& monitors) @@ -466,6 +457,11 @@ return; } + // Check if desktop file was supplied, or if it's set to SC's agent + // See https://bugs.launchpad.net/unity/+bug/1002440 + if (path.empty() || path == "software-center-agent") + return; + SoftwareCenterLauncherIcon::Ptr result = CreateSCLauncherIcon(path, aptdaemon_trans_id, icon_path); launcher_->ForceReveal(true); @@ -724,15 +720,12 @@ } /* static private */ -void Controller::Impl::OnViewOpened(BamfMatcher* matcher, BamfView* view, gpointer data) +void Controller::Impl::OnViewOpened(BamfMatcher* matcher, BamfView* view) { - Impl* self = static_cast(data); - BamfApplication* app; - if (!BAMF_IS_APPLICATION(view)) return; - app = BAMF_APPLICATION(view); + BamfApplication* app = BAMF_APPLICATION(view); if (bamf_view_is_sticky(view) || g_object_get_qdata(G_OBJECT(app), g_quark_from_static_string("unity-seen"))) @@ -741,10 +734,10 @@ } AbstractLauncherIcon::Ptr icon(new BamfLauncherIcon(app)); - icon->visibility_changed.connect(sigc::mem_fun(self, &Impl::SortAndUpdate)); - icon->SetSortPriority(self->sort_priority_++); - self->RegisterIcon(icon); - self->SortAndUpdate(); + icon->visibility_changed.connect(sigc::mem_fun(this, &Impl::SortAndUpdate)); + icon->SetSortPriority(sort_priority_++); + RegisterIcon(icon); + SortAndUpdate(); } AbstractLauncherIcon::Ptr Controller::Impl::CreateFavorite(const char* file_path) @@ -821,7 +814,7 @@ } apps = bamf_matcher_get_applications(matcher_); - on_view_opened_id_ = g_signal_connect(matcher_, "view-opened", (GCallback) &Impl::OnViewOpened, this); + view_opened_signal_.Connect(matcher_, "view-opened", sigc::mem_fun(this, &Impl::OnViewOpened)); for (l = apps; l; l = l->next) { @@ -1209,7 +1202,13 @@ } if (activate) - pimpl->model_->Selection()->Activate(ActionArg(ActionArg::LAUNCHER, 0)); + { + g_idle_add([] (gpointer data) -> gboolean { + Controller *self = (Controller*)data; + self->pimpl->model_->Selection()->Activate(ActionArg(ActionArg::LAUNCHER, 0)); + return FALSE; + }, this); + } pimpl->launcher_keynav = false; if (!pimpl->launcher_open) diff -Nru unity-5.12/plugins/unityshell/src/Launcher.cpp unity-5.14.0/plugins/unityshell/src/Launcher.cpp --- unity-5.12/plugins/unityshell/src/Launcher.cpp 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/Launcher.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -331,6 +331,11 @@ delete _hover_machine; delete _hide_machine; + + g_free(_sc_icon); + g_free(_sc_icon_title); + g_free(_sc_icon_desktop_file); + g_free(_sc_icon_aptdaemon_task); } /* Introspection */ @@ -2101,10 +2106,10 @@ if (_sc_anim_icon) { launcher_addrequest_special.emit(_sc_icon_desktop_file, AbstractLauncherIcon::Ptr(), _sc_icon_aptdaemon_task, _sc_icon, _sc_icon_x, _sc_icon_y, _sc_icon_size); - g_free(_sc_icon); - g_free(_sc_icon_title); - g_free(_sc_icon_desktop_file); - g_free(_sc_icon_aptdaemon_task); + g_free(_sc_icon); _sc_icon = NULL; + g_free(_sc_icon_title); _sc_icon_title = NULL; + g_free(_sc_icon_desktop_file); _sc_icon_desktop_file = NULL; + g_free(_sc_icon_aptdaemon_task); _sc_icon_aptdaemon_task = NULL; _sc_anim_icon = false; } } @@ -2267,8 +2272,36 @@ if (progress >= 1.0f) _model->ReorderSmart(_drag_icon, hovered_icon, true); - else if (progress == 0.0f) - _model->ReorderBefore(_drag_icon, hovered_icon, false); + else if (progress == 0.0f) { + if (_drag_icon->GetIconType() == hovered_icon->GetIconType()) { + _model->ReorderBefore(_drag_icon, hovered_icon, false); + } else { + // LauncherModel::ReorderBefore does not work on different icon types + // so if hovered_icon is of a different type than _drag_icon + // try to use LauncherModel::ReorderAfter with the icon that is before hovered_icon + AbstractLauncherIcon::Ptr iconBeforeHover; + LauncherModel::iterator it; + LauncherModel::iterator prevIt = _model->end(); + for (it = _model->begin(); it != _model->end(); it++) + { + if (!(*it)->GetQuirk(AbstractLauncherIcon::QUIRK_VISIBLE) || !(*it)->IsVisibleOnMonitor(monitor)) + continue; + + if ((*it) == hovered_icon) { + if (prevIt != _model->end()) { + iconBeforeHover = *prevIt; + } + break; + } + + prevIt = it; + } + + if (iconBeforeHover && _drag_icon != iconBeforeHover) { + _model->ReorderAfter(_drag_icon, iconBeforeHover); + } + } + } } } } @@ -2557,7 +2590,7 @@ g_source_remove(_start_dragicon_handle); _start_dragicon_handle = g_timeout_add(START_DRAGICON_DURATION, &Launcher::StartIconDragTimeout, this); - launcher_icon->mouse_down.emit(nux::GetEventButton(button_flags), monitor); + launcher_icon->mouse_down.emit(nux::GetEventButton(button_flags), key_flags, monitor); } } @@ -2573,19 +2606,20 @@ if (_icon_mouse_down && (_icon_mouse_down == launcher_icon)) { - _icon_mouse_down->mouse_up.emit(nux::GetEventButton(button_flags), monitor); + _icon_mouse_down->mouse_up.emit(nux::GetEventButton(button_flags), key_flags, monitor); if (GetActionState() == ACTION_NONE) { + /* This will inform the icon if the action is valid for all the monitors */ int action_monitor = options()->show_for_all ? -1 : monitor; - _icon_mouse_down->mouse_click.emit(nux::GetEventButton(button_flags), action_monitor); + _icon_mouse_down->mouse_click.emit(nux::GetEventButton(button_flags), key_flags, action_monitor); } } if (launcher_icon && (_icon_mouse_down != launcher_icon)) { - launcher_icon->mouse_up.emit(nux::GetEventButton(button_flags), monitor); + launcher_icon->mouse_up.emit(nux::GetEventButton(button_flags), key_flags, monitor); } if (GetActionState() == ACTION_DRAG_LAUNCHER) @@ -2691,9 +2725,6 @@ _hide_machine->SetQuirk(LauncherHideMachine::EXTERNAL_DND_ACTIVE, true); - if (IsOverlayOpen()) - SaturateIcons(); - for (auto it : _dnd_data.Uris()) { if (g_str_has_suffix(it.c_str(), ".desktop")) @@ -2708,11 +2739,22 @@ for (auto it : *_model) { if (it->ShouldHighlightOnDrag(_dnd_data)) + { + it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, false); it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_PRELIGHT, true); + it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, true); + } else + { it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_DIM, true); + } } } + else + { + if (IsOverlayOpen()) + SaturateIcons(); + } } void @@ -2737,6 +2779,7 @@ { it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_PRELIGHT, false); it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_DIM, false); + it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, false); } DndHoveredIconReset(); @@ -2807,7 +2850,7 @@ { for (auto it : *_model) { - if (it->QueryAcceptDrop(_dnd_data) != nux::DNDACTION_NONE) + if (it->ShouldHighlightOnDrag(_dnd_data)) it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_PRELIGHT, true); else it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_DIM, true); @@ -2935,6 +2978,9 @@ } else if (_dnd_hovered_icon && _drag_action != nux::DNDACTION_NONE) { + if (IsOverlayOpen()) + ubus.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST); + _dnd_hovered_icon->AcceptDrop(_dnd_data); } @@ -2975,6 +3021,9 @@ { Launcher* self = (Launcher*)user_data; self->_sc_anim_icon = true; + g_free(self->_sc_icon); + g_free(self->_sc_icon_desktop_file); + g_free(self->_sc_icon_aptdaemon_task); g_variant_get(parameters, "(ssiiiss)", &self->_sc_icon_title, &self->_sc_icon, &self->_sc_icon_x, @@ -2984,6 +3033,8 @@ &self->_sc_icon_aptdaemon_task, NULL); g_dbus_method_invocation_return_value(invocation, nullptr); + + self->EnsureAnimation(); } } diff -Nru unity-5.12/plugins/unityshell/src/LauncherIcon.cpp unity-5.14.0/plugins/unityshell/src/LauncherIcon.cpp --- unity-5.12/plugins/unityshell/src/LauncherIcon.cpp 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/LauncherIcon.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -630,13 +630,13 @@ return true; } -void LauncherIcon::RecvMouseDown(int button, int monitor) +void LauncherIcon::RecvMouseDown(int button, unsigned long key_flags, int monitor) { if (button == 3) OpenQuicklist(); } -void LauncherIcon::RecvMouseUp(int button, int monitor) +void LauncherIcon::RecvMouseUp(int button, unsigned long key_flags, int monitor) { if (button == 3) { @@ -645,14 +645,17 @@ } } -void LauncherIcon::RecvMouseClick(int button, int monitor) +void LauncherIcon::RecvMouseClick(int button, unsigned long key_flags, int monitor) { ActionArg arg(ActionArg::LAUNCHER, button); arg.monitor = monitor; + bool shift_pressed = nux::GetKeyModifierState(key_flags, nux::NUX_STATE_SHIFT); - if (button == 1) + // Click without shift + if (button == 1 && !shift_pressed) Activate(arg); - else if (button == 2) + // Middle click or click with shift + else if ((button == 2) || (button == 1 && shift_pressed)) OpenInstance(arg); } diff -Nru unity-5.12/plugins/unityshell/src/LauncherIcon.h unity-5.14.0/plugins/unityshell/src/LauncherIcon.h --- unity-5.12/plugins/unityshell/src/LauncherIcon.h 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/LauncherIcon.h 2012-07-18 11:12:56.000000000 +0000 @@ -76,11 +76,11 @@ void RecvMouseLeave(int monitor); - void RecvMouseDown(int button, int monitor); + void RecvMouseDown(int button, unsigned long key_flags, int monitor); - void RecvMouseUp(int button, int monitor); + void RecvMouseUp(int button, unsigned long key_flags, int monitor); - void RecvMouseClick(int button, int monitor); + void RecvMouseClick(int button, unsigned long key_flags, int monitor); void HideTooltip(); diff -Nru unity-5.12/plugins/unityshell/src/PluginAdapter.cpp unity-5.14.0/plugins/unityshell/src/PluginAdapter.cpp --- unity-5.12/plugins/unityshell/src/PluginAdapter.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/PluginAdapter.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -533,9 +533,7 @@ PluginAdapter::IsWindowOnTop(guint32 xid) { Window win = xid; - CompWindow* window; - - window = m_Screen->findWindow(win); + CompWindow* window = m_Screen->findWindow(win); if (window) { @@ -543,6 +541,7 @@ return false; CompPoint window_vp = window->defaultViewport(); + nux::Geometry const& window_vp_geo = GetWorkAreaGeometry(window->id()); std::vector const& our_xids = nux::XInputWindow::NativeHandleList(); for (CompWindow* sibling = window->next; sibling; sibling = sibling->next) @@ -550,6 +549,13 @@ if (sibling->defaultViewport() == window_vp && !sibling->minimized() && sibling->isMapped() && sibling->isViewable() && !sibling->inShowDesktopMode() && !(sibling->state() & CompWindowStateAboveMask) && + !(sibling->type() & CompWindowTypeSplashMask) && + !(sibling->type() & CompWindowTypeDockMask) && + /* FIXME: This should be included by the above defaultViewport() check, + * but it doesn't seem to work correctly when there's only one workspace + * enabled, so please drop the line above when bug #996604 is fixed in + * Compiz. */ + !window_vp_geo.Intersect(GetWindowGeometry(sibling->id())).IsNull() && std::find(our_xids.begin(), our_xids.end(), sibling->id()) == our_xids.end()) { return false; diff -Nru unity-5.12/plugins/unityshell/src/QuicklistView.cpp unity-5.14.0/plugins/unityshell/src/QuicklistView.cpp --- unity-5.12/plugins/unityshell/src/QuicklistView.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/QuicklistView.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -65,8 +65,6 @@ , _corner_radius(4) , _padding(13) , _left_padding_correction(-1) - , _bottom_padding_correction_normal(-2) - , _bottom_padding_correction_single_item(-4) , _offset_correction(-1) , _cairo_text_has_changed(true) , _current_item_index(-1) @@ -101,8 +99,6 @@ _item_layout = new nux::VLayout(TEXT(""), NUX_TRACKER_LOCATION); _vlayout->AddLayout(_item_layout, 0); - _default_item_layout = new nux::VLayout(TEXT(""), NUX_TRACKER_LOCATION); - _vlayout->AddLayout(_default_item_layout, 0); _vlayout->AddLayout(_bottom_space, 0); _vlayout->SetMinimumWidth(140); @@ -329,14 +325,6 @@ (*it)->UnReference(); } - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - // Remove from introspection - RemoveChild(*it); - (*it)->UnReference(); - } - - _default_item_list.clear(); _item_list.clear(); } @@ -353,7 +341,7 @@ if (!_enable_quicklist_for_testing) { - if ((_item_list.size() != 0) || (_default_item_list.size() != 0)) + if ((_item_list.size() != 0)) { int offscreen_size = GetBaseY() + GetBaseHeight() - @@ -441,12 +429,6 @@ (*it)->ProcessDraw(gfxContext, forceDraw); } - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - if ((*it)->GetVisible()) - (*it)->ProcessDraw(gfxContext, forceDraw); - } - gfxContext.PopClippingRectangle(); } @@ -475,45 +457,34 @@ (*it)->GetTextExtents(textWidth, textHeight); if (textWidth > MaxItemWidth) MaxItemWidth = textWidth; + textHeight += QuicklistMenuItem::ITEM_MARGIN * 2; TotalItemHeight += textHeight; } - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) + if (TotalItemHeight < _anchor_height) { - // Make sure item is in layout if it should be - if (!(*it)->GetVisible()) - { - _default_item_layout->RemoveChildObject(*it); - continue; - } - else if (!(*it)->GetParentObject()) - _default_item_layout->AddView(*it, 1, nux::eCenter, nux::eFull); + int b = (_anchor_height - TotalItemHeight) / 2 + _padding + _corner_radius; + int t = b + _offset_correction; - int textWidth = 0; - int textHeight = 0; - (*it)->GetTextExtents(textWidth, textHeight); - if (textWidth > MaxItemWidth) - MaxItemWidth = textWidth; - TotalItemHeight += textHeight; - } + _top_space->SetMinimumHeight(t); + _top_space->SetMaximumHeight(t); - if (TotalItemHeight < _anchor_height) - { - _top_space->SetMinMaxSize(1, (_anchor_height - TotalItemHeight) / 2 + 1 + _padding + _corner_radius); - _bottom_space->SetMinMaxSize(1, (_anchor_height - TotalItemHeight) / 2 + 1 + - _padding + _corner_radius + - _bottom_padding_correction_single_item); + _bottom_space->SetMinimumHeight(b); + _bottom_space->SetMaximumHeight(b); } else { - _top_space->SetMinMaxSize(_padding + _corner_radius, _padding + _corner_radius); - _bottom_space->SetMinMaxSize(_padding + _corner_radius - 2, - _padding + _corner_radius + - _bottom_padding_correction_normal); + int b = _padding + _corner_radius; + int t = b + _offset_correction; + + _top_space->SetMinimumHeight(t); + _top_space->SetMaximumHeight(t); + + _bottom_space->SetMinimumHeight(b); + _bottom_space->SetMaximumHeight(b); } _item_layout->SetMinimumWidth(MaxItemWidth); - _default_item_layout->SetMinimumWidth(MaxItemWidth); BaseWindow::PreLayoutManagement(); } @@ -525,7 +496,7 @@ UpdateTexture(); int x = _padding + _anchor_width + _corner_radius + _offset_correction; - int y = _padding + _corner_radius + _offset_correction; + int y = _top_space->GetMinimumHeight(); std::list::iterator it; for (it = _item_list.begin(); it != _item_list.end(); it++) @@ -539,23 +510,12 @@ y += (*it)->GetBaseHeight(); } - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - if (!(*it)->GetVisible()) - continue; - - (*it)->SetBaseX(x); - (*it)->SetBaseY(y); - - y += (*it)->GetBaseHeight(); - } - // We must correct the width of line separators. The rendering of the separator can be smaller than the width of the // quicklist. The reason for that is, the quicklist width is determined by the largest entry it contains. That size is // only after MaxItemWidth is computed in QuicklistView::PreLayoutManagement. // The setting of the separator width is done here after the Layout cycle for this widget is over. The width of the separator // has bee set correctly during the layout cycle, but the cairo rendering still need to be adjusted. - int separator_width = nux::Max(_default_item_layout->GetBaseWidth(), _item_layout->GetBaseWidth()); + int separator_width = _item_layout->GetBaseWidth(); for (it = _item_list.begin(); it != _item_list.end(); it++) { @@ -567,16 +527,6 @@ } } - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - QuicklistMenuItem* item = (QuicklistMenuItem*)(*it); - if (item->GetVisible() && item->CairoSurfaceWidth() != separator_width) - { - // Compute textures of the item. - item->UpdateTexture(); - } - } - return result; } @@ -623,24 +573,6 @@ } } } - - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - if (!(*it)->GetVisible()) - continue; - - geo = (*it)->GetGeometry(); - geo.width = _default_item_layout->GetBaseWidth(); - - if (geo.IsPointInside(x, y)) - { - // An action is performed: send the signal back to the application - if ((*it)->_menuItem) - { - dbusmenu_menuitem_handle_event((*it)->_menuItem, "clicked", NULL, 0); - } - } - } } void QuicklistView::RecvItemMouseRelease(QuicklistMenuItem* item, int x, int y) @@ -664,11 +596,6 @@ { (*it)->_prelight = false; } - - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - (*it)->_prelight = false; - } } void QuicklistView::RecvItemMouseDrag(QuicklistMenuItem* item, int x, int y) @@ -690,22 +617,6 @@ SelectItem(item_index); } } - - for (auto it : _default_item_list) - { - int item_index = GetItemIndex(it); - - if (!IsMenuItemSelectable(item_index)) - continue; - - geo = it->GetGeometry(); - geo.width = _default_item_layout->GetBaseWidth(); - - if (geo.IsPointInside(x + item->GetBaseX(), y + item->GetBaseY())) - { - SelectItem(item_index); - } - } } void QuicklistView::RecvItemMouseEnter(QuicklistMenuItem* item) @@ -773,18 +684,9 @@ (*it)->UnReference(); } - for (it = _default_item_list.begin(); it != _default_item_list.end(); it++) - { - // Remove from introspection - RemoveChild(*it); - (*it)->UnReference(); - } - _item_list.clear(); - _default_item_list.clear(); _item_layout->Clear(); - _default_item_layout->Clear(); _cairo_text_has_changed = true; nux::GetWindowThread()->QueueObjectLayout(this); } @@ -819,7 +721,7 @@ int QuicklistView::GetNumItems() { - return _item_list.size() + _default_item_list.size(); + return _item_list.size(); } QuicklistMenuItem* QuicklistView::GetNthItems(int index) @@ -835,19 +737,6 @@ } } - if (index < (int)_item_list.size() + (int)_default_item_list.size()) - { - int i = 0; - if (_item_list.size() > 0) - i = _item_list.size() - 1; - std::list::iterator it; - for (it = _default_item_list.begin(); it != _default_item_list.end(); i++, it++) - { - if (i == index) - return *it; - } - } - return nullptr; } @@ -863,14 +752,6 @@ return index; } - for (auto it : _default_item_list) - { - ++index; - - if (it == item) - return index; - } - return index; } @@ -1304,7 +1185,7 @@ if (!_enable_quicklist_for_testing) { - if (!_item_list.empty() || !_default_item_list.empty()) + if (!_item_list.empty()) { int offscreen_size = GetBaseY() + height - diff -Nru unity-5.12/plugins/unityshell/src/QuicklistView.h unity-5.14.0/plugins/unityshell/src/QuicklistView.h --- unity-5.12/plugins/unityshell/src/QuicklistView.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/QuicklistView.h 2012-07-18 11:12:56.000000000 +0000 @@ -151,13 +151,10 @@ float _corner_radius; float _padding; float _left_padding_correction; - float _bottom_padding_correction_normal; - float _bottom_padding_correction_single_item; float _offset_correction; nux::HLayout* _hlayout; nux::VLayout* _vlayout; nux::VLayout* _item_layout; - nux::VLayout* _default_item_layout; nux::SpaceLayout* _left_space; //!< Space from the left of the widget to the left of the text. nux::SpaceLayout* _right_space; //!< Space from the right of the text to the right of the widget. nux::SpaceLayout* _top_space; //!< Space from the left of the widget to the left of the text. @@ -166,7 +163,6 @@ bool _cairo_text_has_changed; void UpdateTexture(); std::list _item_list; - std::list _default_item_list; // used by keyboard/a11y-navigation int _current_item_index; diff -Nru unity-5.12/plugins/unityshell/src/SearchBar.cpp unity-5.14.0/plugins/unityshell/src/SearchBar.cpp --- unity-5.12/plugins/unityshell/src/SearchBar.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SearchBar.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -302,27 +302,29 @@ void SearchBar::OnFontChanged(GtkSettings* settings, GParamSpec* pspec) { - gchar* font_name = NULL; + glib::String font_name; PangoFontDescription* desc; std::ostringstream font_desc; g_object_get(settings, "gtk-font-name", &font_name, NULL); - desc = pango_font_description_from_string(font_name); - pango_entry_->SetFontFamily(pango_font_description_get_family(desc)); - pango_entry_->SetFontSize(PANGO_ENTRY_FONT_SIZE); - pango_entry_->SetFontOptions(gdk_screen_get_font_options(gdk_screen_get_default())); - - font_desc << pango_font_description_get_family(desc) << " " << HINT_LABEL_FONT_STYLE << " " << HINT_LABEL_FONT_SIZE; - hint_->SetFont(font_desc.str().c_str()); - - font_desc.str(""); - font_desc.clear(); - font_desc << pango_font_description_get_family(desc) << " " << SHOW_FILTERS_LABEL_FONT_STYLE << " " << SHOW_FILTERS_LABEL_FONT_SIZE; - show_filters_->SetFont(font_desc.str().c_str()); + desc = pango_font_description_from_string(font_name.Value()); + if (desc) + { + pango_entry_->SetFontFamily(pango_font_description_get_family(desc)); + pango_entry_->SetFontSize(PANGO_ENTRY_FONT_SIZE); + pango_entry_->SetFontOptions(gdk_screen_get_font_options(gdk_screen_get_default())); + + font_desc << pango_font_description_get_family(desc) << " " << HINT_LABEL_FONT_STYLE << " " << HINT_LABEL_FONT_SIZE; + hint_->SetFont(font_desc.str().c_str()); + + font_desc.str(""); + font_desc.clear(); + font_desc << pango_font_description_get_family(desc) << " " << SHOW_FILTERS_LABEL_FONT_STYLE << " " << SHOW_FILTERS_LABEL_FONT_SIZE; + show_filters_->SetFont(font_desc.str().c_str()); - pango_font_description_free(desc); - g_free(font_name); + pango_font_description_free(desc); + } } void SearchBar::OnSearchHintChanged() diff -Nru unity-5.12/plugins/unityshell/src/SimpleLauncherIcon.cpp unity-5.14.0/plugins/unityshell/src/SimpleLauncherIcon.cpp --- unity-5.12/plugins/unityshell/src/SimpleLauncherIcon.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SimpleLauncherIcon.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -69,15 +69,15 @@ g_signal_handler_disconnect(gtk_icon_theme_get_default(), theme_changed_id_); } -void SimpleLauncherIcon::OnMouseDown(int button, int monitor) +void SimpleLauncherIcon::OnMouseDown(int button, unsigned long key_flags, int monitor) { } -void SimpleLauncherIcon::OnMouseUp(int button, int monitor) +void SimpleLauncherIcon::OnMouseUp(int button, unsigned long key_flags, int monitor) { } -void SimpleLauncherIcon::OnMouseClick(int button, int monitor) +void SimpleLauncherIcon::OnMouseClick(int button, unsigned long key_flags, int monitor) { } diff -Nru unity-5.12/plugins/unityshell/src/SimpleLauncherIcon.h unity-5.14.0/plugins/unityshell/src/SimpleLauncherIcon.h --- unity-5.12/plugins/unityshell/src/SimpleLauncherIcon.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SimpleLauncherIcon.h 2012-07-18 11:12:56.000000000 +0000 @@ -49,11 +49,12 @@ std::string GetName() const; void AddProperties(GVariantBuilder* builder); - virtual void OnMouseDown(int button, int monitor); - virtual void OnMouseUp(int button, int monitor); - virtual void OnMouseClick(int button, int monitor); + virtual void OnMouseDown(int button, unsigned long key_flags, int monitor); + virtual void OnMouseUp(int button, unsigned long key_flags, int monitor); + virtual void OnMouseClick(int button, unsigned long key_flags, int monitor); virtual void OnMouseEnter(int monitor); virtual void OnMouseLeave(int monitor); + virtual void ActivateLauncherIcon(ActionArg arg); private: diff -Nru unity-5.12/plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp unity-5.14.0/plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp --- unity-5.12/plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -43,6 +43,7 @@ G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START) , finished_(true) , needs_urgent_(false) +, aptdaemon_trans_id_(aptdaemon_trans_id) { aptdaemon_trans_.Connect("PropertyChanged", sigc::mem_fun(this, &SoftwareCenterLauncherIcon::OnPropertyChanged)); @@ -50,7 +51,12 @@ SetIconType(TYPE_APPLICATION); icon_name = icon_path; - tooltip_text = _("Waiting to install"); + if (!aptdaemon_trans_id_.empty()) // Application is being installed, or hasn't been installed yet + tooltip_text = _("Waiting to install"); + else { + SetQuirk(QUIRK_URGENT, true); + needs_urgent_ = true; + } } void SoftwareCenterLauncherIcon::Animate(nux::ObjectPtr launcher, diff -Nru unity-5.12/plugins/unityshell/src/SoftwareCenterLauncherIcon.h unity-5.14.0/plugins/unityshell/src/SoftwareCenterLauncherIcon.h --- unity-5.12/plugins/unityshell/src/SoftwareCenterLauncherIcon.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SoftwareCenterLauncherIcon.h 2012-07-18 11:12:56.000000000 +0000 @@ -21,6 +21,7 @@ #ifndef SOFTWARE_CENTER_LAUNCHERICON_H #define SOFTWARE_CENTER_LAUNCHERICON_H +#include #include #include "BamfLauncherIcon.h" @@ -61,6 +62,8 @@ nux::ObjectPtr launcher_; bool finished_; bool needs_urgent_; + + std::string aptdaemon_trans_id_; }; } diff -Nru unity-5.12/plugins/unityshell/src/StaticCairoText.cpp unity-5.14.0/plugins/unityshell/src/StaticCairoText.cpp --- unity-5.12/plugins/unityshell/src/StaticCairoText.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/StaticCairoText.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -245,6 +245,12 @@ return _text; } +nux::Color StaticCairoText::GetTextColor() const +{ + return _textColor; +} + + void StaticCairoText::SetTextColor(Color const& textColor) { diff -Nru unity-5.12/plugins/unityshell/src/StaticCairoText.h unity-5.14.0/plugins/unityshell/src/StaticCairoText.h --- unity-5.12/plugins/unityshell/src/StaticCairoText.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/StaticCairoText.h 2012-07-18 11:12:56.000000000 +0000 @@ -86,6 +86,7 @@ void SetLines(int maximum_lines); std::string GetText() const; + nux::Color GetTextColor() const; int GetLineCount(); int GetBaseline() const; diff -Nru unity-5.12/plugins/unityshell/src/SwitcherController.cpp unity-5.14.0/plugins/unityshell/src/SwitcherController.cpp --- unity-5.12/plugins/unityshell/src/SwitcherController.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SwitcherController.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -95,7 +95,7 @@ { std::sort(results.begin(), results.end(), CompareSwitcherItemsPriority); } - + model_.reset(new SwitcherModel(results)); AddChild(model_.get()); model_->selection_changed.connect(sigc::mem_fun(this, &Controller::OnModelSelectionChanged)); @@ -187,11 +187,16 @@ { if (!visible_) return; - + ConstructView(); - if (view_window_) + ubus_manager_.SendMessage(UBUS_SWITCHER_START); + + if (view_window_) { + view_window_->ShowWindow(true); + view_window_->PushToFront(); view_window_->SetOpacity(1.0f); + } } void Controller::ConstructWindow() @@ -213,6 +218,7 @@ view_window_->SetLayout(main_layout_); view_window_->SetBackgroundColor(nux::Color(0x00000000)); view_window_->SetGeometry(workarea_); + view_window_->EnableInputWindow(true, "Switcher", false, false); } } @@ -238,7 +244,6 @@ main_layout_->AddView(view_.GetPointer(), 1); view_window_->SetGeometry(workarea_); view_window_->SetOpacity(0.0f); - view_window_->ShowWindow(true); } void Controller::SetWorkspace(nux::Geometry geo, int monitor) @@ -279,6 +284,8 @@ } } + ubus_manager_.SendMessage(UBUS_SWITCHER_END, g_variant_new_boolean(!accept_state)); + if (view_idle_timer_) { g_source_remove(view_idle_timer_); @@ -295,6 +302,8 @@ { view_window_->SetOpacity(0.0f); view_window_->ShowWindow(false); + view_window_->PushToBack(); + view_window_->EnableInputWindow(false); } if (show_timer_) @@ -434,15 +443,20 @@ return view_->ExternalTargets(); } +guint Controller::GetSwitcherInputWindowId() const +{ + return view_window_->GetInputWindowId(); +} + bool Controller::CompareSwitcherItemsPriority(AbstractLauncherIcon::Ptr first, AbstractLauncherIcon::Ptr second) { if (first->GetIconType() == second->GetIconType()) return first->SwitcherPriority() > second->SwitcherPriority(); - + if (first->GetIconType() == AbstractLauncherIcon::IconType::TYPE_DESKTOP) return true; - + if (second->GetIconType() == AbstractLauncherIcon::IconType::TYPE_DESKTOP) return false; return first->GetIconType() < second->GetIconType(); diff -Nru unity-5.12/plugins/unityshell/src/SwitcherController.h unity-5.14.0/plugins/unityshell/src/SwitcherController.h --- unity-5.12/plugins/unityshell/src/SwitcherController.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/SwitcherController.h 2012-07-18 11:12:56.000000000 +0000 @@ -95,6 +95,8 @@ ui::LayoutWindowList ExternalRenderTargets (); + guint GetSwitcherInputWindowId() const; + protected: // Introspectable methods std::string GetName() const; diff -Nru unity-5.12/plugins/unityshell/src/UBusMessages.h unity-5.14.0/plugins/unityshell/src/UBusMessages.h --- unity-5.12/plugins/unityshell/src/UBusMessages.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/UBusMessages.h 2012-07-18 11:12:56.000000000 +0000 @@ -35,7 +35,7 @@ #define UBUS_DASH_ABOUT_TO_SHOW "DASH_ABOUT_TO_SHOW" // Signal sent when an overlay interface is shown, includes a gvariant -// gvariant format is (sb), (interface-name, can_maximize?) +// gvariant format is (sb), (interface-name, can_maximize?) #define UBUS_OVERLAY_FORMAT_STRING "(sbi)" #define UBUS_OVERLAY_HIDDEN "OVERLAY_HIDDEN" #define UBUS_OVERLAY_SHOWN "OVERLAY_SHOWN" @@ -88,6 +88,8 @@ // Signals sent when the switcher is shown, hidden or changes selection #define UBUS_SWITCHER_SHOWN "SWITCHER_SHOWN" +#define UBUS_SWITCHER_START "SWITCHER_START" +#define UBUS_SWITCHER_END "SWITCHER_END" #define UBUS_SWITCHER_SELECTION_CHANGED "SWITCHER_SELECTION_CHANGED" #endif // UBUS_MESSAGES_H diff -Nru unity-5.12/plugins/unityshell/src/unityshell.cpp unity-5.14.0/plugins/unityshell/src/unityshell.cpp --- unity-5.12/plugins/unityshell/src/unityshell.cpp 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/unityshell.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -128,6 +128,7 @@ , hud_keypress_time_(0) , panel_texture_has_changed_(true) , paint_panel_(false) + , scale_just_activated_(false) { Timer timer; gfloat version; @@ -350,6 +351,12 @@ ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_SWTICHER, sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav)); + ubus_manager_.RegisterInterest(UBUS_SWITCHER_START, + sigc::mem_fun(this, &UnityScreen::OnSwitcherStart)); + + ubus_manager_.RegisterInterest(UBUS_SWITCHER_END, + sigc::mem_fun(this, &UnityScreen::OnSwitcherEnd)); + g_idle_add_full (G_PRIORITY_DEFAULT, &UnityScreen::initPluginActions, this, NULL); super_keypressed_ = false; @@ -1389,6 +1396,21 @@ break; case KeyPress: { + if (super_keypressed_) + { + /* We need an idle to postpone this action, after the current event + * has been processed */ + g_idle_add([] (gpointer data) -> gboolean { + auto self = static_cast(data); + + self->shortcut_controller_->SetEnabled(false); + self->shortcut_controller_->Hide(); + self->EnableCancelAction(CancelActionTarget::SHORTCUT_HINT, false); + + return FALSE; + }, this); + } + KeySym key_sym; char key_string[2]; int result = XLookupString(&(event->xkey), key_string, 2, &key_sym, 0); @@ -1416,22 +1438,6 @@ if (super_keypressed_) { - if (key_sym != XK_Escape || (key_sym == XK_Escape && !launcher_controller_->KeyNavIsActive())) - { - /* We need an idle to postpone this action, after the current event - * has been processed */ - g_idle_add([] (gpointer data) -> gboolean { - auto self = static_cast(data); - if (!self->launcher_controller_->KeyNavIsActive()) - { - self->shortcut_controller_->SetEnabled(false); - self->shortcut_controller_->Hide(); - self->EnableCancelAction(CancelActionTarget::SHORTCUT_HINT, false); - } - return FALSE; - }, this); - } - skip_other_plugins = launcher_controller_->HandleLauncherKeyEvent(screen->dpy(), key_sym, event->xkey.keycode, event->xkey.state, key_string); if (!skip_other_plugins) skip_other_plugins = dash_controller_->CheckShortcutActivation(key_string); @@ -1548,6 +1554,12 @@ ubus_manager_.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST); } + if (PluginAdapter::Default()->IsScaleActive() && + g_strcmp0(plugin, "scale") == 0 && super_keypressed_) + { + scale_just_activated_ = true; + } + screen->handleCompizEvent(plugin, event, option); } @@ -1595,6 +1607,18 @@ LOG_DEBUG(logger) << "Super released: " << (was_tap ? "tapped" : "released"); int when = options[7].value().i(); // XEvent time in millisec + // hack...if the scale just wasn't activated AND the 'when' time is within time to start the + // dash then assume was_tap is also true, since the ScalePlugin doesn't accept that state... + if (PluginAdapter::Default()->IsScaleActive() && !scale_just_activated_ && launcher_controller_->AboutToShowDash(true, when)) + { + PluginAdapter::Default()->TerminateScale(); + was_tap = true; + } + else if (scale_just_activated_) + { + scale_just_activated_ = false; + } + if (hud_controller_->IsVisible() && launcher_controller_->AboutToShowDash(was_tap, when)) hud_controller_->HideHud(); @@ -1651,6 +1675,12 @@ { hud_controller_->HideHud(); } + + if (PluginAdapter::Default()->IsScaleActive()) + { + PluginAdapter::Default()->TerminateScale(); + } + ubus_manager_.SendMessage(UBUS_PLACE_ENTRY_ACTIVATE_REQUEST, g_variant_new("(sus)", "commands.lens", 0, "")); } @@ -1931,6 +1961,27 @@ void UnityScreen::OnLauncherEndKeyNav(GVariant* data) { + RestoreWindow(data); +} + +void UnityScreen::OnSwitcherStart(GVariant* data) +{ + newFocusedWindow = screen->findWindow(switcher_controller_->GetSwitcherInputWindowId()); + + if (switcher_controller_->GetSwitcherInputWindowId() != screen->activeWindow()) + PluginAdapter::Default()->saveInputFocus(); + + if (newFocusedWindow) + newFocusedWindow->moveInputFocusTo(); +} + +void UnityScreen::OnSwitcherEnd(GVariant* data) +{ + RestoreWindow(data); +} + +void UnityScreen::RestoreWindow(GVariant* data) +{ bool preserve_focus = false; if (data) diff -Nru unity-5.12/plugins/unityshell/src/unityshell.h unity-5.14.0/plugins/unityshell/src/unityshell.h --- unity-5.12/plugins/unityshell/src/unityshell.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/unityshell.h 2012-07-18 11:12:56.000000000 +0000 @@ -229,6 +229,11 @@ void OnLauncherStartKeyNav(GVariant* data); void OnLauncherEndKeyNav(GVariant* data); + void OnSwitcherStart(GVariant* data); + void OnSwitcherEnd(GVariant* data); + + void RestoreWindow(GVariant* data); + void InitHints(); void OnPanelStyleChanged(); @@ -310,6 +315,8 @@ bool paint_panel_; nux::ObjectPtr panel_texture_; + bool scale_just_activated_; + #ifndef USE_GLES ScreenEffectFramebufferObject::GLXGetProcAddressProc glXGetProcAddressP; #endif diff -Nru unity-5.12/plugins/unityshell/src/WindowButtons.cpp unity-5.14.0/plugins/unityshell/src/WindowButtons.cpp --- unity-5.12/plugins/unityshell/src/WindowButtons.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/WindowButtons.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -681,7 +681,7 @@ restore_button->SetVisible(!maximizable); maximize_button->SetVisible(maximizable); - QueueDraw(); + QueueRelayout(); } } } diff -Nru unity-5.12/plugins/unityshell/src/WindowManager.cpp unity-5.14.0/plugins/unityshell/src/WindowManager.cpp --- unity-5.12/plugins/unityshell/src/WindowManager.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/WindowManager.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -220,6 +220,16 @@ g_debug("%s", G_STRFUNC); } + bool saveInputFocus() + { + return false; + } + + bool restoreInputFocus() + { + return false; + } + void AddProperties(GVariantBuilder* builder) { } diff -Nru unity-5.12/plugins/unityshell/src/WindowManager.h unity-5.14.0/plugins/unityshell/src/WindowManager.h --- unity-5.12/plugins/unityshell/src/WindowManager.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/plugins/unityshell/src/WindowManager.h 2012-07-18 11:12:56.000000000 +0000 @@ -106,6 +106,8 @@ virtual int WorkspaceCount() = 0; + virtual bool saveInputFocus() = 0; + virtual bool restoreInputFocus() = 0; // Signals sigc::signal window_mapped; diff -Nru unity-5.12/tests/autopilot/autopilot/emulators/unity/launcher.py unity-5.14.0/tests/autopilot/autopilot/emulators/unity/launcher.py --- unity-5.12/tests/autopilot/autopilot/emulators/unity/launcher.py 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/emulators/unity/launcher.py 2012-07-18 11:12:56.000000000 +0000 @@ -7,8 +7,10 @@ # by the Free Software Foundation. # +from autopilot.utilities import get_compiz_option import dbus import logging +from math import floor from testtools.matchers import NotEquals from time import sleep @@ -22,6 +24,12 @@ logger = logging.getLogger(__name__) +class IconDragType: + """Define possible positions to drag an icon onto another""" + INSIDE = 0 + OUTSIDE = 1 + + class LauncherController(UnityIntrospectionObject): """The LauncherController class.""" @@ -116,6 +124,16 @@ logger.debug("Moving mouse to center of launcher.") self._mouse.move(target_x, target_y) + def move_mouse_to_icon(self, icon): + # The icon may be off the bottom of screen, so we do this in a loop: + while 1: + target_x = icon.center_x + self.x + target_y = icon.center_y + if self._mouse.x == target_x and self._mouse.y == target_y: + break + self._mouse.move(target_x, target_y) + sleep(0.5) + def mouse_reveal_launcher(self): """Reveal this launcher with the mouse.""" self._screen.move_mouse_to_monitor(self.monitor) @@ -246,6 +264,66 @@ self._mouse.click(button) self.move_mouse_to_right_of_launcher() + def drag_icon_to_position(self, icon, pos, drag_type=IconDragType.INSIDE): + """Place the supplied icon above the icon in the position pos. + + The icon is dragged inside or outside the launcher. + + >>> drag_icon_to_position(calc_icon, 0, IconDragType.INSIDE) + + This will drag the calculator icon above the bfb (but as you can't go + above the bfb it will move below it (to position 1)) + + """ + if not isinstance(icon, BamfLauncherIcon): + raise TypeError("icon must be a LauncherIcon") + + [launcher_model] = LauncherModel.get_all_instances() + all_icons = launcher_model.get_launcher_icons() + all_icon_len = len(all_icons) + if pos >= all_icon_len: + raise ValueError("pos is outside valid range (0-%d)" % all_icon_len) + + logger.debug("Dragging launcher icon %r on monitor %d to position %s" + % (icon, self.monitor, pos)) + self.mouse_reveal_launcher() + + icon_height = get_compiz_option("unityshell", "icon_size") + + target_icon = all_icons[pos] + if target_icon.id == icon.id: + logger.warning("%s is already the icon in position %d. Nothing to do." % (icon, pos)) + return + + self.move_mouse_to_icon(icon) + self._mouse.press() + sleep(2) + + if drag_type == IconDragType.OUTSIDE: + shift_over = self._mouse.x + (icon_height * 2) + self._mouse.move(shift_over, self._mouse.y) + sleep(0.5) + + # find the target drop position, between the center & top of the target icon + target_y = target_icon.center_y - floor(icon_height / 4) + + # Need to move the icons top (if moving up) or bottom (if moving + # downward) to the target position + moving_up = True if icon.center_y > target_icon.center_y else False + icon_half_height = floor(icon_height / 2) + fudge_factor = 5 + if moving_up or drag_type == IconDragType.OUTSIDE: + target_y += icon_half_height + fudge_factor + else: + target_y -= icon_half_height - fudge_factor + + self._mouse.move(self._mouse.x, target_y, rate=20, + time_between_events=0.05) + sleep(1) + + self._mouse.release() + self.move_mouse_to_right_of_launcher() + def lock_to_launcher(self, icon): """lock 'icon' to the launcher, if it's not already. `icon` must be an instance of BamfLauncherIcon. diff -Nru unity-5.12/tests/autopilot/autopilot/tests/test_dash.py unity-5.14.0/tests/autopilot/autopilot/tests/test_dash.py --- unity-5.12/tests/autopilot/autopilot/tests/test_dash.py 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/tests/test_dash.py 2012-07-18 11:12:56.000000000 +0000 @@ -60,6 +60,38 @@ self.keyboard.press_and_release("Alt+F4") self.assertThat(self.dash.visible, Eventually(Equals(False))) + def test_dash_closes_on_spread(self): + """This test shows that when the spread is initiated, the dash closes.""" + self.dash.ensure_visible() + self.addCleanup(self.keybinding, "spread/cancel") + self.keybinding("spread/start") + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + self.assertThat(self.dash.visible, Eventually(Equals(False))) + + def test_dash_opens_when_in_spread(self): + """This test shows the dash opens when in spread mode.""" + self.keybinding("spread/start") + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + + self.dash.ensure_visible() + self.assertThat(self.dash.visible, Eventually(Equals(True))) + + def test_command_lens_opens_when_in_spread(self): + """This test shows the command lens opens when in spread mode.""" + self.keybinding("spread/start") + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + + self.dash.reveal_command_lens() + self.assertThat(self.dash.active_lens, Eventually(Equals('commands.lens'))) + + def test_lens_opens_when_in_spread(self): + """This test shows that any lens opens when in spread mode.""" + self.keybinding("spread/start") + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + + self.dash.reveal_application_lens() + self.assertThat(self.dash.active_lens, Eventually(Equals('applications.lens'))) + class DashSearchInputTests(DashTestCase): """Test features involving input to the dash search""" @@ -82,7 +114,6 @@ self.call_gsettings_cmd('set', 'org.gnome.libgnomekbd.keyboard', 'options', "['Compose key\tcompose:caps']") super(DashMultiKeyTests, self).setUp() - def test_multi_key(self): """Pressing 'Multi_key' must not add any characters to the search.""" self.dash.reveal_application_lens() diff -Nru unity-5.12/tests/autopilot/autopilot/tests/test_hud.py unity-5.14.0/tests/autopilot/autopilot/tests/test_hud.py --- unity-5.12/tests/autopilot/autopilot/tests/test_hud.py 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/tests/test_hud.py 2012-07-18 11:12:56.000000000 +0000 @@ -207,7 +207,7 @@ self.hud.ensure_visible() self.dash.ensure_visible() self.addCleanup(self.dash.ensure_hidden) - + self.keybinding("launcher/keynav") self.assertThat(self.launcher.key_nav_is_active, Equals(False)) @@ -233,6 +233,39 @@ self.workspace.switch_to(2) self.assertThat(self.hud.visible, Eventually(Equals(False))) + def test_hud_closes_on_spread(self): + """This test shows that when the spread is initiated, the hud closes.""" + self.hud.ensure_visible() + self.addCleanup(self.keybinding, "spread/cancel") + self.keybinding("spread/start") + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + self.assertThat(self.hud.visible, Eventually(Equals(False))) + + def test_hud_closes_click_outside_geo_shrunk(self): + """ + Clicking outside the hud when it is shurnk will make it close. + Shurnk is when the hud has no results and is much smaller then normal. + """ + + self.hud.ensure_visible() + (x,y,w,h) = self.hud.view.geometry + self.mouse.move(w/2, h-50) + self.mouse.click() + + self.assertThat(self.hud.visible, Eventually(Equals(False))) + + def test_hud_closes_click_outside_geo(self): + """Clicking outside of the hud will make it close.""" + + self.hud.ensure_visible() + self.keyboard.type("Test") + + (x,y,w,h) = self.hud.view.geometry + self.mouse.move(w/2, h+50) + self.mouse.click() + + self.assertThat(self.hud.visible, Eventually(Equals(False))) + class HudLauncherInteractionsTests(HudTestsBase): diff -Nru unity-5.12/tests/autopilot/autopilot/tests/test_launcher.py unity-5.14.0/tests/autopilot/autopilot/tests/test_launcher.py --- unity-5.12/tests/autopilot/autopilot/tests/test_launcher.py 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/tests/test_launcher.py 2012-07-18 11:12:56.000000000 +0000 @@ -18,6 +18,7 @@ from autopilot.emulators.X11 import ScreenGeometry from autopilot.matchers import Eventually from autopilot.tests import AutopilotTestCase, multiply_scenarios +from unity.emulators.launcher import IconDragType logger = logging.getLogger(__name__) @@ -257,9 +258,9 @@ self.launcher_instance.key_nav_start() def tearDown(self): - super(LauncherKeyNavTests, self).tearDown() if self.launcher.key_nav_is_active: self.launcher_instance.key_nav_cancel() + super(LauncherKeyNavTests, self).tearDown() def test_launcher_keynav_initiate(self): """Tests we can initiate keyboard navigation on the launcher.""" @@ -381,6 +382,16 @@ self.addCleanup(self.switcher.terminate) self.assertThat(self.launcher.key_nav_is_active, Eventually(Equals(False))) + def test_launcher_keynav_expo_focus(self): + """When entering expo mode from KeyNav the Desktop must get focus.""" + + for icon in self.launcher.model.get_launcher_icons_for_monitor(self.launcher_monitor): + if (icon.tooltip_text == "Workspace Switcher"): + self.launcher_instance.key_nav_activate() + break + self.launcher_instance.key_nav_next() + + self.assertThat(self.panels.get_active_panel().title, Eventually(Equals("Ubuntu Desktop"))) class LauncherIconsBehaviorTests(LauncherTestCase): """Test the launcher icons interactions""" @@ -445,6 +456,62 @@ self.assertTrue(mah_win2.is_hidden) self.assertVisibleWindowStack([mah_win1, calc_win]) + def test_clicking_icon_twice_initiates_spread(self): + """This tests shows that when you click on a launcher icon twice, + when an application window is focused, the spread is initiated. + """ + calc = self.start_app("Calculator") + [calc_win1] = calc.get_windows() + self.assertTrue(calc_win1.is_focused) + + self.start_app("Calculator") + # Sleeping due to the start_app only waiting for the bamf model to be + # updated with the application. Since the app has already started, + # and we are just waiting on a second window, however a defined sleep + # here is likely to be problematic. + # TODO: fix bamf emulator to enable waiting for new windows. + sleep(1) + [calc_win2] = [w for w in calc.get_windows() if w.x_id != calc_win1.x_id] + + self.assertVisibleWindowStack([calc_win2, calc_win1]) + self.assertTrue(calc_win2.is_focused) + + calc_icon = self.launcher.model.get_icon_by_desktop_id(calc.desktop_file) + self.addCleanup(self.keybinding, "spread/cancel") + self.launcher_instance.click_launcher_icon(calc_icon) + + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + self.assertThat(self.window_manager.scale_active_for_group, Eventually(Equals(True))) + + def test_while_in_scale_mode_the_dash_will_still_open(self): + """If scale is initiated through the laucher pressing super must close + scale and open the dash. + """ + calc = self.start_app("Calculator") + [calc_win1] = calc.get_windows() + self.start_app("Calculator") + # Sleeping due to the start_app only waiting for the bamf model to be + # updated with the application. Since the app has already started, + # and we are just waiting on a second window, however a defined sleep + # here is likely to be problematic. + # TODO: fix bamf emulator to enable waiting for new windows. + sleep(1) + [calc_win2] = [w for w in calc.get_windows() if w.x_id != calc_win1.x_id] + + self.assertVisibleWindowStack([calc_win2, calc_win1]) + self.assertTrue(calc_win2.is_focused) + + calc_icon = self.launcher.model.get_icon_by_desktop_id(calc.desktop_file) + self.addCleanup(self.keybinding, "spread/cancel") + self.launcher_instance.click_launcher_icon(calc_icon) + self.assertThat(self.window_manager.scale_active, Eventually(Equals(True))) + + self.dash.ensure_visible() + self.addCleanup(self.dash.ensure_hidden) + + self.assertThat(self.dash.visible, Eventually(Equals(True))) + self.assertThat(self.window_manager.scale_active, Eventually(Equals(False))) + def test_icon_shows_on_quick_application_reopen(self): """Icons should stay on launcher when an application is quickly closed/reopened.""" calc = self.start_app("Calculator") @@ -460,6 +527,87 @@ self.assertThat(calc_icon, NotEquals(None)) self.assertThat(calc_icon.visible, Eventually(Equals(True))) + def test_software_center_add_icon(self): + """ Test the ability to add a SoftwareCenterLauncherIcon """ + sleep(.5) + + # Check if SC is pinned to the launcher already + icon = self.launcher.model.get_icon_by_desktop_id("ubuntu-software-center.desktop") + if icon != None: + self.launcher_instance.unlock_from_launcher(icon) + sleep(2.0) + + self.launcher.add_launcher_item_from_position("Unity Test", + "softwarecenter", + 100, + 100, + 32, + "/usr/share/applications/ubuntu-software-center.desktop", + "") + + sleep(2.0) + + icon = self.launcher.model.get_icon_by_desktop_id("ubuntu-software-center.desktop") + + # Check if the icon tooltip is NOT empty and NOT "waiting to install" + self.assertThat(icon.tooltip_text == "Waiting to install", Equals(False)) + self.assertThat(len(icon.tooltip_text) == 0, Equals(False)) + sleep(.5) + +class LauncherDragIconsBehavior(LauncherTestCase): + """Tests interation with dragging icons with the Launcher""" + + scenarios = multiply_scenarios(_make_scenarios(), + [ + ('inside', {'drag_type': IconDragType.INSIDE}), + ('outside', {'drag_type': IconDragType.OUTSIDE}), + ]) + + def ensure_calc_icon_not_in_launcher(self): + while 1: + icon = self.launcher.model.get_icon_by_desktop_id("gcalctool.desktop") + if not icon: + break + sleep(1) + + def test_can_drag_icon_below_bfb(self): + """Application icons must be draggable to below the BFB.""" + + self.ensure_calc_icon_not_in_launcher() + calc = self.start_app("Calculator") + calc_icon = self.launcher.model.get_icon_by_desktop_id(calc.desktop_file) + + bfb_icon_position = 0 + self.launcher_instance.drag_icon_to_position(calc_icon, + bfb_icon_position, + self.drag_type) + moved_icon = self.launcher.model.\ + get_launcher_icons_for_monitor(self.launcher_monitor)[1] + self.assertThat(moved_icon.id, Equals(calc_icon.id)) + + def test_can_drag_icon_above_window_switcher(self): + """Launcher icons must be dragable to above the workspace switcher icon.""" + + self.ensure_calc_icon_not_in_launcher() + calc = self.start_app("Calculator") + calc_icon = self.launcher.model.get_icon_by_desktop_id(calc.desktop_file) + + # Move a known icon to the top as it needs to be more than 2 icon + # spaces away for this test to actually do anything + bfb_icon_position = 0 + self.launcher_instance.drag_icon_to_position(calc_icon, + bfb_icon_position, + self.drag_type) + sleep(1) + switcher_pos = -2 + self.launcher_instance.drag_icon_to_position(calc_icon, + switcher_pos, + self.drag_type) + + moved_icon = self.launcher.model.\ + get_launcher_icons_for_monitor(self.launcher_monitor)[-3] + self.assertThat(moved_icon.id, Equals(calc_icon.id)) + class LauncherRevealTests(LauncherTestCase): """Test the launcher reveal behavior when in autohide mode.""" @@ -739,6 +887,22 @@ # The launcher should have held the mouse a little bit self.assertThat(x_fin, Equals(x - width / 2)) + def test_launcher_capture_while_not_sticky_and_hidden(self): + """Tests that the launcher captures the mouse when moving between monitors + while hidden and sticky is off. (moving left) + """ + + self.set_unity_option('launcher_capture_mouse', False) + self.setHideMode(1) + + x, y, width, height = self.screen_geo.get_monitor_geometry(self.rightMostMonitor()) + self.mouse.move(x + width / 2, y + height / 2, False) + self.mouse.move(x - width / 2, y + height / 2, True, 5, .002) + + x_fin, y_fin = self.mouse.position() + # The launcher should have held the mouse a little bit + self.assertThat(x_fin, GreaterThan(x - width / 2)) + def test_launcher_not_capture_while_not_sticky_and_hidden_moving_right(self): """Tests that the launcher doesn't capture the mouse when moving between monitors while hidden and sticky is off. @@ -807,3 +971,29 @@ self.mouse.move(bfb.center_x, bfb.center_y) self.assertThat(bfb.get_tooltip().active, Eventually(Equals(False))) + +class LauncherIconTests(UnityTestCase): + """Tests for the launcher icons.""" + + def assertNumberWinsIsEventually(self, app, num): + """Asserts that 'app' eventually has 'num' wins. Waits up to 10 seconds.""" + for i in range(10): + wins = app.get_windows() + if len(wins) == num: + return + sleep(1) + + self.assertThat(len(app.get_windows()), Equals(num)) + + def test_shift_click_opens_new_application_instance(self): + """Shift+Clicking MUST open a new instance of an already-running application.""" + app = self.start_app("Calculator") + desktop_id = app.desktop_file + icon = self.launcher.model.get_icon_by_desktop_id(desktop_id) + launcher_instance = self.launcher.get_launcher_for_monitor(0) + + self.keyboard.press("Shift") + self.addCleanup(self.keyboard.release, "Shift") + launcher_instance.click_launcher_icon(icon) + + self.assertNumberWinsIsEventually(app, 2) diff -Nru unity-5.12/tests/autopilot/autopilot/tests/test_shortcut_hint.py unity-5.14.0/tests/autopilot/autopilot/tests/test_shortcut_hint.py --- unity-5.12/tests/autopilot/autopilot/tests/test_shortcut_hint.py 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/tests/test_shortcut_hint.py 2012-07-18 11:12:56.000000000 +0000 @@ -103,6 +103,13 @@ self.keybinding_tap("expo/start") self.addCleanup(self.keybinding, "expo/cancel") + def test_shortcut_hint_hide_pressing_modifiers(self): + """Pressing a modifer key must hide the shortcut hint.""" + self.shortcut_hint.ensure_visible() + self.addCleanup(self.shortcut_hint.ensure_hidden) + + self.keyboard.press('Control') + self.assertThat(self.shortcut_hint.visible, Eventually(Equals(False))) def test_launcher_switcher_next_doesnt_show_shortcut_hint(self): @@ -132,84 +139,6 @@ self.assertThat(self.shortcut_hint.visible, Equals(False)) - def test_launcher_switcher_next_keeps_shortcut_hint(self): - """Super+Tab switcher cycling forwards must not dispel an already-showing - shortcut hint. - - """ - show_timeout = self.shortcut_hint.get_show_timeout() - self.shortcut_hint.ensure_visible() - self.addCleanup(self.shortcut_hint.ensure_hidden) - - self.keybinding("launcher/switcher/next") - self.addCleanup(self.keyboard.press_and_release, "Escape") - - self.assertThat(self.launcher.key_nav_is_active, Equals(True)) - - self.keybinding("launcher/switcher/next") - sleep(show_timeout * 2) - self.assertThat(self.shortcut_hint.visible, Equals(True)) - - def test_launcher_switcher_prev_keeps_shortcut_hint(self): - """Super+Tab switcher cycling backwards must not dispel an already-showing - shortcut hint. - - """ - show_timeout = self.shortcut_hint.get_show_timeout() - self.shortcut_hint.ensure_visible() - self.addCleanup(self.shortcut_hint.ensure_visible) - - self.keybinding("launcher/switcher/next") - self.addCleanup(self.keyboard.press_and_release, "Escape") - self.assertThat(self.launcher.key_nav_is_active, Equals(True)) - - self.keybinding("launcher/switcher/prev") - self.keybinding("launcher/switcher/prev") - sleep(show_timeout * 2) - self.assertThat(self.shortcut_hint.visible, Equals(True)) - - def test_launcher_switcher_cancel_doesnt_hide_shortcut_hint(self): - """Cancelling the launcher switcher (by Escape) must not hide the - shortcut hint view. - - """ - self.shortcut_hint.ensure_visible() - self.addCleanup(self.shortcut_hint.ensure_hidden) - - self.keybinding("launcher/switcher/next") - # NOTE: This will generate an extra Escape keypress if the test passes, - # but that's better than the alternative... - self.addCleanup(self.keybinding, "launcher/switcher/exit") - - self.assertThat(self.launcher.key_nav_is_active, Eventually(Equals(True))) - self.assertThat(self.shortcut_hint.visible, Equals(True)) - - self.keyboard.press_and_release("Escape") - - self.assertThat(self.launcher.key_nav_is_active, Eventually(Equals(False))) - self.assertThat(self.shortcut_hint.visible, Equals(True)) - - def test_launcher_switcher_and_shortcut_hint_escaping(self): - """Cancelling the launcher switcher (by Escape) should not hide the - shortcut hint view, an extra keypress is needed. - - """ - self.shortcut_hint.ensure_visible() - self.addCleanup(self.shortcut_hint.ensure_hidden) - - self.keybinding("launcher/switcher/next") - - self.assertThat(self.launcher.key_nav_is_active, Eventually(Equals(True))) - self.assertThat(self.shortcut_hint.visible, Equals(True)) - - self.keyboard.press_and_release("Escape") - - self.assertThat(self.launcher.key_nav_is_active, Eventually(Equals(False))) - self.assertThat(self.shortcut_hint.visible, Equals(True)) - - self.keyboard.press_and_release("Escape") - self.assertThat(self.shortcut_hint.visible, Eventually(Equals(False))) - def test_launcher_icons_hints_show_with_shortcut_hint(self): """When the shortcut hint is shown also the launcer's icons hints should be shown. diff -Nru unity-5.12/tests/autopilot/autopilot/tests/test_switcher.py unity-5.14.0/tests/autopilot/autopilot/tests/test_switcher.py --- unity-5.12/tests/autopilot/autopilot/tests/test_switcher.py 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/tests/test_switcher.py 2012-07-18 11:12:56.000000000 +0000 @@ -210,6 +210,21 @@ self.assertThat(self.switcher.get_monitor(), Equals(monitor)) self.switcher.terminate() + def test_switcher_alt_f4_is_disabled(self): + """Tests that alt+f4 does not work while switcher is active.""" + + app = self.start_app("Text Editor") + sleep(1) + self.switcher.initiate() + + self.keyboard.press_and_release("Alt+F4") + [win] = [w for w in app.get_windows()] + self.switcher.terminate() + + # Need the sleep to allow the window time to close, for jenkins! + sleep(10) + self.assertThat(win.is_valid, Equals(True)) + class SwitcherWindowsManagementTests(AutopilotTestCase): """Test the switcher window management.""" diff -Nru unity-5.12/tests/autopilot/autopilot/utilities.py unity-5.14.0/tests/autopilot/autopilot/utilities.py --- unity-5.12/tests/autopilot/autopilot/utilities.py 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tests/autopilot/autopilot/utilities.py 2012-07-18 11:12:56.000000000 +0000 @@ -14,6 +14,7 @@ from Xlib import X, display, protocol +from compizconfig import Plugin, Setting _display = display.Display() @@ -70,3 +71,8 @@ win = _display.screen().root atom = win.get_full_property(_display.get_atom(_type), X.AnyPropertyType) if atom: return atom.value + +def get_compiz_option(plugin_name, setting_name): + plugin = Plugin(global_context, plugin_name) + setting = Setting(plugin, setting_name) + return setting.Value diff -Nru unity-5.12/tests/CMakeLists.txt unity-5.14.0/tests/CMakeLists.txt --- unity-5.12/tests/CMakeLists.txt 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/tests/CMakeLists.txt 2012-07-18 11:12:56.000000000 +0000 @@ -143,6 +143,7 @@ test_grabhandle.cpp test_unityshell_private.cpp test_showdesktop_handler.cpp + test_hud_private.cpp ${UNITY_SRC}/AbstractLauncherIcon.cpp ${UNITY_SRC}/AbstractShortcutHint.h ${UNITY_SRC}/Animator.cpp @@ -151,6 +152,7 @@ ${UNITY_SRC}/FavoriteStore.cpp ${UNITY_SRC}/FavoriteStoreGSettings.cpp ${UNITY_SRC}/IconTextureSource.cpp + ${UNITY_SRC}/HudPrivate.cpp ${UNITY_SRC}/LauncherModel.cpp ${UNITY_SRC}/LauncherEntryRemote.cpp ${UNITY_SRC}/FavoriteStorePrivate.cpp @@ -194,19 +196,27 @@ # Tests that require X add_executable(test-gtest + test_hud_button.cpp + test_hud_controller.cpp test_dashview_impl.cpp test_texture_cache.cpp test_main.cpp test_lensview_impl.cpp test_icon_loader.cpp + test_im_text_entry.cpp + test_hud_view.cpp + test_keyboard_util.cpp test_resultviewgrid.cpp test_single_monitor_launcher_icon.cpp test_switcher_controller.cpp test_switcher_model.cpp ${UNITY_SRC}/AbstractLauncherIcon.cpp ${UNITY_SRC}/AbstractPlacesGroup.cpp + ${UNITY_SRC}/Animator.cpp ${UNITY_SRC}/BackgroundEffectHelper.cpp ${UNITY_SRC}/CairoBaseWindow.cpp + ${UNITY_SRC}/DashSettings.cpp + ${UNITY_SRC}/DashStyle.cpp ${UNITY_SRC}/DashViewPrivate.cpp ${UNITY_SRC}/Decaymulator.cpp ${UNITY_SRC}/DNDCollectionWindow.cpp @@ -214,8 +224,17 @@ ${UNITY_SRC}/GeisAdapter.cpp ${UNITY_SRC}/IconLoader.cpp ${UNITY_SRC}/IconRenderer.cpp + ${UNITY_SRC}/IconTexture.cpp ${UNITY_SRC}/IconTextureSource.cpp + ${UNITY_SRC}/IMTextEntry.cpp ${UNITY_SRC}/Introspectable.cpp + ${UNITY_SRC}/HudAbstractView.cpp + ${UNITY_SRC}/HudButton.cpp + ${UNITY_SRC}/HudController.cpp + ${UNITY_SRC}/HudIcon.cpp + ${UNITY_SRC}/HudIconTextureSource.cpp + ${UNITY_SRC}/HudPrivate.cpp + ${UNITY_SRC}/HudView.cpp ${UNITY_SRC}/LayoutSystem.cpp ${UNITY_SRC}/Launcher.cpp ${UNITY_SRC}/LauncherDragWindow.cpp @@ -224,6 +243,11 @@ ${UNITY_SRC}/LauncherHoverMachine.cpp ${UNITY_SRC}/LauncherIcon.cpp ${UNITY_SRC}/LauncherModel.cpp + ${UNITY_SRC}/KeyboardUtil.cpp + ${UNITY_SRC}/OverlayRenderer.cpp + ${UNITY_SRC}/JSONParser.cpp + ${UNITY_SRC}/SearchBar.cpp + ${UNITY_SRC}/SearchBarSpinner.cpp ${UNITY_SRC}/SimpleLauncherIcon.cpp ${UNITY_SRC}/SingleMonitorLauncherIcon.cpp ${UNITY_SRC}/LensViewPrivate.cpp diff -Nru unity-5.12/tests/test_glib_signals.cpp unity-5.14.0/tests/test_glib_signals.cpp --- unity-5.12/tests/test_glib_signals.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tests/test_glib_signals.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -364,4 +364,24 @@ EXPECT_FALSE(signal0_received_); } +TEST_F(TestGLibSignals, TestManagerObjectDisconnection) +{ + SignalManager manager; + + manager.Add(new Signal(test_signals_, + "signal0", + sigc::mem_fun(this, &TestGLibSignals::Signal0Callback))); + + manager.Add(new Signal(test_signals_, + "signal1", + sigc::mem_fun(this, &TestGLibSignals::Signal1Callback))); + + manager.Disconnect(test_signals_); + + g_signal_emit_by_name(test_signals_, "signal0"); + EXPECT_FALSE(signal0_received_); + g_signal_emit_by_name(test_signals_, "signal1", "test"); + EXPECT_FALSE(signal1_received_); +} + } diff -Nru unity-5.12/tests/test_hud_button.cpp unity-5.14.0/tests/test_hud_button.cpp --- unity-5.12/tests/test_hud_button.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/tests/test_hud_button.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,73 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Andrea Azzarone + * + */ + +#include + +#include +#include +#include + +#include "HudButton.h" +#include "DashStyle.h" +#include "StaticCairoText.h" +#include "DashSettings.h" + +using namespace unity; + +namespace +{ + +TEST(TestHudButton, TestLabelOpacity) +{ + dash::Settings unity_settings; + dash::Style dash_style; + nux::ObjectPtr button(new hud::HudButton()); + nux::Layout* layout = button->GetLayout(); + + ASSERT_NE(layout, nullptr); + ASSERT_EQ(layout->GetChildren().size(), 0); + + hud::Query::Ptr query(new hud::Query("Op File", "","", "", "", NULL)); + button->SetQuery(query); + + auto children(layout->GetChildren()); + ASSERT_EQ(children.size(), 3); + + auto it = children.begin(); + nux::StaticCairoText* label = dynamic_cast(*it); + ASSERT_NE(label, nullptr); + EXPECT_EQ(label->GetText(), "Op"); + EXPECT_EQ(label->GetTextColor().alpha, 1.0f); + + it++; + label = dynamic_cast(*it); + ASSERT_NE(label, nullptr); + EXPECT_EQ(label->GetText(), " Fi"); + EXPECT_EQ(label->GetTextColor().alpha, 0.5f); + + it++; + label = dynamic_cast(*it); + ASSERT_NE(label, nullptr); + EXPECT_EQ(label->GetText(), "le"); + EXPECT_EQ(label->GetTextColor().alpha, 1.0f); +} + +} diff -Nru unity-5.12/tests/test_hud_controller.cpp unity-5.14.0/tests/test_hud_controller.cpp --- unity-5.12/tests/test_hud_controller.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/tests/test_hud_controller.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,87 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Andrea Azzarone + * + */ + +#include +using namespace testing; + +#include "HudController.h" +#include "DashStyle.h" +#include "PanelStyle.h" +#include "DashSettings.h" +#include "WindowManager.h" +#include "test_utils.h" +using namespace unity; + +namespace +{ + +class MockHudView : public hud::AbstractView +{ +public: + typedef nux::ObjectPtr Ptr; + + MOCK_METHOD0(AboutToShow, void()); + MOCK_METHOD0(AboutToHide, void()); + MOCK_METHOD0(Relayout, void()); + MOCK_METHOD0(ResetToDefault, void()); + MOCK_METHOD0(SearchFinished, void()); + MOCK_METHOD4(SetIcon, void(std::string const&, unsigned int tile_size, unsigned int size, unsigned int padding)); + MOCK_METHOD1(SetQueries, void(hud::Hud::Queries queries)); + MOCK_METHOD2(SetWindowGeometry, void(nux::Geometry const& absolute_geo, nux::Geometry const& geo)); + MOCK_METHOD1(ShowEmbeddedIcon, void(bool show)); + MOCK_CONST_METHOD0(default_focus, nux::View*()); + MOCK_CONST_METHOD0(GetName, std::string()); + MOCK_METHOD1(AddProperties, void(GVariantBuilder*)); + MOCK_METHOD2(Draw, void(nux::GraphicsEngine&, bool)); + +}; + +class TestHudController : public Test +{ +public: + virtual void SetUp() + { + WindowManager::SetDefault(WindowManager::Default()); + view = new MockHudView; + controller.reset(new hud::Controller([&view]{ return view.GetPointer(); })); + } + + dash::Settings unity_settings; + dash::Style dash_style; + panel::Style panel_style; + + hud::Controller::Ptr controller; + MockHudView::Ptr view; +}; + +TEST_F(TestHudController, TestHideHud) +{ + controller->ShowHud(); + + EXPECT_CALL(*view, ResetToDefault()) + .Times(1); + + controller->HideHud(); + // view->ResetToDefault should be called at the end of the fade out effect. So wait for it. + Utils::WaitForTimeout(2); +} + +} diff -Nru unity-5.12/tests/test_hud_private.cpp unity-5.14.0/tests/test_hud_private.cpp --- unity-5.12/tests/test_hud_private.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/tests/test_hud_private.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,77 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Andrea Azzarone + * + */ + +#include + +#include "HudPrivate.h" +using namespace unity::hud; + +namespace +{ + +TEST(TestHudPrivate, RefactorTextEmpty) +{ + std::vector> temp; + + temp = impl::RefactorText(""); + ASSERT_EQ(temp.size(), 0); + + temp = impl::RefactorText("Test"); + ASSERT_EQ(temp.size(), 1); + EXPECT_EQ(temp[0].first, "Test"); + EXPECT_EQ(temp[0].second, false); // True means "Full opacity", false "Half opacity" + + temp = impl::RefactorText("Test"); + ASSERT_EQ(temp.size(), 1); + EXPECT_EQ(temp[0].first, "Test"); + EXPECT_EQ(temp[0].second, true); + + temp = impl::RefactorText("Hello > Test World"); + ASSERT_EQ(temp.size(), 3); + EXPECT_EQ(temp[0].first, "Hello > "); + EXPECT_EQ(temp[0].second, false); + EXPECT_EQ(temp[1].first, "Test"); + EXPECT_EQ(temp[1].second, true); + EXPECT_EQ(temp[2].first, " World"); + EXPECT_EQ(temp[2].second, false); + + temp = impl::RefactorText("Open File With"); + ASSERT_EQ(temp.size(), 5); + EXPECT_EQ(temp[0].first, "Open "); + EXPECT_EQ(temp[0].second, false); + EXPECT_EQ(temp[1].first, "Fi"); + EXPECT_EQ(temp[1].second, true); + EXPECT_EQ(temp[2].first, "le "); + EXPECT_EQ(temp[2].second, false); + EXPECT_EQ(temp[3].first, "Wit"); + EXPECT_EQ(temp[3].second, true); + EXPECT_EQ(temp[4].first, "h"); + EXPECT_EQ(temp[4].second, false); + + temp = impl::RefactorText("Open File With"); + ASSERT_EQ(temp.size(), 2); + EXPECT_EQ(temp[0].first, "Open "); + EXPECT_EQ(temp[0].second, false); + EXPECT_EQ(temp[1].first, "File With"); + EXPECT_EQ(temp[1].second, true); +} + +} diff -Nru unity-5.12/tests/test_hud_view.cpp unity-5.14.0/tests/test_hud_view.cpp --- unity-5.12/tests/test_hud_view.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/tests/test_hud_view.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,74 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Andrea Azzarone + * + */ + +#include + +#include + +#include +#include +#include + +#include "HudView.h" +#include "DashSettings.h" +#include "DashStyle.h" +using namespace unity; + +namespace +{ + +TEST(TestHudView, TestSetQueries) +{ + dash::Settings unity_settings; + dash::Style dash_style; + nux::ObjectPtr view(new hud::View()); + + hud::Hud::Queries queries; + queries.push_back(hud::Query::Ptr(new hud::Query("1", "","", "", "", NULL))); + queries.push_back(hud::Query::Ptr(new hud::Query("2", "","", "", "", NULL))); + queries.push_back(hud::Query::Ptr(new hud::Query("3", "","", "", "", NULL))); + queries.push_back(hud::Query::Ptr(new hud::Query("4", "","", "", "", NULL))); + view->SetQueries(queries); + + ASSERT_EQ(view->buttons().size(), 4); + + auto it = view->buttons().begin(); + EXPECT_EQ((*it)->label, "4"); + EXPECT_TRUE((*it)->is_rounded); + EXPECT_FALSE((*it)->fake_focused); + + it++; + EXPECT_EQ((*it)->label, "3"); + EXPECT_FALSE((*it)->is_rounded); + EXPECT_FALSE((*it)->fake_focused); + + it++; + EXPECT_EQ((*it)->label, "2"); + EXPECT_FALSE((*it)->is_rounded); + EXPECT_FALSE((*it)->fake_focused); + + it++; + EXPECT_EQ((*it)->label, "1"); + EXPECT_FALSE((*it)->is_rounded); + EXPECT_TRUE((*it)->fake_focused); +} + +} diff -Nru unity-5.12/tests/test_im_text_entry.cpp unity-5.14.0/tests/test_im_text_entry.cpp --- unity-5.12/tests/test_im_text_entry.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/tests/test_im_text_entry.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,170 @@ +/* + * Copyright 2012 Canonical Ltd. + * + * This program is free software: you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License version 3, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranties of + * MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the applicable version of the GNU Lesser General Public + * License for more details. + * + * You should have received a copy of both the GNU Lesser General Public + * License version 3 along with this program. If not, see + * + * + * Authored by: Marco Trevisan (Treviño) <3v1n0@ubuntu.com> + * + */ + +#include +#include "IMTextEntry.h" + +using namespace testing; +using namespace unity; + +namespace +{ + +class TestEvent : public nux::Event +{ +public: + TestEvent(nux::KeyModifier keymod, unsigned long keysym) + { + type = NUX_KEYDOWN; + key_modifiers = keymod; + x11_keysym = keysym; + } + + TestEvent(unsigned long keysym) + { + type = NUX_KEYDOWN; + x11_keysym = keysym; + } +}; + +class MockTextEntry : public IMTextEntry +{ +public: + MOCK_METHOD1(InsertText, void(std::string const&)); + MOCK_METHOD0(Cut, void()); + MOCK_METHOD0(Copy, void()); + MOCK_METHOD1(Paste, void(bool)); + + bool TryHandleSpecial(nux::Event const& event) + { + return IMTextEntry::TryHandleSpecial(event); + } +}; + + +TEST(TestIMTextEntry, CopyCtrlC) +{ + MockTextEntry text_entry; + + TestEvent event(KEY_MODIFIER_CTRL, NUX_VK_c); + + EXPECT_CALL(text_entry, Copy()); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); +} + +TEST(TestIMTextEntry, CopyCtrlIns) +{ + MockTextEntry text_entry; + + TestEvent event(KEY_MODIFIER_CTRL, NUX_VK_INSERT); + + EXPECT_CALL(text_entry, Copy()); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); +} + +TEST(TestIMTextEntry, PasteCtrlV) +{ + MockTextEntry text_entry; + + TestEvent event(KEY_MODIFIER_CTRL, NUX_VK_v); + + EXPECT_CALL(text_entry, Paste(false)); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); +} + +TEST(TestIMTextEntry, PasteShiftIns) +{ + MockTextEntry text_entry; + + TestEvent event(KEY_MODIFIER_SHIFT, NUX_VK_INSERT); + + EXPECT_CALL(text_entry, Paste(false)); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); +} + +TEST(TestIMTextEntry, CutCtrlX) +{ + MockTextEntry text_entry; + + TestEvent event(KEY_MODIFIER_CTRL, NUX_VK_x); + + EXPECT_CALL(text_entry, Cut()); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); +} + +TEST(TestIMTextEntry, CutShiftDel) +{ + MockTextEntry text_entry; + + TestEvent event(KEY_MODIFIER_SHIFT, NUX_VK_DELETE); + + EXPECT_CALL(text_entry, Cut()); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); +} + +TEST(TestIMTextEntry, CtrlMoveKeys) +{ + MockTextEntry text_entry; + + TestEvent left(KEY_MODIFIER_CTRL, NUX_VK_LEFT); + EXPECT_TRUE(text_entry.TryHandleSpecial(left)); + + TestEvent right(KEY_MODIFIER_CTRL, NUX_VK_RIGHT); + EXPECT_TRUE(text_entry.TryHandleSpecial(right)); + + TestEvent home(KEY_MODIFIER_CTRL, NUX_VK_HOME); + EXPECT_TRUE(text_entry.TryHandleSpecial(home)); + + TestEvent end(KEY_MODIFIER_CTRL, NUX_VK_END); + EXPECT_TRUE(text_entry.TryHandleSpecial(end)); +} + +TEST(TestIMTextEntry, CtrlDeleteKeys) +{ + MockTextEntry text_entry; + + TestEvent del(KEY_MODIFIER_CTRL, NUX_VK_DELETE); + EXPECT_TRUE(text_entry.TryHandleSpecial(del)); + + TestEvent backspace(KEY_MODIFIER_CTRL, NUX_VK_BACKSPACE); + EXPECT_TRUE(text_entry.TryHandleSpecial(backspace)); +} + +TEST(TestIMTextEntry, CtrlA) +{ + MockTextEntry text_entry; + + TestEvent selectall(KEY_MODIFIER_CTRL, NUX_VK_a); + EXPECT_TRUE(text_entry.TryHandleSpecial(selectall)); +} + +TEST(TestIMTextEntry, SuperKeybindings) +{ + MockTextEntry text_entry; + + for (unsigned long keysym = 0; keysym < XK_VoidSymbol; ++keysym) + { + TestEvent event(KEY_MODIFIER_SUPER, keysym); + EXPECT_FALSE(text_entry.TryHandleSpecial(event)); + } +} + +} diff -Nru unity-5.12/tests/test_keyboard_util.cpp unity-5.14.0/tests/test_keyboard_util.cpp --- unity-5.12/tests/test_keyboard_util.cpp 1970-01-01 00:00:00.000000000 +0000 +++ unity-5.14.0/tests/test_keyboard_util.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -0,0 +1,115 @@ +// -*- Mode: C++; indent-tabs-mode: nil; tab-width: 2 -*- +/* + * Copyright (C) 2012 Canonical Ltd + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 3 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + * Authored by: Marco Trevisan (Treviño) <3v1n0@ubuntu.com> + */ + +#include +#include + +#include "KeyboardUtil.h" + +using namespace unity::ui; + +namespace +{ + +void test_key(KeyboardUtil const& key_util, Display* x_display, const char* key) +{ + unsigned int above_keycode = key_util.GetKeycodeAboveKeySymbol(XStringToKeysym(key)); + KeySym above_keysym = XkbKeycodeToKeysym(x_display, above_keycode, 0, 1); + EXPECT_NE(above_keysym, NoSymbol); +} + +TEST(TestKeyboardUtil, AboveKeySymbol) +{ + Display* x_display = XOpenDisplay(NULL); + + KeyboardUtil key_util(x_display); + test_key(key_util, x_display, "Tab"); + test_key(key_util, x_display, "Shift_R"); + test_key(key_util, x_display, "Control_L"); + test_key(key_util, x_display, "space"); + test_key(key_util, x_display, "comma"); + test_key(key_util, x_display, "a"); + test_key(key_util, x_display, "b"); + test_key(key_util, x_display, "c"); + test_key(key_util, x_display, "d"); + test_key(key_util, x_display, "e"); + test_key(key_util, x_display, "f"); + test_key(key_util, x_display, "g"); + test_key(key_util, x_display, "h"); + test_key(key_util, x_display, "i"); + test_key(key_util, x_display, "j"); + test_key(key_util, x_display, "k"); + test_key(key_util, x_display, "l"); + test_key(key_util, x_display, "m"); + test_key(key_util, x_display, "n"); + test_key(key_util, x_display, "o"); + test_key(key_util, x_display, "p"); + test_key(key_util, x_display, "k"); + test_key(key_util, x_display, "r"); + test_key(key_util, x_display, "s"); + test_key(key_util, x_display, "t"); + test_key(key_util, x_display, "u"); + test_key(key_util, x_display, "v"); + test_key(key_util, x_display, "w"); + test_key(key_util, x_display, "x"); + test_key(key_util, x_display, "y"); + test_key(key_util, x_display, "z"); +} + +TEST(TestKeyboardUtil, PrintableKeySymbols) +{ + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_Delete)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_BackSpace)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_space)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_3)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_v)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_1)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_ntilde)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_0)); + EXPECT_TRUE(KeyboardUtil::IsPrintableKeySymbol(XK_exclam)); + + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_F1)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Select)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Hyper_R)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Control_L)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Shift_L)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Super_L)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Print)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Insert)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Num_Lock)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_Caps_Lock)); + EXPECT_FALSE(KeyboardUtil::IsPrintableKeySymbol(XK_ISO_Level3_Shift)); +} + +TEST(TestKeyboardUtil, MoveKeySymbols) +{ + std::vector move_symbols { XK_Home, XK_Left, XK_Up, XK_Right, XK_Down, + XK_Prior, XK_Page_Up, XK_Next, XK_Page_Down, + XK_End, XK_Begin }; + + for (KeySym sym = 0; sym < XK_VoidSymbol; ++sym) + { + if (std::find(move_symbols.begin(), move_symbols.end(), sym) != move_symbols.end()) + EXPECT_TRUE(KeyboardUtil::IsMoveKeySymbol(sym)); + else + EXPECT_FALSE(KeyboardUtil::IsMoveKeySymbol(sym)); + } +} + +} // Namespace diff -Nru unity-5.12/tests/test_main.cpp unity-5.14.0/tests/test_main.cpp --- unity-5.12/tests/test_main.cpp 2012-07-20 17:50:57.000000000 +0000 +++ unity-5.14.0/tests/test_main.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -1,12 +1,13 @@ #include #include +#include #include #include int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); - g_type_init(); + gtk_init(&argc, &argv); nux::NuxInitialize (0); nux::WindowThread* wnd_thread = nux::CreateNuxWindow("Tests", 300, 200, nux::WINDOWSTYLE_NORMAL, NULL, false, NULL, NULL); diff -Nru unity-5.12/tests/test_switcher_controller.cpp unity-5.14.0/tests/test_switcher_controller.cpp --- unity-5.12/tests/test_switcher_controller.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tests/test_switcher_controller.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -156,4 +156,15 @@ EXPECT_TRUE(unity::TimeUtil::TimeDelta(&controller.detail_timespec_, ¤t) >= 1000); } +TEST(TestSwitcherController, ShowSwitcher) +{ + MockSwitcherController controller; + std::vector results; + + controller.Show(ShowMode::ALL, SortMode::LAUNCHER_ORDER, false, results); + + Utils::WaitUntil(controller.view_shown_, 2); + ASSERT_TRUE(controller.view_shown_); +} + } diff -Nru unity-5.12/tools/unity.cmake unity-5.14.0/tools/unity.cmake --- unity-5.12/tools/unity.cmake 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/tools/unity.cmake 2012-07-18 11:12:56.000000000 +0000 @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA import gconf +import glib import glob from optparse import OptionParser import os @@ -81,7 +82,7 @@ # as compiz set a new schema instead of a value.. try: current_profile_schema = client.get_schema("/apps/compizconfig-1/current_profile") - except (GError, AttributeError), e: + except (glib.GError, AttributeError), e: print "WARNING: environment is incorrect: %s\nDid you just try to reset in a tty?" % e return diff -Nru unity-5.12/UnityCore/GLibSignal.cpp unity-5.14.0/UnityCore/GLibSignal.cpp --- unity-5.12/UnityCore/GLibSignal.cpp 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/UnityCore/GLibSignal.cpp 2012-07-18 11:12:56.000000000 +0000 @@ -71,12 +71,10 @@ // (it allows you to pass in a GObject without casting up). void SignalManager::Disconnect(void* object, std::string const& signal_name) { - for (ConnectionVector::iterator it = connections_.begin(); - it != connections_.end(); - ++it) + for (auto it = connections_.begin(); it != connections_.end(); ++it) { - if ((*it)->object() == object - && (*it)->name() == signal_name) + if ((*it)->object() == object && + (signal_name.empty() || (*it)->name() == signal_name)) { (*it)->Disconnect(); connections_.erase(it, it); diff -Nru unity-5.12/UnityCore/GLibSignal.h unity-5.14.0/UnityCore/GLibSignal.h --- unity-5.12/UnityCore/GLibSignal.h 2012-04-27 06:31:09.000000000 +0000 +++ unity-5.14.0/UnityCore/GLibSignal.h 2012-07-18 11:12:56.000000000 +0000 @@ -295,7 +295,7 @@ SignalManager(); void Add(SignalBase* signal); - void Disconnect(void* object, std::string const& signal_name); + void Disconnect(void* object, std::string const& signal_name = ""); private: ConnectionVector connections_;