samba: FTBFS (amd64/gcc-4.0): array type has incomplete element type

Bug #15356 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
Debian
Fix Released
Unknown
Ubuntu
Fix Released
High
Martin Pitt

Bug Description

Automatically imported from Debian bug report #299304 http://bugs.debian.org/299304

Revision history for this message
In , Steve Langasek (vorlon) wrote :

tags 299304 fixed-upstream
thanks

I'm told that this bug has been fixed upstream; it remains to be determined
which version it was fixed in, to verify whether the fix has reached Debian
(or when it will).

--
Steve Langasek
postmodern programmer

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #299304 http://bugs.debian.org/299304

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (3.6 KiB)

Message-Id: <email address hidden>
Date: Sun, 13 Mar 2005 14:05:09 +0100
From: Andreas Jochens <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: samba: FTBFS (amd64/gcc-4.0): array type has incomplete element type

Package: samba
Severity: normal
Tags: patch

When building 'samba' on amd64 with gcc-4.0,
I get the following error:

Compiling dynconfig.c
In file included from include/smb.h:1673,
                 from include/includes.h:817,
                 from dynconfig.c:21:
include/popt_common.h:25: error: array type has incomplete element type
include/popt_common.h:26: error: array type has incomplete element type
include/popt_common.h:27: error: array type has incomplete element type
include/popt_common.h:28: error: array type has incomplete element type
make[1]: *** [dynconfig.o] Error 1
make[1]: Leaving directory `/samba-3.0.10/source'
make: *** [build-stamp] Error 2

With the attached patch 'samba' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/samba-3.0.10/debian/patches/gcc4-fix.patch ./debian/patches/gcc4-fix.patch
--- ../tmp-orig/samba-3.0.10/debian/patches/gcc4-fix.patch 1970-01-01 01:00:00.000000000 +0100
+++ ./debian/patches/gcc4-fix.patch 2005-03-11 12:49:11.159111783 +0100
@@ -0,0 +1,57 @@
+diff -urN source.orig/include/popt_common.h samba/source/include/popt_common.h
+--- source.orig/include/popt_common.h 2004-10-25 23:05:06.000000000 +0200
++++ samba/source/include/popt_common.h 2005-03-11 12:48:21.334047738 +0100
+@@ -22,10 +22,10 @@
+ #define _POPT_COMMON_H
+
+ /* Common popt structures */
+-extern struct poptOption popt_common_samba[];
+-extern struct poptOption popt_common_connection[];
+-extern struct poptOption popt_common_version[];
+-extern struct poptOption popt_common_credentials[];
++extern struct poptOption *popt_common_samba;
++extern struct poptOption *popt_common_connection;
++extern struct poptOption *popt_common_version;
++extern struct poptOption *popt_common_credentials;
+
+ #ifndef POPT_TABLEEND
+ #define POPT_TABLEEND { NULL, '\0', 0, 0, 0, NULL, NULL }
+diff -urN source.orig/lib/popt_common.c samba/source/lib/popt_common.c
+--- source.orig/lib/popt_common.c 2004-10-25 23:04:59.000000000 +0200
++++ samba/source/lib/popt_common.c 2005-03-11 12:48:50.942166331 +0100
+@@ -114,7 +114,7 @@
+ }
+ }
+
+-struct poptOption popt_common_connection[] = {
++struct poptOption *popt_common_connection = {
+ { NULL, 0, POPT_ARG_CALLBACK, popt_common_callback },
+ { "socket-options", 'O', POPT_ARG_STRING, NULL, 'O', "socket options to use",
+ "SOCKETOPTIONS" },
+@@ -125,7 +125,7 @@
+ POPT_TABLEEND
+ };
+
+-struct poptOption popt_common_samba[] = {
++struct poptOption *popt_common_samba = {
+ { NULL, 0, POPT_ARG_CALLBACK|POPT_CBFLAG_PRE, popt_common_callback },
+ { "debuglevel", 'd', POPT_ARG_STRING, NULL, 'd', "Set debug level", "DEBUGLEVEL" },
+ { "configfile", 's', POPT_ARG_STRING, NULL, 's', "Use alternative configuration file", "CONFIGFILE" },
+@@ -134,7 +134,7 @@
+ POPT_TABLEEND
+ };
+
+-struct poptOption popt_common_version[] = {
++struct poptOption *popt_common_version = {
+ { NULL, 0, POPT_ARG_CALLBACK, popt_...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Mon, 28 Mar 2005 16:58:42 -0800
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: Re: samba: FTBFS (amd64/gcc-4.0): array type has incomplete element type

--ieNMXl1Fr3cevapt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

tags 299304 fixed-upstream
thanks

I'm told that this bug has been fixed upstream; it remains to be determined
which version it was fixed in, to verify whether the fix has reached Debian
(or when it will).

--=20
Steve Langasek
postmodern programmer

--ieNMXl1Fr3cevapt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCSKhAKN6ufymYLloRAmq3AJ9Rm7aRayJKDZuacN+Ro69b1k2jcgCgv8wq
LzWZyEbxWPHifJcCO6FkLtU=
=POrV
-----END PGP SIGNATURE-----

--ieNMXl1Fr3cevapt--

Revision history for this message
Martin Pitt (pitti) wrote :

 samba (3.0.10-1ubuntu4) breezy; urgency=low
 .
   * debian/patches/gcc4-fix.patch: Fix FTBFS with gcc 4.0. (#9047)

Revision history for this message
In , Adam Conrad (adconrad) wrote : This bug can be closed, and the patch dropped.

In merging Samba with Ubuntu, we used the patch in this bug, and it caused
some broken behaviour in smbclient. Upstream did, however, fix things
differently (and correctly) in a recent enough version that 14a-1 compiled
just fine with gcc-4.0 without the use of this patch.

Feel free, therefore, to close this bug.

... Adam

Revision history for this message
In , Steve Langasek (vorlon) wrote : Re: Bug#299304: This bug can be closed, and the patch dropped.

On Thu, May 19, 2005 at 11:01:10PM +1000, Adam Conrad wrote:
> In merging Samba with Ubuntu, we used the patch in this bug, and it caused
> some broken behaviour in smbclient. Upstream did, however, fix things
> differently (and correctly) in a recent enough version that 14a-1 compiled
> just fine with gcc-4.0 without the use of this patch.

> Feel free, therefore, to close this bug.

Closing as explained.

Thanks,
--
Steve Langasek
postmodern programmer

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.