neutron

unplug_interface of cisco plugin's l2network_plugin.py references non-existing exception

Bug #1006226 reported by yong sheng gong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Chinmay Kulkarni
neutron 2012.2 "folsom"

Bug Description

unplug_interface of cisco plugin's l2network_plugin.py references non-existing exception InvalidDetach.
According to plugin api of QuantumPluginBase, unplug_interface should only raise exception.NetworkNotFound
        exception.PortNotFound

See original description
Revision history for this message
yong sheng gong (gongysh) wrote :

similar one at https://bugs.launchpad.net/quantum/+bug/1006221

description: updated
Revision history for this message
dan wendlandt (danwent) wrote :

assigning to sumit to triage

Changed in quantum:
importance: Undecided → Low
assignee: nobody → Sumit Naiksatam (snaiksat)
dan wendlandt (danwent)
Changed in quantum:
status: New → Confirmed
Revision history for this message
Chinmay Kulkarni (chnm-kulkarni) wrote :

hey,
i was just thinking, i know that the quantumpluginbase mentions that unplugiface needs to raise only those two exceptions, but an extra exception could be added to the cisco exceptions list for an invalid detach moreover,
raise exc.InvalidDetach(port_id=port_id, net_id=net_id ,att_id=remote_interface_id) would just need to be replaced by
raise cexc.InvalidDetach(port_id=port_id, net_id=net_id,att_id=remote_interface_id)

This correction would be much easier, correct me if i'm wrong...

Revision history for this message
Sumit Naiksatam (snaiksat) wrote :

Thanks, yes we can do that. Guessing that you are also interested in doing this, so assigning it to you. Let me know otherwise.

Changed in quantum:
assignee: Sumit Naiksatam (snaiksat) → Chinmay Kulkarni (chnm-kulkarni)
milestone: none → folsom-2
Revision history for this message
Chinmay Kulkarni (chnm-kulkarni) wrote :

sumit,
Thanks, will take care of it

Revision history for this message
Chinmay Kulkarni (chnm-kulkarni) wrote :

Sumit,
I've fixed the issue ,but my membership to the contributors has not been approved yet, so it will take some time for me to commit these changes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8654

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/8736
Committed: http://github.com/openstack/quantum/commit/4ac32079279347c454f5d9fe22a21dfcbf3ab64f
Submitter: Jenkins
Branch: master

commit 4ac32079279347c454f5d9fe22a21dfcbf3ab64f
Author: chnm-kulkarni <email address hidden>
Date: Sat Jun 30 09:40:53 2012 +0530

    Cisco's unplug_iface refers to non existing exception

    Bug #1006226

    An extra exception,InvalidDetach has been added to cisco_exception.py and
    unplug_iface has been redirected to this exception

    Change-Id: I5d1e4070fd0cb60a973e55e5645509aef58e8083

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-2 → 2012.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/8654
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.