TPAC unable to link to specific organization by shortname

After some testing, this seems to work for me: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/locg-ou-name (for master anyway).

It wants more testing from someone else. The parts of the TPAC code affected by this are murky, where we have loc and locg and pref_lib and physical_loc and some cookies and HTTP headers too. A single, easy-to-find design or document of intent about the correct interplay of all these inputs would facilitate confident development in this area.

Works in 2.2, but with one caveat. locg is case sensitive, so isli is bad but ISLI is good. Can we remove that case sensitivity?

Sure thing Mike. I force-pushed a revised commit to the same branch that does that. Here's an explanation from the revised commit message:

    Now case insensitive per recommendation by Michael Peters. In the
    event that you have org units with names that are the same except
    for case (probably a bad practice), the locg parameter will simply
    fail to set your context, rather than try to guess which org unit
    you meant.

Big thanks, Lebbeous!

Marking as new feature for 2.4.

Tested, and works nicely. My signoff: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/locg-ou-name-signoff

I had to resolve a merge conflict, but testing showed that using locg=4 was the same as locg=BR1 and locg=Br1, so that worked for me. Pushed to master. And thanks!

Thanks Pasi / Dan