setup.py always builds zope.hookable._zope_hookable extension

Bug #1025470 reported by Arfrever Frehtes Taifersar Arahesis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zope.hookable
Fix Released
Undecided
Tres Seaver

Bug Description

setup.py calls Extension("zope.hookable._zope_hookable", ...) twice, which results in always building zope.hookable._zope_hookable extension, even with PyPy or with CPython and --without-Cwrapper option passed (`python setup.py --without-Cwrapper build`).

--- setup.py
+++ setup.py
@@ -72,11 +72,6 @@
       features=features,
       packages=find_packages('src'),
       package_dir={'': 'src'},
- ext_modules=[Extension("zope.hookable._zope_hookable",
- [os.path.join('src', 'zope', 'hookable',
- "_zope_hookable.c")
- ], extra_compile_args=['-g']),
- ],
       namespace_packages=['zope',],
       install_requires=['setuptools'],
       include_package_data=True,

Revision history for this message
Tres Seaver (tseaver) wrote :

I agree with this patch: the work to make the feature bit disabled
under PyPy is subverted by explicitly building the extension.

Changed in zope.hookable:
assignee: nobody → Tres Seaver (tseaver)
status: New → In Progress
Tres Seaver (tseaver)
Changed in zope.hookable:
status: In Progress → Fix Committed
Revision history for this message
Arfrever Frehtes Taifersar Arahesis (arfrever-fta) wrote :

Fix was released in zope.hookable-4.0.1.

Changed in zope.hookable:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.