reduce duplicate code in ovs agent

btw, rkukura mentioned that me might tackle this, either as part of the provider networks stuff, or after that.

The patch for ovs provider networks probably also addresses this bug.
Il giorno 27/ago/2012 10:36, "dan wendlandt" <email address hidden>
ha scritto:

> ** Changed in: quantum
> Status: New => Confirmed
>
> ** Changed in: quantum
> Importance: Undecided => Wishlist
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/1035492
>
> Title:
> reduce duplicate code in ovs agent
>
> Status in OpenStack Quantum (virtual network service):
> Confirmed
>
> Bug description:
> OVSQuantumAgent and OVSQuantumTunnelAgent duplicate a lot of the same
> code between each other. It would be nice if we could remove a lot of
> the duplication.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1035492/+subscriptions
>

Yes, this should be closed when the provider networks patch is merged.

Fix proposed to branch: master
Review: https://review.openstack.org/12271

Reviewed: https://review.openstack.org/12271
Committed: http://github.com/openstack/quantum/commit/493903c0d03e53fd8192dff2177698d332935087
Submitter: Jenkins
Branch: master

commit 493903c0d03e53fd8192dff2177698d332935087
Author: Bob Kukura <email address hidden>
Date: Fri Aug 31 00:12:41 2012 -0400

    expose openvswitch GRE tunnel_id via provider API

    The provider:vlan_id extended attribute is renamed to
    provider:segmentation_id, and the openvswitch plugin returns the
    tunnel_id of GRE networks as this attribute.

    Fixes bug 1044375. Final patch in series that fixes bug 1037341 and
    bug 1035492.

    Detailed changes:

    - Rename provider:vlan_id to provider:segmentation_id.
    - Use consts for providernet extension's attribute names
    - Remove validation clause from provider:segmentation_id resource attribute map data.
    - Validate provider:segmentation_id in linuxbridge and openvswitch plugins.
    - Rename physical_id to segmentation_id in the openvswitch schema, plugin, and agent.

    Change-Id: Ic023b30b6e3275955bcb8a09c7936035dacf3f87