configure_networking net-DEVICE.conf in /tmp, but upstart job expects /run

Bug #1047722 reported by Scott Moser
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
open-iscsi (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Fix Released
Medium
Unassigned

Bug Description

=== Begin SRU Information ===
[Impact]
Open-iscsi's /etc/init/iscsi-network-interface job expects that
the 'ipconfig' code in the client writes a file named /run/${DEVICE}.conf

The klibc in 12.04 writes that file to /tmp. This is simply a verison
and expectation mismatch between klibc and open-iscsi in 12.04.

It can result in the network interface upon which the iscsi target
resides being brought down, as /etc/init/iscsi-network-interface no
longer functions correctly.

With a network block-device under your root filesystem, bringing
down the network is not good.

The fix here is done in the initramfs and should be forwards compatible.
If a file has been written named /tmp/net-DEVICE.conf and a file
has *not* been written /run/net-device.conf, then it will be copyied from
/tmp to /run. That will later be picked up by iscsi-network-interface.conf
which will then function correctly.

[Test Case]
its easy to see that if the net-DEVICE.conf file is not written in
/run, then the code in /etc/init/iscsi-network-interface will not have
the desired affect.

[Regression Potential]
There should not be much chance for regression here. Likely, fallout
would be limited to iscsi root instances.

[Other Info]
The maas "ephemeral images" have been using this patch for several
months, and the changes are the same as applied in quantal.
=== End SRU Information ===

This bug was initially opened with misunderstanding.
The issue present is that open-iscsi's upstart job expects ipconfig files to be in /run, but they are written by ipconfig in precise to /tmp.

ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: initramfs-tools 0.103ubuntu0.1
ProcVersionSignature: User Name 3.5.0-13.14-generic 3.5.3
Uname: Linux 3.5.0-13-generic x86_64
ApportVersion: 2.5.1-0ubuntu7
Architecture: amd64
Date: Sat Sep 8 03:28:37 2012
Ec2AMI: ami-00000148
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: m1.small
Ec2Kernel: unavailable
Ec2Ramdisk: unavailable
PackageArchitecture: all
ProcEnviron:
 TERM=screen
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: initramfs-tools
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Scott Moser (smoser) wrote :

Moving to kblic-utils.

affects: initramfs-tools (Ubuntu) → klibc (Ubuntu)
Changed in klibc (Ubuntu):
importance: Undecided → Medium
status: New → Fix Released
Changed in klibc (Ubuntu Precise):
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Scott Moser (smoser) wrote :

<slangasek> smoser: I've checked the source in quantal, it's definitely writing to /run now
^^ as a result, marked fix-released and targetted to 12.04.

Revision history for this message
Scott Moser (smoser) wrote :

I've added open-iscsi here. The fix necessary there is in debian/extra/initramfs.local-top. This was looking in /tmp, but if we modify kblic to write to /run, we need to modify this script also.

Changed in open-iscsi (Ubuntu):
status: New → Fix Released
importance: Undecided → Medium
Changed in open-iscsi (Ubuntu Precise):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Scott Moser (smoser) wrote :

Hm..
I'm now thinking my initial collection of this might have been flawed. [1] shows this as expecting data in /tmp.

--
[1] http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/initramfs-tools/precise/view/head:/scripts/functions#L405

Revision history for this message
Scott Moser (smoser) wrote :

as far as I can see now, the only issue is that openiscsi's 'iscsi-network-interface.conf' upstart file
debian/open-iscsi.iscsi-network-interface.upstart

expects the file to be written in /run, but with klibc/ipconfig in precise it is written to /tmp.

summary: - configure_networking net-DEVICE.conf in /run, but ipconfig writes in
- /tmp
+ configure_networking net-DEVICE.conf in /tmp, but upstart job expects
+ /run
no longer affects: initramfs-tools (Ubuntu)
no longer affects: klibc (Ubuntu)
no longer affects: initramfs-tools (Ubuntu Precise)
no longer affects: klibc (Ubuntu Precise)
description: updated
Scott Moser (smoser)
description: updated
Revision history for this message
Scott Moser (smoser) wrote :

uploaded fix to precise-proposed yesterday.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Scott, or anyone else affected,

Accepted open-iscsi into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/open-iscsi/2.0.871-0ubuntu9.12.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in open-iscsi (Ubuntu Precise):
status: Triaged → Fix Committed
tags: added: verification-needed
Scott Moser (smoser)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package open-iscsi - 2.0.871-0ubuntu9.12.04.2

---------------
open-iscsi (2.0.871-0ubuntu9.12.04.2) precise-proposed; urgency=low

  * update resolvconf with settings found by ipconfig for the
    interface that contains the iscsi-root filesystem (LP: #1050487)
  * support files written by klibc ipconfig to be found in /tmp or
    /run. copy files in /tmp to /run (LP: #1047722)
 -- Scott Moser <email address hidden> Mon, 17 Sep 2012 16:44:24 -0400

Changed in open-iscsi (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.