get_object does not allow user-provided headers

Bug #1051046 reported by David Kranz
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-swiftclient
Fix Released
Wishlist
Matthieu Huin

Bug Description

For example, a user may want to provide a "Range" header or other headers documented in the Swift API reference.

Changed in python-swiftclient:
status: New → Confirmed
Revision history for this message
Darrell Bishop (darrellb) wrote :

cf. http://docs.openstack.org/api/openstack-object-storage/1.0/content/retrieve-object.html

I see the following set of potentially-desired headers:

 * If-Match
 * If-None-Match
 * If-Modified-Since
 * If-Unmodified-Since
 * Range (partially supported)

We could add support for them to get_object in the same way additional headers are supported in put_object (i.e. as optional keyword args, with good defaults, and potentially additional handling before marshaling into actual header values).

Revision history for this message
David Kranz (david-kranz) wrote :

That is kind of what I was thinking. An issue I ran in with my last submission of adding an endpoint argument is that the unit tests for this library are very limited. There do not appear to be any tests for the keyword options for put_object at all.

Revision history for this message
David Kranz (david-kranz) wrote :

Another, simpler, alternative would be to add an optional 'headers' argument.

Changed in python-swiftclient:
importance: Undecided → Wishlist
Revision history for this message
Byron McCollum (byron-mccollum) wrote :

Others of interest:

X-Delete-At
X-Delete-After

Matthieu Huin (mhu-s)
Changed in python-swiftclient:
assignee: nobody → Matthieu Huin (mhu-s)
Matthieu Huin (mhu-s)
Changed in python-swiftclient:
status: Confirmed → In Progress
Revision history for this message
Fabien Boucher (fabien-boucher) wrote :

This is addressed by the review :
https://review.openstack.org/#/c/41715/

Changed in python-swiftclient:
status: In Progress → Fix Committed
Changed in python-swiftclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.