[nova|cinder]-manage volume commands no longer work after the ID -> UUID changes

Bug #1051603 reported by Kiall Mac Innes
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Cinder
Invalid
High
Unassigned
OpenStack Compute (nova)
Fix Released
High
John Griffith

Bug Description

The nova-manage / cinder-manage volume commands no longer work after the ID -> UUID changes introduced in folsom.

This prevents administrators for being able to repair volume inconsistencies.

Revision history for this message
Kiall Mac Innes (kiall) wrote :

This actually seems to be deeper than than ID -> UUID changes.

When cinder is used:

* nova-manage has no knowledge of the volume - so it cannot reattach the volume.
* cinder-manage has no knowledge of the instance - so it cannot reattach the volume.

description: updated
summary: - [nova|cinder]-manage volume commands no longer work after the volume ID
- -> UUID changes
+ [nova|cinder]-manage volume commands no longer work after the ID -> UUID
+ changes
Revision history for this message
John Griffith (john-griffith) wrote :

Yep, the direct db/volume calls in nova-manage need to be updated to use the appropriate Volume API instead of trying to go direct.

Dan Prince (dan-prince)
Changed in nova:
milestone: none → folsom-rc1
importance: Undecided → High
status: New → Triaged
Changed in cinder:
importance: Undecided → High
status: New → Triaged
milestone: none → folsom-rc1
Changed in nova:
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13181

Changed in nova:
status: Triaged → In Progress
Changed in cinder:
milestone: folsom-rc1 → none
Revision history for this message
John Griffith (john-griffith) wrote :

This can be worked using the admin update extensions that were recently merged:
nova commit id: If795599d
cinder commit id: I29f4b892

In the meantime deprecate these functions and exit with an error is cinder is the configured volume api.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/13181
Committed: http://github.com/openstack/nova/commit/088472b86f3748e00e82c8a0b304371caebbd519
Submitter: Jenkins
Branch: master

commit 088472b86f3748e00e82c8a0b304371caebbd519
Author: John Griffith <email address hidden>
Date: Mon Sep 17 21:05:49 2012 -0600

    Fix volume id conversion in nova-manage volume

      The nova-manage volume commands weren't updated when the switch
      from int volume-id's to uuid's was made. This updates the
      param2id method to call the appropriate conversion, and doesn't
      attempt to cast the value to an int.

      There is an additional issue with the nova-manage commands with the
      introduction of Cinder. The calls in nova-manage are direct to the
      nova database which when using Cinder is not valid. Add an error message
      when trying to use delete or re-attach commands as they don't work.

      This change deprecates the nova-manage delete function as it's now
      implemented as an admin extension (nova commit id: If795599d and
      cinder commit id: I29f4b892).

      The reattach command is only valid for nova-volumes, a similar extension
      will need to be added to cover cinder at which time the nova-manage volume
      reattach can be deprecated as well.

      Partial fix for bug #1051603

    Change-Id: I666d4e627dee4a2025f7135560ee36c40f4bf17a

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
Changed in cinder:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.