Sync indicator state can get out of sync
Bug #1053631 reported by
Alejandro J. Cura
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-4-0 |
Triaged
|
Undecided
|
Unassigned | |||
Stable-4-2 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
High
|
Diego Sarmentero | |||
ubuntuone-client (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
Quantal |
Won't Fix
|
Undecided
|
Unassigned | |||
Raring |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The sync indicator code has its own copy of the sync enabled state in the self._paused variable, and it can get out of sync with the state of sync daemon when the user toggles the sync state via control panel or u1sdtool.
Instead of having it's own copy of the state, the sync indicator code in sync daemon should instead request the state from syncdaemon, and listen for state changes in the sync daemon internal events.
Related branches
lp:~diegosarmentero/ubuntuone-client/ubuntuone-client-syncstate
- Manuel de la Peña (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 238 lines (+110/-21)4 files modifiedtests/platform/sync_menu/test_linux.py (+50/-15)
tests/status/test_aggregator.py (+30/-0)
ubuntuone/platform/sync_menu/linux.py (+16/-6)
ubuntuone/status/aggregator.py (+14/-0)
Changed in ubuntuone-client: | |
status: | Triaged → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
summary: |
- The sync state in the sync indicator can get out of sync + Sync indicator state can get out of sync |
Changed in ubuntuone-client (Ubuntu Raring): | |
status: | New → Triaged |
Changed in ubuntuone-client (Ubuntu Quantal): | |
status: | New → Triaged |
Changed in ubuntuone-client (Ubuntu Quantal): | |
status: | Triaged → Won't Fix |
To post a comment you must log in.
This bug was fixed in the package ubuntuone-client - 4.1.0-0ubuntu1
---------------
ubuntuone-client (4.1.0-0ubuntu1) raring; urgency=low
* New upstream release.
- Trap DBusException on ubuntuone-login startup. (LP: #711324)
- Remove messaging menu integration. (LP: #820345)
- Avoid KeyError during an Upload. (LP: #988534)
- Ignore .lock files from synchronization. (LP: #1042268)
- Avoid duplicate state tracking for sync menu. (LP: #1053631)
- Add a separator between recent and current transfers. (LP: #1054259)
- Search and filtering API for shares tab in control panel. (LP: #1056197)
- Ensure Upload/Download objects have path attribute. (LP: #1061490)
- Use correct file size for percentages in sync menu. (LP: #1062729)
- Open shares tab from sync menu. (LP: #1063786)
- Open the Ubuntu One folder from sync menu. (LP: #1063788)
- Use correct glib method to launch control panel. (LP: #1065272)
- Always use GI bindings in launch and login scripts. (LP: #1066943)
- Show active downloads in transfers menu as well. (LP: #1067806)
- Avoid duplicates in transfers menu. (LP: #1069953)
- Do case-insenstive fuzzy filename matching. (LP: #1073664)
* debian/watch:
- Update to use stable-4-2 series for Ubuntu 13.04 releases.
-- Rodney Dawes <email address hidden> Tue, 11 Dec 2012 17:05:43 -0500