Ubuntu
ubiquity package

ubiquity-kde codepage problem in Timezone map (Timezone.py)

Bug #1057485 reported by Pantelis Koukousoulas
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
High
Unassigned
Ubuntu ubuntu-12.10
Precise
Fix Released
High
Colin Watson
Ubuntu ubuntu-12.04.3
Quantal
Fix Released
High
Unassigned
Ubuntu ubuntu-12.10

Bug Description

When installing kubuntu using the Greek language, in the Timezone selection screen,
there is a tooltip that shows the time and then supposedly "am" or "pm" but in Greek
case it shows gibberish instead of "πμ" or "μμ".

The reason is a hidden python str -> QString conversion since QString is latin-1 by
default.

One way to solve this problem is to add:

QtCore.QTextCodec.setCodecForCStrings(QtCore.QText.CodecForName("utf8"))

after

class TimezoneMap(QtGui.QWidget):

at

ubiquity/frontend/kde_components/Timezone.py

I would guess that this also affects other languages with non-latin alphabets
(e.g., Russian). Please fix.

Pantelis Koukousoulas (pktoss)
tags: added: kubuntu
Scott Kitterman (kitterman)
Changed in ubiquity (Ubuntu Quantal):
status: New → Triaged
importance: Undecided → High
milestone: none → ubuntu-12.10
Revision history for this message
Pantelis Koukousoulas (pktoss) wrote :

I made a small mistake above :S

The correct line (as proposed in IRC by tsimpson) is

QtCore.QTextCodec.setCodecForCStrings(QtCore.QTextCodec.codecForName("utf8"))

Revision history for this message
Pantelis Koukousoulas (pktoss) wrote :

Here is the suggested solution also in patch form

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "ubiquity-utf8-tooltip-in-timezone.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Colin Watson (cjwatson) wrote :

Wow. QString is ISO-8859-1 by default, seriously? What decade is it again? :-)

Were you using the Python 3 port in 12.10 for this, or is this patch against 12.04? You don't mention which.

I think that if we make this change then it should be in the main KDE frontend code, to make sure it applies to the entire installer. But I'm quite surprised that this isn't picked up from the locale.

Revision history for this message
Pantelis Koukousoulas (pktoss) wrote :

Hi,

It could also be python's problem to be honest, I 'm not so sure. The patch was for 12.04
(it should probably apply cleanly to 12.10's ubiquity but it was written with python 2.7
and 12.04 in mind).

Revision history for this message
Colin Watson (cjwatson) wrote :

Note to developers: you may need to 'sudo locale-gen el_GR.UTF-8' before starting ubiquity in order to reproduce this bug properly.

I have confirmed that this bug was naturally fixed by the new Python 3-based PyQt API used in 12.10, but I can still reproduce it in 12.04.

Changed in ubiquity (Ubuntu Precise):
status: New → Triaged
importance: Undecided → High
milestone: none → ubuntu-12.04.2
Changed in ubiquity (Ubuntu Quantal):
status: Triaged → Fix Released
Colin Watson (cjwatson)
Changed in ubiquity (Ubuntu Precise):
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in ubiquity (Ubuntu Precise):
milestone: ubuntu-12.04.2 → ubuntu-12.04.3
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Pantelis, or anyone else affected,

Accepted ubiquity into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubiquity/2.10.25 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubiquity (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Stéphane Graber (stgraber) wrote :

Tried an install in greek and I'm now getting am/pm so I guess that's good.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.10.25

---------------
ubiquity (2.10.25) precise; urgency=low

  [ Colin Watson ]
  * KDE frontend:
    - Set default QString encoding to UTF-8 (LP: #1057485).
  * Make ubiquity-frontend-debconf Architecture: any rather than all; the
    .bgf font format is architecture-dependent (LP: #1180880).
  * Automatic update of included source packages: partman-basicfilesystems
    71ubuntu3.1, partman-efi 25ubuntu1.1.

  [ Ma Jun (Kylin Team) ]
  * Fix referencing variable before assignment (LP: #945027)

  [ Stéphane Graber ]
  * Fix crash in ubi-console-setup when quickly moving back and forth between
    pages. (LP: #944614)
 -- Colin Watson <email address hidden> Fri, 17 May 2013 15:08:59 +0100

Changed in ubiquity (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.