pt-mysql-summary may report the wrong cnf file
Bug #1070916 reported by
Daniel Nichter
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
Bug Description
Finally digging into this failure:
# Failed '"/tmp/
# /tmp/percona-
# PID TTY STAT TIME COMMAND
# 1427 ? Sl 0:13 /home/jenkins/
# 20928 ? Sl 0:07 /home/jenkins/
# 29930 ? Sl 0:00 /home/jenkins/
mysql_collect_
Related branches
lp:~percona-toolkit-dev/percona-toolkit/find_my_cnf_file-bug-1070916
- Daniel Nichter: Approve
-
Diff: 250 lines (+93/-46)6 files modifiedbin/pt-mysql-summary (+13/-14)
lib/bash/collect_mysql_info.sh (+16/-15)
t/lib/bash/collect_mysql_info.sh (+53/-11)
t/lib/bash/report_mysql_info.sh (+1/-1)
t/pt-mysql-summary/pt-mysql-summary.t (+6/-5)
t/pt-mysql-summary/samples/ps-mysqld-005.txt (+4/-0)
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #1 |
| summary: |
- pt-mysql-summary may get the wrong cnf file + pt-mysql-summary may report the wrong cnf file |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Before:
not ok 15 - collect_
# Failed '"/tmp/
Problem was:
if test -n "$port" && grep -- "/mysqld.
If a port was given but it wasn't found, then it just used the first MySQL instance whose cnf would then be reported. So in this test case port 12345's cnf is searched for, but not found, so the first instance is used, 12347, which creates a false-positive.