Notifier's default_publisher_id option requires a 'host' option to be registered
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
oslo.messaging |
Invalid
|
Medium
|
Unassigned |
Bug Description
This review:
https:/
threw up an interesting issue. In openstack.
cfg.
We also have this:
def publisher_
if not host:
host = CONF.host
return "%s.%s" % (service, host)
which basically means projects can only use this API if they first register a 'host' configuration option.
I guess we have a few options:
1) We could make 'host' a config option registered by some base part of the library - I'm a little reluctant to do this because the semantics are a little weird. What does changing it mean? It affects a whole bunch of places in Nova, for example. Also, what part of openstack-common would it make sense to register the option from?
2) Make the default for default_
3) We make projects which use the notifier API supply the publisher ID in a setup function - I think this is something we want to support anyway, so perhaps doing this makes most sense
affects: | openstack-common → oslo |
Changed in oslo: | |
importance: | High → Medium |
status: | Confirmed → Triaged |
affects: | oslo-incubator → oslo.messaging |
I don't think this is still a issue, openstack. common. notifier. api have disappeared, everybody have switch to oslo.messaging. Notifier and set the publisher_id manually and use CONF.host by default (every project have naturally used Option #3).