Mahara

mnetloggedinfrom not displaying

Bug #1079260 reported by William Mair on 2012-11-15

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Melissa Draper	Mahara 1.6.2

Bug Description

In Mahara 1.6.1, the 'You have logged in from' institution name is not displaying for Mahoodle (I'm not sure about across different institutions as I only have one).

In /lib/mahara.php on line 2456, it looks like the institution_display_name is sending the wrong field to the get_field database request in institution_display_name (/lib/institution.php).

As per https://mahara.org/interaction/forum/topic.php?id=5005#post21955, I have a couple of quick suggestions to fix (although the latter regresses back to 1.5 code).

Revision history for this message

Hugh Davenport (hugh-davenport) wrote on 2012-11-15:

Hi William,

Thank you for reporting this bug, and mentioning a fix on the forums.

If you would like, you can submit a patch to us and we can push it upstream so you get some kudos :D

Have a read of https://wiki.mahara.org/index.php/Developer_Area/Contributing_Code to get started, and we are here to help if you get stuck.

Cheers,

Hugh

Changed in mahara:
status:	New → Triaged
importance:	Undecided → High
milestone:	none → 1.7.0

Revision history for this message

Melissa Draper (melissa) wrote on 2012-11-15:

Hi William,

Do you think you can make the changes and put a commit request through our review system? Once you're set up, you'll be ready to suggest all sorts of changes ;)

The information below should get you started. If you have any problems getting set up, drop me a mail at my first name at catalyst.net.nz and I'll help you debug.
https://wiki.mahara.org/index.php/Developer_Area/Developer_Tools
https://wiki.mahara.org/index.php/Developer_Area/Contributing_Code

Melissa Draper (melissa) on 2012-11-18

Changed in mahara:
milestone:	1.7.0 → 1.6.2

Melissa Draper (melissa) on 2012-11-20

Changed in mahara:
assignee:	nobody → Melissa Draper (melissa)

Revision history for this message

Melissa Draper (melissa) wrote on 2012-11-20:

Hi Wullie,

I've picked this up so we can get 1.6.2 out soon. It was caused by https://reviews.mahara.org/#/c/1183/2 and there was more than just that link broken.

Thanks,
Melissa.

Revision history for this message

Melissa Draper (melissa) wrote on 2012-11-20:

https://reviews.mahara.org/1850

Revision history for this message

Melissa Draper (melissa) wrote on 2012-11-20:

https://reviews.mahara.org/1851 for master

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2012-11-23: A change has been merged

Reviewed: https://reviews.mahara.org/1850
Committed: http://gitorious.org/mahara/mahara/commit/f84b948ac934caec8f5afed0ab52b2d1f6003c14
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit f84b948ac934caec8f5afed0ab52b2d1f6003c14
Author: Melissa Draper <email address hidden>
Date: Tue Nov 20 17:53:59 2012 +1300

Fix mnet jump-back link regression (Bug #1079260)