I18N issue: some log/messages are not wrapped with _()

Bug #1081498 reported by Ying Chun Guo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Ying Chun Guo
oslo-incubator
Fix Released
Low
Davanum Srinivas (DIMS)
Grizzly
Fix Released
Low
Davanum Srinivas (DIMS)

Bug Description

Hi, all

In cinder source code, some LOG messages or printing messages are wrapped with _(), some are not. I used a program to scan all the source code. There are around 1500+ messages wrapped with _() and 10 messages without _(). I saved all the LOG messages and printing messages without _() into a file.

I suggest we fix this issue and provide i18n to those messages without _().

Daisy

Tags: i18n
Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16644

Changed in cinder:
assignee: nobody → Ying Chun Guo (daisy-ycguo)
status: New → In Progress
Changed in cinder:
status: In Progress → Triaged
status: Triaged → In Progress
Mark McLoughlin (markmc)
Changed in oslo:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in oslo:
assignee: nobody → Davanum Srinivas (dims-v)
status: Confirmed → In Progress
Changed in cinder:
importance: Undecided → Medium
milestone: none → grizzly-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/16644
Committed: http://github.com/openstack/cinder/commit/e78667da0dbcb6b65dc9017822854c9e97f5a4ab
Submitter: Jenkins
Branch: master

commit e78667da0dbcb6b65dc9017822854c9e97f5a4ab
Author: daisy-ycguo <email address hidden>
Date: Thu Nov 22 00:16:04 2012 +0800

    Provide i18n to those messages without _()

    bug 1081498

    There are a few log messages without _(), but a lot messages with _().
    Wrap these log messages with _() in order to make the code consistent.

    Change-Id: Ie8961453569e9a75bd0fd0733344db8059d05222

Changed in cinder:
status: In Progress → Fix Committed
Changed in oslo:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
Changed in oslo:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.