Refactor quantum.api.v2.attributes.py

Bug #1082224 reported by Zhongyue Luo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Zhongyue Luo

Bug Description

The quantum.api.v2.attributes module has some redundant and inconsistant code.

1) Lines 116-120, 122-124, 157-160 are exceptions which will never happen
2) Method of verifying keys in a dictionary are different across functions

These things should need a cleanup

Changed in quantum:
assignee: nobody → Zhongyue Luo (zyluo)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/16183
Committed: http://github.com/openstack/quantum/commit/99886025986b92aa3beb7666f5d9fc4851e6a591
Submitter: Jenkins
Branch: master

commit 99886025986b92aa3beb7666f5d9fc4851e6a591
Author: Zhongyue Luo <email address hidden>
Date: Thu Nov 15 22:47:49 2012 +0900

    Refactors quantum.api.v2.attributes.py

    Logic changes were done for consistency across methods,
    removal of redundant code and lower memory consumption.

    Fixes bug #1082224

    Change-Id: Ie09773d35325bec69ea82b3b59f812af5fa1c4d6

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.