Odoo Addons (MOVED TO GITHUB)

[sale_stock ] sale line properties missing on a procurement

Bug #1083077 reported by Paulius Sladkevičius @ hbee
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 2
OpenERP Community Backports (Addons)
Status tracked in 7.0
7.0
Fix Released
Low
Holger Brunn (Therp)

Bug Description

When you assign properties for a sale order line and confirm order, you don't find them on a related procurement.
Please check my patch to get better view.

revno: 8073

Paulius

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-1083077-kbh
Lionel Sausin - Initiatives/Numérigraphe (community): Disapprove
Alexandre Fayolle - camptocamp (community): Needs Fixing (code review, test)
OpenERP Core Team: Pending requested
Diff: 11 lines (+1/-0)
1 file modified
sale_stock/sale_stock.py (+1/-0)
lp:~therp-nl/ocb-addons/7.0-lp1083077
Raphaël Valyi - http://www.akretion.com: Approve
Pedro Manuel Baeza: Approve (code review)
Guewen Baconnier @ Camptocamp: Approve (code review)
Diff: 11 lines (+1/-0)
1 file modified
sale_stock/sale_stock.py (+1/-0)
Revision history for this message
Paulius Sladkevičius @ hbee (komsas) wrote :
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Paulius,

Have you used sale_stock module..??

Cause we have already fixed this issue ago on trunk, would you please check it lp:926107

Please notify us.

Thank you!

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Paulius Sladkevičius @ hbee (komsas) wrote :

Hi Amit

of course I used it, did you check my patch, it patch sale_stock module?

After refactor code to sale_stock module properties disappear.
Check http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/view/head:/sale_stock/sale_stock.py#L267

Changed in openobject-addons:
status: Incomplete → New
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Paulish,

"sale_stock" module does not belong to an addon of this project you can refer to community documetation.

You can contact to related author otherwise you have already provided the patch, So I would like to suggest would you please make merge proposal for related branch.

[1] http://doc.openerp.com/v6.1/contribute/05_developing_modules.html#community-addons

Thank you!

Changed in openobject-addons:
status: New → Invalid
summary: - [trunk] sale line properties missing on a procurement
+ [sale_stock ] sale line properties missing on a procurement
Changed in openobject-addons:
status: Invalid → Won't Fix
Revision history for this message
Paulius Sladkevičius @ hbee (komsas) wrote :

Amit,

sale_stock module is in the offical trunk http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/files and author of this module is OpenERP s.a.. Seems it's not related with community.

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello,

that's strange, while Akretion went to Belgium during August for code sprint, I think Quentin de Paoli merge my merge proposal fixing that:
https://code.launchpad.net/~akretion-team/openobject-addons/bug-926107-order-line-properties-lost/+merge/94839
after it has regressed from 6.0 to 6.1

I actually think Quentin did the merge but without processing the Launchpad merge properly (appears as un-merged)

And then probably what happen is that the sale_stock module extraction done by OpenERP SA (yes!) which came later in time was probably based on the un-patched branch before the inclusion of my merge.

That's why even if I didn't take time to try reproducing the bug my self, I strongly suspect the bug report is correct and encourage OpenERP SA to merge that one-liner patch which seems the proper fix.

Regards

Revision history for this message
Amit Parik (amit-parik) wrote :

Opps.....Sorry for the inconvenience faced...!!

Sale_stock is now on offical addons.

Thanks!

Changed in openobject-addons:
status: Won't Fix → New
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance: Undecided → Low
status: New → Confirmed
Khushboo Bhatt(openerp) (kbh-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Khushboo Bhatt(openerp) (kbh-openerp) wrote :

Hello Paulius,

This issue has been fixed on lp:~openerp-dev/openobject-addons/trunk-bug-1083077-kbh
branch with following rev no and rev ID

Rev No : 8149
Revision ID:<email address hidden>

Thanks,
Khushboo.

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
开阖软件 Jeff Wang (jeff.osbzr.com) wrote :

It took me 2 hours to find this issue and solution in OpenERP-7.0-20130305 version, I found it is solved 5 months ago, but not merged into main branch, why ? the priority is low?

Revision history for this message
wowas (wowas18) wrote :

Why it fix in revision
~openerp/openobject-addons/7.0 » Revision 9172

And then revert back in revision
 ~openerp/openobject-addons/7.0 » Revision 9175

What cause?

Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

The initial commit put the fix in the wrong module, OpenERP's Martin fixed it at revid:<email address hidden> .

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.