neutron

Remove unused imports

Bug #1083934 reported by Zhongyue Luo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Ivan Kolodyazhny
neutron 2013.1 "grizzly"

Bug Description

These are the list of unused imports in master

************* Module run_tests
W: 46,0: Unused import unittest
W: 44,0: Unused import gettext
************* Module quantum.rootwrap.wrapper
W: 22,0: Unused import sys
************* Module quantum.debug.shell
W: 23,0: Unused import quantum
W: 18,0: Unused import itertools
************* Module quantum.debug.debug_agent
W: 21,0: Unused import os
W: 18,0: Unused import datetime
W: 24,0: Unused import sys
W: 30,0: Unused import interface
W: 19,0: Unused import errno
W: 35,0: Unused import client
W: 34,0: Unused import importutils
W: 28,0: Unused import config
************* Module quantum.agent.linux.utils
W: 23,0: Unused import signal
************* Module quantum.tests.unit.test_quantum_manager
W: 20,0: Unused import config
************* Module quantum.tests.unit.openvswitch.test_ovs_defaults
W: 19,0: Unused import config
************* Module quantum.tests.unit.openvswitch.test_ovs_quantum_agent
W: 22,0: Unused import config
************* Module quantum.tests.unit.test_rootwrap
W: 18,0: Unused import subprocess
************* Module quantum.tests.unit.test_agent_utils
W: 20,0: Unused import mock
************* Module quantum.tests.unit.test_extension_security_group
W: 35,0: Unused import test_extensions
W: 24,0: Unused import APIRouter
W: 28,0: Unused import db
W: 32,0: Unused import QuantumManager
W: 25,0: Unused import config
W: 36,0: Unused import JSONDeserializer
W: 23,0: Unused import attributes
W: 22,0: Unused import PluginAwareExtensionManager
************* Module quantum.tests.unit.ryu.test_ryu_db
W: 24,0: Unused import config
************* Module quantum.tests.unit.ryu.test_defaults
W: 21,0: Unused import config
************* Module quantum.tests.unit.test_extensions
W: 33,0: Unused import exceptions
************* Module quantum.tests.unit.testlib_api
W: 17,0: Unused import Serializer
************* Module quantum.tests.unit.test_debug_commands
W: 19,0: Unused import sys
W: 28,0: Unused import exceptions
W: 25,0: Unused import config
W: 27,0: Unused import utils
W: 20,0: Unused import uuid
************* Module quantum.tests.unit.test_policy
W: 32,0: Unused import cfg
W: 30,0: Unused import utils
************* Module quantum.tests.unit.test_linux_dhcp
W: 20,0: Unused import tempfile
************* Module quantum.tests.unit.metaplugin.test_metaplugin
W: 36,0: Unused import fake_plugin
W: 35,0: Unused import ProxyPluginV2
W: 26,0: Unused import NotImplementedError
W: 25,0: Unused import config
************* Module quantum.tests.unit.metaplugin.fake_plugin
W: 22,0: Unused import models_v2
W: 18,0: Unused import find_config_file
W: 19,0: Unused import db
W: 17,0: Unused import q_exc
************* Module quantum.tests.unit.test_dhcp_agent
W: 24,0: Unused import config
************* Module quantum.tests.unit._test_rootwrap_exec
W: 18,0: Unused import mock
************* Module quantum.tests.unit.test_l3_agent
W: 18,0: Unused import time
************* Module quantum.tests.unit.cisco.test_network_plugin
W: 16,0: Unused import inspect
W: 20,0: Unused import APIRouter
W: 28,0: Unused import cfg
W: 32,0: Unused import ovs_models_v2
W: 26,0: Unused import quotav2_model
W: 22,0: Unused import test_config
W: 34,0: Unused import JSONDeserializer
W: 25,0: Unused import l3_db
W: 21,0: Unused import config
************* Module quantum.tests.unit.cisco.test_nexus_plugin
W: 16,0: Unused import logging
W: 20,0: Unused import exc
W: 24,0: Unused import creds
************* Module quantum.tests.unit.test_linux_ip_lib
W: 22,0: Unused import utils
************* Module quantum.tests.unit.linuxbridge.test_defaults
W: 19,0: Unused import config
************* Module quantum.tests.unit.linuxbridge.test_lb_quantum_agent
W: 22,0: Unused import config
************* Module quantum.common.config
W: 23,0: Unused import sys
************* Module quantum.db.api
W: 25,0: Unused import exc
************* Module quantum.plugins.openvswitch.agent.ovs_quantum_agent
W: 39,0: Unused import config
************* Module quantum.plugins.openvswitch.ovs_quantum_plugin
W: 38,0: Unused import config
************* Module quantum.plugins.bigswitch.tests.test_server
W: 26,0: Unused import application_uri
W: 26,0: Unused import request_uri
************* Module quantum.plugins.ryu.ryu_quantum_plugin
W: 37,0: Unused import config
************* Module quantum.plugins.ryu.agent.ryu_quantum_agent
W: 40,0: Unused import config
************* Module quantum.plugins.metaplugin.meta_db_v2
W: 20,0: Unused import db
************* Module quantum.plugins.metaplugin.meta_quantum_plugin
W: 20,0: Unused import attributes
W: 22,0: Unused import find_config_file
W: 34,0: Unused import policy
W: 30,0: Unused import config
************* Module quantum.plugins.metaplugin.run_tests
W: 32,0: Unused import core
************* Module quantum.plugins.nicira.nicira_nvp_plugin.nvplib
W: 27,0: Unused import functools
W: 31,0: Unused import random
W: 33,0: Unused import uuid
W: 32,0: Unused import re
W: 35,0: Unused import semaphore
************* Module quantum.plugins.nicira.nicira_nvp_plugin.QuantumPlugin
W: 32,0: Unused import uuid
W: 31,0: Unused import urllib
W: 24,0: Unused import json
W: 29,0: Unused import sys
W: 23,0: Unused import ConfigParser
W: 36,0: Unused import client_eventlet
W: 27,0: Unused import netaddr
W: 41,0: Unused import attributes
************* Module quantum.plugins.cisco.nexus.cisco_nexus_plugin_v2
W: 26,0: Unused import db
************* Module quantum.plugins.cisco.network_plugin
W: 29,0: Unused import cred
************* Module quantum.plugins.cisco.tests.unit.v2.ucs.test_ucs_inventory_v2
W: 23,0: Unused import exc
************* Module quantum.plugins.cisco.tests.unit.v2.ucs.cisco_ucs_inventory_fake
W: 23,0: Unused import find_config_file
************* Module quantum.plugins.cisco.db.network_db_v2
W: 24,0: Unused import models_v2
W: 25,0: Unused import const
W: 28,0: Unused import nexus_models_v2
W: 29,0: Unused import ucs_models_v2
************* Module quantum.plugins.cisco.db.ucs_models_v2
W: 22,0: Unused import models
W: 19,0: Unused import relation
************* Module quantum.plugins.cisco.models.virt_phy_sw_v2
W: 24,0: Unused import l3_db
************* Module quantum.plugins.nec.common.config
W: 20,0: Unused import rpc
************* Module quantum.plugins.linuxbridge.agent.linuxbridge_quantum_agent
W: 42,0: Unused import config
************* Module quantum.plugins.linuxbridge.db.l2network_db_v2
W: 24,0: Unused import config

Mark McClain (markmcclain)
Changed in quantum:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Mark McClain (markmcclain) wrote :

There are unused imports within the codebase. Please be aware that static import analysis can sometimes be misleading. There are few modules may rely on import side-effects. In those cases we should add code comments to that effect.

When working on this, please submit reviews based on functional area (agent, db, plugins/<>, etc) and not the entire codebase at once.

Revision history for this message
Jason (zzs) wrote :

It looks like there are some assigned but never used variables also.
Should we fix this also by this chance.

Thanks,

Jason

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18762

Changed in quantum:
assignee: nobody → Ivan Kolodyazhny (e0ne)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18763

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18764

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18765

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18766

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18767

Revision history for this message
Ivan Kolodyazhny (e0ne) wrote :

> Please be aware that static import analysis can sometimes be misleading. There are few modules may rely on import side-effects.

Mark, could you specify such modules? I didn't find anyone in Quantum. But I did not try to fix imports ib Quantum plugins and their unit tests yet

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18822

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/18825

Revision history for this message
Zhongyue Luo (zyluo) wrote :

************* Module quantum.tests.unit.openvswitch.test_ovs_defaults
W: 19,0: Unused import config
************* Module quantum.tests.unit.openvswitch.test_ovs_quantum_agent
W: 22,0: Unused import config
************* Module quantum.tests.unit.ryu.test_ryu_db
W: 23,0: Unused import models_v2
W: 25,0: Unused import config
W: 20,0: Unused import unittest2
************* Module quantum.tests.unit.ryu.test_defaults
W: 21,0: Unused import config
************* Module quantum.tests.unit.test_linux_dhcp
W: 20,0: Unused import tempfile
************* Module quantum.tests.unit.metaplugin.test_metaplugin
W: 37,0: Unused import fake_plugin
W: 36,0: Unused import ProxyPluginV2
W: 26,0: Unused import NotImplementedError
W: 25,0: Unused import config
W: 31,0: Unused import l3
************* Module quantum.tests.unit.metaplugin.fake_plugin
W: 22,0: Unused import models_v2
W: 18,0: Unused import find_config_file
W: 19,0: Unused import db
W: 17,0: Unused import q_exc
************* Module quantum.tests.unit.cisco.test_network_plugin
W: 16,0: Unused import inspect
W: 20,0: Unused import APIRouter
W: 28,0: Unused import cfg
W: 32,0: Unused import ovs_models_v2
W: 26,0: Unused import quotav2_model
W: 22,0: Unused import test_config
W: 34,0: Unused import JSONDeserializer
W: 25,0: Unused import l3_db
W: 21,0: Unused import config
************* Module quantum.tests.unit.cisco.test_nexus_plugin
W: 16,0: Unused import logging
W: 20,0: Unused import exc
W: 24,0: Unused import creds
************* Module quantum.tests.unit.linuxbridge.test_defaults
W: 19,0: Unused import config
************* Module quantum.tests.unit.linuxbridge.test_lb_quantum_agent
W: 22,0: Unused import config

Revision history for this message
Ivan Kolodyazhny (e0ne) wrote :

Zhongyue Luo, thanks for review. I planned to fix imports in agents tests with agents code.

According to
> W: 28,0: Unused import cfg
 It looks like such imports is needed for correct configuration setup. I'll review it and create new patch.

Revision history for this message
Ivan Kolodyazhny (e0ne) wrote :

All necessary was merged to master:
https://review.openstack.org/#/c/18843/
https://review.openstack.org/#/c/19550/
https://review.openstack.org/#/c/18846/
https://review.openstack.org/#/c/18844/
https://review.openstack.org/#/c/18845/

Changed in quantum:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in quantum:
milestone: none → grizzly-3
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.