Remote stdlib exceptions are not de-serialized

Bug #1086798 reported by Mark McLoughlin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
High
Mark McLoughlin
Grizzly
Fix Released
High
Mark McLoughlin

Bug Description

Looking into bug #1060884, the nova-compute virt driver can throw a NotImplementedError but it is received on the nova-api as a RemoteError

The issue is quite simple - the stdlib 'exceptions' module is not in the default list for the allowed_rpc_exception_modules configuration option

Tags: rpc
Revision history for this message
Mark McLoughlin (markmc) wrote :

For reference, the original review was here: https://review.openstack.org/5749

Alex and Vish had a bunch of discussion around patch set 3 and there was some mention of the 'exceptions' module being included in the list but was then discarded in later comments

Perhaps there was some rationale for excluding it, but I'm not seeing it in the discussion

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17533

Changed in oslo:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/17533
Committed: http://github.com/openstack/oslo-incubator/commit/670dc3f8844e6fd3bcf9df1195891162a13719fe
Submitter: Jenkins
Branch: master

commit 670dc3f8844e6fd3bcf9df1195891162a13719fe
Author: Mark McLoughlin <email address hidden>
Date: Wed Dec 5 13:48:18 2012 +0000

    Allow remote stdlib exceptions to be deserialized

    Fixes bug #1086798

    Add 'exceptions' to allowed_rpc_exception_modules so that stdlib
    exceptions (like NotImplementedError) can be deserialized from a
    RemoteError.

    Change-Id: I57f40fed2a86cc08fb64b81d648c71cd7db8027c

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.