Hardware Sensors Indicator

Indicator-Sensors menu is in English, while all the words ("Preferences...", "About..." and "Quit") are translated to Lithuanian, Polish and other languages

Bug #1087150 reported by Mantas Kriaučiūnas on 2012-12-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Hardware Sensors Indicator	Fix Released	High	Alex Murray

Bug Description

Indicator-Sensors menu (which appears when you click on Indicator-sensors icon) is in English, while all the words ("Preferences...", "About..." and "Quit") are translated to Lithuanian, Polish and other languages - see screenshot https://launchpadlibrarian.net/120135194/Indicator-sensors-menu-in-EN-instead-of-LT.png (notice, that string "No sensors selected" is shown in Lithuanian - "Nepasirinktas daviklis")

You can test this bug with Polish (pl) or Lithuanian (lt) language - indicator-sensors is 100% translated to Polish. Check if your system has Polish locale generated with comand "localedef --list-archive" (if not - then run sudo apt-get install language-pack-pl ) and then run "LANG=pl_PL.UTF-8 indicator-sensors" from terminal:

ubuntu@ubuntu:~$ localedef --list-archive |grep pl
pl_PL.utf8
ubuntu@ubuntu:~$ LANG=pl_PL.UTF-8 indicator-sensors

Also I've found one string missing in translation template (indicator-sensors.pot file) - Preferences Window title (string "Hardware Sensors Indicator Preferences"), see attached screenshot of Preferences Window in Polish language

Revision history for this message

Mantas Kriaučiūnas (mantas) wrote on 2012-12-06:

Screenshot of Preferences Window in Polish language - Window title is in English Edit (32.5 KiB, image/png)

Revision history for this message

Mantas Kriaučiūnas (mantas) wrote on 2012-12-06:

I think problem with Indicator-Sensors menu translation is in file /indicator-sensors/is-indicator.c lines 159-175 - there is macros N_() used:
static GtkActionEntry entries[] = { { "Preferences", "application-preferences", N_("Preferences…"), NULL, N_("Preferences"), G_CALLBACK(prefs_action) },
while other lines with translation strings has _() instead of N_(), see for example line 699:
is_indicator_set_label(self, _("No active sensors"));
(I'm not C language guru, so, maybe I'm wrong, maybe problem is in other place ;))

Also I think, that untranslated Preferences Window title (string "Hardware Sensors Indicator Preferences") is because of line 108 in file /indicator-sensors/is-preferences-dialog.c line:
gtk_window_set_title(GTK_WINDOW(self), _(PACKAGE_NAME " Preferences"));

Maybe this line should be like this (I forgot C language many years ago, but you should understand my idea ;) ):
gtk_window_set_title(GTK_WINDOW(self), _(PACKAGE_NAME) + _(" Preferences"));

Revision history for this message

Alex Murray (alexmurray) wrote on 2012-12-06:

Hopefully both these issues should now be fixed in git / bzr - so once the daily build is done for revision 191 can you please let me know if this is resolved? Thanks.

Changed in indicator-sensors:
status:	New → In Progress
importance:	Undecided → High
assignee:	nobody → Alex Murray (alexmurray)

Revision history for this message

Mantas Kriaučiūnas (mantas) wrote on 2012-12-07:

Indicator-Sensors rev. 191 menu is in Lithuanian - bug is fixed :)
Untranslated Preferences Window title bug should be fixed when I and other translators translate newly appeared string, so please wait a few days or write an emails to translators :)

I think it would be wise to release new 0.4 version after translations will be finished - crash bug was fixed, also there are nice improvements in indicator-sensors code since 0.3 release :)

Alex Murray (alexmurray) wrote on 2012-12-06:
> Hopefully both these issues should now be fixed in git / bzr - so once the daily build is done for revision 191 can you please let me know if this is resolved?