no icon in kde menu

please tell me which one it is for certain, and I will be more than happy to change it for you :D

Based on the fact that the Ubuntu-desktop package (which provides the standard ubuntu/gnome desktop) depends on gnome-icon-theme but not on gnome-icon-theme-gperfection2, I would say the icon in the former package is the one normally used. Other than that, my guess is as good as yours... the packages listed are simply taken from the output of the command 'apt-file search stock_send-fax.png'.

Hi, could you test this for me, it seem sto work on my machines.

the .deb is the my version, with gnome-icon-theme-gperfection2 as a dep

if it works I will offer hte patch to the motu

Sam, your package does install gnome-icon-theme-gperfection2 as a dependency, but unfortunately this does not appear to have any effect. Efax-gtk's menu entry in kubuntu's kde menu (under "Office") still does not have an icon.

You might want to take a look at bug #108742 which is very similar (but for a different package); it has detailed comments and recommendations by a mentor. From what I understand of it all is that the approach taken there is adding an icon to the specific package and changing the desktop file to point to that icon. Hope this helps you in your efforts.

efax-gtk (3.0.14-1ubuntu1~ppa1) gutsy; urgency=low

  * Add of the desired icon inside the package (LP: #108746)
    - Addition of the icon "stock_send-fax.xpm" in the debian directory
    - Installation of the icon using debian/install in
      /usr/share/icons/hicolor/24x24/apps to match KDE needs

  * Cleanup of the efax-gtk.desktop file
    - Removal of the Encoding (deprecated)
    - Removal of Application in Categories (deprecated)
    - Removal of the file extension of the icon

  * Modification of the debian/menu to satisfy menu 2.1.35

  * Modify Maintainer value to match Debian-Maintainer-Field Spec

  * Usage of the debian/dirs to ensure the creation of the needed dirs

 -- Christophe Sauthier <email address hidden> Thu, 20 Sep 2007 18:59:37 +0200

Finally after 2 more builds I come to a package that satisfy myself (~ppa3). It builds perfectly and corrects the bug. Here is the debdiff

In the Menu file, I think Applications/Network is not correct as it is missing the section.
The available sections are:

Network/Communication
Network/File Transfer
Network/Monitoring
Network/Web Browsing
Network/Web News

I think this application would fall under File Transfer?

Any reason for the icon to be 24x24? The freedesktop,org specification suggests a 48x48 icon for .desktop files (http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html).

For the desktop file, isn't better to have it patched offline?

Please correct also the version (its 3.0.14-1ubuntu1~ppa3 now).

Regarding the Menu file, it was a misreading of the spec. But let me clarify something : should it be "Applications/Network/File Transfert" or just "Network/File Transfert"

The size of the icon is 24x24, since I couldn't found the right icon with the suggested size (48x48) so after various talks on #ubuntu-motu I was encouraged to do so.

I don't understand the meaning of "having it patched offline".

I skipped the ~ppa2 version because it was only tests... That is why I didn't published it here. I think it was not important to put every step in here juste the result. So in my mind the next build will be ~ppa4 right ?

Same changelog but this time it is the result of an offline patch and the Menu file has been corrected.

Looks very good but still few minor issues:

1. Please add to the changelog the addition of dpatch in debian/control and debian/rules
2. The Menu section is "Transfer" not "Transfert"
3. It is always a good idea to add a description of the patch in the dpatch patch. The template is in the lines:

## All lines beginning with `## DP:' are a description of the patch.
## DP: No description.

4. Note also that you are using the (incorrect) email <chris@chabarrou> in the patch while it is <email address hidden> in the changelog (I think this is simply because you have not set the DEBEMAIL env variable).

When you have a new patch available, please unassign yourself, set it as confirmed and resubscribe u-u-s.

New patch that corrects the minor issues described above.

efax-gtk (3.0.14-1ubuntu1) gutsy; urgency=low

  * Add menu icon (LP: #108746):
    - Add icon "stock_send-fax.xpm" from gnome-icon-theme in /debian
    - Install the icon using debian/install in
      /usr/share/icons/hicolor/24x24/apps
  * Update the .desktop file in line with freedesktop.org guidelines:
    - Add 01-efax-gtk.desktop.dpatch patch in debian/patches
      + Remove the Encoding field (deprecated)
      + Remove Application in the Categories field (deprecated)
      + Remove the icon's extension
  * Add dpatch support in debian/control and debian/rules
  * Modify debian/menu in line with new menu hierarchy
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Add debian/dirs

 -- Christophe Sauthier <email address hidden> Wed, 26 Sep 2007 09:56:34 +0200