OpenStack Compute (nova)

Somehow server lists raises NotFound

Bug #1089385 reported by Mauro S M Rodrigues
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Jay Pipes
OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

I'm not sure what is the situation to raise NotFound but it's raise here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L451 and

So this can be an error if it's never trully raised or if it should be raise cause there is no unit test to cover it

Michael Still (mikal)
Changed in nova:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Giampaolo Lauria (lauria) wrote :

Mauro, I can't think of a scenario in which HTTPNotFound could be raised in this context.

I think we should just remove the check for it (lines 455-457). What do you think?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18662

Changed in nova:
assignee: nobody → Jay Pipes (jaypipes)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/18662
Committed: http://github.com/openstack/nova/commit/fa16f2b68603be04cb5f4e915625181ac6c119eb
Submitter: Jenkins
Branch: master

commit fa16f2b68603be04cb5f4e915625181ac6c119eb
Author: Jay Pipes <email address hidden>
Date: Wed Dec 26 14:53:53 2012 -0500

    Remove improper NotFound except block in list servers

    Added a couple tests to verify that NotFound was actually
    never raised when no results are returned from list servers
    or list servers details, and then removed the except blocks
    from the controller.

    Change-Id: I36856066b9e4c4e3f7b85ddf8facb35204034838
    fixes: lp bug #1089385

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.